)]}'
{"novaclient/base.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"c5d9fb6d29954cf805dae142e67e405b5ac757b5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from novaclient import utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"UUID_CACHE_DIR \u003d os.getenv(\u0027NOVACLIENT_UUID_CACHE_DIR\u0027, \"~/.novaclient\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Python 2.4 compat"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F6Xo%3D","line":29,"updated":"2012-02-15 17:29:21.000000000","message":"Would you mind extracting the \u0027env\u0027 function from novaclient/shell.py and placing it in novaclient/utils.py, then you can use that here instead of calling \u0027os.getenv\u0027","commit_id":"b661a29d49534f6f7bc6208598c7524a59436e01"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"de4d75febf9b1c27f56d089edadd11354bdd4545","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from novaclient import utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"UUID_CACHE_DIR \u003d os.getenv(\u0027NOVACLIENT_UUID_CACHE_DIR\u0027, \"~/.novaclient\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Python 2.4 compat"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F6Nw%3D","line":29,"in_reply_to":"AAAAEn%2F%2F6QU%3D","updated":"2012-02-15 21:43:51.000000000","message":"`env` in shell handles the odd (and hopefully temporary) case where we have environment variables that have multiple names yet mean the same thing. For example, NOVA_USERNAME and OS_USERNAME.\n\nIt would more properly be called `env_with_fallback` or the like.\n\nWhere that fallback functionality is needed, it makes sense to use that helper, but if you\u0027re just doing vanilla environment look ups, then standard library is going to be the simplest choice.","commit_id":"b661a29d49534f6f7bc6208598c7524a59436e01"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"ecb19d0ff2c9929ca305f856550dc04a8ab4e493","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from novaclient import utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"UUID_CACHE_DIR \u003d os.getenv(\u0027NOVACLIENT_UUID_CACHE_DIR\u0027, \"~/.novaclient\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Python 2.4 compat"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F6QU%3D","line":29,"in_reply_to":"AAAAEn%2F%2F6U4%3D","updated":"2012-02-15 20:45:31.000000000","message":"Then can I ask what the value of the \u0027env\u0027 function is?","commit_id":"b661a29d49534f6f7bc6208598c7524a59436e01"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"0415de66ee19d00a0899774d4f9fbd9de041177f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from novaclient import utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"UUID_CACHE_DIR \u003d os.getenv(\u0027NOVACLIENT_UUID_CACHE_DIR\u0027, \"~/.novaclient\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Python 2.4 compat"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F6U4%3D","line":29,"in_reply_to":"AAAAEn%2F%2F6Wg%3D","updated":"2012-02-15 18:37:16.000000000","message":"The `env` function in shell.py doesn\u0027t add anything special in this case, so it seems pretty silly to use that just for the sake of using it. \n\nI think, where a standard library call will suffice, we should just go ahead and use it directly.","commit_id":"b661a29d49534f6f7bc6208598c7524a59436e01"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"587543b0b10f20f528ec3b4829f61b5dc1757449","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from novaclient import utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"UUID_CACHE_DIR \u003d os.getenv(\u0027NOVACLIENT_UUID_CACHE_DIR\u0027, \"~/.novaclient\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Python 2.4 compat"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F6Wg%3D","line":29,"in_reply_to":"AAAAEn%2F%2F6XA%3D","updated":"2012-02-15 17:48:20.000000000","message":"I\u0027m not sure I follow you, we already have a function designed specifically to get environment variables in novaclient/shell.py. I\u0027m asking to use that rather than duplicate the logic.","commit_id":"b661a29d49534f6f7bc6208598c7524a59436e01"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"66c29004f7f683cdf533a920849f19c6af13784f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from novaclient import utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"UUID_CACHE_DIR \u003d os.getenv(\u0027NOVACLIENT_UUID_CACHE_DIR\u0027, \"~/.novaclient\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Python 2.4 compat"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F6XA%3D","line":29,"in_reply_to":"AAAAEn%2F%2F6Xo%3D","updated":"2012-02-15 17:37:08.000000000","message":"Brian: What\u0027s the benefit of doing that here? In other words, if the this isn\u0027t likely to be reused elsewhere, why should I have to go look at different file to see what\u0027s going on?","commit_id":"b661a29d49534f6f7bc6208598c7524a59436e01"}]}