)]}'
{"id":"openstack%2Fpython-novaclient~4293","triplet_id":"openstack%2Fpython-novaclient~master~I56eace59f774623a2cb878657b3b797420c48408","project":"openstack/python-novaclient","branch":"master","topic":"volume-types","hashtags":[],"change_id":"I56eace59f774623a2cb878657b3b797420c48408","subject":"Add support for volume types","status":"MERGED","created":"2012-02-17 23:35:38.000000000","updated":"2012-02-28 20:47:30.000000000","submitted":"2012-02-28 20:47:30.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2e234adf20cac241015a07d3c317cb424e00da03","_number":4293,"virtual_id_number":4293,"owner":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":1,"date":"2012-02-28 20:47:30.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"date":"2012-02-28 20:47:30.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-02-28 20:31:27.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"value":2,"date":"2012-02-27 23:20:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},{"value":2,"date":"2012-02-28 00:16:11.000000000","_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"all":[{"value":0,"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2012-02-28 20:31:27.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"value":0,"date":"2012-02-27 23:20:30.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},{"value":0,"date":"2012-02-28 00:16:11.000000000","_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-02-24 02:31:32.000000000","updated_by":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"reviewer":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"state":"REVIEWER"},{"updated":"2012-02-24 18:05:16.000000000","updated_by":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"reviewer":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"state":"REVIEWER"},{"updated":"2012-02-27 23:20:30.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2012-02-28 00:16:11.000000000","updated_by":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"reviewer":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"state":"REVIEWER"},{"updated":"2012-02-28 20:31:27.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2012-02-28 20:47:30.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"44c327945bc4f30d01c55fa8aeb6e99a44732368","author":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"date":"2012-02-17 23:39:52.000000000","message":"Patch Set 1:\n\nJust FYI,\n\nThe volume-type-list command isn\u0027t going to work until this bug is fixed in Nova:\n\nhttps://bugs.launchpad.net/nova/+bug/934435\n\n--\nChuck","accounts_in_message":[],"_revision_number":1},{"id":"2be5d64b56db9f13c21e4832e48ef159623f532d","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-02-17 23:41:21.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"5c8512b20a4dfcdad099a57393f2808e45f64dd2","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2012-02-21 20:30:31.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nThis is clear to land as soon as my branch lands: https://review.openstack.org/#change,4361. Tested both together and they work.","accounts_in_message":[],"_revision_number":1},{"id":"58c50a95a32538a378f4063c119a04f61e9abce3","author":{"_account_id":112,"name":"Jesse Andrews","email":"anotherjesse@gmail.com","username":"anotherjesse"},"date":"2012-02-24 02:31:32.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\nthe review bcwaldon referenced has merged, lgtm","accounts_in_message":[],"_revision_number":1},{"id":"c3962fd70353c7d063cca94874deb2e26d2eb8ba","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-02-24 02:39:48.000000000","message":"Patch Set 1: Fails; I would prefer that you didn\u0027t submit this\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-python-novaclient-merge/121/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-pep8/121/ : UNSTABLE \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/1801/ : FAILURE \nhttps://jenkins.openstack.org/job/gate-python-novaclient-unittests/123/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"1b622b6aa3713abe920c764698e8ac5199a364db","author":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"date":"2012-02-24 18:05:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"362e9bce13ad1aee8dc17b4522ef33d9d400aa62","author":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"date":"2012-02-24 18:12:56.000000000","message":"Patch Set 2:\n\nI fixed the pep8 issue, but there seems to be an issue with the devstack tests?\n\nclayg helped me track down the following:\n\n+ nova volume-attach bc812580-340c-43a6-bc64-494f892fab7d 1 /dev/vdb\n+ timeout 60 sh -c \u0027while ! nova volume-list | grep myvol-10a5bb97 | grep in-use; do sleep 1; done\u0027\n| 1  | in-use | myvol-10a5bb97 | 1    | None        | bc812580-340c-43a6-bc64-494f892fab7d |\n++ nova volume-list\n++ grep myvol-10a5bb97\n++ sed \u0027s/ //g\u0027\n++ cut \u0027-d|\u0027 -f6\n++ head -1\nVolume not attached to correct instance\n+ VOL_ATTACH\u003dNone\n+ [[ None !\u003d bc812580-340c-43a6-bc64-494f892fab7d ]]\n+ echo \u0027Volume not attached to correct instance\u0027\n+ exit 1\n\nSo the test seems to be using the user readable table to get the data which seems like a bad idea IMHO.  Either way I\u0027m not sure what is the right way to get the test fixed?","accounts_in_message":[],"_revision_number":2},{"id":"dff9625ebf97a8da6a7a8f2d878230dcb0294a4d","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2012-02-27 16:31:31.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t submit this\n\nSo two things jump out at me:\n\n* The devstack test is fragile as it depends on the fifth column to be the attachment. You inserted the volume type into the fifth column and bumped attachment to the sixth, so in order for this change to make it in as-is, you will need to update that devstack exercise.\n* The volume type is being presented as None (evident in the code you pasted from devstack). That seems wrong.","accounts_in_message":[],"_revision_number":2},{"id":"5f108e097503bc690168fa33e013b054a7c10b27","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-02-27 22:46:22.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b4c24d98e5fa3ae97c1f0bfba0772211f5eed5f9","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-02-27 23:20:30.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"a5152aba48865a31a235720476ba840da3155b94","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2012-02-28 00:16:11.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\nGood to land once the dependent branch goes in.","accounts_in_message":[],"_revision_number":3},{"id":"5b0a8c7d75070ca39d99cdbe538b34dd9a47a760","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-02-28 20:31:27.000000000","message":"Patch Set 3: Approved\n\ndependent patch merged.","accounts_in_message":[],"_revision_number":3},{"id":"df17e58a17761c9b47543f013c71c38f37b7cb6b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-02-28 20:47:30.000000000","message":"Patch Set 3: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-python-novaclient-merge/126/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-pep8/126/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/1920/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-unittests/128/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"a401ced9d7f5f13c503f18d30a2dc599b15bcf83","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-02-28 20:47:30.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"30e11332031c8b5c288f95747867855e29514c3e","revisions":{"7a49d5f81f8b790750dcb64d2e3f329c8e1adee5":{"kind":"REWORK","_number":1,"created":"2012-02-17 23:35:38.000000000","uploader":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"ref":"refs/changes/93/4293/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/93/4293/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/93/4293/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/93/4293/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/93/4293/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/93/4293/1"}}},"commit":{"parents":[{"commit":"bca5acddafcf0cc7864022db92ae47ee1c61b29f","subject":"Add ssh convenience command","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/bca5acddafcf0cc7864022db92ae47ee1c61b29f"}]}],"author":{"name":"Chuck","email":"cthier@gmail.com","date":"2012-02-16 16:16:26.000000000","tz":-360},"committer":{"name":"Chuck","email":"cthier@gmail.com","date":"2012-02-17 23:35:18.000000000","tz":-360},"subject":"Add support for volume types","message":"Add support for volume types\n\nChange-Id: I56eace59f774623a2cb878657b3b797420c48408\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7a49d5f81f8b790750dcb64d2e3f329c8e1adee5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7a49d5f81f8b790750dcb64d2e3f329c8e1adee5"}]},"branch":"refs/heads/master"},"369af4b79c0bf302eff72bf2f65ee32d44138765":{"kind":"REWORK","_number":2,"created":"2012-02-24 18:05:16.000000000","uploader":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"ref":"refs/changes/93/4293/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/93/4293/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/93/4293/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/93/4293/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/93/4293/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/93/4293/2"}}},"commit":{"parents":[{"commit":"39bfd0585b8f1a08ebb62f429f7fb7fa57d6f982","subject":"Merge \"Add support for ephemeral_gb to novaclient.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/39bfd0585b8f1a08ebb62f429f7fb7fa57d6f982"}]}],"author":{"name":"Scott Moser","email":"smoser@ubuntu.com","date":"2012-02-17 21:29:59.000000000","tz":-300},"committer":{"name":"Chuck","email":"cthier@gmail.com","date":"2012-02-24 18:05:15.000000000","tz":-360},"subject":"Add support for volume types","message":"Add support for volume types\n\nChange-Id: I56eace59f774623a2cb878657b3b797420c48408\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/369af4b79c0bf302eff72bf2f65ee32d44138765"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/369af4b79c0bf302eff72bf2f65ee32d44138765"}]},"branch":"refs/heads/master"},"30e11332031c8b5c288f95747867855e29514c3e":{"kind":"REWORK","_number":3,"created":"2012-02-27 22:46:22.000000000","uploader":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"ref":"refs/changes/93/4293/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/93/4293/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/93/4293/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/93/4293/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/93/4293/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/93/4293/3"}}},"commit":{"parents":[{"commit":"6d8e445b794aa4611e75835ace905dd73d3a342f","subject":"Merge \"Fix for backward compatibility with stable/diablo flavors\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/6d8e445b794aa4611e75835ace905dd73d3a342f"}]}],"author":{"name":"Scott Moser","email":"smoser@ubuntu.com","date":"2012-02-17 21:29:59.000000000","tz":-300},"committer":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2012-02-27 22:46:02.000000000","tz":0},"subject":"Add support for volume types","message":"Add support for volume types\n\n * Depends on https://review.openstack.org/4600\n\nChange-Id: I56eace59f774623a2cb878657b3b797420c48408\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/30e11332031c8b5c288f95747867855e29514c3e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/30e11332031c8b5c288f95747867855e29514c3e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}