)]}'
{"id":"openstack%2Fpython-novaclient~434781","triplet_id":"openstack%2Fpython-novaclient~master~I9b039effa6867bec7e8adbe952d91af3d66e2001","project":"openstack/python-novaclient","branch":"master","hashtags":[],"change_id":"I9b039effa6867bec7e8adbe952d91af3d66e2001","subject":"Avoid limit\u003d-1 description","status":"ABANDONED","created":"2017-02-16 09:55:58.000000000","updated":"2017-05-18 02:25:53.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0c9cb4155544eb367a6354d2bedfb624537bbfc2","_number":434781,"virtual_id_number":434781,"owner":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2017-02-16 11:09:59.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},{"date":"2017-02-28 12:08:09.000000000","_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2017-02-22 21:43:00.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":-1,"date":"2017-02-22 20:28:56.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-02-16 11:09:59.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-02-22 20:28:56.000000000","updated_by":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"reviewer":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"state":"REVIEWER"},{"updated":"2017-02-22 21:43:00.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"}],"messages":[{"id":"e3e73579353749403e3513d26f7ed20dcf6fbe93","author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"date":"2017-02-16 09:55:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a00d2300f3bcbded10edaba4c48eedb02065039e","author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"date":"2017-02-16 09:56:54.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"837c0f73a523c91e41ffd2a1fd92ed46fd13a80e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-16 11:09:59.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/81/434781/2/check/gate-python-novaclient-docs-ubuntu-xenial/28cf466//doc/build/html/ : SUCCESS in 1m 57s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/81/434781/2/check/gate-python-novaclient-pep8-ubuntu-xenial/4c6faf6/ : SUCCESS in 3m 34s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/81/434781/2/check/gate-python-novaclient-python27-ubuntu-xenial/a0ac760/ : SUCCESS in 3m 07s\n- gate-python-novaclient-python35 http://logs.openstack.org/81/434781/2/check/gate-python-novaclient-python35/95d1726/ : SUCCESS in 1m 32s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/81/434781/2/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/5f9bee1/ : SUCCESS in 1h 02m 52s\n- gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv http://logs.openstack.org/81/434781/2/check/gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv/49bfa6b/ : SUCCESS in 30m 15s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/81/434781/2/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/f00a59f/ : SUCCESS in 58m 34s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/81/434781/2/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/d841c9d/ : SUCCESS in 1h 11m 38s","accounts_in_message":[],"_revision_number":2},{"id":"32fb41bfeb4a096d3f429c5cb2badbcc1cedeecc","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2017-02-22 17:45:31.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"75024253be105ef04d19113c16efa417be203edf","author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"date":"2017-02-22 20:28:56.000000000","message":"Patch Set 2: Code-Review-1\n\nHmm... I could be wrong, but I think -1 is valid for this endpoint and that the behaviour differs from the other endpoints (you can bypass the CONF.api.max_limit for example).\n\nHave you manually tested these cases?\n\nI recently went through all these help messages, and removed the references to -1 that weren\u0027t true, but I recall intentionally keeping this one because it did differed from the others.\n\n    Correct copy/paste errors in help\n    https://review.openstack.org/#/c/403913/\n\nAs always, I could be wrong, but I\u0027d like to see some testing for this (manual even), before merging this change.","accounts_in_message":[],"_revision_number":2},{"id":"be3af71a3c72c28cc34bb2a83837c74061a3903e","author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"date":"2017-02-22 20:29:55.000000000","message":"Patch Set 2:\n\ntypo:  because it did *differ* from the others","accounts_in_message":[],"_revision_number":2},{"id":"6131ca367eff58698a301fe8726b819035dfa88a","author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"date":"2017-02-22 20:59:25.000000000","message":"Patch Set 2:\n\nHere are manual testing notes from devstack (stable/newton) that show the special -1 case in action.\n\n- http://paste.openstack.org/show/600104/\n\nIf this case no longer works in stable/ocata (I haven\u0027t tested it) then that\u0027s a regression (perhaps from the new query parameter schema validation, if I had to guess).\n\nMaybe we\u0027re okay with that regression, but I think we need to have that discussion before changing the help message to match the new behaviour.","accounts_in_message":[],"_revision_number":2},{"id":"1c926aae8d38782dc4c1a0640b87736365762b82","author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"date":"2017-02-22 21:39:38.000000000","message":"Patch Set 2:\n\nThis good news is that this still works in ocata. My manual testing notes:\n\n- http://paste.openstack.org/show/600106/\n\nIt works because the python-novaclient loops in a \"while True\", doing multiple requests behind the scenes to make this magical -1 case work.\n\n- https://github.com/openstack/python-novaclient/blob/540f9ceb461e4ad55b83e873419f46d5b75bcac8/novaclient/v2/servers.py#L835\n\nSo unless I\u0027ve missed something, the help message should remain as-is.","accounts_in_message":[],"_revision_number":2},{"id":"58444d3f8576afa23e5ce27916261b08a406b7bd","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2017-02-22 21:43:00.000000000","message":"Patch Set 2: -Code-Review","accounts_in_message":[],"_revision_number":2},{"id":"96fa0f183f1bb89d5891d12d719bd6e935111997","author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"date":"2017-02-28 12:08:09.000000000","message":"Patch Set 2:\n\nHi Diana\nThanks a lot for your detailed explanation, from my point of view, this limit thing (which is CONF.api.max_limit now in API) should apply to all APIs\n\ne.g https://github.com/openstack/python-novaclient/blob/540f9ceb461e4ad55b83e873419f46d5b75bcac8/novaclient/v2/shell.py#L3320 we don\u0027t have -1 here\n\nmaybe make them consistent will be much helpful , so do you think it make sense to copy server mechanism to all others ?(because we need not break old method we provided?)","accounts_in_message":[],"_revision_number":2},{"id":"0c9cb4155544eb367a6354d2bedfb624537bbfc2","author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"date":"2017-05-18 02:25:53.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"71fb844a83f2ef312a261b8edcd0c7182f09397b","revisions":{"d386a03308d72b262cc80c10236ec19a35a84f5f":{"kind":"REWORK","_number":1,"created":"2017-02-16 09:55:58.000000000","uploader":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"ref":"refs/changes/81/434781/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/81/434781/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/81/434781/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/81/434781/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/81/434781/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/81/434781/1"}}},"commit":{"parents":[{"commit":"540f9ceb461e4ad55b83e873419f46d5b75bcac8","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/540f9ceb461e4ad55b83e873419f46d5b75bcac8"}]}],"author":{"name":"jichenjc","email":"jichenjc@cn.ibm.com","date":"2017-01-24 11:04:09.000000000","tz":480},"committer":{"name":"jichenjc","email":"jichenjc@cn.ibm.com","date":"2017-01-24 11:05:19.000000000","tz":480},"subject":"Avoid limit\u003d-1 description","message":"Avoid limit\u003d-1 description\n\nAccording to this definition\nhttps://github.com/openstack/nova/blob/master/nova/api/validation/parameter_types.py#L423\nnova don\u0027t allow limit \u003c 0 to be accepted in API layer\n\nin shell layer, -1 is handled well so it won\u0027t pass down to nova api layer\nbut provide a -1 limit make no sense because\nif user want no limit, they just don\u0027t provide the limit\noption, so it can avoid confusion.\n\nunfortunately, previously novaclient lib allows -1 which means\nremove -1 will be backward uncompatible change, so this patch\nonly update description to not suggest user in using -1 in CLI.\n\nChange-Id: I9b039effa6867bec7e8adbe952d91af3d66e2001\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d386a03308d72b262cc80c10236ec19a35a84f5f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d386a03308d72b262cc80c10236ec19a35a84f5f"}]},"branch":"refs/heads/master"},"71fb844a83f2ef312a261b8edcd0c7182f09397b":{"kind":"REWORK","_number":2,"created":"2017-02-16 09:56:54.000000000","uploader":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"ref":"refs/changes/81/434781/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/81/434781/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/81/434781/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/81/434781/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/81/434781/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/81/434781/2"}}},"commit":{"parents":[{"commit":"540f9ceb461e4ad55b83e873419f46d5b75bcac8","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/540f9ceb461e4ad55b83e873419f46d5b75bcac8"}]}],"author":{"name":"jichenjc","email":"jichenjc@cn.ibm.com","date":"2017-01-24 11:04:09.000000000","tz":480},"committer":{"name":"jichenjc","email":"jichenjc@cn.ibm.com","date":"2017-01-24 11:06:13.000000000","tz":480},"subject":"Avoid limit\u003d-1 description","message":"Avoid limit\u003d-1 description\n\nAccording to this definition\nhttps://github.com/openstack/nova/blob/master/nova/api/validation/parameter_types.py#L423\nnova don\u0027t allow limit \u003c 0 to be accepted in API layer\n\nin shell layer, -1 is handled well so it won\u0027t pass down to nova api layer\nbut provide a -1 limit make no sense because\nif user want no limit, they just don\u0027t provide the limit\noption, so it can avoid confusion.\n\nunfortunately, previously novaclient lib allows -1 which means\nremove -1 will be backward uncompatible change, so this patch\nonly update description to not suggest user in using -1 in CLI.\n\nChange-Id: I9b039effa6867bec7e8adbe952d91af3d66e2001\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/71fb844a83f2ef312a261b8edcd0c7182f09397b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/71fb844a83f2ef312a261b8edcd0c7182f09397b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}