)]}'
{"novaclient/v2/migrations.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"cb74766bb0f3d887d1885db934a13b225e7271aa","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class MigrationManager(base.ManagerWithFind):"},{"line_number":28,"context_line":"    resource_class \u003d Migration"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def list(self, host\u003dNone, status\u003dNone):"},{"line_number":31,"context_line":"        \"\"\""},{"line_number":32,"context_line":"        Get a list of migrations."},{"line_number":33,"context_line":"        :param host: (optional) filter migrations by host name."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_63d1b2fb","line":30,"updated":"2017-02-28 20:34:51.000000000","message":"Dropping the argument could break backwards compatibility.  I\u0027d rather we left the argument there but issued a warning if a value is given.","commit_id":"0990c975c6b0d7610fba47e78af9dc0181f2dafe"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b1c4f2fa1309db9e3e9f016fa03277ec74902a2f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if status:"},{"line_number":44,"context_line":"            opts[\u0027status\u0027] \u003d status"},{"line_number":45,"context_line":"        if cell_name:"},{"line_number":46,"context_line":"            logger \u003d logging.getLogger(__name__)"},{"line_number":47,"context_line":"            logger.warning(_LW(\"Argument \u0027cell_name\u0027 is deprecated since \""},{"line_number":48,"context_line":"                               \"Pike, and will be removed.\"))"},{"line_number":49,"context_line":"            opts[\u0027cell_name\u0027] \u003d cell_name"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_b96d7d06","line":46,"range":{"start_line":46,"start_character":12,"end_line":46,"end_character":48},"updated":"2017-03-01 12:31:11.000000000","message":"novaclient doesn\u0027t use oslo.log which has default configured logger. It means that logging.getLogger(__name__) returns a logger without configured logging output, it will send the warning in /dev/null :)\n\nPossible solutions:\n\n1) use warning.warn . It will work in any case\n2) use self.client.logger object. It is an object that is transmitted by user (or other OS services) with proper configuration of logging level and output\n3) use something like https://github.com/openstack/python-novaclient/blob/master/novaclient/api_versions.py#L29-L30","commit_id":"7d0688de2e8dc4562b5ae64a50f42b5f997c901e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b1c4f2fa1309db9e3e9f016fa03277ec74902a2f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if cell_name:"},{"line_number":46,"context_line":"            logger \u003d logging.getLogger(__name__)"},{"line_number":47,"context_line":"            logger.warning(_LW(\"Argument \u0027cell_name\u0027 is deprecated since \""},{"line_number":48,"context_line":"                               \"Pike, and will be removed.\"))"},{"line_number":49,"context_line":"            opts[\u0027cell_name\u0027] \u003d cell_name"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # Transform the dict to a sequence of two-element tuples in fixed"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_5956412a","line":48,"range":{"start_line":48,"start_character":38,"end_line":48,"end_character":57},"updated":"2017-03-01 12:31:11.000000000","message":"The statement sounds unfinished. Please include information when it will be removed. Something like \"and will be removed in further release\" for example.","commit_id":"7d0688de2e8dc4562b5ae64a50f42b5f997c901e"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"144c0bb421bfd7c6b7b29f346d4d37358d46aa77","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if cell_name:"},{"line_number":44,"context_line":"            self.client.logger.warning(_LW(\"Argument \u0027cell_name\u0027 is \""},{"line_number":45,"context_line":"                                           \"deprecated since Pike, and will \""},{"line_number":46,"context_line":"                                           \"be removed in further release.\"))"},{"line_number":47,"context_line":"            opts[\u0027cell_name\u0027] \u003d cell_name"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # Transform the dict to a sequence of two-element tuples in fixed"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_40e39da3","line":46,"range":{"start_line":46,"start_character":55,"end_line":46,"end_character":65},"updated":"2017-03-01 15:05:45.000000000","message":"s/in further/in a future/ (femtonit)","commit_id":"bc5abc66f2ca08c5b8206d70264c245b830b5398"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"a85fab52c45d499ab4083dbc0ee380c16cde1ff2","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if cell_name:"},{"line_number":44,"context_line":"            self.client.logger.warning(_LW(\"Argument \u0027cell_name\u0027 is \""},{"line_number":45,"context_line":"                                           \"deprecated since Pike, and will \""},{"line_number":46,"context_line":"                                           \"be removed in further release.\"))"},{"line_number":47,"context_line":"            opts[\u0027cell_name\u0027] \u003d cell_name"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # Transform the dict to a sequence of two-element tuples in fixed"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_331b6174","line":46,"range":{"start_line":46,"start_character":55,"end_line":46,"end_character":65},"in_reply_to":"ba2be162_40e39da3","updated":"2017-03-01 15:08:55.000000000","message":"Done","commit_id":"bc5abc66f2ca08c5b8206d70264c245b830b5398"}],"novaclient/v2/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"cb74766bb0f3d887d1885db934a13b225e7271aa","unresolved":false,"context_lines":[{"line_number":4768,"context_line":"    dest\u003d\u0027status\u0027,"},{"line_number":4769,"context_line":"    metavar\u003d\u0027\u003cstatus\u003e\u0027,"},{"line_number":4770,"context_line":"    help\u003d_(\u0027Fetch migrations for the given status.\u0027))"},{"line_number":4771,"context_line":"def do_migration_list(cs, args):"},{"line_number":4772,"context_line":"    \"\"\"Print a list of migrations.\"\"\""},{"line_number":4773,"context_line":"    migrations \u003d cs.migrations.list(args.host, args.status)"},{"line_number":4774,"context_line":"    _print_migrations(cs, migrations)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_23feda6b","line":4771,"updated":"2017-02-28 20:34:51.000000000","message":"I worry about backwards compatibility here, as well.  I\u0027d recommend using DeprecatedAction to mark the argument deprecated.","commit_id":"0990c975c6b0d7610fba47e78af9dc0181f2dafe"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"7ca6fe8e4fa98ec0c0b3bd74d2eac67fe02be981","unresolved":false,"context_lines":[{"line_number":4779,"context_line":"          \u0027removed after version 8.0.0.\u0027))"},{"line_number":4780,"context_line":"def do_migration_list(cs, args):"},{"line_number":4781,"context_line":"    \"\"\"Print a list of migrations.\"\"\""},{"line_number":4782,"context_line":"    migrations \u003d cs.migrations.list(args.host, args.status, args.cell_name)"},{"line_number":4783,"context_line":"    _print_migrations(cs, migrations)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_70407957","line":4782,"range":{"start_line":4782,"start_character":58,"end_line":4782,"end_character":74},"updated":"2017-03-01 11:42:25.000000000","message":"let\u0027s do not transmit it to novaclient\u0027s python api","commit_id":"0b0043053fe4a8e59ff6ccf3dfbfcc4080bf2d3a"}]}
