)]}'
{"id":"openstack%2Fpython-novaclient~447009","triplet_id":"openstack%2Fpython-novaclient~master~Ifef6fdc1a737dd219712a4525d4e34afd3fbd80c","project":"openstack/python-novaclient","branch":"master","topic":"bug/1673789","hashtags":[],"change_id":"Ifef6fdc1a737dd219712a4525d4e34afd3fbd80c","subject":"Fix aggregate_update name and availability_zone clash","status":"MERGED","created":"2017-03-17 14:13:47.000000000","updated":"2017-03-20 02:57:34.000000000","submitted":"2017-03-20 02:57:34.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":18,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"70da4402fd6dfb1d3b81e675eb67a8a7d49569cc","_number":447009,"virtual_id_number":447009,"owner":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-03-20 02:57:34.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-03-17 17:10:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2017-03-17 16:49:29.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-03-17 17:10:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-17 16:49:29.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2017-03-17 17:10:41.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2017-03-20 02:57:34.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"35818d781412f95e035cd132b8dcb3c653617907","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2017-03-17 14:13:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5df032018e369b8a867f950042216ccd22393db4","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2017-03-17 14:17:57.000000000","message":"Patch Set 1:\n\nWe have tests already that test both the new case:\n\nhttps://github.com/openstack/python-novaclient/blob/master/novaclient/tests/unit/v2/test_shell.py#L1893\n\nand the legacy, deprecated case:\n\nhttps://github.com/openstack/python-novaclient/blob/master/novaclient/tests/unit/v2/test_shell.py#L1931\n\nBoth pass, but this is definitely broken in real life.","accounts_in_message":[],"_revision_number":1},{"id":"e7d736d28cbea6c78c56e6affa8d58a9e7336d03","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-03-17 14:24:25.000000000","message":"Patch Set 1: Workflow-1\n\nWe should add a functional test to the novaclient tree that exhibits the bug because obviously the unit tests are busted.","accounts_in_message":[],"_revision_number":1},{"id":"fb08053477b99f1d1929e9e638ab489da46821af","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2017-03-17 15:00:59.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c7a0b61be0125a178a8c3195ff46c73cb28012dc","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2017-03-17 15:20:31.000000000","message":"Patch Set 2:\n\nI think this bug is more complicated than just a name clash: using the same \u0027dest\u0027 for multiple arguments, even when one is a positional argument, has worked correctly before.  I think what\u0027s confusing argparse here is the fact that we have two positional arguments that both have \"nargs\u003d\u0027?\u0027\", because we are trying to deprecate both simultaneously.  I wonder if we shouldn\u0027t specify a positional parameter that accepts 0, 1, or 2 values, then map those to \u0027name\u0027 and \u0027availability_zone\u0027 by hand within do_aggregate_update()?","accounts_in_message":[],"_revision_number":2},{"id":"02a84265e8e0a0e22ba201cefa7b94ebc4b2536c","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2017-03-17 15:28:24.000000000","message":"Patch Set 2:\n\nI\u0027m not sure why that would make it work before and not work now. I\u0027m also not sure why name has nargs\u003d? either, since it was required.\n\nThis is slated to be removed pretty soon and this fix seems to work. Do you have a case where this change doesn\u0027t work or makes things worse?","accounts_in_message":[],"_revision_number":2},{"id":"4eb67f88c6a499bd7728d990c01ce4a15947fcfa","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-03-17 15:48:10.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b7a7d12682588103cded044702c03da6064a1c21","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-03-17 15:52:12.000000000","message":"Patch Set 2:\n\n(6 comments)\n\nWhy don\u0027t we just remove the legacy deprecated arguments? We could do that in a follow up change too since it requires a major version bump (which we\u0027re going to do in the next novaclient release anyway because I\u0027ve already removed a bunch of deprecated proxy CLIs and APIs).","accounts_in_message":[],"_revision_number":2},{"id":"2bcebf276fa369eb3694d9e4297b225bd2a31d00","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-03-17 15:52:43.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"effa4ff1ee65bce1045c3b880273001ce4835f8f","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2017-03-17 16:01:06.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"2ef81fdd89f1b0885c39b4909564774439948d13","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-03-17 16:04:21.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"7c09ed5743dbd5a0172838244403cb72c749dc22","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2017-03-17 16:08:02.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a3e07564563788aa38d7e69cebc22026d7e59bdc","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2017-03-17 16:08:40.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a5218530079d629b42377ffb6c53250d186322c5","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-03-17 16:11:05.000000000","message":"Patch Set 3: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"be8c4438ea2075af5274fb5cca1abe96187de1db","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-03-17 16:11:36.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"182531f24abccd6fc4e330ed7c9ad98197654e3c","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2017-03-17 16:13:32.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"863c0f518aad00419a5694f4b808da9c0b628908","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2017-03-17 16:14:16.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"de3578891fcb126bc9214fb95071588aa8d3a0ef","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-03-17 16:32:51.000000000","message":"Patch Set 4:\n\nLGTM, I\u0027m just waiting on the functional test results.","accounts_in_message":[],"_revision_number":4},{"id":"4f95176988a64523400e44efb12bf9e509ba3c85","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-03-17 16:49:29.000000000","message":"Patch Set 4: Code-Review+2\n\nNew tests worked in the mitaka functional job:\n\nhttp://logs.openstack.org/09/447009/4/check/gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv/faccb2b/console.html#_2017-03-17_16_36_03_212900","accounts_in_message":[],"_revision_number":4},{"id":"1197b5891948d0933bb97d0da467e61a39563611","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2017-03-17 17:10:41.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\n@Dan: no, I\u0027m just speculating on what the underlying issue is.  As I say, we\u0027ve done positional argument name and option dest identical before and it\u0027s worked; the \"nargs\u003d\u0027?\u0027\" could introduce an ambiguity given that there are two of them.  As for why it\u0027s there, it\u0027s to make the positional argument optional so that --name/--availability-zone can be used instead of the positional arguments.\n\nIn any case, I agree with Matt; let\u0027s get this in, as-is, since it seems to work and we\u0027ll want to back-port; then, let\u0027s drop the deprecated arguments and simplify our lives for the future :)","accounts_in_message":[],"_revision_number":4},{"id":"bac0963984d2281ed527e9ca9ce1f36e116cea86","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-17 17:38:28.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/09/447009/4/check/gate-python-novaclient-docs-ubuntu-xenial/0276b1f//doc/build/html/ : SUCCESS in 2m 02s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/09/447009/4/check/gate-python-novaclient-pep8-ubuntu-xenial/6b8c9d4/ : SUCCESS in 2m 55s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/09/447009/4/check/gate-python-novaclient-python27-ubuntu-xenial/1a0a4c6/ : SUCCESS in 1m 51s\n- gate-python-novaclient-python35 http://logs.openstack.org/09/447009/4/check/gate-python-novaclient-python35/3a808ae/ : SUCCESS in 2m 54s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/09/447009/4/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/6ab2d8a/ : SUCCESS in 1h 20m 34s\n- gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv http://logs.openstack.org/09/447009/4/check/gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv/faccb2b/ : SUCCESS in 31m 16s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/09/447009/4/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/ee384a3/ : SUCCESS in 42m 30s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/09/447009/4/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/77c39cc/ : SUCCESS in 58m 29s","accounts_in_message":[],"_revision_number":4},{"id":"843c1d18d947ac672a7b8851fe60d31fa13a617c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-17 17:38:38.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"647a85a692b43197bb2f341b73369c43e0feae76","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-17 20:22:21.000000000","message":"Patch Set 4: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/09/447009/4/gate/gate-python-novaclient-docs-ubuntu-xenial/2498f2c//doc/build/html/ : SUCCESS in 3m 58s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/09/447009/4/gate/gate-python-novaclient-pep8-ubuntu-xenial/90ad064/ : SUCCESS in 4m 45s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/09/447009/4/gate/gate-python-novaclient-python27-ubuntu-xenial/4e70a78/ : SUCCESS in 3m 05s\n- gate-python-novaclient-python35 http://logs.openstack.org/09/447009/4/gate/gate-python-novaclient-python35/2e6ad7d/ : SUCCESS in 2m 16s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/09/447009/4/gate/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/e32abce/ : SUCCESS in 1h 02m 52s\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/09/447009/4/gate/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/b76c2d6/ : FAILURE in 1h 46m 11s","accounts_in_message":[],"_revision_number":4},{"id":"cb5778f80cd18d4bd9ab547f104a7c337d43ece6","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-03-17 21:12:18.000000000","message":"Patch Set 4:\n\nrecheck infra","accounts_in_message":[],"_revision_number":4},{"id":"3594aad9b6c680f0ae80f933ee86ecef3bed1c24","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-17 23:00:26.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/09/447009/4/check/gate-python-novaclient-docs-ubuntu-xenial/608c95e//doc/build/html/ : SUCCESS in 2m 37s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/09/447009/4/check/gate-python-novaclient-pep8-ubuntu-xenial/a0b7681/ : SUCCESS in 2m 09s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/09/447009/4/check/gate-python-novaclient-python27-ubuntu-xenial/1da8567/ : SUCCESS in 1m 34s\n- gate-python-novaclient-python35 http://logs.openstack.org/09/447009/4/check/gate-python-novaclient-python35/55767f1/ : SUCCESS in 2m 29s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/09/447009/4/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/f87ca99/ : SUCCESS in 1h 09m 47s\n- gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv http://logs.openstack.org/09/447009/4/check/gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv/0ed39c5/ : SUCCESS in 30m 30s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/09/447009/4/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/a78795b/ : SUCCESS in 56m 47s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/09/447009/4/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/1175915/ : FAILURE in 1h 46m 41s","accounts_in_message":[],"_revision_number":4},{"id":"99885c2661f14504addd75c266f582b7200a8e28","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-03-20 00:06:37.000000000","message":"Patch Set 4:\n\nrecheck infra","accounts_in_message":[],"_revision_number":4},{"id":"62a6ae55d9be89c553b89f57ce703fadce383f1e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-20 01:53:17.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/09/447009/4/check/gate-python-novaclient-docs-ubuntu-xenial/845e06b//doc/build/html/ : SUCCESS in 1m 49s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/09/447009/4/check/gate-python-novaclient-pep8-ubuntu-xenial/35ae2bb/ : SUCCESS in 3m 11s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/09/447009/4/check/gate-python-novaclient-python27-ubuntu-xenial/1a7cf0e/ : SUCCESS in 1m 36s\n- gate-python-novaclient-python35 http://logs.openstack.org/09/447009/4/check/gate-python-novaclient-python35/37d5223/ : SUCCESS in 1m 56s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/09/447009/4/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/02d98b6/ : SUCCESS in 1h 02m 52s\n- gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv http://logs.openstack.org/09/447009/4/check/gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv/db4ec85/ : SUCCESS in 45m 56s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/09/447009/4/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/7148613/ : FAILURE in 1h 46m 27s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/09/447009/4/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/9eb7199/ : SUCCESS in 57m 36s","accounts_in_message":[],"_revision_number":4},{"id":"db2866af888a9edb4e747caebc024f11ce0146fd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-20 01:53:27.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"82200877857bc7b8b63e9b9fbb4553060f6b7f2e","date":"2017-03-20 02:57:34.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":4},{"id":"2850923fa5e25754d219fb28f3eeec942b612c9a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-20 02:57:34.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/09/447009/4/gate/gate-python-novaclient-docs-ubuntu-xenial/422918a//doc/build/html/ : SUCCESS in 1m 43s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/09/447009/4/gate/gate-python-novaclient-pep8-ubuntu-xenial/4164bdd/ : SUCCESS in 2m 27s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/09/447009/4/gate/gate-python-novaclient-python27-ubuntu-xenial/46b90fe/ : SUCCESS in 3m 00s\n- gate-python-novaclient-python35 http://logs.openstack.org/09/447009/4/gate/gate-python-novaclient-python35/203c65d/ : SUCCESS in 2m 14s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/09/447009/4/gate/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/8f62dad/ : SUCCESS in 1h 03m 50s\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/09/447009/4/gate/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/acfa021/ : SUCCESS in 40m 03s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"20f00553d0d8ed791105d5f7fc8798b9ac6a6a53","revisions":{"6208f7759a50bd86d676596c6ef4f6b4b35decfc":{"kind":"REWORK","_number":1,"created":"2017-03-17 14:13:47.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/09/447009/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/09/447009/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/09/447009/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/09/447009/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/09/447009/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/09/447009/1"}}},"commit":{"parents":[{"commit":"296b5da84b595fb9da9de831eaae154ce61fa1b3","subject":"Merge \"Fix ValueError when incorrect metadata passed\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/296b5da84b595fb9da9de831eaae154ce61fa1b3"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2017-03-17 14:11:38.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2017-03-17 14:11:38.000000000","tz":-420},"subject":"Fix aggregate_update name and availability_zone clash","message":"Fix aggregate_update name and availability_zone clash\n\nThe name and availability_zone arguments to aggregate update were\nreplaced by optional parameters in change\nI778ab7ec54a376c60f19dcc89fe62fcab6e59e42. However, the \u0027--name\u0027 and\n\u0027name\u0027 arguments in the parser would conflict, resulting in only the\ndeprecated argument working. Thus, attempting to update the name\non an aggregate using --name would end up doing a PUT with no new\nname provided.\n\nChange-Id: Ifef6fdc1a737dd219712a4525d4e34afd3fbd80c\nCloses-Bug: #1673789\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/6208f7759a50bd86d676596c6ef4f6b4b35decfc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/6208f7759a50bd86d676596c6ef4f6b4b35decfc"}]},"branch":"refs/heads/master"},"b0976fa82c36c4bb74d417db35ce8b262e8220a2":{"kind":"REWORK","_number":2,"created":"2017-03-17 15:00:59.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/09/447009/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/09/447009/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/09/447009/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/09/447009/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/09/447009/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/09/447009/2"}}},"commit":{"parents":[{"commit":"296b5da84b595fb9da9de831eaae154ce61fa1b3","subject":"Merge \"Fix ValueError when incorrect metadata passed\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/296b5da84b595fb9da9de831eaae154ce61fa1b3"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2017-03-17 14:11:38.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2017-03-17 15:01:23.000000000","tz":-420},"subject":"Fix aggregate_update name and availability_zone clash","message":"Fix aggregate_update name and availability_zone clash\n\nThe name and availability_zone arguments to aggregate update were\nreplaced by optional parameters in change\nI778ab7ec54a376c60f19dcc89fe62fcab6e59e42. However, the \u0027--name\u0027 and\n\u0027name\u0027 arguments in the parser would conflict, resulting in only the\ndeprecated argument working. Thus, attempting to update the name\non an aggregate using --name would end up doing a PUT with no new\nname provided.\n\nNote that there were unit tests for this, but they were not catching\nthis problem. So, this removes those tests and adds functional tests\nto poke it.\n\nChange-Id: Ifef6fdc1a737dd219712a4525d4e34afd3fbd80c\nCloses-Bug: #1673789\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b0976fa82c36c4bb74d417db35ce8b262e8220a2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b0976fa82c36c4bb74d417db35ce8b262e8220a2"}]},"branch":"refs/heads/master"},"eedf1660c0ea4d0c59182e48c5661a486bb46049":{"kind":"REWORK","_number":3,"created":"2017-03-17 16:08:40.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/09/447009/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/09/447009/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/09/447009/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/09/447009/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/09/447009/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/09/447009/3"}}},"commit":{"parents":[{"commit":"296b5da84b595fb9da9de831eaae154ce61fa1b3","subject":"Merge \"Fix ValueError when incorrect metadata passed\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/296b5da84b595fb9da9de831eaae154ce61fa1b3"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2017-03-17 14:11:38.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2017-03-17 16:09:32.000000000","tz":-420},"subject":"Fix aggregate_update name and availability_zone clash","message":"Fix aggregate_update name and availability_zone clash\n\nThe name and availability_zone arguments to aggregate update were\nreplaced by optional parameters in change\nI778ab7ec54a376c60f19dcc89fe62fcab6e59e42. However, the \u0027--name\u0027 and\n\u0027name\u0027 arguments in the parser would conflict, resulting in only the\ndeprecated argument working. Thus, attempting to update the name\non an aggregate using --name would end up doing a PUT with no new\nname provided.\n\nNote that there were unit tests for this, but they were not catching\nthis problem. So, this removes those tests and adds functional tests\nto poke it.\n\nChange-Id: Ifef6fdc1a737dd219712a4525d4e34afd3fbd80c\nCloses-Bug: #1673789\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/eedf1660c0ea4d0c59182e48c5661a486bb46049"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/eedf1660c0ea4d0c59182e48c5661a486bb46049"}]},"branch":"refs/heads/master"},"20f00553d0d8ed791105d5f7fc8798b9ac6a6a53":{"kind":"REWORK","_number":4,"created":"2017-03-17 16:14:16.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/09/447009/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/09/447009/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/09/447009/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/09/447009/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/09/447009/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/09/447009/4"}}},"commit":{"parents":[{"commit":"296b5da84b595fb9da9de831eaae154ce61fa1b3","subject":"Merge \"Fix ValueError when incorrect metadata passed\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/296b5da84b595fb9da9de831eaae154ce61fa1b3"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2017-03-17 14:11:38.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2017-03-17 16:15:10.000000000","tz":-420},"subject":"Fix aggregate_update name and availability_zone clash","message":"Fix aggregate_update name and availability_zone clash\n\nThe name and availability_zone arguments to aggregate update were\nreplaced by optional parameters in change\nI778ab7ec54a376c60f19dcc89fe62fcab6e59e42. However, the \u0027--name\u0027 and\n\u0027name\u0027 arguments in the parser would conflict, resulting in only the\ndeprecated argument working. Thus, attempting to update the name\non an aggregate using --name would end up doing a PUT with no new\nname provided.\n\nNote that there were unit tests for this, but they were not catching\nthis problem. So, this removes those tests and adds functional tests\nto poke it.\n\nChange-Id: Ifef6fdc1a737dd219712a4525d4e34afd3fbd80c\nCloses-Bug: #1673789\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/20f00553d0d8ed791105d5f7fc8798b9ac6a6a53"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/20f00553d0d8ed791105d5f7fc8798b9ac6a6a53"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}