)]}'
{"id":"openstack%2Fpython-novaclient~450763","triplet_id":"openstack%2Fpython-novaclient~master~I8b40b0db450287bbc5ee8d69834aa764353dbd98","project":"openstack/python-novaclient","branch":"master","topic":"servers_group","hashtags":[],"change_id":"I8b40b0db450287bbc5ee8d69834aa764353dbd98","subject":"Explicitly specify arguments of server_groups creation","status":"MERGED","created":"2017-03-28 12:35:53.000000000","updated":"2017-04-18 14:52:44.000000000","submitted":"2017-04-18 14:52:44.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"00a7636750ec4caade466d2e037cb73df563fc81","_number":450763,"virtual_id_number":450763,"owner":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":2,"date":"2017-04-18 14:52:44.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"recommended":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"all":[{"value":1,"date":"2017-04-06 06:10:54.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-03-28 14:33:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2017-03-28 19:33:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},{"value":2,"date":"2017-04-18 13:32:06.000000000","_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},{"value":1,"date":"2017-04-18 13:32:06.000000000","_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-28 14:33:48.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2017-03-28 19:33:21.000000000","updated_by":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"reviewer":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"state":"REVIEWER"},{"updated":"2017-04-06 06:10:54.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2017-04-18 13:32:06.000000000","updated_by":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"reviewer":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"state":"REVIEWER"},{"updated":"2017-04-18 14:52:44.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"10be0b0771378bffc50770e21c6e5e7801740dc4","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2017-03-28 12:35:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a8c04831d4f3cfb0a449604d12dd456c4ea8760d","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2017-03-28 12:54:10.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"20d77003cb554bb264999666eb4fc69cfec9767a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-28 14:28:25.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/63/450763/2/check/gate-python-novaclient-docs-ubuntu-xenial/64a2198//doc/build/html/ : SUCCESS in 1m 50s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/63/450763/2/check/gate-python-novaclient-pep8-ubuntu-xenial/325a7aa/ : SUCCESS in 3m 18s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/63/450763/2/check/gate-python-novaclient-python27-ubuntu-xenial/2d66192/ : SUCCESS in 3m 15s\n- gate-python-novaclient-python35 http://logs.openstack.org/63/450763/2/check/gate-python-novaclient-python35/7416f52/ : SUCCESS in 2m 10s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/63/450763/2/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/faba39a/ : SUCCESS in 1h 30m 31s\n- gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv http://logs.openstack.org/63/450763/2/check/gate-novaclient-dsvm-functional-mitaka-ubuntu-trusty-nv/6e2e249/ : SUCCESS in 27m 23s (non-voting)\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/63/450763/2/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/759b82d/ : SUCCESS in 58m 08s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/63/450763/2/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/cd4f18a/ : SUCCESS in 1h 03m 39s","accounts_in_message":[],"_revision_number":2},{"id":"a48ecd1a799a244283ebc8328f786cb7b7735789","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2017-03-28 14:33:48.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"c9283cee00493292aa1e2758a698bcfc92a862f7","author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"date":"2017-03-28 19:33:21.000000000","message":"Patch Set 2: Code-Review+1\n\nPrior to this change, the following failed.\n\n    nova_client.server_groups.create(name\u003d\"foo\", policies\u003d\"affinity\")\n\nWith the error message:\n\n    Value: affinity. u\u0027affinity\u0027 is not of type \u0027array\u0027\n\nNow, it works fine.\n\nI\u0027m +1 on this change, but I wonder if a unit test should be added for the ternary list-maker you added to server groups create (for the newly valid string case).\n\nSome manual testing notes:\n\n- http://paste.openstack.org/show/604560/","accounts_in_message":[],"_revision_number":2},{"id":"8ede12388b6a71418c6f475d8732bcdffe404dd7","author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"date":"2017-03-28 19:37:24.000000000","message":"Patch Set 2:\n\nPS. There was a typo in my more than 1 policy case (which doesn\u0027t work in practice anyway). Here it is corrected:\n\n- http://paste.openstack.org/show/604562/\n\nCheers!","accounts_in_message":[],"_revision_number":2},{"id":"8b5a40ac44b0324c2e0fa63df52499fff243014b","author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"date":"2017-03-28 19:39:24.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"326f739f8a32d683cc51b9199604739472cecb84","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2017-04-06 06:10:54.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"a4c3eb4134b883de81aa56147e9fd83c0a012027","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2017-04-18 13:32:06.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nI am +1 the extra until test, and ideally a reno note describing the \"fix\", but I am OK with the change, and don\u0027t want to delay it any more.","accounts_in_message":[],"_revision_number":2},{"id":"f558efddeefb15ba1de385511fef738ff1756fe5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-18 13:32:31.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"b8155b0fa83c01e02b6eb96bdcace377b1514086","date":"2017-04-18 14:52:44.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"f7ca505abc9c9f52124dedef7c1cae939edfd7aa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-18 14:52:44.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/63/450763/2/gate/gate-python-novaclient-docs-ubuntu-xenial/9156219//doc/build/html/ : SUCCESS in 1m 45s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/63/450763/2/gate/gate-python-novaclient-pep8-ubuntu-xenial/efc0693/ : SUCCESS in 2m 14s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/63/450763/2/gate/gate-python-novaclient-python27-ubuntu-xenial/763293d/ : SUCCESS in 1m 55s\n- gate-python-novaclient-python35 http://logs.openstack.org/63/450763/2/gate/gate-python-novaclient-python35/221921d/ : SUCCESS in 2m 53s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/63/450763/2/gate/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/01eb896/ : SUCCESS in 1h 18m 53s\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/63/450763/2/gate/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/8a29683/ : SUCCESS in 50m 57s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"773aea23b8817aaa077db90ebcecedb33383550e","revisions":{"f94138e655b91f6a064f4bd65b4f645b1ebacb2b":{"kind":"REWORK","_number":1,"created":"2017-03-28 12:35:53.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/63/450763/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/63/450763/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/63/450763/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/63/450763/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/63/450763/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/63/450763/1"}}},"commit":{"parents":[{"commit":"85106a6f706e4f3b22d5e3e954e9a5b69fd43e78","subject":"Merge \"Remove py34 tox env and pypi classifier\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/85106a6f706e4f3b22d5e3e954e9a5b69fd43e78"}]}],"author":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2017-03-28 12:32:01.000000000","tz":180},"committer":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2017-03-28 12:32:01.000000000","tz":180},"subject":"Explicitly specify arguments of server_groups creation","message":"Explicitly specify arguments of server_groups creation\n\nCreate API call expectes two parameters - name and policy[*]. It is not a\ncomplex structure, so there is no reason to support kwargs. It is better to\nspecify explicitly all expected parameters.\n\nPS: removing support of kwargs is \"backward compatible\", since we have\nvalidation at API side and usage of additional parameters was an error\npreviously.\n\n[*] - https://developer.openstack.org/api-ref/compute/?expanded\u003dcreate-server-group-detail\n\nChange-Id: I8b40b0db450287bbc5ee8d69834aa764353dbd98\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f94138e655b91f6a064f4bd65b4f645b1ebacb2b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f94138e655b91f6a064f4bd65b4f645b1ebacb2b"}]},"branch":"refs/heads/master"},"773aea23b8817aaa077db90ebcecedb33383550e":{"kind":"REWORK","_number":2,"created":"2017-03-28 12:54:10.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/63/450763/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/63/450763/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/63/450763/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/63/450763/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/63/450763/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/63/450763/2"}}},"commit":{"parents":[{"commit":"85106a6f706e4f3b22d5e3e954e9a5b69fd43e78","subject":"Merge \"Remove py34 tox env and pypi classifier\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/85106a6f706e4f3b22d5e3e954e9a5b69fd43e78"}]}],"author":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2017-03-28 12:32:01.000000000","tz":180},"committer":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2017-03-28 12:53:44.000000000","tz":180},"subject":"Explicitly specify arguments of server_groups creation","message":"Explicitly specify arguments of server_groups creation\n\nCreate API call expectes two parameters - name and policies[*]. It is not a\ncomplex structure, so there is no reason to support kwargs. It is better to\nspecify explicitly all expected parameters.\n\nPS: removing support of kwargs is \"backward compatible\", since we have\nvalidation at API side and usage of additional parameters was an error\npreviously.\n\n[*] - https://developer.openstack.org/api-ref/compute/?expanded\u003dcreate-server-group-detail\n\nChange-Id: I8b40b0db450287bbc5ee8d69834aa764353dbd98\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/773aea23b8817aaa077db90ebcecedb33383550e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/773aea23b8817aaa077db90ebcecedb33383550e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}