)]}'
{"id":"openstack%2Fpython-novaclient~463477","triplet_id":"openstack%2Fpython-novaclient~master~I1995b13e707e38a8a8f4de3fd6cfa8497e21ecdf","project":"openstack/python-novaclient","branch":"master","topic":"bug/1674247","hashtags":[],"change_id":"I1995b13e707e38a8a8f4de3fd6cfa8497e21ecdf","subject":"Reset-state\u0027s default parameter needs correction","status":"ABANDONED","created":"2017-05-09 06:36:34.000000000","updated":"2017-07-04 05:56:59.000000000","total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ac34e5123b7f638ed6d11330e56db601eed68d96","_number":463477,"virtual_id_number":463477,"owner":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2017-06-02 12:02:21.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"date":"2017-06-02 15:20:38.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"date":"2017-06-05 11:09:06.000000000","_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":-1,"date":"2017-06-06 17:58:26.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-05-12 05:40:24.000000000","updated_by":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"reviewer":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"state":"REVIEWER"},{"updated":"2017-05-12 05:40:24.000000000","updated_by":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"reviewer":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"state":"REVIEWER"},{"updated":"2017-05-12 05:40:24.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2017-05-12 05:40:24.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2017-05-12 05:40:24.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2017-05-12 05:40:24.000000000","updated_by":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"reviewer":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"state":"REVIEWER"},{"updated":"2017-05-12 05:40:24.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2017-05-12 05:40:24.000000000","updated_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"reviewer":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"state":"REVIEWER"},{"updated":"2017-05-12 05:40:24.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2017-06-02 12:02:21.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-06-02 15:20:38.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2017-06-06 17:58:26.000000000","updated_by":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"reviewer":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"state":"REVIEWER"}],"messages":[{"id":"fdf360c5411ef0bb8b1001703ab7208b8b57885f","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-05-09 06:36:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bd10872127822f0b85646e7cf22d7d37586350c7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-09 07:56:34.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/77/463477/1/check/gate-python-novaclient-docs-ubuntu-xenial/72908ac//doc/build/html/ : SUCCESS in 2m 22s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/77/463477/1/check/gate-python-novaclient-pep8-ubuntu-xenial/7223c26/ : SUCCESS in 2m 57s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/77/463477/1/check/gate-python-novaclient-python27-ubuntu-xenial/9368d13/ : SUCCESS in 1m 32s\n- gate-python-novaclient-python35 http://logs.openstack.org/77/463477/1/check/gate-python-novaclient-python35/1dca2ae/ : SUCCESS in 2m 06s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/77/463477/1/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/a1bd1c0/ : SUCCESS in 1h 19m 44s\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/77/463477/1/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/20a5df6/ : FAILURE in 53m 40s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/77/463477/1/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/1baac02/ : FAILURE in 33m 44s","accounts_in_message":[],"_revision_number":1},{"id":"876be6ebde3add3262898fd58c0fc6e2fced15a8","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-05-09 09:54:28.000000000","message":"Patch Set 1:\n\nRECHECK","accounts_in_message":[],"_revision_number":1},{"id":"fa08418d06e47291aaa706c023b0cbdfa8f07647","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-09 11:06:04.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/77/463477/1/check/gate-python-novaclient-docs-ubuntu-xenial/dc04636//doc/build/html/ : SUCCESS in 1m 20s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/77/463477/1/check/gate-python-novaclient-pep8-ubuntu-xenial/7fccfc5/ : SUCCESS in 1m 56s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/77/463477/1/check/gate-python-novaclient-python27-ubuntu-xenial/2418f86/ : SUCCESS in 2m 09s\n- gate-python-novaclient-python35 http://logs.openstack.org/77/463477/1/check/gate-python-novaclient-python35/d2af508/ : SUCCESS in 1m 39s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/77/463477/1/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/88d698f/ : SUCCESS in 1h 09m 26s\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/77/463477/1/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/8c0f257/ : FAILURE in 51m 31s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/77/463477/1/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/47bcef1/ : FAILURE in 53m 56s","accounts_in_message":[],"_revision_number":1},{"id":"f850266b93f687b9afdc901c244dce1c7c251418","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2017-05-09 21:54:57.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nIf I recall correctly, \"reset-state\" was introduced solely to handle the case of recovery from Nova internal errors, and the default of \u0027error\u0027 was deliberately chosen to encourage developers to spend their time correcting the problem in Nova rather than leveraging the work-around.","accounts_in_message":[],"_revision_number":1},{"id":"0b7d0e8c1ea2c756964d53c106e2a19cfa03b6e3","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-05-10 07:08:30.000000000","message":"Patch Set 1:\n\nRECHECK","accounts_in_message":[],"_revision_number":1},{"id":"192ffcd220c3113e8415b1997630066d81aea6b2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-10 08:28:39.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/77/463477/1/check/gate-python-novaclient-docs-ubuntu-xenial/1278703//doc/build/html/ : SUCCESS in 2m 47s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/77/463477/1/check/gate-python-novaclient-pep8-ubuntu-xenial/120bfcb/ : SUCCESS in 3m 26s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/77/463477/1/check/gate-python-novaclient-python27-ubuntu-xenial/bea7e39/ : SUCCESS in 1m 28s\n- gate-python-novaclient-python35 http://logs.openstack.org/77/463477/1/check/gate-python-novaclient-python35/ab1342c/ : SUCCESS in 2m 21s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/77/463477/1/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/d035d07/ : SUCCESS in 1h 19m 52s\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/77/463477/1/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/bfea7c4/ : FAILURE in 51m 46s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/77/463477/1/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/2a4dcc0/ : FAILURE in 52m 07s","accounts_in_message":[],"_revision_number":1},{"id":"1602872d666d2417846c3feb92036af5a3f216fb","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-05-11 05:00:57.000000000","message":"Patch Set 1:\n\nRECHECK","accounts_in_message":[],"_revision_number":1},{"id":"d26e4baa29e253f46136fbaf3d06ab21aaecddf3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-11 06:13:40.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/77/463477/1/check/gate-python-novaclient-docs-ubuntu-xenial/40134d3//doc/build/html/ : SUCCESS in 1m 09s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/77/463477/1/check/gate-python-novaclient-pep8-ubuntu-xenial/2d041ed/ : SUCCESS in 2m 46s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/77/463477/1/check/gate-python-novaclient-python27-ubuntu-xenial/49d1fcd/ : SUCCESS in 2m 10s\n- gate-python-novaclient-python35 http://logs.openstack.org/77/463477/1/check/gate-python-novaclient-python35/0c5e811/ : SUCCESS in 1m 26s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/77/463477/1/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/af41abe/ : SUCCESS in 1h 11m 50s\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/77/463477/1/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/1573994/ : FAILURE in 32m 05s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/77/463477/1/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/00e6a9f/ : FAILURE in 1h 02m 30s","accounts_in_message":[],"_revision_number":1},{"id":"2f735c14d3d0735b08f3036bb54d9b7d74202c6e","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-05-12 05:40:10.000000000","message":"Patch Set 1:\n\n\u003e (1 comment)\n \u003e \n \u003e If I recall correctly, \"reset-state\" was introduced solely to\n \u003e handle the case of recovery from Nova internal errors, and the\n \u003e default of \u0027error\u0027 was deliberately chosen to encourage developers\n \u003e to spend their time correcting the problem in Nova rather than\n \u003e leveraging the work-around.\n\n\n\nHello Kevin,\n\nAs its an admin exposed command and as you said \n\"to handle the case of recovery from Nova internal error\"\n\nOnce internal error is sorted, this is to set the instance back to active state.\n\nThis is similar to logic being followed in cinder manila.\n\nhttps://blueprints.launchpad.net/horizon/+spec/cinder-reset-volume-state\n\nDoes that make sense ?","accounts_in_message":[],"_revision_number":1},{"id":"8883f0f14f4c3aca36352f7471ad7e215c8f6d48","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-05-23 10:25:20.000000000","message":"Patch Set 1:\n\nHello Kevin,\n\nWhat do you say, should we proceed with fix to change state from error to active as per reason given in my previous message?","accounts_in_message":[],"_revision_number":1},{"id":"8d733cac696ad29072560df65412cdc08cb0748d","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-05-23 10:25:35.000000000","message":"Patch Set 1:\n\nRECHECK","accounts_in_message":[],"_revision_number":1},{"id":"f3a046c78d3cc1a32e1f070f6037778d901581c2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-23 11:45:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/77/463477/1/check/gate-python-novaclient-docs-ubuntu-xenial/4c4bb1e//doc/build/html/ : SUCCESS in 2m 40s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/77/463477/1/check/gate-python-novaclient-pep8-ubuntu-xenial/3ed5810/ : SUCCESS in 3m 30s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/77/463477/1/check/gate-python-novaclient-python27-ubuntu-xenial/5211f89/ : SUCCESS in 3m 52s\n- gate-python-novaclient-python35 http://logs.openstack.org/77/463477/1/check/gate-python-novaclient-python35/906374f/ : SUCCESS in 1m 40s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/77/463477/1/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/c28f85d/ : SUCCESS in 1h 18m 36s\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/77/463477/1/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/ef8b729/ : SUCCESS in 34m 19s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/77/463477/1/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/9778371/ : SUCCESS in 32m 21s","accounts_in_message":[],"_revision_number":1},{"id":"f5bc384b5ec5ae0fc5046139e2e30cc2fa68e394","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-05-25 04:50:29.000000000","message":"Patch Set 1:\n\ncan someone please review it ?","accounts_in_message":[],"_revision_number":1},{"id":"fc8eff718313f9ba24f945ffbf8160c65cad5e0f","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-06-01 06:39:29.000000000","message":"Patch Set 1:\n\nCan someone please review it ??","accounts_in_message":[],"_revision_number":1},{"id":"cf99ddc2c725b51c636da75540d70ceab5a9653f","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-06-01 06:40:09.000000000","message":"Patch Set 1:\n\nWaiting for its review.. can someone please review?","accounts_in_message":[],"_revision_number":1},{"id":"7b513f227a9e2654e9e9eb3a99d05ee8ab388414","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2017-06-01 15:27:42.000000000","message":"Patch Set 1: Code-Review-1\n\nI gave a review, but you haven\u0027t revised your commit message yet.  But to make it more formal, I\u0027ll hit -1.","accounts_in_message":[],"_revision_number":1},{"id":"01d473ff40c03ee7c4a34ed111dd359ec99906d6","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-06-02 05:52:22.000000000","message":"Patch Set 1:\n\nOh!! My mistake, By mistake i just missed this commit message comment.\nWorking on it","accounts_in_message":[],"_revision_number":1},{"id":"e5df1944526996d0f0b672d4e8afa005c6fb93ed","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-06-02 10:27:44.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"72a093c4e18b224a896b7c7c6c4e16bdb4e4a05b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-02 12:02:21.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/77/463477/2/check/gate-python-novaclient-docs-ubuntu-xenial/ff6b086//doc/build/html/ : SUCCESS in 2m 06s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/77/463477/2/check/gate-python-novaclient-pep8-ubuntu-xenial/1bf17ce/ : SUCCESS in 2m 39s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/77/463477/2/check/gate-python-novaclient-python27-ubuntu-xenial/eab2148/ : SUCCESS in 1m 45s\n- gate-python-novaclient-python35 http://logs.openstack.org/77/463477/2/check/gate-python-novaclient-python35/e9c5e71/ : SUCCESS in 3m 11s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/77/463477/2/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/b4f02e1/ : SUCCESS in 1h 32m 46s\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/77/463477/2/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/6906563/ : SUCCESS in 55m 03s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/77/463477/2/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/4a38e4c/ : SUCCESS in 53m 45s","accounts_in_message":[],"_revision_number":2},{"id":"52da15d2ca5c0063dcad04c70e16bb7ea1e96d5e","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2017-06-02 15:20:38.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nI\u0027d like to see some comments from other reviewers about whether we should change the default of reset-state to \"active\".  It would also be good to discuss whether we should provide the ability to set other states, as this change eliminates the possibility to do so from the command line.","accounts_in_message":[],"_revision_number":2},{"id":"15e9b4850823d9426543d75ab98dbe0bea877f6b","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-06-05 11:09:06.000000000","message":"Patch Set 2:\n\n\u003e (1 comment)\n \u003e \n \u003e I\u0027d like to see some comments from other reviewers about whether we\n \u003e should change the default of reset-state to \"active\".  It would\n \u003e also be good to discuss whether we should provide the ability to\n \u003e set other states, as this change eliminates the possibility to do\n \u003e so from the command line.\n\n \u003e (1 comment)\n \u003e \n \u003e I\u0027d like to see some comments from other reviewers about whether we\n \u003e should change the default of reset-state to \"active\".  It would\n \u003e also be good to discuss whether we should provide the ability to\n \u003e set other states, as this change eliminates the possibility to do\n \u003e so from the command line.\n\n\n\nHi Kevin,\n\nSummarizing\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nEarlier we had possibility to set -\u003e\n   state \"active\" explicitly by giving --active\n   state as \"error\" by default.\n \nThere wasn\u0027t any option to set any other state. PCMIIW\n\nAfter this change \n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nstate will be \"active\" by default.\n--active will set it to active explicitly - You are right it looks redundant.\n\nDo we require/want to allow admin to put instance in any other state than active explicitly ? \n\nDo we want --error to put instance in error state for some use case ?","accounts_in_message":[],"_revision_number":2},{"id":"0483815c6fc125d3d30dfae710adbc78dc53ead3","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-06-06 05:01:47.000000000","message":"Patch Set 2:\n\nReviewers,\n\nWould request your opinion on this..\n\nWill make changes accordingly.","accounts_in_message":[],"_revision_number":2},{"id":"5ca819afd09a255037ac57f60552c9cbd48bce00","author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"date":"2017-06-06 17:58:26.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b7c85193c1a55fa403555bf0a28139d19a87bf2a","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-06-08 07:03:12.000000000","message":"Patch Set 2:\n\nHello reviewers,\n\nMay i know your opinion on,\n\n1)\nMy reasoning for changing default state to active - as done similarly in other openstack codes for reset-state and for reasons stated in commit message,\n\n\"Reset-state is an admin exposed command and once admin has sorted\ninternal error occurred in nova instance, this command will help to set the instance back to “active” state\"\n\nDoes this make sense? \n\n2) In that case should i deprecate --active?\n\n3)Should we consider giving user a facility of changing to any other state by giving --state as an optional arg?\n\n4)But if we see difference from cinder command \nCinder states \"its a database only change\"\n\n\nstack@ubuntu14-OptiPlex-3020:~/openstack_install/devstack$ cinder help reset-state\nusage: cinder reset-state [--type \u003ctype\u003e] [--state \u003cstate\u003e]\n                          [--attach-status \u003cattach-status\u003e]\n                          [--reset-migration-status]\n                          \u003centity\u003e [\u003centity\u003e ...]\n\nExplicitly updates the entity state in the Cinder database. Being a database\nchange only, this has no impact on the true state of the entity and may not\nmatch the actual state. This can render a entity unusable in the case of\nchanging to the \u0027available\u0027 state.\n\n\nbut in nova case Its not stated so \nstack@ubuntu14-OptiPlex-3020:~/openstack_install/devstack$ nova help reset-state\nusage: nova reset-state [--all-tenants] [--active] \u003cserver\u003e [\u003cserver\u003e ...]\n\nReset the state of a server.\n\n\nSo will it be possible to change state of server to any state ?","accounts_in_message":[],"_revision_number":2},{"id":"38531b45fb4e2f81109eae320a694ceef091dadb","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-06-08 07:25:21.000000000","message":"Patch Set 2:\n\nhave queried same in openstack-dev mailinng list.","accounts_in_message":[],"_revision_number":2},{"id":"46d93411cd6a4c3d6c8693b2495fd94525ae6bab","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-06-19 05:26:07.000000000","message":"Patch Set 2:\n\nNO reply on mailing list. How to go further on this. \nCore members kindly suggest !!","accounts_in_message":[],"_revision_number":2},{"id":"747fe2a1bbc5a281d42f4dd19655519ae71289a6","author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"date":"2017-06-19 17:20:28.000000000","message":"Patch Set 2:\n\nSorry for my reply,\n\n \u003e 1)\n \u003e My reasoning for changing default state to active - as done\n \u003e similarly in other openstack codes for reset-state and for reasons\n \u003e stated in commit message,\n \u003e\n \u003e \"Reset-state is an admin exposed command and once admin has sorted\n \u003e internal error occurred in nova instance, this command will help to\n \u003e set the instance back to “active” state\"\n\nThat doesn\u0027t make sense so much for me.\nBecause this reset-state subcommand has been implemented since the commit I47d1d75e3bd2a07b3b75302b512122b27d5d79d9 which was 2012 and the default value was never changed. So many users already use this default value over 5 years. I could not find the above reason is enough against the existing users.\n\nDoes this make sense?","accounts_in_message":[],"_revision_number":2},{"id":"1c6dc66faa59426c723184a5110cd784eee6d8f1","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-06-20 04:49:21.000000000","message":"Patch Set 2:\n\n\u003e Sorry for my reply,\n \u003e \n \u003e \u003e 1)\n \u003e \u003e My reasoning for changing default state to active - as done\n \u003e \u003e similarly in other openstack codes for reset-state and for\n \u003e reasons\n \u003e \u003e stated in commit message,\n \u003e \u003e\n \u003e \u003e \"Reset-state is an admin exposed command and once admin has\n \u003e sorted\n \u003e \u003e internal error occurred in nova instance, this command will help\n \u003e to\n \u003e \u003e set the instance back to “active” state\"\n \u003e \n \u003e That doesn\u0027t make sense so much for me.\n \u003e Because this reset-state subcommand has been implemented since the\n \u003e commit I47d1d75e3bd2a07b3b75302b512122b27d5d79d9 which was 2012 and\n \u003e the default value was never changed. So many users already use this\n \u003e default value over 5 years. I could not find the above reason is\n \u003e enough against the existing users.\n \u003e \n \u003e Does this make sense?\n\nHello Ken,\nThanks for your reply. May be you are right,\nOthers please opinionate..\nI will abandon the change if its not a required change.\n\nThanks\nNidhi","accounts_in_message":[],"_revision_number":2},{"id":"522fc492864c9d61eb60d671aa20777c56298531","author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"date":"2017-07-04 05:56:59.000000000","message":"Abandoned\n\nAbandoning the change, It looks like its not required change","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"720d5a787b22e3644744db72115eb6da18d12c11","revisions":{"003cad9a34eded4a0a0dbddf43b5be1173cac113":{"kind":"REWORK","_number":1,"created":"2017-05-09 06:36:34.000000000","uploader":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"ref":"refs/changes/77/463477/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/77/463477/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/77/463477/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/77/463477/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/77/463477/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/77/463477/1"}}},"commit":{"parents":[{"commit":"ff1eff18d9815ffa2588034769c842615e76507d","subject":"Remove direct dependency on requests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ff1eff18d9815ffa2588034769c842615e76507d"}]}],"author":{"name":"nidhimittalhada","email":"nidhimittal19@gmail.com","date":"2017-05-09 06:28:29.000000000","tz":330},"committer":{"name":"nidhimittalhada","email":"nidhimittal19@gmail.com","date":"2017-05-09 06:36:05.000000000","tz":330},"subject":"Reset-state\u0027s default parameter needs correction","message":"Reset-state\u0027s default parameter needs correction\n\nChanged reset-state default parameter to be \u0027active\u0027\ninstead of \u0027error\u0027.\n\nChange-Id: I1995b13e707e38a8a8f4de3fd6cfa8497e21ecdf\nCloses-Bug: #1674247\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/003cad9a34eded4a0a0dbddf43b5be1173cac113"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/003cad9a34eded4a0a0dbddf43b5be1173cac113"}]},"branch":"refs/heads/master"},"720d5a787b22e3644744db72115eb6da18d12c11":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2017-06-02 10:27:44.000000000","uploader":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"ref":"refs/changes/77/463477/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/77/463477/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/77/463477/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/77/463477/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/77/463477/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/77/463477/2"}}},"commit":{"parents":[{"commit":"ff1eff18d9815ffa2588034769c842615e76507d","subject":"Remove direct dependency on requests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ff1eff18d9815ffa2588034769c842615e76507d"}]}],"author":{"name":"nidhimittalhada","email":"nidhimittal19@gmail.com","date":"2017-05-09 06:28:29.000000000","tz":330},"committer":{"name":"nidhimittalhada","email":"nidhimittal19@gmail.com","date":"2017-06-02 10:24:58.000000000","tz":330},"subject":"Reset-state\u0027s default parameter needs correction","message":"Reset-state\u0027s default parameter needs correction\n\nReset-state is an admin exposed command and once admin has sorted\ninternal error occurred in nova instance, this command will help to set\nthe instance back to “active” state.\n\nHence, Changed reset-state default parameter to be \u0027active\u0027\ninstead of \u0027error\u0027.\n\nChange-Id: I1995b13e707e38a8a8f4de3fd6cfa8497e21ecdf\nCloses-Bug: #1674247\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/720d5a787b22e3644744db72115eb6da18d12c11"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/720d5a787b22e3644744db72115eb6da18d12c11"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
