)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"33a3b032710be0b5bf123c87298d13779302386a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously, the client would allow a boot command containing, for"},{"line_number":10,"context_line":"example, --nic auto,tag\u003dfoo, given the impression that the auto nic"},{"line_number":11,"context_line":"woudl receive a tag. This is not the case. Instead of silently"},{"line_number":12,"context_line":"ignoring the tag argument in such a case, this patch makes the client"},{"line_number":13,"context_line":"error out with a warning message."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df140735_bd80e7c0","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":5},"updated":"2017-06-01 20:24:51.000000000","message":"would","commit_id":"3cedba30ac0955ef16e88e49062fdd88307a16f8"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"43aedc777319f4f86d4ac3e15853a8c6b8d90166","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously, the client would allow a boot command containing, for"},{"line_number":10,"context_line":"example, --nic auto,tag\u003dfoo, given the impression that the auto nic"},{"line_number":11,"context_line":"woudl receive a tag. This is not the case. Instead of silently"},{"line_number":12,"context_line":"ignoring the tag argument in such a case, this patch makes the client"},{"line_number":13,"context_line":"error out with a warning message."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df140735_d8e3a9d8","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":5},"in_reply_to":"df140735_bd80e7c0","updated":"2017-06-01 21:02:04.000000000","message":"Done","commit_id":"3cedba30ac0955ef16e88e49062fdd88307a16f8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"33a3b032710be0b5bf123c87298d13779302386a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"woudl receive a tag. This is not the case. Instead of silently"},{"line_number":12,"context_line":"ignoring the tag argument in such a case, this patch makes the client"},{"line_number":13,"context_line":"error out with a warning message."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Id7ef67435fa7a3f49c9abcb751f5fa9458388f13"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df140735_7d6ecf2f","line":14,"updated":"2017-06-01 20:24:51.000000000","message":"Want to open a bug for this so we can backport the fix to stable?","commit_id":"3cedba30ac0955ef16e88e49062fdd88307a16f8"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"43aedc777319f4f86d4ac3e15853a8c6b8d90166","unresolved":false,"context_lines":[{"line_number":11,"context_line":"woudl receive a tag. This is not the case. Instead of silently"},{"line_number":12,"context_line":"ignoring the tag argument in such a case, this patch makes the client"},{"line_number":13,"context_line":"error out with a warning message."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Id7ef67435fa7a3f49c9abcb751f5fa9458388f13"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df140735_b8e475e1","line":14,"in_reply_to":"df140735_7d6ecf2f","updated":"2017-06-01 21:02:04.000000000","message":"Done","commit_id":"3cedba30ac0955ef16e88e49062fdd88307a16f8"}],"novaclient/v2/shell.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"33a3b032710be0b5bf123c87298d13779302386a","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        for kv_str in nic_str.split(\",\"):"},{"line_number":302,"context_line":"            if auto_or_none:"},{"line_number":303,"context_line":"                raise expcetions.CommandError(\"\u0027auto\u0027 or \u0027none\u0027 cannot be \""},{"line_number":304,"context_line":"                                              \"user with any other nic \""},{"line_number":305,"context_line":"                                              \"arguments\")"},{"line_number":306,"context_line":"            try:"},{"line_number":307,"context_line":"                # handle the special auto/none cases"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_7d292fe4","line":304,"range":{"start_line":304,"start_character":47,"end_line":304,"end_character":51},"updated":"2017-06-01 20:24:51.000000000","message":"used","commit_id":"3cedba30ac0955ef16e88e49062fdd88307a16f8"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"43aedc777319f4f86d4ac3e15853a8c6b8d90166","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        for kv_str in nic_str.split(\",\"):"},{"line_number":302,"context_line":"            if auto_or_none:"},{"line_number":303,"context_line":"                raise expcetions.CommandError(\"\u0027auto\u0027 or \u0027none\u0027 cannot be \""},{"line_number":304,"context_line":"                                              \"user with any other nic \""},{"line_number":305,"context_line":"                                              \"arguments\")"},{"line_number":306,"context_line":"            try:"},{"line_number":307,"context_line":"                # handle the special auto/none cases"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_38d8651c","line":304,"range":{"start_line":304,"start_character":47,"end_line":304,"end_character":51},"in_reply_to":"df140735_7d292fe4","updated":"2017-06-01 21:02:04.000000000","message":"Done","commit_id":"3cedba30ac0955ef16e88e49062fdd88307a16f8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"33a3b032710be0b5bf123c87298d13779302386a","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    for nic_str in args.nics:"},{"line_number":301,"context_line":"        for kv_str in nic_str.split(\",\"):"},{"line_number":302,"context_line":"            if auto_or_none:"},{"line_number":303,"context_line":"                raise expcetions.CommandError(\"\u0027auto\u0027 or \u0027none\u0027 cannot be \""},{"line_number":304,"context_line":"                                              \"user with any other nic \""},{"line_number":305,"context_line":"                                              \"arguments\")"},{"line_number":306,"context_line":"            try:"},{"line_number":307,"context_line":"                # handle the special auto/none cases"},{"line_number":308,"context_line":"                if kv_str in (\u0027auto\u0027, \u0027none\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_fd7adfee","line":305,"range":{"start_line":303,"start_character":46,"end_line":305,"end_character":57},"updated":"2017-06-01 20:24:51.000000000","message":"Put this in _() so it\u0027s marked for translation.","commit_id":"3cedba30ac0955ef16e88e49062fdd88307a16f8"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"43aedc777319f4f86d4ac3e15853a8c6b8d90166","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    for nic_str in args.nics:"},{"line_number":301,"context_line":"        for kv_str in nic_str.split(\",\"):"},{"line_number":302,"context_line":"            if auto_or_none:"},{"line_number":303,"context_line":"                raise expcetions.CommandError(\"\u0027auto\u0027 or \u0027none\u0027 cannot be \""},{"line_number":304,"context_line":"                                              \"user with any other nic \""},{"line_number":305,"context_line":"                                              \"arguments\")"},{"line_number":306,"context_line":"            try:"},{"line_number":307,"context_line":"                # handle the special auto/none cases"},{"line_number":308,"context_line":"                if kv_str in (\u0027auto\u0027, \u0027none\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_9802d16e","line":305,"range":{"start_line":303,"start_character":46,"end_line":305,"end_character":57},"in_reply_to":"df140735_fd7adfee","updated":"2017-06-01 21:02:04.000000000","message":"Done","commit_id":"3cedba30ac0955ef16e88e49062fdd88307a16f8"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3190713a7bdd3348ad0b8a0a7451c9bda107e703","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    for nic_str in args.nics:"},{"line_number":301,"context_line":"        for kv_str in nic_str.split(\",\"):"},{"line_number":302,"context_line":"            if auto_or_none:"},{"line_number":303,"context_line":"                raise expcetions.CommandError(_(\"\u0027auto\u0027 or \u0027none\u0027 cannot be \""},{"line_number":304,"context_line":"                                              \"used with any other nic \""},{"line_number":305,"context_line":"                                              \"arguments\"))"},{"line_number":306,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_f237a9fe","line":303,"range":{"start_line":303,"start_character":22,"end_line":303,"end_character":32},"updated":"2017-06-01 23:00:17.000000000","message":"Looks like a typo.  Did you remember to run the test suite prior to submitting the change for review?","commit_id":"b7caf93211bbe82b29eede72056845c3f3217524"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ebef99b47d08fb2b7ab756ec4027f1ac5cc23799","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    for nic_str in args.nics:"},{"line_number":301,"context_line":"        for kv_str in nic_str.split(\",\"):"},{"line_number":302,"context_line":"            if auto_or_none:"},{"line_number":303,"context_line":"                raise expcetions.CommandError(_(\"\u0027auto\u0027 or \u0027none\u0027 cannot be \""},{"line_number":304,"context_line":"                                              \"used with any other nic \""},{"line_number":305,"context_line":"                                              \"arguments\"))"},{"line_number":306,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_35a74baa","line":303,"range":{"start_line":303,"start_character":22,"end_line":303,"end_character":32},"in_reply_to":"df140735_f237a9fe","updated":"2017-06-02 00:01:24.000000000","message":"That\u0027s a rhetorical question and we both know it ;)","commit_id":"b7caf93211bbe82b29eede72056845c3f3217524"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3190713a7bdd3348ad0b8a0a7451c9bda107e703","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                    if not supports_auto_alloc:"},{"line_number":310,"context_line":"                        raise exceptions.CommandError(err_msg % nic_str)"},{"line_number":311,"context_line":"                    nics.append(kv_str)"},{"line_number":312,"context_line":"                    auto_or_none \u003d True"},{"line_number":313,"context_line":"                    continue"},{"line_number":314,"context_line":"                k, v \u003d kv_str.split(\"\u003d\", 1)"},{"line_number":315,"context_line":"            except ValueError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_722399be","line":312,"updated":"2017-06-01 23:00:17.000000000","message":"We\u0027re not raising an exception here.  Shouldn\u0027t the same error raising logic apply for \"--nic tag\u003dfoo,auto\"?","commit_id":"b7caf93211bbe82b29eede72056845c3f3217524"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ebef99b47d08fb2b7ab756ec4027f1ac5cc23799","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                    if not supports_auto_alloc:"},{"line_number":310,"context_line":"                        raise exceptions.CommandError(err_msg % nic_str)"},{"line_number":311,"context_line":"                    nics.append(kv_str)"},{"line_number":312,"context_line":"                    auto_or_none \u003d True"},{"line_number":313,"context_line":"                    continue"},{"line_number":314,"context_line":"                k, v \u003d kv_str.split(\"\u003d\", 1)"},{"line_number":315,"context_line":"            except ValueError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_b537db4d","line":312,"in_reply_to":"df140735_722399be","updated":"2017-06-02 00:01:24.000000000","message":"If I\u0027m understanding your question correctly, we\u0027re not raising here because the idea is that we set auto_or_none to True here, then in the next iteration - ie, when we\u0027re parsing the next key\u003dvalue pair after the comma, we raise an error if we\u0027re previously encountered auto or none. I\u0027ll add a comment to that effect.","commit_id":"b7caf93211bbe82b29eede72056845c3f3217524"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"9e33c3dd5945cb78b8e05d883b2d97d65c3d6bac","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                    if not supports_auto_alloc:"},{"line_number":314,"context_line":"                        raise exceptions.CommandError(err_msg % nic_str)"},{"line_number":315,"context_line":"                    nics.append(kv_str)"},{"line_number":316,"context_line":"                    auto_or_none \u003d True"},{"line_number":317,"context_line":"                    continue"},{"line_number":318,"context_line":"                k, v \u003d kv_str.split(\"\u003d\", 1)"},{"line_number":319,"context_line":"            except ValueError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_55051f13","line":316,"updated":"2017-06-01 23:51:02.000000000","message":"Did you see my comment on patchset 2?\n\n    We\u0027re not raising an exception here. Shouldn\u0027t the same\n    error raising logic apply for \"--nic tag\u003dfoo,auto\"?\"","commit_id":"c67972566998c8cffd30e4c10abedcfffb514e2c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"54310f84e54190dec6907abbcd5e880963007e84","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                    if not supports_auto_alloc:"},{"line_number":314,"context_line":"                        raise exceptions.CommandError(err_msg % nic_str)"},{"line_number":315,"context_line":"                    nics.append(kv_str)"},{"line_number":316,"context_line":"                    auto_or_none \u003d True"},{"line_number":317,"context_line":"                    continue"},{"line_number":318,"context_line":"                k, v \u003d kv_str.split(\"\u003d\", 1)"},{"line_number":319,"context_line":"            except ValueError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_48bd8200","line":316,"in_reply_to":"df140735_55051f13","updated":"2017-06-02 00:03:46.000000000","message":"Dammit, just understood what you meant - namely, what happens if auto/none comes *after* a key\u003dvalue pair. Will fix.","commit_id":"c67972566998c8cffd30e4c10abedcfffb514e2c"}]}