)]}'
{"id":"openstack%2Fpython-novaclient~477483","triplet_id":"openstack%2Fpython-novaclient~master~I514ffe48cc24a5eb2f1b2151db2344b90c9e61b5","project":"openstack/python-novaclient","branch":"master","topic":"wrap","hashtags":[],"change_id":"I514ffe48cc24a5eb2f1b2151db2344b90c9e61b5","subject":"Fixed wrap argument to accept only non-negative values","status":"ABANDONED","created":"2017-06-26 10:37:15.000000000","updated":"2017-11-16 15:25:52.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8b2985f686121d2513d51185cc610acc8026969e","_number":477483,"virtual_id_number":477483,"owner":{"_account_id":20184,"name":"Pallavi","email":"pallavi.s@nectechnologies.in","username":"pallavi"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2017-06-26 12:07:35.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2017-07-12 09:26:48.000000000","_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"date":"2017-06-26 13:02:56.000000000","_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":-1,"date":"2017-06-26 15:28:24.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-26 12:07:35.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-06-26 13:02:56.000000000","updated_by":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"reviewer":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"state":"REVIEWER"},{"updated":"2017-06-26 15:28:24.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2017-07-12 09:26:48.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"}],"messages":[{"id":"832864d6e3dd4bab2aae39557170acf447f066c4","author":{"_account_id":20184,"name":"Pallavi","email":"pallavi.s@nectechnologies.in","username":"pallavi"},"date":"2017-06-26 10:37:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7206ea567aa364c2df3b0c821c1188ff611a9548","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-26 12:07:35.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/83/477483/1/check/gate-python-novaclient-docs-ubuntu-xenial/8e6256e//doc/build/html/ : SUCCESS in 1m 38s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/83/477483/1/check/gate-python-novaclient-pep8-ubuntu-xenial/c0779e8/ : SUCCESS in 2m 08s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/83/477483/1/check/gate-python-novaclient-python27-ubuntu-xenial/bb8b750/ : FAILURE in 2m 46s\n- gate-python-novaclient-python35 http://logs.openstack.org/83/477483/1/check/gate-python-novaclient-python35/bfb612e/ : FAILURE in 3m 13s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/83/477483/1/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/4df4dbf/ : SUCCESS in 1h 26m 31s\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/83/477483/1/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/ebe4c46/ : FAILURE in 44m 44s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/83/477483/1/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/d9808fe/ : FAILURE in 28m 00s","accounts_in_message":[],"_revision_number":1},{"id":"764af00f4289febdce086b524b43ec388c70713f","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2017-06-26 13:02:56.000000000","message":"Patch Set 1:\n\nI noticed jenkins failed, I think you hit bug(s):\n\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial: https://bugs.launchpad.net/bugs/1700364 https://bugs.launchpad.net/bugs/1700359\n- gate-python-novaclient-python27-ubuntu-xenial: https://bugs.launchpad.net/bugs/1694371\n- gate-python-novaclient-python35: https://bugs.launchpad.net/bugs/1694371\n\nIf you believe we\u0027ve correctly identified the failure, feel free to leave a \u0027recheck\u0027 comment to run the tests again.\nFor more details on this and other bugs, please see http://status.openstack.org/elastic-recheck/","accounts_in_message":[],"_revision_number":1},{"id":"0da9570c337211285b0dca13267a289f6d16dfe9","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2017-06-26 15:28:24.000000000","message":"Patch Set 1: Code-Review-1\n\n1. I\u0027m not sure we care.  A negative value for wrap is currently treated like a 0 value, which I think is just fine.  I have to note, though, that the way your change is written isn\u0027t treating 0 properly, however, and that is a bug you will need to fix.\n\n2. Elastic Recheck is wrong about the unit test failures being a known bug; those are actually a typo on your part.\n\n3. The functional test failure is probably (I haven\u0027t looked to verify) due to a problem that is currently being debugged, so I wouldn\u0027t worry too much about that right now.\n\n4. If we do decide to go forward with this change, I would expect an added test to verify that ValueError is being raised at the right time.","accounts_in_message":[],"_revision_number":1},{"id":"4dbbc5884e25d79dd8a8f753ad1c1520ace4bf75","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2017-07-12 09:26:48.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c1d997709a96cafcd81fe59e95bbcbb2825e5dff","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-11-16 15:25:52.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"92342116a4ec7911b7724c662946526a58cb4421","revisions":{"92342116a4ec7911b7724c662946526a58cb4421":{"kind":"REWORK","_number":1,"created":"2017-06-26 10:37:15.000000000","uploader":{"_account_id":20184,"name":"Pallavi","email":"pallavi.s@nectechnologies.in","username":"pallavi"},"ref":"refs/changes/83/477483/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/83/477483/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/83/477483/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/83/477483/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/83/477483/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/83/477483/1"}}},"commit":{"parents":[{"commit":"c23324ef4806706bef257e711ac6ffaa8a833ea4","subject":"Make --profile load from environment variables","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/c23324ef4806706bef257e711ac6ffaa8a833ea4"}]}],"author":{"name":"pallavi","email":"pallavi.s@nectechnologies.in","date":"2017-06-26 10:33:37.000000000","tz":330},"committer":{"name":"pallavi","email":"pallavi.s@nectechnologies.in","date":"2017-06-26 10:36:19.000000000","tz":330},"subject":"Fixed wrap argument to accept only non-negative values","message":"Fixed wrap argument to accept only non-negative values\n\nWrap argument is accepting negative values. This fix will throw error\nfor negative values as \"Wrap argument should be a non-negative\ninteger\".\n\nChange-Id: I514ffe48cc24a5eb2f1b2151db2344b90c9e61b5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/92342116a4ec7911b7724c662946526a58cb4421"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/92342116a4ec7911b7724c662946526a58cb4421"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}