)]}'
{"id":"openstack%2Fpython-novaclient~484147","triplet_id":"openstack%2Fpython-novaclient~master~Ibfe6c89eb47ff1fc3956c2a1e91dbb4d487a0fc9","project":"openstack/python-novaclient","branch":"master","topic":"get_attinfo_by_volid","hashtags":[],"change_id":"Ibfe6c89eb47ff1fc3956c2a1e91dbb4d487a0fc9","subject":"Add sub command volume-attachment","status":"ABANDONED","created":"2017-07-15 16:12:21.000000000","updated":"2018-06-14 00:54:13.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7f164bbca26ceb1e998e7e589058692dd06d546d","_number":484147,"virtual_id_number":484147,"owner":{"_account_id":21135,"name":"zhangdaolong","email":"daodragonzhang@gmail.com","username":"zhangdaolong"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":1,"date":"2017-07-15 19:26:45.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":-1,"date":"2017-08-15 01:52:53.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":-1,"date":"2017-11-16 19:15:44.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2017-07-17 13:36:35.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-07-15 19:26:45.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-07-17 13:36:35.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2017-08-15 01:52:53.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2017-11-16 19:15:44.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"}],"messages":[{"id":"1cc91ce2c8166f25346fd92aa5bde4d77c718973","author":{"_account_id":21135,"name":"zhangdaolong","email":"daodragonzhang@gmail.com","username":"zhangdaolong"},"date":"2017-07-15 16:12:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6cefc0ccfc3b40dd95f2fda75acddf301e32963a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-15 17:35:17.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/47/484147/1/check/gate-python-novaclient-docs-ubuntu-xenial/ab8bff2//doc/build/html/ : SUCCESS in 4m 39s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/47/484147/1/check/gate-python-novaclient-pep8-ubuntu-xenial/6df565d/ : FAILURE in 1m 48s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/47/484147/1/check/gate-python-novaclient-python27-ubuntu-xenial/329339c/ : SUCCESS in 2m 09s\n- gate-python-novaclient-python35 http://logs.openstack.org/47/484147/1/check/gate-python-novaclient-python35/6feb1d9/ : SUCCESS in 2m 33s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/47/484147/1/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/4fb68db/ : SUCCESS in 1h 22m 44s\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/47/484147/1/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/a2b381c/ : SUCCESS in 48m 53s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/47/484147/1/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/6a3b456/ : SUCCESS in 33m 59s","accounts_in_message":[],"_revision_number":1},{"id":"d61530f6fdecb521b2a0d102a4d6df40b5d19334","author":{"_account_id":21135,"name":"zhangdaolong","email":"daodragonzhang@gmail.com","username":"zhangdaolong"},"date":"2017-07-15 18:14:43.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"63f2281e411445b54f4acd93214bb5cae2ea8955","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-15 19:26:45.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/47/484147/2/check/gate-python-novaclient-docs-ubuntu-xenial/027426e//doc/build/html/ : SUCCESS in 4m 11s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/47/484147/2/check/gate-python-novaclient-pep8-ubuntu-xenial/42cf7f1/ : SUCCESS in 2m 20s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/47/484147/2/check/gate-python-novaclient-python27-ubuntu-xenial/581511e/ : SUCCESS in 2m 02s\n- gate-python-novaclient-python35 http://logs.openstack.org/47/484147/2/check/gate-python-novaclient-python35/ff48413/ : SUCCESS in 3m 20s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/47/484147/2/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/f4dfc8d/ : SUCCESS in 1h 11m 50s\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/47/484147/2/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/a1029e4/ : SUCCESS in 55m 49s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/47/484147/2/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/75d0fbc/ : SUCCESS in 32m 29s","accounts_in_message":[],"_revision_number":2},{"id":"89a211583b8ceed159370b52cec3657d0f756d6f","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2017-08-15 01:52:53.000000000","message":"Patch Set 2: Code-Review-1\n\nA release note should be added.","accounts_in_message":[],"_revision_number":2},{"id":"09ecbcf289d0e2e91aaaf62fd5bf2516c99b7868","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-11-16 19:15:44.000000000","message":"Patch Set 2: Code-Review-1\n\nI\u0027m not sure how useful this is. The API response is not very useful. The attachment ID is the same value as the volume ID that the user has to provide to this CLI:\n\nhttps://github.com/openstack/nova/blob/0de06818955c3a77d002a8295b43f17cbd894b25/nova/api/openstack/compute/volumes.py#L226\n\nSo the only other piece that is of any value is the device, but that device name might not actually be what\u0027s in the guest for the instance. Since the Liberty release, the libvirt driver has completely ignored the device name that a user supplies when attaching a volume to a server, and the driver (and hypervisor) actually calculate the device itself. Plus if you reboot the guest, the hypervisor might mount the block device in a different location, so the device name in the API is really something we shouldn\u0027t build upon as something that is stable and we want people using, see:\n\nhttps://review.openstack.org/#/c/452546/","accounts_in_message":[],"_revision_number":2},{"id":"39621c8c9e6418967cbc04a1cd775b6533de4aa5","author":{"_account_id":21135,"name":"zhangdaolong","email":"daodragonzhang@gmail.com","username":"zhangdaolong"},"date":"2018-06-14 00:54:13.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7fcf2c0732b026fca6931f9568ddf4fed642a7cc","revisions":{"2056b3402cdfa8730c8bf27abcdb266914afe780":{"kind":"REWORK","_number":1,"created":"2017-07-15 16:12:21.000000000","uploader":{"_account_id":21135,"name":"zhangdaolong","email":"daodragonzhang@gmail.com","username":"zhangdaolong"},"ref":"refs/changes/47/484147/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/47/484147/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/47/484147/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/47/484147/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/47/484147/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/47/484147/1"}}},"commit":{"parents":[{"commit":"77f940c5345d662fd7adef410ea0989e35fa2664","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/77f940c5345d662fd7adef410ea0989e35fa2664"}]}],"author":{"name":"zhangdaolong","email":"zhangdaolong@fiberhome.com","date":"2017-07-15 16:06:34.000000000","tz":480},"committer":{"name":"zhangdaolong","email":"zhangdaolong@fiberhome.com","date":"2017-07-15 16:06:34.000000000","tz":480},"subject":"Add sub command volume-attachment","message":"Add sub command volume-attachment\n\nAdd sub command volume-attachment to get attachment by\nvolume ID.\n\nChange-Id: Ibfe6c89eb47ff1fc3956c2a1e91dbb4d487a0fc9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2056b3402cdfa8730c8bf27abcdb266914afe780"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2056b3402cdfa8730c8bf27abcdb266914afe780"}]},"branch":"refs/heads/master"},"7fcf2c0732b026fca6931f9568ddf4fed642a7cc":{"kind":"REWORK","_number":2,"created":"2017-07-15 18:14:43.000000000","uploader":{"_account_id":21135,"name":"zhangdaolong","email":"daodragonzhang@gmail.com","username":"zhangdaolong"},"ref":"refs/changes/47/484147/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/47/484147/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/47/484147/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/47/484147/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/47/484147/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/47/484147/2"}}},"commit":{"parents":[{"commit":"77f940c5345d662fd7adef410ea0989e35fa2664","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/77f940c5345d662fd7adef410ea0989e35fa2664"}]}],"author":{"name":"zhangdaolong","email":"zhangdaolong@fiberhome.com","date":"2017-07-15 16:06:34.000000000","tz":480},"committer":{"name":"zhangdaolong","email":"zhangdaolong@fiberhome.com","date":"2017-07-15 18:14:27.000000000","tz":480},"subject":"Add sub command volume-attachment","message":"Add sub command volume-attachment\n\nAdd sub command volume-attachment to get attachment by\nvolume ID.\n\nChange-Id: Ibfe6c89eb47ff1fc3956c2a1e91dbb4d487a0fc9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7fcf2c0732b026fca6931f9568ddf4fed642a7cc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7fcf2c0732b026fca6931f9568ddf4fed642a7cc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}