)]}'
{"id":"openstack%2Fpython-novaclient~490784","triplet_id":"openstack%2Fpython-novaclient~master~I77df96b09fc0b66449339a474ac725edb890c0bc","project":"openstack/python-novaclient","branch":"master","hashtags":[],"change_id":"I77df96b09fc0b66449339a474ac725edb890c0bc","subject":"Replace six.itervalues() with dict.values() in python-novaclient","status":"MERGED","created":"2017-08-04 07:54:40.000000000","updated":"2017-08-04 15:13:24.000000000","submitted":"2017-08-04 15:13:24.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"dc0915d7d3057a3a72b57da261bc1c0da8709ba4","_number":490784,"virtual_id_number":490784,"owner":{"_account_id":25432,"name":"yanghuichan","email":"yanghc@fiberhome.com","username":"yanghuichan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-08-04 15:13:24.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-08-04 14:00:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2017-08-04 09:55:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":1,"date":"2017-08-04 09:55:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-08-04 14:00:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-08-04 09:55:47.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"},{"updated":"2017-08-04 09:55:57.000000000","updated_by":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"reviewer":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"state":"REVIEWER"},{"updated":"2017-08-04 14:00:51.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2017-08-04 15:13:24.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"24d51a572e2c834fc607ca3ae7d958f3c51826c2","author":{"_account_id":25432,"name":"yanghuichan","email":"yanghc@fiberhome.com","username":"yanghuichan"},"date":"2017-08-04 07:54:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"64cc7a477c685415824b866a9418ae583eb7c982","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-04 09:16:19.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/84/490784/1/check/gate-python-novaclient-docs-ubuntu-xenial/3e0d279//doc/build/html/ : SUCCESS in 1m 56s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/84/490784/1/check/gate-python-novaclient-pep8-ubuntu-xenial/0b75736/ : SUCCESS in 3m 05s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/84/490784/1/check/gate-python-novaclient-python27-ubuntu-xenial/373554a/ : FAILURE in 2m 03s\n- gate-python-novaclient-python35 http://logs.openstack.org/84/490784/1/check/gate-python-novaclient-python35/a1b9626/ : FAILURE in 2m 59s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/84/490784/1/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/1c041d9/ : FAILURE in 1h 20m 08s\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/84/490784/1/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/1bbd132/ : SUCCESS in 55m 41s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/84/490784/1/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/7df3d3f/ : SUCCESS in 1h 02m 01s","accounts_in_message":[],"_revision_number":1},{"id":"9475d76405c46a14698ffcc5d8ebe246919cfa7b","author":{"_account_id":25432,"name":"yanghuichan","email":"yanghc@fiberhome.com","username":"yanghuichan"},"date":"2017-08-04 09:32:53.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c39a6dfea7c95dd09f8734ad17e23c202dbe58c2","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2017-08-04 09:55:47.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"15991c18158447ed46a70aace5278ea6dac5a4e1","author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"date":"2017-08-04 09:55:57.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"aaadba4ba655fedaee8b65a76a40a6b878dd2cc0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-04 11:01:08.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/84/490784/2/check/gate-python-novaclient-docs-ubuntu-xenial/1640c24//doc/build/html/ : SUCCESS in 3m 06s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/84/490784/2/check/gate-python-novaclient-pep8-ubuntu-xenial/e46bcf8/ : SUCCESS in 1m 34s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/84/490784/2/check/gate-python-novaclient-python27-ubuntu-xenial/fe8eb38/ : SUCCESS in 3m 08s\n- gate-python-novaclient-python35 http://logs.openstack.org/84/490784/2/check/gate-python-novaclient-python35/0225135/ : SUCCESS in 1m 42s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/84/490784/2/check/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/5a5390d/ : SUCCESS in 1h 26m 07s\n- gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv http://logs.openstack.org/84/490784/2/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/a78376c/ : SUCCESS in 36m 53s (non-voting)\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/84/490784/2/check/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/a0cfe43/ : SUCCESS in 37m 52s","accounts_in_message":[],"_revision_number":2},{"id":"facde66d9a9b2af3e43ba91589946b8ba7e4f760","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2017-08-04 14:00:51.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"ee866724fa18c76e61e341f17c84aea6eee84f73","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-04 14:01:01.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"5dd6c777953b6003911988926e36397f42fbb0c4","date":"2017-08-04 15:13:24.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"dc0915d7d3057a3a72b57da261bc1c0da8709ba4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-04 15:13:24.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-novaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/84/490784/2/gate/gate-python-novaclient-docs-ubuntu-xenial/ffcdb89//doc/build/html/ : SUCCESS in 3m 24s\n- gate-python-novaclient-pep8-ubuntu-xenial http://logs.openstack.org/84/490784/2/gate/gate-python-novaclient-pep8-ubuntu-xenial/0738e64/ : SUCCESS in 3m 18s\n- gate-python-novaclient-python27-ubuntu-xenial http://logs.openstack.org/84/490784/2/gate/gate-python-novaclient-python27-ubuntu-xenial/fc357bf/ : SUCCESS in 3m 15s\n- gate-python-novaclient-python35 http://logs.openstack.org/84/490784/2/gate/gate-python-novaclient-python35/d496a3e/ : SUCCESS in 1m 53s\n- gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial http://logs.openstack.org/84/490784/2/gate/gate-tempest-dsvm-neutron-src-python-novaclient-ubuntu-xenial/211fe7c/ : SUCCESS in 1h 11m 17s\n- gate-novaclient-dsvm-functional-neutron-ubuntu-xenial http://logs.openstack.org/84/490784/2/gate/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/0995205/ : SUCCESS in 36m 29s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"0fe136a9e032f47c8d61ec82f1dbe5ffd3d8fedf","revisions":{"51a426c40332c31734144edca0015a799004bd6b":{"kind":"REWORK","_number":1,"created":"2017-08-04 07:54:40.000000000","uploader":{"_account_id":25432,"name":"yanghuichan","email":"yanghc@fiberhome.com","username":"yanghuichan"},"ref":"refs/changes/84/490784/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/84/490784/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/84/490784/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/84/490784/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/84/490784/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/84/490784/1"}}},"commit":{"parents":[{"commit":"de8bb757dd6f75338f3894930fe79a93654b2c20","subject":"Merge \"Remove custom autodoc implementation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/de8bb757dd6f75338f3894930fe79a93654b2c20"}]}],"author":{"name":"yanghuichan","email":"yanghc@fiberhome.com","date":"2017-08-04 07:51:46.000000000","tz":480},"committer":{"name":"yanghuichan","email":"yanghc@fiberhome.com","date":"2017-08-04 07:54:37.000000000","tz":480},"subject":"Replace six.itervalues() with dict.values() in python-novaclient","message":"Replace six.itervalues() with dict.values() in python-novaclient\n\n1.As mentioned in [1], we should avoid using six.itervalues\n  to achieve iterators. We can use dict.values instead, as it\n  will return iterators in PY3 as well. And dict.values will\n  more readable.\n2.In py2, the performance about list should be negligible,\n  see the link [2].\n\n[1] https://wiki.openstack.org/wiki/Python3#Common_patterns\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: I77df96b09fc0b66449339a474ac725edb890c0bc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/51a426c40332c31734144edca0015a799004bd6b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/51a426c40332c31734144edca0015a799004bd6b"}]},"branch":"refs/heads/master"},"0fe136a9e032f47c8d61ec82f1dbe5ffd3d8fedf":{"kind":"REWORK","_number":2,"created":"2017-08-04 09:32:53.000000000","uploader":{"_account_id":25432,"name":"yanghuichan","email":"yanghc@fiberhome.com","username":"yanghuichan"},"ref":"refs/changes/84/490784/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/84/490784/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/84/490784/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/84/490784/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/84/490784/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/84/490784/2"}}},"commit":{"parents":[{"commit":"de8bb757dd6f75338f3894930fe79a93654b2c20","subject":"Merge \"Remove custom autodoc implementation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/de8bb757dd6f75338f3894930fe79a93654b2c20"}]}],"author":{"name":"yanghuichan","email":"yanghc@fiberhome.com","date":"2017-08-04 07:51:46.000000000","tz":480},"committer":{"name":"yanghuichan","email":"yanghc@fiberhome.com","date":"2017-08-04 09:32:35.000000000","tz":480},"subject":"Replace six.itervalues() with dict.values() in python-novaclient","message":"Replace six.itervalues() with dict.values() in python-novaclient\n\n1.As mentioned in [1], we should avoid using six.itervalues\n  to achieve iterators. We can use dict.values instead, as it\n  will return iterators in PY3 as well. And dict.values will\n  more readable.\n2.In py2, the performance about list should be negligible,\n  see the link [2].\n\n[1] https://wiki.openstack.org/wiki/Python3#Common_patterns\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: I77df96b09fc0b66449339a474ac725edb890c0bc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/0fe136a9e032f47c8d61ec82f1dbe5ffd3d8fedf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/0fe136a9e032f47c8d61ec82f1dbe5ffd3d8fedf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}