)]}'
{"novaclient/v2/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"5e995bb0ce862a50888fdbd64b0eadae329966be","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    supports_auto_alloc \u003d cs.api_version \u003e\u003d api_versions.APIVersion(\u00272.37\u0027)"},{"line_number":269,"context_line":"    supports_nic_tags \u003d _supports_nic_tags(cs)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    nic_keys \u003d [\u0027net-id\u0027, \u0027v4-fixed-ip\u0027, \u0027v6-fixed-ip\u0027, \u0027port-id\u0027, \u0027net-name\u0027]"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    if supports_auto_alloc and supports_nic_tags:"},{"line_number":274,"context_line":"        # API version \u003e\u003d 2.42"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_32a698c3","line":271,"updated":"2017-08-09 15:37:08.000000000","message":"Suggestion: make this a set literal:\n\n    nic_keys \u003d {\u0027net-id\u0027, \u0027v4-fixed-ip\u0027, …}\n\nThen use nic_keys.add() for \u0027tag\u0027.  This way, the __contains__ test at line 344 doesn\u0027t have to go search through the list.\n\nThat said, the performance savings from this suggestion will be incredibly small, which is why I\u0027m making this a suggestion, not a requirement :)","commit_id":"956defa431fc8b6e2d6b9d519cd7b4aced03e9f6"}]}