)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22060cbc359627c79e942809f4af9141e3a46ff6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Microversion 2.63 - Add trusted_image_certificates"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a `--trusted-image-certificate-ids` option to the"},{"line_number":10,"context_line":"`nova boot` and `nova rebuild` commands. This option takes in a"},{"line_number":11,"context_line":"comma-separated list of trusted image certificate IDs, which will be"},{"line_number":12,"context_line":"used to validate certificates in the image signature verification"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":47,"id":"5f7c97a3_bda2b1ac","line":9,"range":{"start_line":9,"start_character":48,"end_line":9,"end_character":51},"updated":"2018-06-15 12:50:33.000000000","message":"id","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb7b44e654936c36ed8bd92536917b62c316003f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Microversion 2.63 - Add trusted_image_certificates"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a `--trusted-image-certificate-ids` option to the"},{"line_number":10,"context_line":"`nova boot` and `nova rebuild` commands. This option takes in a"},{"line_number":11,"context_line":"comma-separated list of trusted image certificate IDs, which will be"},{"line_number":12,"context_line":"used to validate certificates in the image signature verification"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":47,"id":"5f7c97a3_18697325","line":9,"range":{"start_line":9,"start_character":48,"end_line":9,"end_character":51},"in_reply_to":"5f7c97a3_bda2b1ac","updated":"2018-06-15 13:41:11.000000000","message":"Done","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22060cbc359627c79e942809f4af9141e3a46ff6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a `--trusted-image-certificate-ids` option to the"},{"line_number":10,"context_line":"`nova boot` and `nova rebuild` commands. This option takes in a"},{"line_number":11,"context_line":"comma-separated list of trusted image certificate IDs, which will be"},{"line_number":12,"context_line":"used to validate certificates in the image signature verification"},{"line_number":13,"context_line":"process. If ID values are not specified using this option, the value of"},{"line_number":14,"context_line":"the newly added OS_TRUSTED_IMAGE_CERTIFICATE_IDS environment variable"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":47,"id":"5f7c97a3_7dac199f","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":53},"updated":"2018-06-15 12:50:33.000000000","message":"a single trusted certificate ID. The option may be used multiple times to specify multiple trusted certificate IDs,","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb7b44e654936c36ed8bd92536917b62c316003f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a `--trusted-image-certificate-ids` option to the"},{"line_number":10,"context_line":"`nova boot` and `nova rebuild` commands. This option takes in a"},{"line_number":11,"context_line":"comma-separated list of trusted image certificate IDs, which will be"},{"line_number":12,"context_line":"used to validate certificates in the image signature verification"},{"line_number":13,"context_line":"process. If ID values are not specified using this option, the value of"},{"line_number":14,"context_line":"the newly added OS_TRUSTED_IMAGE_CERTIFICATE_IDS environment variable"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":47,"id":"5f7c97a3_f86fd725","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":53},"in_reply_to":"5f7c97a3_7dac199f","updated":"2018-06-15 13:41:11.000000000","message":"Done","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22060cbc359627c79e942809f4af9141e3a46ff6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"will be used instead. This value will be converted into a list before"},{"line_number":16,"context_line":"being passed on."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Correpsonding `trusted_image_certificates` kwarg has been added to the"},{"line_number":19,"context_line":"server create and rebuild Python API bindings."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I235541a689732826950c7b2a510d5835211120c3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":47,"id":"5f7c97a3_9d86d516","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":13},"updated":"2018-06-15 12:50:33.000000000","message":"Corresponding","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb7b44e654936c36ed8bd92536917b62c316003f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"will be used instead. This value will be converted into a list before"},{"line_number":16,"context_line":"being passed on."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Correpsonding `trusted_image_certificates` kwarg has been added to the"},{"line_number":19,"context_line":"server create and rebuild Python API bindings."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I235541a689732826950c7b2a510d5835211120c3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":47,"id":"5f7c97a3_985ee377","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":13},"in_reply_to":"5f7c97a3_9d86d516","updated":"2018-06-15 13:41:11.000000000","message":"Done","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"}],"doc/source/cli/nova.rst":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ca3c54a2a9ea4b2c399fbcfa8da39e902799b325","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"                    [--config-drive \u003cvalue\u003e] [--poll] [--admin-pass \u003cvalue\u003e]"},{"line_number":1012,"context_line":"                    [--access-ip-v4 \u003cvalue\u003e] [--access-ip-v6 \u003cvalue\u003e]"},{"line_number":1013,"context_line":"                    [--description \u003cdescription\u003e]"},{"line_number":1014,"context_line":"                    [--trusted-image-certificate-id]"},{"line_number":1015,"context_line":"                    \u003cname\u003e"},{"line_number":1016,"context_line":""},{"line_number":1017,"context_line":"Boot a new server."}],"source_content_type":"text/x-rst","patch_set":50,"id":"5f7c97a3_076259ae","line":1014,"range":{"start_line":1014,"start_character":20,"end_line":1014,"end_character":52},"updated":"2018-06-17 23:28:58.000000000","message":"nit: [--trusted-image-certificate-id \u003ctrusted-image-certificate-id\u003e]","commit_id":"7f10707e5d060874f1a562b5efdce5ddc2701389"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"b10d103869a4ba09aac97a54dd994590aa6aeb30","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"                    [--config-drive \u003cvalue\u003e] [--poll] [--admin-pass \u003cvalue\u003e]"},{"line_number":1012,"context_line":"                    [--access-ip-v4 \u003cvalue\u003e] [--access-ip-v6 \u003cvalue\u003e]"},{"line_number":1013,"context_line":"                    [--description \u003cdescription\u003e]"},{"line_number":1014,"context_line":"                    [--trusted-image-certificate-id]"},{"line_number":1015,"context_line":"                    \u003cname\u003e"},{"line_number":1016,"context_line":""},{"line_number":1017,"context_line":"Boot a new server."}],"source_content_type":"text/x-rst","patch_set":50,"id":"5f7c97a3_a828e884","line":1014,"range":{"start_line":1014,"start_character":20,"end_line":1014,"end_character":52},"in_reply_to":"5f7c97a3_076259ae","updated":"2018-06-19 15:20:09.000000000","message":"Added patch to fix this: https://review.openstack.org/#/c/576555/","commit_id":"7f10707e5d060874f1a562b5efdce5ddc2701389"}],"doc/source/user/shell.rst":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"c31404d5c66a3dd17e88d5e58e3cec2eb39cac5b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    The Keystone region name. Defaults to the first region if multiple regions"},{"line_number":42,"context_line":"    are available."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":".. envvar:: OS_TRUSTED_CERTIFICATE_IDS"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    A comma-delimited list of trusted certificate IDs."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f2577a7_0a6bf31d","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":38},"updated":"2017-09-15 17:13:31.000000000","message":"Should there be a unit test confirming this is used?","commit_id":"124849f2cda2736b7611848cfe8a99624bedbfdf"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"52ac0a9e0cb6c067b237a7097b5a19fe4dd65516","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    The Keystone region name. Defaults to the first region if multiple regions"},{"line_number":42,"context_line":"    are available."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":".. envvar:: OS_TRUSTED_CERTIFICATE_IDS"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    A comma-delimited list of trusted certificate IDs."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5f2577a7_5ee418e0","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":38},"in_reply_to":"5f2577a7_0a6bf31d","updated":"2017-09-16 06:56:42.000000000","message":"That would probably be best. Added in patch set 8.","commit_id":"124849f2cda2736b7611848cfe8a99624bedbfdf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22060cbc359627c79e942809f4af9141e3a46ff6","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. envvar:: OS_TRUSTED_IMAGE_CERTIFICATE_IDS"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    A comma-delimited list of trusted image certificate IDs."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"For example, in Bash you\u0027d use::"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":47,"id":"5f7c97a3_1d7ac524","line":65,"updated":"2018-06-15 12:50:33.000000000","message":"Might want to mention this is only used for nova boot and nova rebuild commands.","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb7b44e654936c36ed8bd92536917b62c316003f","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. envvar:: OS_TRUSTED_IMAGE_CERTIFICATE_IDS"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    A comma-delimited list of trusted image certificate IDs."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"For example, in Bash you\u0027d use::"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":47,"id":"5f7c97a3_1852d369","line":65,"in_reply_to":"5f7c97a3_1d7ac524","updated":"2018-06-15 13:41:11.000000000","message":"Done","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"}],"novaclient/__init__.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"34d2716cf373efb6895153c391f420382b67bfe6","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# when client supported the max version, and bumped sequentially, otherwise"},{"line_number":26,"context_line":"# the client may break due to server side new version may include some"},{"line_number":27,"context_line":"# backward incompatible change."},{"line_number":28,"context_line":"API_MAX_VERSION \u003d api_versions.APIVersion(\"2.55\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"ff82abbf_8b3f5c86","side":"PARENT","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":49},"updated":"2017-12-01 03:56:01.000000000","message":"It cannot be bumped from 2.55 to 2.57.\nIn nova, microversion 2.56 has been merged. (https://review.openstack.org/#/c/408964/)\n\nAnd there is a python-novaclient patch for microversion 2.56 (https://review.openstack.org/#/c/406707/).\n\nSo you set a dependency to it.\nSee https://docs.openstack.org/infra/manual/developers.html#adding-a-dependency .","commit_id":"f7c991703517b6fd6a42f732fc602badb0caebb8"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"0b671cabc4f067231b393f8132dcc37a89921cca","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# when client supported the max version, and bumped sequentially, otherwise"},{"line_number":26,"context_line":"# the client may break due to server side new version may include some"},{"line_number":27,"context_line":"# backward incompatible change."},{"line_number":28,"context_line":"API_MAX_VERSION \u003d api_versions.APIVersion(\"2.55\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"ff82abbf_2b5090d4","side":"PARENT","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":49},"in_reply_to":"ff82abbf_8b3f5c86","updated":"2017-12-01 03:57:42.000000000","message":"Sorry.\nI want to say that \"So you should set a dependency to it.\"","commit_id":"f7c991703517b6fd6a42f732fc602badb0caebb8"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"4bdfbe90b42dc99d5696c55f6d77c9f22441383f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# when client supported the max version, and bumped sequentially, otherwise"},{"line_number":26,"context_line":"# the client may break due to server side new version may include some"},{"line_number":27,"context_line":"# backward incompatible change."},{"line_number":28,"context_line":":PI_MAX_VERSION \u003d api_versions.APIVersion(\"2.61\")"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f96bb07_3a508a0a","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":1},"updated":"2018-01-23 18:47:23.000000000","message":"Well, that\u0027s embarassing","commit_id":"54988341016e45162a3d05c47fb52de2e58010e0"}],"novaclient/shell.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"225c5ff29d30f4b310a417f4ab9e549e9cd096dd","unresolved":false,"context_lines":[{"line_number":382,"context_line":"    def __init__(self):"},{"line_number":383,"context_line":"        self.client_logger \u003d None"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    def _append_global_identity_args(self, parser, argv):"},{"line_number":387,"context_line":"        # Register the CLI arguments that have moved to the session object."},{"line_number":388,"context_line":"        loading.register_session_argparse_arguments(parser)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_0f9ed306","line":385,"updated":"2017-09-04 03:00:46.000000000","message":"It is an unnecessary change.","commit_id":"cb647ff69eac8b9ef02f0d6d459694ce263adfa3"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"f1d67bc60deb98f4db64c70499e6688029d516ed","unresolved":false,"context_lines":[{"line_number":382,"context_line":"    def __init__(self):"},{"line_number":383,"context_line":"        self.client_logger \u003d None"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    def _append_global_identity_args(self, parser, argv):"},{"line_number":387,"context_line":"        # Register the CLI arguments that have moved to the session object."},{"line_number":388,"context_line":"        loading.register_session_argparse_arguments(parser)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_952d34aa","line":385,"in_reply_to":"7f287b81_0f9ed306","updated":"2017-09-04 06:15:35.000000000","message":"Fixed in patch 3.","commit_id":"cb647ff69eac8b9ef02f0d6d459694ce263adfa3"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"225c5ff29d30f4b310a417f4ab9e549e9cd096dd","unresolved":false,"context_lines":[{"line_number":466,"context_line":"            trusted_certs \u003d \u0027\u0027"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"        parser.add_argument("},{"line_number":469,"context_line":"            \u0027--os-trusted-certificate-ids\u0027,"},{"line_number":470,"context_line":"            metavar\u003d\u0027\u003ctrusted-certificates\u003e\u0027,"},{"line_number":471,"context_line":"            default\u003dtrusted_certs,"},{"line_number":472,"context_line":"            help\u003d_(\u0027Defaults to env[OS_TRUSTED_CERTIFICATE_IDS].\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_4f629b18","line":469,"range":{"start_line":469,"start_character":13,"end_line":469,"end_character":41},"updated":"2017-09-04 03:00:46.000000000","message":"The unit tests for this change should be added in novaclient/unit/test_shell.py .","commit_id":"cb647ff69eac8b9ef02f0d6d459694ce263adfa3"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"f1d67bc60deb98f4db64c70499e6688029d516ed","unresolved":false,"context_lines":[{"line_number":466,"context_line":"            trusted_certs \u003d \u0027\u0027"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"        parser.add_argument("},{"line_number":469,"context_line":"            \u0027--os-trusted-certificate-ids\u0027,"},{"line_number":470,"context_line":"            metavar\u003d\u0027\u003ctrusted-certificates\u003e\u0027,"},{"line_number":471,"context_line":"            default\u003dtrusted_certs,"},{"line_number":472,"context_line":"            help\u003d_(\u0027Defaults to env[OS_TRUSTED_CERTIFICATE_IDS].\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_55190c86","line":469,"range":{"start_line":469,"start_character":13,"end_line":469,"end_character":41},"in_reply_to":"7f287b81_4f629b18","updated":"2017-09-04 06:15:35.000000000","message":"Thanks, Takashi. Added in patch 3.","commit_id":"cb647ff69eac8b9ef02f0d6d459694ce263adfa3"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"ed0bef5fff062c4445487b91f0ba14427683ba74","unresolved":false,"context_lines":[{"line_number":458,"context_line":"            \u0027--os-trusted-certificate-ids\u0027,"},{"line_number":459,"context_line":"            metavar\u003d\u0027\u003ctrusted-certificate-ids\u003e\u0027,"},{"line_number":460,"context_line":"            default\u003dutils.env(\u0027OS_TRUSTED_CERTIFICATE_IDS\u0027),"},{"line_number":461,"context_line":"            help\u003d_(\u0027Defaults to env[OS_TRUSTED_CERTIFICATE_IDS].\u0027))"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        parser.add_argument("},{"line_number":464,"context_line":"            \u0027--service-type\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_338bea68","line":461,"updated":"2017-09-06 20:40:16.000000000","message":"In addition to adding what it defaults to, I think it would be beneficial to explain that the certificate IDs are used during image signature verification.","commit_id":"5ee2654e902a022f09b315c28f93fa7e63c95fcf"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"641c21bb1e1813928d5cfbd5ae43b8822e207f7c","unresolved":false,"context_lines":[{"line_number":458,"context_line":"            \u0027--os-trusted-certificate-ids\u0027,"},{"line_number":459,"context_line":"            metavar\u003d\u0027\u003ctrusted-certificate-ids\u003e\u0027,"},{"line_number":460,"context_line":"            default\u003dutils.env(\u0027OS_TRUSTED_CERTIFICATE_IDS\u0027),"},{"line_number":461,"context_line":"            help\u003d_(\u0027Defaults to env[OS_TRUSTED_CERTIFICATE_IDS].\u0027))"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        parser.add_argument("},{"line_number":464,"context_line":"            \u0027--service-type\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_8ffa6740","line":461,"in_reply_to":"7f287b81_338bea68","updated":"2017-09-07 04:49:37.000000000","message":"Updated in patch set 6.","commit_id":"5ee2654e902a022f09b315c28f93fa7e63c95fcf"}],"novaclient/tests/unit/v2/test_servers.py":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"ed0bef5fff062c4445487b91f0ba14427683ba74","unresolved":false,"context_lines":[{"line_number":1583,"context_line":"                           )"},{"line_number":1584,"context_line":""},{"line_number":1585,"context_line":"    def test_create_server_with_tags_pre_254_fails(self):"},{"line_number":1586,"context_line":"        self.cs.api_version \u003d api_versions.APIVersion(\u00272.52\u0027)"},{"line_number":1587,"context_line":"        self.assertRaises(exceptions.UnsupportedAttribute,"},{"line_number":1588,"context_line":"                          self.cs.servers.create,"},{"line_number":1589,"context_line":"                          name\u003d\"My server\","}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_d356e6ce","line":1586,"range":{"start_line":1586,"start_character":58,"end_line":1586,"end_character":59},"updated":"2017-09-06 20:40:16.000000000","message":"I think this should be a 3 instead, since 2.53 comes before 2.54.","commit_id":"5ee2654e902a022f09b315c28f93fa7e63c95fcf"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"641c21bb1e1813928d5cfbd5ae43b8822e207f7c","unresolved":false,"context_lines":[{"line_number":1583,"context_line":"                           )"},{"line_number":1584,"context_line":""},{"line_number":1585,"context_line":"    def test_create_server_with_tags_pre_254_fails(self):"},{"line_number":1586,"context_line":"        self.cs.api_version \u003d api_versions.APIVersion(\u00272.52\u0027)"},{"line_number":1587,"context_line":"        self.assertRaises(exceptions.UnsupportedAttribute,"},{"line_number":1588,"context_line":"                          self.cs.servers.create,"},{"line_number":1589,"context_line":"                          name\u003d\"My server\","}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_4f96bff2","line":1586,"range":{"start_line":1586,"start_character":58,"end_line":1586,"end_character":59},"in_reply_to":"7f287b81_d356e6ce","updated":"2017-09-07 04:49:37.000000000","message":"Good catch. Fixed in patch set 6.","commit_id":"5ee2654e902a022f09b315c28f93fa7e63c95fcf"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ae4b2dff3b7bcff87c745971d52ec69bc1b31496","unresolved":false,"context_lines":[{"line_number":1552,"context_line":"                          tags\u003d[\u0027tag1\u0027, \u0027tag2\u0027])"},{"line_number":1553,"context_line":""},{"line_number":1554,"context_line":""},{"line_number":1555,"context_line":"class ServersV254Test(ServersV252Test):"},{"line_number":1556,"context_line":""},{"line_number":1557,"context_line":"    api_version \u003d \"2.54\""},{"line_number":1558,"context_line":""},{"line_number":1559,"context_line":"    def test_rebuild_with_key_name(self):"},{"line_number":1560,"context_line":"        s \u003d self.cs.servers.get(1234)"},{"line_number":1561,"context_line":"        ret \u003d s.rebuild(image\u003d\"1\", key_name\u003d\"test_keypair\")"},{"line_number":1562,"context_line":"        self.assert_request_id(ret, fakes.FAKE_REQUEST_ID_LIST)"},{"line_number":1563,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/servers/1234/action\u0027,"},{"line_number":1564,"context_line":"                           {\u0027rebuild\u0027: {"},{"line_number":1565,"context_line":"                               \u0027imageRef\u0027: \u00271\u0027,"},{"line_number":1566,"context_line":"                               \u0027key_name\u0027: \u0027test_keypair\u0027}})"},{"line_number":1567,"context_line":""},{"line_number":1568,"context_line":"    def test_rebuild_with_key_name_none(self):"},{"line_number":1569,"context_line":"        s \u003d self.cs.servers.get(1234)"},{"line_number":1570,"context_line":"        ret \u003d s.rebuild(image\u003d\"1\", key_name\u003dNone)"},{"line_number":1571,"context_line":"        self.assert_request_id(ret, fakes.FAKE_REQUEST_ID_LIST)"},{"line_number":1572,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/servers/1234/action\u0027,"},{"line_number":1573,"context_line":"                           {\u0027rebuild\u0027: {"},{"line_number":1574,"context_line":"                               \u0027key_name\u0027: None,"},{"line_number":1575,"context_line":"                               \u0027imageRef\u0027: \u00271\u0027}})"},{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"    def test_rebuild_with_key_name_pre_254_fails(self):"},{"line_number":1578,"context_line":"        self.cs.api_version \u003d api_versions.APIVersion(\u00272.53\u0027)"},{"line_number":1579,"context_line":"        ex \u003d self.assertRaises(exceptions.UnsupportedAttribute,"},{"line_number":1580,"context_line":"                               self.cs.servers.rebuild,"},{"line_number":1581,"context_line":"                               \u00271234\u0027, fakes.FAKE_IMAGE_UUID_1,"},{"line_number":1582,"context_line":"                               key_name\u003d\u0027test_keypair\u0027)"},{"line_number":1583,"context_line":"        self.assertIn(\u0027key_name\u0027, six.text_type(ex.message))"}],"source_content_type":"text/x-python","patch_set":15,"id":"ff82abbf_9e9ca06a","side":"PARENT","line":1583,"range":{"start_line":1555,"start_character":0,"end_line":1583,"end_character":60},"updated":"2017-11-30 02:38:37.000000000","message":"These are tests for microversion 2.54.\nThey should NOT be removed.","commit_id":"f7c991703517b6fd6a42f732fc602badb0caebb8"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"ea25e06a81e3706badfe3325ebea3f42eb7d020a","unresolved":false,"context_lines":[{"line_number":1636,"context_line":"                           }}"},{"line_number":1637,"context_line":"                           )"},{"line_number":1638,"context_line":""},{"line_number":1639,"context_line":"    def test_create_server_with_tags_pre_257_fails(self):"},{"line_number":1640,"context_line":"        self.cs.api_version \u003d api_versions.APIVersion(\u00272.56\u0027)"},{"line_number":1641,"context_line":"        self.assertRaises(exceptions.UnsupportedAttribute,"},{"line_number":1642,"context_line":"                          self.cs.servers.create,"}],"source_content_type":"text/x-python","patch_set":23,"id":"df87a7cf_fb25060a","line":1639,"range":{"start_line":1639,"start_character":8,"end_line":1639,"end_character":50},"updated":"2017-12-08 15:23:27.000000000","message":"This will be renamed appropriately in the next patch","commit_id":"510e2069d449980e9417644f5569d350e117de09"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"10798745abcaf83b27009a94457232d329b56276","unresolved":false,"context_lines":[{"line_number":1568,"context_line":"        self.assertIn(\u0027files\u0027, six.text_type(ex))"},{"line_number":1569,"context_line":""},{"line_number":1570,"context_line":""},{"line_number":1571,"context_line":"class ServersV263Test(ServersV257Test):"},{"line_number":1572,"context_line":""},{"line_number":1573,"context_line":"    api_version \u003d \"2.63\""},{"line_number":1574,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_5c8a9a1a","line":1571,"updated":"2018-06-14 13:35:27.000000000","message":"Test cases for the rebuild method are missing.","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"8045d128d2694a53079d2c427e417fd6490b0f70","unresolved":false,"context_lines":[{"line_number":1568,"context_line":"        self.assertIn(\u0027files\u0027, six.text_type(ex))"},{"line_number":1569,"context_line":""},{"line_number":1570,"context_line":""},{"line_number":1571,"context_line":"class ServersV263Test(ServersV257Test):"},{"line_number":1572,"context_line":""},{"line_number":1573,"context_line":"    api_version \u003d \"2.63\""},{"line_number":1574,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_091e1974","line":1571,"in_reply_to":"5f7c97a3_5c8a9a1a","updated":"2018-06-14 19:36:46.000000000","message":"Done","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22060cbc359627c79e942809f4af9141e3a46ff6","unresolved":false,"context_lines":[{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"    def test_create_server_with_trusted_image_certificates_pre_263_fails(self):"},{"line_number":1578,"context_line":"        self.cs.api_version \u003d api_versions.APIVersion(\u00272.62\u0027)"},{"line_number":1579,"context_line":"        self.assertRaises(exceptions.UnsupportedAttribute,"},{"line_number":1580,"context_line":"                          self.cs.servers.create,"},{"line_number":1581,"context_line":"                          name\u003d\"My server\","},{"line_number":1582,"context_line":"                          image\u003d1,"}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_bd907144","line":1579,"updated":"2018-06-15 12:50:33.000000000","message":"Would be nice to add this assertion too:\n\nself.assertIn(\u0027trusted_image_certificates\u0027, six.text_type(ex.message))","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb7b44e654936c36ed8bd92536917b62c316003f","unresolved":false,"context_lines":[{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"    def test_create_server_with_trusted_image_certificates_pre_263_fails(self):"},{"line_number":1578,"context_line":"        self.cs.api_version \u003d api_versions.APIVersion(\u00272.62\u0027)"},{"line_number":1579,"context_line":"        self.assertRaises(exceptions.UnsupportedAttribute,"},{"line_number":1580,"context_line":"                          self.cs.servers.create,"},{"line_number":1581,"context_line":"                          name\u003d\"My server\","},{"line_number":1582,"context_line":"                          image\u003d1,"}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_384f8fbf","line":1579,"in_reply_to":"5f7c97a3_bd907144","updated":"2018-06-15 13:41:11.000000000","message":"Done","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"}],"novaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ae4b2dff3b7bcff87c745971d52ec69bc1b31496","unresolved":false,"context_lines":[{"line_number":3328,"context_line":"            51,  # There are no version-wrapped shell method changes for this."},{"line_number":3329,"context_line":"            52,  # There are no version-wrapped shell method changes for this."},{"line_number":3330,"context_line":"            54,  # There are no version-wrapped shell method changes for this."},{"line_number":3331,"context_line":"            55,  # There are no version-wrapped shell method changes for this."},{"line_number":3332,"context_line":"            56,  # There are no version-wrapped shell method changes for this."},{"line_number":3333,"context_line":"        ])"},{"line_number":3334,"context_line":"        versions_supported \u003d set(range(0,"}],"source_content_type":"text/x-python","patch_set":15,"id":"ff82abbf_bec2c451","line":3331,"range":{"start_line":3331,"start_character":12,"end_line":3331,"end_character":78},"updated":"2017-11-30 02:38:37.000000000","message":"It is not necessary. Remove it.","commit_id":"1786388b1a7159ead27b0b11870f6929df1b218d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ecefb66a500daaa6fe7fb0ef7656bfc0495a21e8","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"               \u0027--trusted-image-certificate-ids id1,id2\u0027 % FAKE_UUID_1)"},{"line_number":1203,"context_line":"        self.assertRaises(SystemExit, self.run_command,"},{"line_number":1204,"context_line":"                          cmd, api_version\u003d\u00272.56\u0027)"},{"line_number":1205,"context_line":""},{"line_number":1206,"context_line":"    def test_flavor_list(self):"},{"line_number":1207,"context_line":"        out, _ \u003d self.run_command(\u0027flavor-list\u0027)"},{"line_number":1208,"context_line":"        self.assert_called_anytime(\u0027GET\u0027, \u0027/flavors/detail\u0027)"}],"source_content_type":"text/x-python","patch_set":21,"id":"df87a7cf_1049b62f","line":1205,"updated":"2017-12-08 01:34:41.000000000","message":"Add a test with \u0027OS_TRUSTED_IMAGE_CERTIFICATE_IDS\u0027 in microversion 2.56.","commit_id":"43acafdd6cd500b88aec84b0935b579c8d410420"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"420141de38567fc99fe89a9f2bfc80e9f9e0061f","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"               \u0027--trusted-image-certificate-ids id1,id2\u0027 % FAKE_UUID_1)"},{"line_number":1203,"context_line":"        self.assertRaises(SystemExit, self.run_command,"},{"line_number":1204,"context_line":"                          cmd, api_version\u003d\u00272.56\u0027)"},{"line_number":1205,"context_line":""},{"line_number":1206,"context_line":"    def test_flavor_list(self):"},{"line_number":1207,"context_line":"        out, _ \u003d self.run_command(\u0027flavor-list\u0027)"},{"line_number":1208,"context_line":"        self.assert_called_anytime(\u0027GET\u0027, \u0027/flavors/detail\u0027)"}],"source_content_type":"text/x-python","patch_set":21,"id":"df87a7cf_3b9b6e66","line":1205,"in_reply_to":"df87a7cf_1049b62f","updated":"2017-12-08 15:20:23.000000000","message":"Done","commit_id":"43acafdd6cd500b88aec84b0935b579c8d410420"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ecefb66a500daaa6fe7fb0ef7656bfc0495a21e8","unresolved":false,"context_lines":[{"line_number":1666,"context_line":"                                            [\u0027var_id1\u0027, \u0027var_id2\u0027]}"},{"line_number":1667,"context_line":"                            }, pos\u003d3)"},{"line_number":1668,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/v2/images/%s\u0027 % FAKE_UUID_2, pos\u003d4)"},{"line_number":1669,"context_line":""},{"line_number":1670,"context_line":"    def test_start(self):"},{"line_number":1671,"context_line":"        self.run_command(\u0027start sample-server\u0027)"},{"line_number":1672,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/servers/1234/action\u0027, {\u0027os-start\u0027: None})"}],"source_content_type":"text/x-python","patch_set":21,"id":"df87a7cf_505c1eec","line":1669,"updated":"2017-12-08 01:34:41.000000000","message":"Add the following tests for rebuid\n\n* 2.56 with --trusted-image-certificate-ids option\n* 2.56 with OS_TRUSTED_IMAGE_CERTIFICATE_IDS","commit_id":"43acafdd6cd500b88aec84b0935b579c8d410420"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"420141de38567fc99fe89a9f2bfc80e9f9e0061f","unresolved":false,"context_lines":[{"line_number":1666,"context_line":"                                            [\u0027var_id1\u0027, \u0027var_id2\u0027]}"},{"line_number":1667,"context_line":"                            }, pos\u003d3)"},{"line_number":1668,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/v2/images/%s\u0027 % FAKE_UUID_2, pos\u003d4)"},{"line_number":1669,"context_line":""},{"line_number":1670,"context_line":"    def test_start(self):"},{"line_number":1671,"context_line":"        self.run_command(\u0027start sample-server\u0027)"},{"line_number":1672,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/servers/1234/action\u0027, {\u0027os-start\u0027: None})"}],"source_content_type":"text/x-python","patch_set":21,"id":"df87a7cf_7bbed6b4","line":1669,"in_reply_to":"df87a7cf_505c1eec","updated":"2017-12-08 15:20:23.000000000","message":"Done","commit_id":"43acafdd6cd500b88aec84b0935b579c8d410420"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"10798745abcaf83b27009a94457232d329b56276","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"            }},"},{"line_number":1208,"context_line":"        )"},{"line_number":1209,"context_line":""},{"line_number":1210,"context_line":"    def test_boot_without_trusted_image_certificates_v262(self):"},{"line_number":1211,"context_line":"        self.run_command(\u0027boot --flavor 1 --image %s --nic auto some-server\u0027"},{"line_number":1212,"context_line":"                         % FAKE_UUID_1, api_version\u003d\u00272.63\u0027)"},{"line_number":1213,"context_line":"        self.assert_called_anytime("}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_dc69cabd","line":1210,"range":{"start_line":1210,"start_character":54,"end_line":1210,"end_character":57},"updated":"2018-06-14 13:35:27.000000000","message":"263","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"8045d128d2694a53079d2c427e417fd6490b0f70","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"            }},"},{"line_number":1208,"context_line":"        )"},{"line_number":1209,"context_line":""},{"line_number":1210,"context_line":"    def test_boot_without_trusted_image_certificates_v262(self):"},{"line_number":1211,"context_line":"        self.run_command(\u0027boot --flavor 1 --image %s --nic auto some-server\u0027"},{"line_number":1212,"context_line":"                         % FAKE_UUID_1, api_version\u003d\u00272.63\u0027)"},{"line_number":1213,"context_line":"        self.assert_called_anytime("}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_e9095d32","line":1210,"range":{"start_line":1210,"start_character":54,"end_line":1210,"end_character":57},"in_reply_to":"5f7c97a3_dc69cabd","updated":"2018-06-14 19:36:46.000000000","message":"Done","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"10798745abcaf83b27009a94457232d329b56276","unresolved":false,"context_lines":[{"line_number":1860,"context_line":"                            }, pos\u003d4)"},{"line_number":1861,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/v2/images/%s\u0027 % FAKE_UUID_2, pos\u003d5)"},{"line_number":1862,"context_line":""},{"line_number":1863,"context_line":"    def test_rebuild_without_trusted_image_certificates_v262(self):"},{"line_number":1864,"context_line":"        self.run_command(\u0027rebuild sample-server %s\u0027 % FAKE_UUID_1,"},{"line_number":1865,"context_line":"                         api_version\u003d\u00272.63\u0027)"},{"line_number":1866,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/servers?name\u003dsample-server\u0027, pos\u003d0)"}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_7c9e76b8","line":1863,"range":{"start_line":1863,"start_character":57,"end_line":1863,"end_character":60},"updated":"2018-06-14 13:35:27.000000000","message":"263","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"8045d128d2694a53079d2c427e417fd6490b0f70","unresolved":false,"context_lines":[{"line_number":1860,"context_line":"                            }, pos\u003d4)"},{"line_number":1861,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/v2/images/%s\u0027 % FAKE_UUID_2, pos\u003d5)"},{"line_number":1862,"context_line":""},{"line_number":1863,"context_line":"    def test_rebuild_without_trusted_image_certificates_v262(self):"},{"line_number":1864,"context_line":"        self.run_command(\u0027rebuild sample-server %s\u0027 % FAKE_UUID_1,"},{"line_number":1865,"context_line":"                         api_version\u003d\u00272.63\u0027)"},{"line_number":1866,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/servers?name\u003dsample-server\u0027, pos\u003d0)"}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_4915f148","line":1863,"range":{"start_line":1863,"start_character":57,"end_line":1863,"end_character":60},"in_reply_to":"5f7c97a3_7c9e76b8","updated":"2018-06-14 19:36:46.000000000","message":"Done","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0c514551cfcffdb2fdf103d45691e31d40d9e6d9","unresolved":false,"context_lines":[{"line_number":1239,"context_line":"               % FAKE_UUID_1)"},{"line_number":1240,"context_line":"        self.assertRaises(exceptions.UnsupportedAttribute, self.run_command,"},{"line_number":1241,"context_line":"                          cmd, api_version\u003d\u00272.62\u0027)"},{"line_number":1242,"context_line":""},{"line_number":1243,"context_line":"    def test_flavor_list(self):"},{"line_number":1244,"context_line":"        out, _ \u003d self.run_command(\u0027flavor-list\u0027)"},{"line_number":1245,"context_line":"        self.assert_called_anytime(\u0027GET\u0027, \u0027/flavors/detail\u0027)"}],"source_content_type":"text/x-python","patch_set":49,"id":"5f7c97a3_4f0f1e2f","line":1242,"updated":"2018-06-15 14:29:10.000000000","message":"Would be nice to have a boot test case with env +  --trusted-image-certificates to assert that the env is ignored in this case.","commit_id":"5a198aa0d6488e2c340a82453fabb0cd1f309aed"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0ba9e9d743cc5f3b4a4c0f2776e5806467c0b1a2","unresolved":false,"context_lines":[{"line_number":1239,"context_line":"               % FAKE_UUID_1)"},{"line_number":1240,"context_line":"        self.assertRaises(exceptions.UnsupportedAttribute, self.run_command,"},{"line_number":1241,"context_line":"                          cmd, api_version\u003d\u00272.62\u0027)"},{"line_number":1242,"context_line":""},{"line_number":1243,"context_line":"    def test_flavor_list(self):"},{"line_number":1244,"context_line":"        out, _ \u003d self.run_command(\u0027flavor-list\u0027)"},{"line_number":1245,"context_line":"        self.assert_called_anytime(\u0027GET\u0027, \u0027/flavors/detail\u0027)"}],"source_content_type":"text/x-python","patch_set":49,"id":"5f7c97a3_ef906a45","line":1242,"in_reply_to":"5f7c97a3_4f0f1e2f","updated":"2018-06-15 14:44:29.000000000","message":"Done","commit_id":"5a198aa0d6488e2c340a82453fabb0cd1f309aed"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0c514551cfcffdb2fdf103d45691e31d40d9e6d9","unresolved":false,"context_lines":[{"line_number":1870,"context_line":"        self.assertIn(\"Cannot specify \u0027--trusted-image-certificates-unset\u0027 \""},{"line_number":1871,"context_line":"                      \"with \u0027--trusted-image-certificate-id\u0027\","},{"line_number":1872,"context_line":"                      six.text_type(ex))"},{"line_number":1873,"context_line":""},{"line_number":1874,"context_line":"    def test_start(self):"},{"line_number":1875,"context_line":"        self.run_command(\u0027start sample-server\u0027)"},{"line_number":1876,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/servers/1234/action\u0027, {\u0027os-start\u0027: None})"}],"source_content_type":"text/x-python","patch_set":49,"id":"5f7c97a3_6c07881f","line":1873,"updated":"2018-06-15 14:29:10.000000000","message":"would be nice to have a rebuild test with both env and  --trusted-image-certificates asserting that the env is ignored in this case.","commit_id":"5a198aa0d6488e2c340a82453fabb0cd1f309aed"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0ba9e9d743cc5f3b4a4c0f2776e5806467c0b1a2","unresolved":false,"context_lines":[{"line_number":1870,"context_line":"        self.assertIn(\"Cannot specify \u0027--trusted-image-certificates-unset\u0027 \""},{"line_number":1871,"context_line":"                      \"with \u0027--trusted-image-certificate-id\u0027\","},{"line_number":1872,"context_line":"                      six.text_type(ex))"},{"line_number":1873,"context_line":""},{"line_number":1874,"context_line":"    def test_start(self):"},{"line_number":1875,"context_line":"        self.run_command(\u0027start sample-server\u0027)"},{"line_number":1876,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/servers/1234/action\u0027, {\u0027os-start\u0027: None})"}],"source_content_type":"text/x-python","patch_set":49,"id":"5f7c97a3_8f953635","line":1873,"in_reply_to":"5f7c97a3_6c07881f","updated":"2018-06-15 14:44:29.000000000","message":"Done","commit_id":"5a198aa0d6488e2c340a82453fabb0cd1f309aed"}],"novaclient/v2/servers.py":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"ed0bef5fff062c4445487b91f0ba14427683ba74","unresolved":false,"context_lines":[{"line_number":1351,"context_line":"        :param tags: A list of arbitrary strings to be added to the"},{"line_number":1352,"context_line":"                     server as tags (allowed since microversion 2.52)"},{"line_number":1353,"context_line":"        :param trusted_certificates: A list of trusted certificate UUIDs"},{"line_number":1354,"context_line":"                                    (allowed since microversion 2.54)"},{"line_number":1355,"context_line":"        \"\"\""},{"line_number":1356,"context_line":"        if not min_count:"},{"line_number":1357,"context_line":"            min_count \u003d 1"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_b3deba3b","line":1354,"range":{"start_line":1354,"start_character":34,"end_line":1354,"end_character":35},"updated":"2017-09-06 20:40:16.000000000","message":"I think this would look better with an additional space.","commit_id":"5ee2654e902a022f09b315c28f93fa7e63c95fcf"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"641c21bb1e1813928d5cfbd5ae43b8822e207f7c","unresolved":false,"context_lines":[{"line_number":1351,"context_line":"        :param tags: A list of arbitrary strings to be added to the"},{"line_number":1352,"context_line":"                     server as tags (allowed since microversion 2.52)"},{"line_number":1353,"context_line":"        :param trusted_certificates: A list of trusted certificate UUIDs"},{"line_number":1354,"context_line":"                                    (allowed since microversion 2.54)"},{"line_number":1355,"context_line":"        \"\"\""},{"line_number":1356,"context_line":"        if not min_count:"},{"line_number":1357,"context_line":"            min_count \u003d 1"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_cf898fca","line":1354,"range":{"start_line":1354,"start_character":34,"end_line":1354,"end_character":35},"in_reply_to":"7f287b81_b3deba3b","updated":"2017-09-07 04:49:37.000000000","message":"Good catch. Fixed in patch set 6. The same fix applies to L1517.","commit_id":"5ee2654e902a022f09b315c28f93fa7e63c95fcf"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"18e5c75505a8d528f80391f091d2540184c3ff53","unresolved":false,"context_lines":[{"line_number":1538,"context_line":"        if \"description\" in kwargs:"},{"line_number":1539,"context_line":"            body[\"description\"] \u003d kwargs[\"description\"]"},{"line_number":1540,"context_line":"        if \"trusted_certificates\" in kwargs:"},{"line_number":1541,"context_line":"            body[\"trusted_certificates\"] \u003d strutils.split_by_commas("},{"line_number":1542,"context_line":"                kwargs[\"trusted_certificates\"])"},{"line_number":1543,"context_line":"        if meta:"},{"line_number":1544,"context_line":"            body[\u0027metadata\u0027] \u003d meta"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f2577a7_50b88ee3","line":1541,"range":{"start_line":1541,"start_character":43,"end_line":1541,"end_character":67},"updated":"2017-09-15 18:32:52.000000000","message":"This call to split_by_commas doesn\u0027t work, and I don\u0027t think it\u0027s needed.  The line can be changed to:\n\n            body[\"trusted_certificates\"] \u003d kwargs[\"trusted_certificates\"])","commit_id":"124849f2cda2736b7611848cfe8a99624bedbfdf"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"52ac0a9e0cb6c067b237a7097b5a19fe4dd65516","unresolved":false,"context_lines":[{"line_number":1538,"context_line":"        if \"description\" in kwargs:"},{"line_number":1539,"context_line":"            body[\"description\"] \u003d kwargs[\"description\"]"},{"line_number":1540,"context_line":"        if \"trusted_certificates\" in kwargs:"},{"line_number":1541,"context_line":"            body[\"trusted_certificates\"] \u003d strutils.split_by_commas("},{"line_number":1542,"context_line":"                kwargs[\"trusted_certificates\"])"},{"line_number":1543,"context_line":"        if meta:"},{"line_number":1544,"context_line":"            body[\u0027metadata\u0027] \u003d meta"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f2577a7_fec98458","line":1541,"range":{"start_line":1541,"start_character":43,"end_line":1541,"end_character":67},"in_reply_to":"5f2577a7_50b88ee3","updated":"2017-09-16 06:56:42.000000000","message":"You\u0027re right, we don\u0027t need the split_by_commas. It has been removed in patch set 8.","commit_id":"124849f2cda2736b7611848cfe8a99624bedbfdf"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"10798745abcaf83b27009a94457232d329b56276","unresolved":false,"context_lines":[{"line_number":769,"context_line":"            body[\u0027server\u0027][\u0027tags\u0027] \u003d tags"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"        if trusted_image_certificates:"},{"line_number":772,"context_line":"            body[\u0027server\u0027][\u0027trusted_image_certificates\u0027] \u003d \\"},{"line_number":773,"context_line":"                trusted_image_certificates"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        return self._create(\u0027/servers\u0027, body, response_key,"},{"line_number":776,"context_line":"                            return_raw\u003dreturn_raw, **kwargs)"}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_9c17d2ee","line":773,"range":{"start_line":772,"start_character":0,"end_line":773,"end_character":42},"updated":"2018-06-14 13:35:27.000000000","message":"nit:\n            body[\u0027server\u0027][\u0027trusted_image_certificates\u0027] \u003d (\n                trusted_image_certificates)","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"8045d128d2694a53079d2c427e417fd6490b0f70","unresolved":false,"context_lines":[{"line_number":769,"context_line":"            body[\u0027server\u0027][\u0027tags\u0027] \u003d tags"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"        if trusted_image_certificates:"},{"line_number":772,"context_line":"            body[\u0027server\u0027][\u0027trusted_image_certificates\u0027] \u003d \\"},{"line_number":773,"context_line":"                trusted_image_certificates"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        return self._create(\u0027/servers\u0027, body, response_key,"},{"line_number":776,"context_line":"                            return_raw\u003dreturn_raw, **kwargs)"}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_0444c018","line":773,"range":{"start_line":772,"start_character":0,"end_line":773,"end_character":42},"in_reply_to":"5f7c97a3_9c17d2ee","updated":"2018-06-14 19:36:46.000000000","message":"Done","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"10798745abcaf83b27009a94457232d329b56276","unresolved":false,"context_lines":[{"line_number":1302,"context_line":"            raise exceptions.UnsupportedAttribute(\u0027files\u0027, \u00272.0\u0027, \u00272.56\u0027)"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"        trusted_certs_microversion \u003d api_versions.APIVersion(\"2.63\")"},{"line_number":1305,"context_line":"        if \"trusted_image_certificates\" in kwargs and \\"},{"line_number":1306,"context_line":"                self.api_version \u003c trusted_certs_microversion:"},{"line_number":1307,"context_line":"            raise exceptions.UnsupportedAttribute(\"trusted_image_certificates\","},{"line_number":1308,"context_line":"                                                  \"2.63\")"},{"line_number":1309,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_fcf366e5","line":1306,"range":{"start_line":1305,"start_character":0,"end_line":1306,"end_character":62},"updated":"2018-06-14 13:35:27.000000000","message":"nit: \n        if (\"trusted_image_certificates\" in kwargs and\n                self.api_version \u003c trusted_certs_microversion):","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"8045d128d2694a53079d2c427e417fd6490b0f70","unresolved":false,"context_lines":[{"line_number":1302,"context_line":"            raise exceptions.UnsupportedAttribute(\u0027files\u0027, \u00272.0\u0027, \u00272.56\u0027)"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"        trusted_certs_microversion \u003d api_versions.APIVersion(\"2.63\")"},{"line_number":1305,"context_line":"        if \"trusted_image_certificates\" in kwargs and \\"},{"line_number":1306,"context_line":"                self.api_version \u003c trusted_certs_microversion:"},{"line_number":1307,"context_line":"            raise exceptions.UnsupportedAttribute(\"trusted_image_certificates\","},{"line_number":1308,"context_line":"                                                  \"2.63\")"},{"line_number":1309,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_24569cd0","line":1306,"range":{"start_line":1305,"start_character":0,"end_line":1306,"end_character":62},"in_reply_to":"5f7c97a3_fcf366e5","updated":"2018-06-14 19:36:46.000000000","message":"Done","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"10798745abcaf83b27009a94457232d329b56276","unresolved":false,"context_lines":[{"line_number":1454,"context_line":"            raise exceptions.UnsupportedAttribute(\u0027userdata\u0027, \u00272.57\u0027)"},{"line_number":1455,"context_line":""},{"line_number":1456,"context_line":"        trusted_certs_microversion \u003d api_versions.APIVersion(\"2.63\")"},{"line_number":1457,"context_line":"        if \"trusted_image_certificates\" in kwargs and \\"},{"line_number":1458,"context_line":"                self.api_version \u003c trusted_certs_microversion:"},{"line_number":1459,"context_line":"            raise exceptions.UnsupportedAttribute(\"trusted_image_certificates\","},{"line_number":1460,"context_line":"                                                  \"2.63\")"},{"line_number":1461,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_9ce2722f","line":1458,"range":{"start_line":1457,"start_character":0,"end_line":1458,"end_character":61},"updated":"2018-06-14 13:35:27.000000000","message":"ditto","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"8045d128d2694a53079d2c427e417fd6490b0f70","unresolved":false,"context_lines":[{"line_number":1454,"context_line":"            raise exceptions.UnsupportedAttribute(\u0027userdata\u0027, \u00272.57\u0027)"},{"line_number":1455,"context_line":""},{"line_number":1456,"context_line":"        trusted_certs_microversion \u003d api_versions.APIVersion(\"2.63\")"},{"line_number":1457,"context_line":"        if \"trusted_image_certificates\" in kwargs and \\"},{"line_number":1458,"context_line":"                self.api_version \u003c trusted_certs_microversion:"},{"line_number":1459,"context_line":"            raise exceptions.UnsupportedAttribute(\"trusted_image_certificates\","},{"line_number":1460,"context_line":"                                                  \"2.63\")"},{"line_number":1461,"context_line":""}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_6401f4b5","line":1458,"range":{"start_line":1457,"start_character":0,"end_line":1458,"end_character":61},"in_reply_to":"5f7c97a3_9ce2722f","updated":"2018-06-14 19:36:46.000000000","message":"Done","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"10798745abcaf83b27009a94457232d329b56276","unresolved":false,"context_lines":[{"line_number":1473,"context_line":"        if \u0027key_name\u0027 in kwargs:"},{"line_number":1474,"context_line":"            body[\u0027key_name\u0027] \u003d kwargs[\u0027key_name\u0027]"},{"line_number":1475,"context_line":"        if \"trusted_image_certificates\" in kwargs:"},{"line_number":1476,"context_line":"            body[\"trusted_image_certificates\"] \u003d\\"},{"line_number":1477,"context_line":"                kwargs[\"trusted_image_certificates\"]"},{"line_number":1478,"context_line":"        if meta:"},{"line_number":1479,"context_line":"            body[\u0027metadata\u0027] \u003d meta"},{"line_number":1480,"context_line":"        if files:"}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_3c0ebee3","line":1477,"range":{"start_line":1476,"start_character":0,"end_line":1477,"end_character":52},"updated":"2018-06-14 13:35:27.000000000","message":"nit:\n            body[\"trusted_image_certificates\"] \u003d kwargs[\n                \"trusted_image_certificates\"]","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"8045d128d2694a53079d2c427e417fd6490b0f70","unresolved":false,"context_lines":[{"line_number":1473,"context_line":"        if \u0027key_name\u0027 in kwargs:"},{"line_number":1474,"context_line":"            body[\u0027key_name\u0027] \u003d kwargs[\u0027key_name\u0027]"},{"line_number":1475,"context_line":"        if \"trusted_image_certificates\" in kwargs:"},{"line_number":1476,"context_line":"            body[\"trusted_image_certificates\"] \u003d\\"},{"line_number":1477,"context_line":"                kwargs[\"trusted_image_certificates\"]"},{"line_number":1478,"context_line":"        if meta:"},{"line_number":1479,"context_line":"            body[\u0027metadata\u0027] \u003d meta"},{"line_number":1480,"context_line":"        if files:"}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_44295835","line":1477,"range":{"start_line":1476,"start_character":0,"end_line":1477,"end_character":52},"in_reply_to":"5f7c97a3_3c0ebee3","updated":"2018-06-14 19:36:46.000000000","message":"Done","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22060cbc359627c79e942809f4af9141e3a46ff6","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"                            microversion 2.19)"},{"line_number":1257,"context_line":"        :param tags: A list of arbitrary strings to be added to the"},{"line_number":1258,"context_line":"                     server as tags (allowed since microversion 2.52)"},{"line_number":1259,"context_line":"        :param trusted_image_certificates: A list of trusted certificate UUIDs"},{"line_number":1260,"context_line":"                                           (allowed since microversion 2.63)"},{"line_number":1261,"context_line":"        \"\"\""},{"line_number":1262,"context_line":"        if not min_count:"}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_3dc5413e","line":1259,"range":{"start_line":1259,"start_character":15,"end_line":1259,"end_character":41},"updated":"2018-06-15 12:50:33.000000000","message":"Let\u0027s make this a named kwarg also.","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22060cbc359627c79e942809f4af9141e3a46ff6","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"                            microversion 2.19)"},{"line_number":1257,"context_line":"        :param tags: A list of arbitrary strings to be added to the"},{"line_number":1258,"context_line":"                     server as tags (allowed since microversion 2.52)"},{"line_number":1259,"context_line":"        :param trusted_image_certificates: A list of trusted certificate UUIDs"},{"line_number":1260,"context_line":"                                           (allowed since microversion 2.63)"},{"line_number":1261,"context_line":"        \"\"\""},{"line_number":1262,"context_line":"        if not min_count:"}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_9db495d6","line":1259,"range":{"start_line":1259,"start_character":73,"end_line":1259,"end_character":78},"updated":"2018-06-15 12:50:33.000000000","message":"nit: they don\u0027t necessarily have to be UUIDs otherwise the compute REST API schema would validate for that","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb7b44e654936c36ed8bd92536917b62c316003f","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"                            microversion 2.19)"},{"line_number":1257,"context_line":"        :param tags: A list of arbitrary strings to be added to the"},{"line_number":1258,"context_line":"                     server as tags (allowed since microversion 2.52)"},{"line_number":1259,"context_line":"        :param trusted_image_certificates: A list of trusted certificate UUIDs"},{"line_number":1260,"context_line":"                                           (allowed since microversion 2.63)"},{"line_number":1261,"context_line":"        \"\"\""},{"line_number":1262,"context_line":"        if not min_count:"}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_d84bfbae","line":1259,"range":{"start_line":1259,"start_character":15,"end_line":1259,"end_character":41},"in_reply_to":"5f7c97a3_3dc5413e","updated":"2018-06-15 13:41:11.000000000","message":"Done","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb7b44e654936c36ed8bd92536917b62c316003f","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"                            microversion 2.19)"},{"line_number":1257,"context_line":"        :param tags: A list of arbitrary strings to be added to the"},{"line_number":1258,"context_line":"                     server as tags (allowed since microversion 2.52)"},{"line_number":1259,"context_line":"        :param trusted_image_certificates: A list of trusted certificate UUIDs"},{"line_number":1260,"context_line":"                                           (allowed since microversion 2.63)"},{"line_number":1261,"context_line":"        \"\"\""},{"line_number":1262,"context_line":"        if not min_count:"}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_f84837b4","line":1259,"range":{"start_line":1259,"start_character":73,"end_line":1259,"end_character":78},"in_reply_to":"5f7c97a3_9db495d6","updated":"2018-06-15 13:41:11.000000000","message":"Done","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22060cbc359627c79e942809f4af9141e3a46ff6","unresolved":false,"context_lines":[{"line_number":1428,"context_line":"                         well or a string. If None is specified, the existing"},{"line_number":1429,"context_line":"                         user_data is unset."},{"line_number":1430,"context_line":"                         (starting from microversion 2.57)"},{"line_number":1431,"context_line":"        :param trusted_image_certificates: A list of trusted certificate UUIDs"},{"line_number":1432,"context_line":"                                           (allowed since microversion 2.63)"},{"line_number":1433,"context_line":"        :returns: :class:`Server`"},{"line_number":1434,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_9dd9f529","line":1431,"range":{"start_line":1431,"start_character":73,"end_line":1431,"end_character":78},"updated":"2018-06-15 12:50:33.000000000","message":"IDs","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22060cbc359627c79e942809f4af9141e3a46ff6","unresolved":false,"context_lines":[{"line_number":1428,"context_line":"                         well or a string. If None is specified, the existing"},{"line_number":1429,"context_line":"                         user_data is unset."},{"line_number":1430,"context_line":"                         (starting from microversion 2.57)"},{"line_number":1431,"context_line":"        :param trusted_image_certificates: A list of trusted certificate UUIDs"},{"line_number":1432,"context_line":"                                           (allowed since microversion 2.63)"},{"line_number":1433,"context_line":"        :returns: :class:`Server`"},{"line_number":1434,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_ddc1ad31","line":1431,"range":{"start_line":1431,"start_character":15,"end_line":1431,"end_character":41},"updated":"2018-06-15 12:50:33.000000000","message":"named kwarg","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb7b44e654936c36ed8bd92536917b62c316003f","unresolved":false,"context_lines":[{"line_number":1428,"context_line":"                         well or a string. If None is specified, the existing"},{"line_number":1429,"context_line":"                         user_data is unset."},{"line_number":1430,"context_line":"                         (starting from microversion 2.57)"},{"line_number":1431,"context_line":"        :param trusted_image_certificates: A list of trusted certificate UUIDs"},{"line_number":1432,"context_line":"                                           (allowed since microversion 2.63)"},{"line_number":1433,"context_line":"        :returns: :class:`Server`"},{"line_number":1434,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_98c34307","line":1431,"range":{"start_line":1431,"start_character":73,"end_line":1431,"end_character":78},"in_reply_to":"5f7c97a3_9dd9f529","updated":"2018-06-15 13:41:11.000000000","message":"Done","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ef5556ec990ace4637595bd1a39c28190b66f750","unresolved":false,"context_lines":[{"line_number":1428,"context_line":"                         well or a string. If None is specified, the existing"},{"line_number":1429,"context_line":"                         user_data is unset."},{"line_number":1430,"context_line":"                         (starting from microversion 2.57)"},{"line_number":1431,"context_line":"        :param trusted_image_certificates: A list of trusted certificate UUIDs"},{"line_number":1432,"context_line":"                                           (allowed since microversion 2.63)"},{"line_number":1433,"context_line":"        :returns: :class:`Server`"},{"line_number":1434,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_dd552d20","line":1431,"range":{"start_line":1431,"start_character":15,"end_line":1431,"end_character":41},"in_reply_to":"5f7c97a3_ddc1ad31","updated":"2018-06-15 13:02:28.000000000","message":"\u003e named kwarg\n\nNevermind this one, I guess we don\u0027t want to make it a named kwarg default to None since that could be confused with an intentional unset/reset.","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0c514551cfcffdb2fdf103d45691e31d40d9e6d9","unresolved":false,"context_lines":[{"line_number":1430,"context_line":"                         well or a string. If None is specified, the existing"},{"line_number":1431,"context_line":"                         user_data is unset."},{"line_number":1432,"context_line":"                         (starting from microversion 2.57)"},{"line_number":1433,"context_line":"        :param trusted_image_certificates: A list of trusted certificate IDs"},{"line_number":1434,"context_line":"                                           (allowed since microversion 2.63)"},{"line_number":1435,"context_line":"        :returns: :class:`Server`"},{"line_number":1436,"context_line":"        \"\"\""},{"line_number":1437,"context_line":"        descr_microversion \u003d api_versions.APIVersion(\"2.19\")"}],"source_content_type":"text/x-python","patch_set":49,"id":"5f7c97a3_cc91fcf9","line":1434,"range":{"start_line":1433,"start_character":43,"end_line":1434,"end_character":76},"updated":"2018-06-15 14:29:10.000000000","message":"or None to unset the certificates during rebuild.","commit_id":"5a198aa0d6488e2c340a82453fabb0cd1f309aed"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0ba9e9d743cc5f3b4a4c0f2776e5806467c0b1a2","unresolved":false,"context_lines":[{"line_number":1430,"context_line":"                         well or a string. If None is specified, the existing"},{"line_number":1431,"context_line":"                         user_data is unset."},{"line_number":1432,"context_line":"                         (starting from microversion 2.57)"},{"line_number":1433,"context_line":"        :param trusted_image_certificates: A list of trusted certificate IDs"},{"line_number":1434,"context_line":"                                           (allowed since microversion 2.63)"},{"line_number":1435,"context_line":"        :returns: :class:`Server`"},{"line_number":1436,"context_line":"        \"\"\""},{"line_number":1437,"context_line":"        descr_microversion \u003d api_versions.APIVersion(\"2.19\")"}],"source_content_type":"text/x-python","patch_set":49,"id":"5f7c97a3_8fa776bd","line":1434,"range":{"start_line":1433,"start_character":43,"end_line":1434,"end_character":76},"in_reply_to":"5f7c97a3_cc91fcf9","updated":"2018-06-15 14:44:29.000000000","message":"Done","commit_id":"5a198aa0d6488e2c340a82453fabb0cd1f309aed"}],"novaclient/v2/shell.py":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"c31404d5c66a3dd17e88d5e58e3cec2eb39cac5b","unresolved":false,"context_lines":[{"line_number":900,"context_line":"    help\u003d_(\"Return a reservation id bound to created servers.\"))"},{"line_number":901,"context_line":"@utils.arg("},{"line_number":902,"context_line":"    \u0027--trusted-certificate-ids\u0027,"},{"line_number":903,"context_line":"    metavar\u003d\u0027\u003ctrusted-certificate-ids\u003e\u0027,"},{"line_number":904,"context_line":"    dest\u003d\u0027trusted_certificates\u0027,"},{"line_number":905,"context_line":"    default\u003dutils.env(\u0027OS_TRUSTED_CERTIFICATE_IDS\u0027),"},{"line_number":906,"context_line":"    help\u003d_(\u0027Comma-separated list of trusted certificate UUIDs.\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f2577a7_e77d82b2","line":903,"range":{"start_line":903,"start_character":13,"end_line":903,"end_character":38},"updated":"2017-09-15 17:13:31.000000000","message":"If you\u0027re wanting the values to be separated by commas (instead of having multiple --trusted-certificate-id parameters, but I don\u0027t know how that would work with the environment variable), there should be an example, similar to what \u0027tags\u0027 does in its help line above.","commit_id":"124849f2cda2736b7611848cfe8a99624bedbfdf"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"52ac0a9e0cb6c067b237a7097b5a19fe4dd65516","unresolved":false,"context_lines":[{"line_number":900,"context_line":"    help\u003d_(\"Return a reservation id bound to created servers.\"))"},{"line_number":901,"context_line":"@utils.arg("},{"line_number":902,"context_line":"    \u0027--trusted-certificate-ids\u0027,"},{"line_number":903,"context_line":"    metavar\u003d\u0027\u003ctrusted-certificate-ids\u003e\u0027,"},{"line_number":904,"context_line":"    dest\u003d\u0027trusted_certificates\u0027,"},{"line_number":905,"context_line":"    default\u003dutils.env(\u0027OS_TRUSTED_CERTIFICATE_IDS\u0027),"},{"line_number":906,"context_line":"    help\u003d_(\u0027Comma-separated list of trusted certificate UUIDs.\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f2577a7_bebf7ca8","line":903,"range":{"start_line":903,"start_character":13,"end_line":903,"end_character":38},"in_reply_to":"5f2577a7_e77d82b2","updated":"2017-09-16 06:56:42.000000000","message":"Added in patch set 8.","commit_id":"124849f2cda2736b7611848cfe8a99624bedbfdf"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"c31404d5c66a3dd17e88d5e58e3cec2eb39cac5b","unresolved":false,"context_lines":[{"line_number":903,"context_line":"    metavar\u003d\u0027\u003ctrusted-certificate-ids\u003e\u0027,"},{"line_number":904,"context_line":"    dest\u003d\u0027trusted_certificates\u0027,"},{"line_number":905,"context_line":"    default\u003dutils.env(\u0027OS_TRUSTED_CERTIFICATE_IDS\u0027),"},{"line_number":906,"context_line":"    help\u003d_(\u0027Comma-separated list of trusted certificate UUIDs.\u0027"},{"line_number":907,"context_line":"           \u0027Defaults to env[OS_TRUSTED_CERTIFICATE_IDS].\u0027"},{"line_number":908,"context_line":"           \u0027These UUIDs are used to validate certificates during the image\u0027"},{"line_number":909,"context_line":"           \u0027signature verification process.\u0027),"},{"line_number":910,"context_line":"    start_version\u003d\"2.54\")"},{"line_number":911,"context_line":"def do_boot(cs, args):"},{"line_number":912,"context_line":"    \"\"\"Boot a new server.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f2577a7_0702ce3d","line":909,"range":{"start_line":906,"start_character":0,"end_line":909,"end_character":46},"updated":"2017-09-15 17:13:31.000000000","message":"Spaced should be added between the sentences and between \u0027image\u0027 and \u0027signature.\u0027\n\nIt currently is displayed as follows:\n\n  --trusted-certificate-ids \u003ctrusted-certificate-ids\u003e\n                                Comma-separated list of trusted certificate\n                                UUIDs.Defaults to\n                                env[OS_TRUSTED_CERTIFICATE_IDS].These UUIDs\n                                are used to validate certificates during the\n                                imagesignature verification process.\n                                (Supported by API versions \u00272.54\u0027 -\n                                \u00272.latest\u0027)","commit_id":"124849f2cda2736b7611848cfe8a99624bedbfdf"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"52ac0a9e0cb6c067b237a7097b5a19fe4dd65516","unresolved":false,"context_lines":[{"line_number":903,"context_line":"    metavar\u003d\u0027\u003ctrusted-certificate-ids\u003e\u0027,"},{"line_number":904,"context_line":"    dest\u003d\u0027trusted_certificates\u0027,"},{"line_number":905,"context_line":"    default\u003dutils.env(\u0027OS_TRUSTED_CERTIFICATE_IDS\u0027),"},{"line_number":906,"context_line":"    help\u003d_(\u0027Comma-separated list of trusted certificate UUIDs.\u0027"},{"line_number":907,"context_line":"           \u0027Defaults to env[OS_TRUSTED_CERTIFICATE_IDS].\u0027"},{"line_number":908,"context_line":"           \u0027These UUIDs are used to validate certificates during the image\u0027"},{"line_number":909,"context_line":"           \u0027signature verification process.\u0027),"},{"line_number":910,"context_line":"    start_version\u003d\"2.54\")"},{"line_number":911,"context_line":"def do_boot(cs, args):"},{"line_number":912,"context_line":"    \"\"\"Boot a new server.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f2577a7_7ee354da","line":909,"range":{"start_line":906,"start_character":0,"end_line":909,"end_character":46},"in_reply_to":"5f2577a7_0702ce3d","updated":"2017-09-16 06:56:42.000000000","message":"Good catch. Updated in patch set 8.","commit_id":"124849f2cda2736b7611848cfe8a99624bedbfdf"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"10798745abcaf83b27009a94457232d329b56276","unresolved":false,"context_lines":[{"line_number":510,"context_line":"    if include_files:"},{"line_number":511,"context_line":"        boot_kwargs[\u0027files\u0027] \u003d files"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    if \u0027trusted_image_certificates\u0027 in args and \\"},{"line_number":514,"context_line":"            args.trusted_image_certificates:"},{"line_number":515,"context_line":"        boot_kwargs[\u0027trusted_image_certificates\u0027] \u003d \\"},{"line_number":516,"context_line":"            args.trusted_image_certificates.split(\u0027,\u0027)"}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_7cbf56cf","line":513,"range":{"start_line":513,"start_character":48,"end_line":513,"end_character":49},"updated":"2018-06-14 13:35:27.000000000","message":"ditto","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"8045d128d2694a53079d2c427e417fd6490b0f70","unresolved":false,"context_lines":[{"line_number":510,"context_line":"    if include_files:"},{"line_number":511,"context_line":"        boot_kwargs[\u0027files\u0027] \u003d files"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    if \u0027trusted_image_certificates\u0027 in args and \\"},{"line_number":514,"context_line":"            args.trusted_image_certificates:"},{"line_number":515,"context_line":"        boot_kwargs[\u0027trusted_image_certificates\u0027] \u003d \\"},{"line_number":516,"context_line":"            args.trusted_image_certificates.split(\u0027,\u0027)"}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_a4170cef","line":513,"range":{"start_line":513,"start_character":48,"end_line":513,"end_character":49},"in_reply_to":"5f7c97a3_7cbf56cf","updated":"2018-06-14 19:36:46.000000000","message":"Done","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"10798745abcaf83b27009a94457232d329b56276","unresolved":false,"context_lines":[{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    if \u0027trusted_image_certificates\u0027 in args and \\"},{"line_number":514,"context_line":"            args.trusted_image_certificates:"},{"line_number":515,"context_line":"        boot_kwargs[\u0027trusted_image_certificates\u0027] \u003d \\"},{"line_number":516,"context_line":"            args.trusted_image_certificates.split(\u0027,\u0027)"},{"line_number":517,"context_line":"    elif utils.env(\u0027OS_TRUSTED_IMAGE_CERTIFICATE_IDS\u0027):"},{"line_number":518,"context_line":"        boot_kwargs[\"trusted_image_certificates\"] \u003d utils.env("}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_1cb2e206","line":515,"range":{"start_line":515,"start_character":52,"end_line":515,"end_character":53},"updated":"2018-06-14 13:35:27.000000000","message":"ditto","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"8045d128d2694a53079d2c427e417fd6490b0f70","unresolved":false,"context_lines":[{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    if \u0027trusted_image_certificates\u0027 in args and \\"},{"line_number":514,"context_line":"            args.trusted_image_certificates:"},{"line_number":515,"context_line":"        boot_kwargs[\u0027trusted_image_certificates\u0027] \u003d \\"},{"line_number":516,"context_line":"            args.trusted_image_certificates.split(\u0027,\u0027)"},{"line_number":517,"context_line":"    elif utils.env(\u0027OS_TRUSTED_IMAGE_CERTIFICATE_IDS\u0027):"},{"line_number":518,"context_line":"        boot_kwargs[\"trusted_image_certificates\"] \u003d utils.env("}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_c41488ec","line":515,"range":{"start_line":515,"start_character":52,"end_line":515,"end_character":53},"in_reply_to":"5f7c97a3_1cb2e206","updated":"2018-06-14 19:36:46.000000000","message":"Done","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"10798745abcaf83b27009a94457232d329b56276","unresolved":false,"context_lines":[{"line_number":886,"context_line":"    \u0027--trusted-image-certificate-ids\u0027,"},{"line_number":887,"context_line":"    metavar\u003d\u0027\u003ctrusted-image-certificate-ids\u003e\u0027,"},{"line_number":888,"context_line":"    dest\u003d\u0027trusted_image_certificates\u0027,"},{"line_number":889,"context_line":"    default\u003dNone,"},{"line_number":890,"context_line":"    help\u003d_(\u0027Trusted image certificate IDs used to validate certificates \u0027"},{"line_number":891,"context_line":"           \u0027during the image signature verification process. \u0027"},{"line_number":892,"context_line":"           \u0027Defaults to env[OS_TRUSTED_IMAGE_CERTIFICATE_IDS]. \u0027"}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_9c1d92bf","line":889,"range":{"start_line":889,"start_character":4,"end_line":889,"end_character":16},"updated":"2018-06-14 13:35:27.000000000","message":"nit: It can be:\n\ndefault\u003dutils.env(\u0027OS_TRUSTED_IMAGE_CERTIFICATE_IDS\u0027)","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"8045d128d2694a53079d2c427e417fd6490b0f70","unresolved":false,"context_lines":[{"line_number":886,"context_line":"    \u0027--trusted-image-certificate-ids\u0027,"},{"line_number":887,"context_line":"    metavar\u003d\u0027\u003ctrusted-image-certificate-ids\u003e\u0027,"},{"line_number":888,"context_line":"    dest\u003d\u0027trusted_image_certificates\u0027,"},{"line_number":889,"context_line":"    default\u003dNone,"},{"line_number":890,"context_line":"    help\u003d_(\u0027Trusted image certificate IDs used to validate certificates \u0027"},{"line_number":891,"context_line":"           \u0027during the image signature verification process. \u0027"},{"line_number":892,"context_line":"           \u0027Defaults to env[OS_TRUSTED_IMAGE_CERTIFICATE_IDS]. \u0027"}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_24d9bc55","line":889,"range":{"start_line":889,"start_character":4,"end_line":889,"end_character":16},"in_reply_to":"5f7c97a3_9c1d92bf","updated":"2018-06-14 19:36:46.000000000","message":"Done","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"10798745abcaf83b27009a94457232d329b56276","unresolved":false,"context_lines":[{"line_number":1830,"context_line":"    \u0027--trusted-image-certificate-ids\u0027,"},{"line_number":1831,"context_line":"    metavar\u003d\u0027\u003ctrusted-image-certificate-ids\u003e\u0027,"},{"line_number":1832,"context_line":"    dest\u003d\u0027trusted_image_certificates\u0027,"},{"line_number":1833,"context_line":"    default\u003dNone,"},{"line_number":1834,"context_line":"    help\u003d_(\u0027Trusted image certificate IDs used to validate certificates \u0027"},{"line_number":1835,"context_line":"           \u0027during the image signature verification process. \u0027"},{"line_number":1836,"context_line":"           \u0027Defaults to env[OS_TRUSTED_IMAGE_CERTIFICATE_IDS]. \u0027"}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_9c73524e","line":1833,"range":{"start_line":1833,"start_character":12,"end_line":1833,"end_character":16},"updated":"2018-06-14 13:35:27.000000000","message":"ditto","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"8045d128d2694a53079d2c427e417fd6490b0f70","unresolved":false,"context_lines":[{"line_number":1830,"context_line":"    \u0027--trusted-image-certificate-ids\u0027,"},{"line_number":1831,"context_line":"    metavar\u003d\u0027\u003ctrusted-image-certificate-ids\u003e\u0027,"},{"line_number":1832,"context_line":"    dest\u003d\u0027trusted_image_certificates\u0027,"},{"line_number":1833,"context_line":"    default\u003dNone,"},{"line_number":1834,"context_line":"    help\u003d_(\u0027Trusted image certificate IDs used to validate certificates \u0027"},{"line_number":1835,"context_line":"           \u0027during the image signature verification process. \u0027"},{"line_number":1836,"context_line":"           \u0027Defaults to env[OS_TRUSTED_IMAGE_CERTIFICATE_IDS]. \u0027"}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_44de383f","line":1833,"range":{"start_line":1833,"start_character":12,"end_line":1833,"end_character":16},"in_reply_to":"5f7c97a3_9c73524e","updated":"2018-06-14 19:36:46.000000000","message":"Done","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"10798745abcaf83b27009a94457232d329b56276","unresolved":false,"context_lines":[{"line_number":1853,"context_line":"    if \u0027description\u0027 in args:"},{"line_number":1854,"context_line":"        kwargs[\u0027description\u0027] \u003d args.description"},{"line_number":1855,"context_line":""},{"line_number":1856,"context_line":"    if \u0027trusted_image_certificates\u0027 in args and \\"},{"line_number":1857,"context_line":"            args.trusted_image_certificates:"},{"line_number":1858,"context_line":"        kwargs[\u0027trusted_image_certificates\u0027] \u003d \\"},{"line_number":1859,"context_line":"            args.trusted_image_certificates.split(\u0027,\u0027)"}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_3cb55eed","line":1856,"range":{"start_line":1856,"start_character":48,"end_line":1856,"end_character":49},"updated":"2018-06-14 13:35:27.000000000","message":"ditto","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"8045d128d2694a53079d2c427e417fd6490b0f70","unresolved":false,"context_lines":[{"line_number":1853,"context_line":"    if \u0027description\u0027 in args:"},{"line_number":1854,"context_line":"        kwargs[\u0027description\u0027] \u003d args.description"},{"line_number":1855,"context_line":""},{"line_number":1856,"context_line":"    if \u0027trusted_image_certificates\u0027 in args and \\"},{"line_number":1857,"context_line":"            args.trusted_image_certificates:"},{"line_number":1858,"context_line":"        kwargs[\u0027trusted_image_certificates\u0027] \u003d \\"},{"line_number":1859,"context_line":"            args.trusted_image_certificates.split(\u0027,\u0027)"}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_84bd30d9","line":1856,"range":{"start_line":1856,"start_character":48,"end_line":1856,"end_character":49},"in_reply_to":"5f7c97a3_3cb55eed","updated":"2018-06-14 19:36:46.000000000","message":"Done","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"10798745abcaf83b27009a94457232d329b56276","unresolved":false,"context_lines":[{"line_number":1855,"context_line":""},{"line_number":1856,"context_line":"    if \u0027trusted_image_certificates\u0027 in args and \\"},{"line_number":1857,"context_line":"            args.trusted_image_certificates:"},{"line_number":1858,"context_line":"        kwargs[\u0027trusted_image_certificates\u0027] \u003d \\"},{"line_number":1859,"context_line":"            args.trusted_image_certificates.split(\u0027,\u0027)"},{"line_number":1860,"context_line":"    elif utils.env(\u0027OS_TRUSTED_IMAGE_CERTIFICATE_IDS\u0027):"},{"line_number":1861,"context_line":"        kwargs[\u0027trusted_image_certificates\u0027] \u003d utils.env("}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_dccf8a7c","line":1858,"range":{"start_line":1858,"start_character":47,"end_line":1858,"end_character":48},"updated":"2018-06-14 13:35:27.000000000","message":"ditto","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"8045d128d2694a53079d2c427e417fd6490b0f70","unresolved":false,"context_lines":[{"line_number":1855,"context_line":""},{"line_number":1856,"context_line":"    if \u0027trusted_image_certificates\u0027 in args and \\"},{"line_number":1857,"context_line":"            args.trusted_image_certificates:"},{"line_number":1858,"context_line":"        kwargs[\u0027trusted_image_certificates\u0027] \u003d \\"},{"line_number":1859,"context_line":"            args.trusted_image_certificates.split(\u0027,\u0027)"},{"line_number":1860,"context_line":"    elif utils.env(\u0027OS_TRUSTED_IMAGE_CERTIFICATE_IDS\u0027):"},{"line_number":1861,"context_line":"        kwargs[\u0027trusted_image_certificates\u0027] \u003d utils.env("}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_24b21c08","line":1858,"range":{"start_line":1858,"start_character":47,"end_line":1858,"end_character":48},"in_reply_to":"5f7c97a3_dccf8a7c","updated":"2018-06-14 19:36:46.000000000","message":"Done","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"58f942523262dbcecfeeb58c37a37c5b3d20a0d3","unresolved":false,"context_lines":[{"line_number":739,"context_line":"           \"and format it to \u003cformat\u003e.\"))"},{"line_number":740,"context_line":"@utils.arg("},{"line_number":741,"context_line":"    \u0027--hint\u0027,"},{"line_number":742,"context_line":"    action\u003d\u0027append\u0027,"},{"line_number":743,"context_line":"    dest\u003d\u0027scheduler_hints\u0027,"},{"line_number":744,"context_line":"    default\u003d[],"},{"line_number":745,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_3e0b08d6","line":742,"range":{"start_line":742,"start_character":4,"end_line":742,"end_character":20},"updated":"2018-06-14 22:15:51.000000000","message":"and","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"58f942523262dbcecfeeb58c37a37c5b3d20a0d3","unresolved":false,"context_lines":[{"line_number":812,"context_line":"    metavar\u003d\"\u003cauto,none,\""},{"line_number":813,"context_line":"            \"net-id\u003dnet-uuid,net-name\u003dnetwork-name,port-id\u003dport-uuid,\""},{"line_number":814,"context_line":"            \"v4-fixed-ip\u003dip-addr,v6-fixed-ip\u003dip-addr,tag\u003dtag\u003e\","},{"line_number":815,"context_line":"    action\u003d\u0027append\u0027,"},{"line_number":816,"context_line":"    dest\u003d\u0027nics\u0027,"},{"line_number":817,"context_line":"    default\u003d[],"},{"line_number":818,"context_line":"    start_version\u003d\u00272.42\u0027,"}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_9e06dccd","line":815,"range":{"start_line":815,"start_character":4,"end_line":815,"end_character":20},"updated":"2018-06-14 22:15:51.000000000","message":"see","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8e5b4fdf9fd9827fed7f1555a15c43b57a329f28","unresolved":false,"context_lines":[{"line_number":883,"context_line":"    default\u003dFalse,"},{"line_number":884,"context_line":"    help\u003d_(\"Return a reservation id bound to created servers.\"))"},{"line_number":885,"context_line":"@utils.arg("},{"line_number":886,"context_line":"    \u0027--trusted-image-certificate-ids\u0027,"},{"line_number":887,"context_line":"    metavar\u003d\u0027\u003ctrusted-image-certificate-ids\u003e\u0027,"},{"line_number":888,"context_line":"    dest\u003d\u0027trusted_image_certificates\u0027,"},{"line_number":889,"context_line":"    default\u003dutils.env(\u0027OS_TRUSTED_IMAGE_CERTIFICATE_IDS\u0027),"}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_1ef2cce4","line":886,"updated":"2018-06-14 22:16:50.000000000","message":"Please add this to the nova boot CLI reference too please:\n\nhttps://github.com/openstack/python-novaclient/blob/master/doc/source/cli/nova.rst#nova-boot","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb7b44e654936c36ed8bd92536917b62c316003f","unresolved":false,"context_lines":[{"line_number":883,"context_line":"    default\u003dFalse,"},{"line_number":884,"context_line":"    help\u003d_(\"Return a reservation id bound to created servers.\"))"},{"line_number":885,"context_line":"@utils.arg("},{"line_number":886,"context_line":"    \u0027--trusted-image-certificate-ids\u0027,"},{"line_number":887,"context_line":"    metavar\u003d\u0027\u003ctrusted-image-certificate-ids\u003e\u0027,"},{"line_number":888,"context_line":"    dest\u003d\u0027trusted_image_certificates\u0027,"},{"line_number":889,"context_line":"    default\u003dutils.env(\u0027OS_TRUSTED_IMAGE_CERTIFICATE_IDS\u0027),"}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_b8c87f21","line":886,"in_reply_to":"5f7c97a3_1ef2cce4","updated":"2018-06-15 13:41:11.000000000","message":"Done","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"58f942523262dbcecfeeb58c37a37c5b3d20a0d3","unresolved":false,"context_lines":[{"line_number":890,"context_line":"    help\u003d_(\u0027Trusted image certificate IDs used to validate certificates \u0027"},{"line_number":891,"context_line":"           \u0027during the image signature verification process. \u0027"},{"line_number":892,"context_line":"           \u0027Defaults to env[OS_TRUSTED_IMAGE_CERTIFICATE_IDS]. \u0027"},{"line_number":893,"context_line":"           \u0027IDs must be separated by commas: \u0027"},{"line_number":894,"context_line":"           \u0027--trusted-image-certificate-ids \u003cid1,id2\u003e\u0027),"},{"line_number":895,"context_line":"    start_version\u003d\"2.63\")"},{"line_number":896,"context_line":"def do_boot(cs, args):"}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_5e104401","line":893,"range":{"start_line":893,"start_character":12,"end_line":893,"end_character":43},"updated":"2018-06-14 22:15:51.000000000","message":"Rather than do this, can we be consistent with what\u0027s proposed in OSC and used for other list type args in nova boot like --block-device and use action\u003d\u0027append\u0027?\n\nhttps://review.openstack.org/#/c/501926/5/openstackclient/compute/v2/server.py","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb7b44e654936c36ed8bd92536917b62c316003f","unresolved":false,"context_lines":[{"line_number":890,"context_line":"    help\u003d_(\u0027Trusted image certificate IDs used to validate certificates \u0027"},{"line_number":891,"context_line":"           \u0027during the image signature verification process. \u0027"},{"line_number":892,"context_line":"           \u0027Defaults to env[OS_TRUSTED_IMAGE_CERTIFICATE_IDS]. \u0027"},{"line_number":893,"context_line":"           \u0027IDs must be separated by commas: \u0027"},{"line_number":894,"context_line":"           \u0027--trusted-image-certificate-ids \u003cid1,id2\u003e\u0027),"},{"line_number":895,"context_line":"    start_version\u003d\"2.63\")"},{"line_number":896,"context_line":"def do_boot(cs, args):"}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_58cdab2e","line":893,"range":{"start_line":893,"start_character":12,"end_line":893,"end_character":43},"in_reply_to":"5f7c97a3_5e104401","updated":"2018-06-15 13:41:11.000000000","message":"Done","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22060cbc359627c79e942809f4af9141e3a46ff6","unresolved":false,"context_lines":[{"line_number":1827,"context_line":"           \"\u0027--user-data\u0027 option.\"),"},{"line_number":1828,"context_line":"    start_version\u003d\u00272.57\u0027)"},{"line_number":1829,"context_line":"@utils.arg("},{"line_number":1830,"context_line":"    \u0027--trusted-image-certificate-ids\u0027,"},{"line_number":1831,"context_line":"    metavar\u003d\u0027\u003ctrusted-image-certificate-ids\u003e\u0027,"},{"line_number":1832,"context_line":"    dest\u003d\u0027trusted_image_certificates\u0027,"},{"line_number":1833,"context_line":"    default\u003dutils.env(\u0027OS_TRUSTED_IMAGE_CERTIFICATE_IDS\u0027),"}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_fdd34900","line":1830,"range":{"start_line":1830,"start_character":33,"end_line":1830,"end_character":36},"updated":"2018-06-15 12:50:33.000000000","message":"same as above","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb7b44e654936c36ed8bd92536917b62c316003f","unresolved":false,"context_lines":[{"line_number":1827,"context_line":"           \"\u0027--user-data\u0027 option.\"),"},{"line_number":1828,"context_line":"    start_version\u003d\u00272.57\u0027)"},{"line_number":1829,"context_line":"@utils.arg("},{"line_number":1830,"context_line":"    \u0027--trusted-image-certificate-ids\u0027,"},{"line_number":1831,"context_line":"    metavar\u003d\u0027\u003ctrusted-image-certificate-ids\u003e\u0027,"},{"line_number":1832,"context_line":"    dest\u003d\u0027trusted_image_certificates\u0027,"},{"line_number":1833,"context_line":"    default\u003dutils.env(\u0027OS_TRUSTED_IMAGE_CERTIFICATE_IDS\u0027),"}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_78d2e7d3","line":1830,"range":{"start_line":1830,"start_character":33,"end_line":1830,"end_character":36},"in_reply_to":"5f7c97a3_fdd34900","updated":"2018-06-15 13:41:11.000000000","message":"Done","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ec2e92a205b7a4b2eb39f16e81e28694f4e281b8","unresolved":false,"context_lines":[{"line_number":1830,"context_line":"    \u0027--trusted-image-certificate-ids\u0027,"},{"line_number":1831,"context_line":"    metavar\u003d\u0027\u003ctrusted-image-certificate-ids\u003e\u0027,"},{"line_number":1832,"context_line":"    dest\u003d\u0027trusted_image_certificates\u0027,"},{"line_number":1833,"context_line":"    default\u003dutils.env(\u0027OS_TRUSTED_IMAGE_CERTIFICATE_IDS\u0027),"},{"line_number":1834,"context_line":"    help\u003d_(\u0027Trusted image certificate IDs used to validate certificates \u0027"},{"line_number":1835,"context_line":"           \u0027during the image signature verification process. \u0027"},{"line_number":1836,"context_line":"           \u0027Defaults to env[OS_TRUSTED_IMAGE_CERTIFICATE_IDS]. \u0027"}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_3d078120","line":1833,"range":{"start_line":1833,"start_character":4,"end_line":1833,"end_character":58},"updated":"2018-06-15 13:08:24.000000000","message":"Hmm, if this defaults to None, then couldn\u0027t that be confused with intentionally passing None to unset/reset the trusted certs while rebuilding?","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb7b44e654936c36ed8bd92536917b62c316003f","unresolved":false,"context_lines":[{"line_number":1830,"context_line":"    \u0027--trusted-image-certificate-ids\u0027,"},{"line_number":1831,"context_line":"    metavar\u003d\u0027\u003ctrusted-image-certificate-ids\u003e\u0027,"},{"line_number":1832,"context_line":"    dest\u003d\u0027trusted_image_certificates\u0027,"},{"line_number":1833,"context_line":"    default\u003dutils.env(\u0027OS_TRUSTED_IMAGE_CERTIFICATE_IDS\u0027),"},{"line_number":1834,"context_line":"    help\u003d_(\u0027Trusted image certificate IDs used to validate certificates \u0027"},{"line_number":1835,"context_line":"           \u0027during the image signature verification process. \u0027"},{"line_number":1836,"context_line":"           \u0027Defaults to env[OS_TRUSTED_IMAGE_CERTIFICATE_IDS]. \u0027"}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_18d733c3","line":1833,"range":{"start_line":1833,"start_character":4,"end_line":1833,"end_character":58},"in_reply_to":"5f7c97a3_3d078120","updated":"2018-06-15 13:41:11.000000000","message":"Done","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"291259a700eb90d713d8b26466a181e453d7cfd3","unresolved":false,"context_lines":[{"line_number":1853,"context_line":"    if \u0027description\u0027 in args:"},{"line_number":1854,"context_line":"        kwargs[\u0027description\u0027] \u003d args.description"},{"line_number":1855,"context_line":""},{"line_number":1856,"context_line":"    if (\u0027trusted_image_certificates\u0027 in args and"},{"line_number":1857,"context_line":"            args.trusted_image_certificates):"},{"line_number":1858,"context_line":"        kwargs[\u0027trusted_image_certificates\u0027] \u003d ("},{"line_number":1859,"context_line":"            args.trusted_image_certificates.split(\u0027,\u0027))"},{"line_number":1860,"context_line":"    elif utils.env(\u0027OS_TRUSTED_IMAGE_CERTIFICATE_IDS\u0027):"},{"line_number":1861,"context_line":"        kwargs[\u0027trusted_image_certificates\u0027] \u003d utils.env("},{"line_number":1862,"context_line":"            \u0027OS_TRUSTED_IMAGE_CERTIFICATE_IDS\u0027).split(\u0027,\u0027)"},{"line_number":1863,"context_line":""},{"line_number":1864,"context_line":"    # 2.57 deprecates the --file option and adds the --user-data and"},{"line_number":1865,"context_line":"    # --user-data-unset options."}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_581e0b60","line":1862,"range":{"start_line":1856,"start_character":4,"end_line":1862,"end_character":58},"updated":"2018-06-15 13:09:31.000000000","message":"Hmm, this won\u0027t allow me to unset/reset via the shell...\n\nWe need something like --key-unset.","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb7b44e654936c36ed8bd92536917b62c316003f","unresolved":false,"context_lines":[{"line_number":1853,"context_line":"    if \u0027description\u0027 in args:"},{"line_number":1854,"context_line":"        kwargs[\u0027description\u0027] \u003d args.description"},{"line_number":1855,"context_line":""},{"line_number":1856,"context_line":"    if (\u0027trusted_image_certificates\u0027 in args and"},{"line_number":1857,"context_line":"            args.trusted_image_certificates):"},{"line_number":1858,"context_line":"        kwargs[\u0027trusted_image_certificates\u0027] \u003d ("},{"line_number":1859,"context_line":"            args.trusted_image_certificates.split(\u0027,\u0027))"},{"line_number":1860,"context_line":"    elif utils.env(\u0027OS_TRUSTED_IMAGE_CERTIFICATE_IDS\u0027):"},{"line_number":1861,"context_line":"        kwargs[\u0027trusted_image_certificates\u0027] \u003d utils.env("},{"line_number":1862,"context_line":"            \u0027OS_TRUSTED_IMAGE_CERTIFICATE_IDS\u0027).split(\u0027,\u0027)"},{"line_number":1863,"context_line":""},{"line_number":1864,"context_line":"    # 2.57 deprecates the --file option and adds the --user-data and"},{"line_number":1865,"context_line":"    # --user-data-unset options."}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_38d46fbb","line":1862,"range":{"start_line":1856,"start_character":4,"end_line":1862,"end_character":58},"in_reply_to":"5f7c97a3_581e0b60","updated":"2018-06-15 13:41:11.000000000","message":"Done","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0c514551cfcffdb2fdf103d45691e31d40d9e6d9","unresolved":false,"context_lines":[{"line_number":1917,"context_line":"            if trusted_image_certificates:"},{"line_number":1918,"context_line":"                raise exceptions.CommandError("},{"line_number":1919,"context_line":"                    _(\"Cannot specify \u0027--trusted-image-certificates-unset\u0027 \""},{"line_number":1920,"context_line":"                      \"with \u0027--trusted-image-certificate-id\u0027.\"))"},{"line_number":1921,"context_line":"        elif trusted_image_certificates:"},{"line_number":1922,"context_line":"            # Only specify the kwarg if there is a value specified to avoid"},{"line_number":1923,"context_line":"            # confusion with unsetting the value."}],"source_content_type":"text/x-python","patch_set":49,"id":"5f7c97a3_8ce304d9","line":1920,"range":{"start_line":1920,"start_character":22,"end_line":1920,"end_character":62},"updated":"2018-06-15 14:29:10.000000000","message":"This could be misleading as the user might not specified --trusted-image-certificate-id but has the OS_TRUSTED_IMAGE_CERTIFICATE_IDS set in her environment. So I suggest to say \"Cannot specify \u0027--trusted-image-certificates-unset\u0027 with \u0027--trusted-image-certificate-id\u0027 or with OS_TRUSTED_IMAGE_CERTIFICATE_IDS env variable set.\"","commit_id":"5a198aa0d6488e2c340a82453fabb0cd1f309aed"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0ba9e9d743cc5f3b4a4c0f2776e5806467c0b1a2","unresolved":false,"context_lines":[{"line_number":1917,"context_line":"            if trusted_image_certificates:"},{"line_number":1918,"context_line":"                raise exceptions.CommandError("},{"line_number":1919,"context_line":"                    _(\"Cannot specify \u0027--trusted-image-certificates-unset\u0027 \""},{"line_number":1920,"context_line":"                      \"with \u0027--trusted-image-certificate-id\u0027.\"))"},{"line_number":1921,"context_line":"        elif trusted_image_certificates:"},{"line_number":1922,"context_line":"            # Only specify the kwarg if there is a value specified to avoid"},{"line_number":1923,"context_line":"            # confusion with unsetting the value."}],"source_content_type":"text/x-python","patch_set":49,"id":"5f7c97a3_cf9d6e6d","line":1920,"range":{"start_line":1920,"start_character":22,"end_line":1920,"end_character":62},"in_reply_to":"5f7c97a3_8ce304d9","updated":"2018-06-15 14:44:29.000000000","message":"Done","commit_id":"5a198aa0d6488e2c340a82453fabb0cd1f309aed"}],"releasenotes/notes/microversion-v2_62-cd058a9145550cae.yaml":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"4e2adc4e389be145b9df231d098938e6cfe392e6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        - ``novaclient.v2.servers.ServerManager.create()``"},{"line_number":13,"context_line":"        - ``novaclient.v2.servers.ServerManager.rebuild()``"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    .. _microversion 2.62: https://docs.openstack.org/nova/latest/api_microversion_history.html#id56"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"9f6a8fd7_be602103","line":15,"range":{"start_line":15,"start_character":96,"end_line":15,"end_character":100},"updated":"2018-04-19 02:51:49.000000000","message":"id55\n\nhttp://logs.openstack.org/04/486204/93/check/build-openstack-sphinx-docs/7929cef/html/reference/api-microversion-history.html#id55","commit_id":"eb74e82c18cfa9f24fe4abfc29a5240b57791b1e"}],"releasenotes/notes/microversion-v2_63-cd058a9145550cae.yaml":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"10798745abcaf83b27009a94457232d329b56276","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        - ``novaclient.v2.servers.ServerManager.create()``"},{"line_number":13,"context_line":"        - ``novaclient.v2.servers.ServerManager.rebuild()``"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    .. _microversion 2.63: https://docs.openstack.org/nova/latest/api_microversion_history.html#id56"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"5f7c97a3_01791b2d","line":15,"range":{"start_line":15,"start_character":27,"end_line":15,"end_character":100},"updated":"2018-06-14 13:35:27.000000000","message":"https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id57","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"8045d128d2694a53079d2c427e417fd6490b0f70","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        - ``novaclient.v2.servers.ServerManager.create()``"},{"line_number":13,"context_line":"        - ``novaclient.v2.servers.ServerManager.rebuild()``"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    .. _microversion 2.63: https://docs.openstack.org/nova/latest/api_microversion_history.html#id56"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"5f7c97a3_c4c24854","line":15,"range":{"start_line":15,"start_character":27,"end_line":15,"end_character":100},"in_reply_to":"5f7c97a3_01791b2d","updated":"2018-06-14 19:36:46.000000000","message":"Done","commit_id":"9ca9ff33572e0be5213730df0dd0804841530e3f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22060cbc359627c79e942809f4af9141e3a46ff6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    changes:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    - New environment variable called ``OS_TRUSTED_IMAGE_CERTIFICATE_IDS``"},{"line_number":8,"context_line":"    - New ``nova boot`` option called ``--trusted-image-certificate-ids``"},{"line_number":9,"context_line":"    - New kwarg called ``trusted_image_certificates`` added to python API"},{"line_number":10,"context_line":"      bindings:"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":47,"id":"5f7c97a3_1df64592","line":8,"range":{"start_line":8,"start_character":68,"end_line":8,"end_character":71},"updated":"2018-06-15 12:50:33.000000000","message":"id\n\nand nova rebuild","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cb7b44e654936c36ed8bd92536917b62c316003f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    changes:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    - New environment variable called ``OS_TRUSTED_IMAGE_CERTIFICATE_IDS``"},{"line_number":8,"context_line":"    - New ``nova boot`` option called ``--trusted-image-certificate-ids``"},{"line_number":9,"context_line":"    - New kwarg called ``trusted_image_certificates`` added to python API"},{"line_number":10,"context_line":"      bindings:"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":47,"id":"5f7c97a3_d8e0db9a","line":8,"range":{"start_line":8,"start_character":68,"end_line":8,"end_character":71},"in_reply_to":"5f7c97a3_1df64592","updated":"2018-06-15 13:41:11.000000000","message":"Done","commit_id":"392490842816ccc31d75ddbcd7e7ba965ffa276e"}]}