)]}'
{"novaclient/v1_1/shell.py":[{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"6f57bb4c78fd250a844bd642541333466d52a0b2","unresolved":false,"context_lines":[{"line_number":2686,"context_line":"def _print_aggregate_details(aggregate):"},{"line_number":2687,"context_line":"    columns \u003d [\u0027Id\u0027, \u0027Name\u0027, \u0027Availability Zone\u0027, \u0027Hosts\u0027, \u0027Metadata\u0027]"},{"line_number":2688,"context_line":""},{"line_number":2689,"context_line":"    parser_metadata \u003d lambda o: \\"},{"line_number":2690,"context_line":"        utils.pretty_choice_dict(getattr(o, \u0027metadata\u0027, {}) or {})"},{"line_number":2691,"context_line":"    parser_availability_zone \u003d lambda o: \\"},{"line_number":2692,"context_line":"        utils.pretty_choice_list(getattr(o, \u0027availability_zone\u0027, []))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2F1Ao%3D","line":2689,"updated":"2013-10-09 09:49:45.000000000","message":"nit: please do not using \\ to start newline, thanks.","commit_id":"579cab3c4e0a2d0202bfd92f20c7902f06fb905f"},{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"49ae49f35c365c0783bbc2453ccc0fe611714dc5","unresolved":false,"context_lines":[{"line_number":2686,"context_line":"def _print_aggregate_details(aggregate):"},{"line_number":2687,"context_line":"    columns \u003d [\u0027Id\u0027, \u0027Name\u0027, \u0027Availability Zone\u0027, \u0027Hosts\u0027, \u0027Metadata\u0027]"},{"line_number":2688,"context_line":""},{"line_number":2689,"context_line":"    parser_metadata \u003d lambda o: \\"},{"line_number":2690,"context_line":"        utils.pretty_choice_dict(getattr(o, \u0027metadata\u0027, {}) or {})"},{"line_number":2691,"context_line":"    parser_availability_zone \u003d lambda o: \\"},{"line_number":2692,"context_line":"        utils.pretty_choice_list(getattr(o, \u0027availability_zone\u0027, []))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2F07M%3D","line":2689,"in_reply_to":"AAAATH%2F%2F0%2FE%3D","updated":"2013-10-09 10:20:39.000000000","message":"well, you can do it like \n\n    parser_hosts_1 \u003d lambda o: utils.pretty_choice_list(\n                        getattr(o, \u0027hosts\u0027, []))\n\nor\n\n    ld \u003d lambda o: utils.pretty_choice_list(getattr(o, \u0027hosts\u0027, []))\n    parser_hosts \u003d ld","commit_id":"579cab3c4e0a2d0202bfd92f20c7902f06fb905f"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"555920244203285bdbe1e9bb80b8598c2273aab1","unresolved":false,"context_lines":[{"line_number":2686,"context_line":"def _print_aggregate_details(aggregate):"},{"line_number":2687,"context_line":"    columns \u003d [\u0027Id\u0027, \u0027Name\u0027, \u0027Availability Zone\u0027, \u0027Hosts\u0027, \u0027Metadata\u0027]"},{"line_number":2688,"context_line":""},{"line_number":2689,"context_line":"    parser_metadata \u003d lambda o: \\"},{"line_number":2690,"context_line":"        utils.pretty_choice_dict(getattr(o, \u0027metadata\u0027, {}) or {})"},{"line_number":2691,"context_line":"    parser_availability_zone \u003d lambda o: \\"},{"line_number":2692,"context_line":"        utils.pretty_choice_list(getattr(o, \u0027availability_zone\u0027, []))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2F0%2FE%3D","line":2689,"in_reply_to":"AAAATH%2F%2F1Ao%3D","updated":"2013-10-09 09:59:10.000000000","message":"Yep np, How i can do that?","commit_id":"579cab3c4e0a2d0202bfd92f20c7902f06fb905f"},{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"a4806c3d4663b4b2ae3358f5cc75833de92c8d13","unresolved":false,"context_lines":[{"line_number":2688,"context_line":""},{"line_number":2689,"context_line":"    parser_metadata \u003d lambda o: utils.pretty_choice_dict("},{"line_number":2690,"context_line":"        getattr(o, \u0027metadata\u0027, {}) or {})"},{"line_number":2691,"context_line":"    parser_availability_zone \u003d lambda o: utils.pretty_choice_list("},{"line_number":2692,"context_line":"        getattr(o, \u0027availability_zone\u0027, []))"},{"line_number":2693,"context_line":"    parser_hosts \u003d lambda o: utils.pretty_choice_list("},{"line_number":2694,"context_line":"        getattr(o, \u0027hosts\u0027, []))"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2F0rM%3D","line":2691,"updated":"2013-10-09 11:31:47.000000000","message":"There can only be one AZ value per aggregate, so why try and pares this as a list ? \nIn fact this breaks an aggregate not defined as an AZ","commit_id":"721915870f73c3db1ebcb17ca805c33c7556bdf3"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"9657412a74bf7f7c82c850c654e6847686ce9374","unresolved":false,"context_lines":[{"line_number":2688,"context_line":""},{"line_number":2689,"context_line":"    parser_metadata \u003d lambda o: utils.pretty_choice_dict("},{"line_number":2690,"context_line":"        getattr(o, \u0027metadata\u0027, {}) or {})"},{"line_number":2691,"context_line":"    parser_availability_zone \u003d lambda o: utils.pretty_choice_list("},{"line_number":2692,"context_line":"        getattr(o, \u0027availability_zone\u0027, []))"},{"line_number":2693,"context_line":"    parser_hosts \u003d lambda o: utils.pretty_choice_list("},{"line_number":2694,"context_line":"        getattr(o, \u0027hosts\u0027, []))"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2F0bI%3D","line":2691,"in_reply_to":"AAAATH%2F%2F0rM%3D","updated":"2013-10-09 12:46:06.000000000","message":"Interesting, thanks for the time you pass on my work, I\u0027m going to work on that.","commit_id":"721915870f73c3db1ebcb17ca805c33c7556bdf3"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"cdc74a7a6ad621bd4b1c35fef14928dff787dd16","unresolved":false,"context_lines":[{"line_number":2695,"context_line":""},{"line_number":2696,"context_line":"    formatters \u003d {"},{"line_number":2697,"context_line":"        \u0027Metadata\u0027: parser_metadata,"},{"line_number":2698,"context_line":"        \u0027Hosts\u0027: parser_hosts}"},{"line_number":2699,"context_line":"    utils.print_list([aggregate], columns, formatters\u003dformatters)"},{"line_number":2700,"context_line":""},{"line_number":2701,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2F88o%3D","line":2698,"updated":"2013-10-24 17:27:11.000000000","message":"femtonit: I\u0027d like this formatted as:\n\n    formatters \u003d {\n        \u0027Metadata\u0027: parser_metadata,\n        \u0027Hosts\u0027: parser_hosts,\n    }\n\n(Note the \u0027,\u0027 at the end of the \u0027Hosts\u0027 line and the \u0027}\u0027 on a line by itself)","commit_id":"a0825953a8570e8797b71d8f6fa3b777e742be6a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"25590c903e4ddf9cdf1fbc08a949b47237f13948","unresolved":false,"context_lines":[{"line_number":2695,"context_line":""},{"line_number":2696,"context_line":"    formatters \u003d {"},{"line_number":2697,"context_line":"        \u0027Metadata\u0027: parser_metadata,"},{"line_number":2698,"context_line":"        \u0027Hosts\u0027: parser_hosts}"},{"line_number":2699,"context_line":"    utils.print_list([aggregate], columns, formatters\u003dformatters)"},{"line_number":2700,"context_line":""},{"line_number":2701,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2F6s8%3D","line":2698,"in_reply_to":"AAAATn%2F%2F88o%3D","updated":"2013-10-25 09:00:20.000000000","message":"Ok Kevin, I\u0027m working on that.","commit_id":"a0825953a8570e8797b71d8f6fa3b777e742be6a"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"459617fe522eb9a6d5bf1a859c456509b0e73a46","unresolved":false,"context_lines":[{"line_number":2695,"context_line":""},{"line_number":2696,"context_line":"    formatters \u003d {"},{"line_number":2697,"context_line":"        \u0027Metadata\u0027: parser_metadata,"},{"line_number":2698,"context_line":"        \u0027Hosts\u0027: parser_hosts,"},{"line_number":2699,"context_line":"    }"},{"line_number":2700,"context_line":"    utils.print_list([aggregate], columns, formatters\u003dformatters)"},{"line_number":2701,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2F5Ok%3D","line":2698,"updated":"2013-10-25 15:34:07.000000000","message":"Thanks, but I\u0027ll point out you left it alone in v3/shell.py :)  Reviewers will often only point out the first instance of a nit, and expect you to know to update the other instances…","commit_id":"3afb85b73bdfe6bbdca6bbe3320c637c045b2f56"}],"novaclient/v3/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e006b30cba1803a911963abf8c7cd4f3c3dc22ea","unresolved":false,"context_lines":[{"line_number":2521,"context_line":"        getattr(o, \u0027metadata\u0027, {}) or {})"},{"line_number":2522,"context_line":"    parser_hosts \u003d lambda o: utils.pretty_choice_list("},{"line_number":2523,"context_line":"        getattr(o, \u0027hosts\u0027, []))"},{"line_number":2524,"context_line":"    "},{"line_number":2525,"context_line":"    formatters \u003d {"},{"line_number":2526,"context_line":"        \u0027Metadata\u0027: parser_metadata,"},{"line_number":2527,"context_line":"        \u0027Hosts\u0027: parser_hosts,"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2F5LQ%3D","line":2524,"updated":"2013-10-25 15:44:08.000000000","message":"There\u0027s trailing space on this line, which will break PEP8…","commit_id":"265f3ff8956e4dfd89e0ee129ea72cc32891f894"}]}
