)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"79ddb7a62d2dc14e9a2adaa5b597f6b171307c8f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-11-16 15:40:53 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Microversion 2.54 - Enable reset keypair while rebuild"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie2a39bb29dd59c070adc94e79ea0f6473227a427"},{"line_number":10,"context_line":"Implements: blueprint rebuild-keypair-reset"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f485f77_46fb1978","line":8,"updated":"2017-11-17 05:09:50.000000000","message":"What about add some tips for this new command args?","commit_id":"640ef2564c0f38e3ee775e09a3446c3ecbeb769d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"b76cfbbd0a80588d698ae1f42e628c77ddf66784","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-11-16 15:40:53 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Microversion 2.54 - Enable reset keypair while rebuild"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie2a39bb29dd59c070adc94e79ea0f6473227a427"},{"line_number":10,"context_line":"Implements: blueprint rebuild-keypair-reset"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f485f77_41b0a343","line":8,"in_reply_to":"1f485f77_46fb1978","updated":"2017-11-17 05:46:07.000000000","message":"Done","commit_id":"640ef2564c0f38e3ee775e09a3446c3ecbeb769d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"79ddb7a62d2dc14e9a2adaa5b597f6b171307c8f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Microversion 2.54 - Enable reset keypair while rebuild"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie2a39bb29dd59c070adc94e79ea0f6473227a427"},{"line_number":10,"context_line":"Implements: blueprint rebuild-keypair-reset"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f485f77_66029571","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":10},"updated":"2017-11-17 05:09:50.000000000","message":"This should be ｀Partially-Implements｀.","commit_id":"640ef2564c0f38e3ee775e09a3446c3ecbeb769d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"b76cfbbd0a80588d698ae1f42e628c77ddf66784","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Microversion 2.54 - Enable reset keypair while rebuild"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie2a39bb29dd59c070adc94e79ea0f6473227a427"},{"line_number":10,"context_line":"Implements: blueprint rebuild-keypair-reset"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f485f77_61a71f0d","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":10},"in_reply_to":"1f485f77_66029571","updated":"2017-11-17 05:46:07.000000000","message":"\"Partially-Implements\" is sometimes used.\nBut it is not in Developer\u0027s Guide(*1). IMO, It is not official.\nSo keep it as it is.\n\n*1: https://docs.openstack.org/infra/manual/developers.html","commit_id":"640ef2564c0f38e3ee775e09a3446c3ecbeb769d"}],"novaclient/tests/unit/v2/test_servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"92a33a89140edf068860fe2d63d2448dd80f0ed7","unresolved":false,"context_lines":[{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"    def test_rebuild_with_key_name_pre_254_fails(self):"},{"line_number":1578,"context_line":"        self.cs.api_version \u003d api_versions.APIVersion(\u00272.53\u0027)"},{"line_number":1579,"context_line":"        self.assertRaises(exceptions.UnsupportedAttribute,"},{"line_number":1580,"context_line":"                          self.cs.servers.rebuild,"},{"line_number":1581,"context_line":"                          \u00271234\u0027, fakes.FAKE_IMAGE_UUID_1,"},{"line_number":1582,"context_line":"                          key_name\u003d\u0027test_keypair\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_a8e5250b","line":1579,"updated":"2017-11-15 22:48:53.000000000","message":"Let\u0027s make sure the failure is for the key_name attribute, so do something like:\n\nex \u003d self.assertRaises(exceptions.UnsupportedAttribute...)\nself.assertIn(\u0027key_name\u0027, six.text_type(ex))","commit_id":"5c1c0821149f9d5d821213ba4ef5fa0ccf36e484"}],"novaclient/v2/servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"92a33a89140edf068860fe2d63d2448dd80f0ed7","unresolved":false,"context_lines":[{"line_number":1500,"context_line":"                      and each file must be 10k or less."},{"line_number":1501,"context_line":"        :param description: optional description of the server (allowed since"},{"line_number":1502,"context_line":"                            microversion 2.19)"},{"line_number":1503,"context_line":"        :param key_name: optional key pair name for rebuild operation"},{"line_number":1504,"context_line":"                         (starting from microversion 2.54)"},{"line_number":1505,"context_line":"        :returns: :class:`Server`"},{"line_number":1506,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_68ebaddb","line":1503,"updated":"2017-11-15 22:48:53.000000000","message":"Should probably also note that passing None will unset the keypair for the instance.","commit_id":"5c1c0821149f9d5d821213ba4ef5fa0ccf36e484"}],"novaclient/v2/shell.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"92a33a89140edf068860fe2d63d2448dd80f0ed7","unresolved":false,"context_lines":[{"line_number":1791,"context_line":"    metavar\u003d\u0027\u003ckey-name\u003e\u0027,"},{"line_number":1792,"context_line":"    default\u003dNone,"},{"line_number":1793,"context_line":"    help\u003d_(\"Keypair name to set in the server. \""},{"line_number":1794,"context_line":"           \"If \u0027--key-unset\u0027 option is specified, \""},{"line_number":1795,"context_line":"           \"this option will be ignored.\"),"},{"line_number":1796,"context_line":"    start_version\u003d\u00272.54\u0027)"},{"line_number":1797,"context_line":"@utils.arg("},{"line_number":1798,"context_line":"    \u0027--key-unset\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_08a9d98e","line":1795,"range":{"start_line":1794,"start_character":11,"end_line":1795,"end_character":41},"updated":"2017-11-15 22:48:53.000000000","message":"I don\u0027t really like this behavior - how about we just fail if both are specified? The client should be explicit about what they want and not be surprised because they didn\u0027t read the help text.","commit_id":"5c1c0821149f9d5d821213ba4ef5fa0ccf36e484"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"92a33a89140edf068860fe2d63d2448dd80f0ed7","unresolved":false,"context_lines":[{"line_number":1837,"context_line":"    if cs.api_version \u003e\u003d api_versions.APIVersion(\u00272.54\u0027):"},{"line_number":1838,"context_line":"        if args.key_unset:"},{"line_number":1839,"context_line":"            kwargs[\u0027key_name\u0027] \u003d None"},{"line_number":1840,"context_line":"            if args.key_name:"},{"line_number":1841,"context_line":"                print(_(\"Warning: \u0027--key-name\u0027 is ignored.\"))"},{"line_number":1842,"context_line":"        elif args.key_name:"},{"line_number":1843,"context_line":"            kwargs[\u0027key_name\u0027] \u003d args.key_name"},{"line_number":1844,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_a87c051f","line":1841,"range":{"start_line":1840,"start_character":12,"end_line":1841,"end_character":61},"updated":"2017-11-15 22:48:53.000000000","message":"As noted above, I think we should just fail if both are specified. Let\u0027s not be ambiguous.","commit_id":"5c1c0821149f9d5d821213ba4ef5fa0ccf36e484"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"18f07fe35435e3b8494feac1806d0b4cc338d91c","unresolved":false,"context_lines":[{"line_number":1792,"context_line":"    default\u003dNone,"},{"line_number":1793,"context_line":"    help\u003d_(\"Keypair name to set in the server. \""},{"line_number":1794,"context_line":"           \"Cannot be specified with the \u0027--key-unset\u0027 option.\"),"},{"line_number":1795,"context_line":"    start_version\u003d\u00272.54\u0027)"},{"line_number":1796,"context_line":"@utils.arg("},{"line_number":1797,"context_line":"    \u0027--key-unset\u0027,"},{"line_number":1798,"context_line":"    action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_7d110904","line":1795,"range":{"start_line":1795,"start_character":4,"end_line":1795,"end_character":24},"updated":"2017-11-16 21:26:49.000000000","message":"Actually, what happens if you specify --key-name with --os-compute-api-version 2.1? Does it fail in a graceful way?","commit_id":"a7ddaaca873838e88124429cc22314712ea3f057"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"78b518b63e72a817f870b1f06424dcaf113f75f4","unresolved":false,"context_lines":[{"line_number":1792,"context_line":"    default\u003dNone,"},{"line_number":1793,"context_line":"    help\u003d_(\"Keypair name to set in the server. \""},{"line_number":1794,"context_line":"           \"Cannot be specified with the \u0027--key-unset\u0027 option.\"),"},{"line_number":1795,"context_line":"    start_version\u003d\u00272.54\u0027)"},{"line_number":1796,"context_line":"@utils.arg("},{"line_number":1797,"context_line":"    \u0027--key-unset\u0027,"},{"line_number":1798,"context_line":"    action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_03f87846","line":1795,"range":{"start_line":1795,"start_character":4,"end_line":1795,"end_character":24},"in_reply_to":"1f485f77_7d110904","updated":"2017-11-16 23:19:12.000000000","message":"This is what you get:\n\nstack@queens:~/python-novaclient$ nova --os-compute-api-version 2.1 rebuild fake-server fake-image --key-name wrong\nusage: nova [--version] [--debug] [--os-cache] [--timings]\n            [--os-region-name \u003cregion-name\u003e] [--service-type \u003cservice-type\u003e]\n            [--service-name \u003cservice-name\u003e]\n            [--os-endpoint-type \u003cendpoint-type\u003e]\n            [--os-compute-api-version \u003ccompute-api-ver\u003e]\n            [--endpoint-override \u003cbypass-url\u003e] [--profile HMAC_KEY]\n            [--insecure] [--os-cacert \u003cca-certificate\u003e]\n            [--os-cert \u003ccertificate\u003e] [--os-key \u003ckey\u003e] [--timeout \u003cseconds\u003e]\n            [--os-auth-type \u003cname\u003e] [--os-auth-url OS_AUTH_URL]\n            [--os-domain-id OS_DOMAIN_ID] [--os-domain-name OS_DOMAIN_NAME]\n            [--os-project-id OS_PROJECT_ID]\n            [--os-project-name OS_PROJECT_NAME]\n            [--os-project-domain-id OS_PROJECT_DOMAIN_ID]\n            [--os-project-domain-name OS_PROJECT_DOMAIN_NAME]\n            [--os-trust-id OS_TRUST_ID]\n            [--os-default-domain-id OS_DEFAULT_DOMAIN_ID]\n            [--os-default-domain-name OS_DEFAULT_DOMAIN_NAME]\n            [--os-user-id OS_USER_ID] [--os-username OS_USERNAME]\n            [--os-user-domain-id OS_USER_DOMAIN_ID]\n            [--os-user-domain-name OS_USER_DOMAIN_NAME]\n            [--os-password OS_PASSWORD]\n            \u003csubcommand\u003e ...\nerror: unrecognized arguments: --key-name wrong\nTry \u0027nova help \u0027 for more information.\n\n\nWhich is good enough.","commit_id":"a7ddaaca873838e88124429cc22314712ea3f057"}]}