)]}'
{"id":"openstack%2Fpython-novaclient~520666","triplet_id":"openstack%2Fpython-novaclient~master~I62188e73a48f6878ce920a3b4724dba101564aef","project":"openstack/python-novaclient","branch":"master","topic":"bug/1732744","hashtags":[],"change_id":"I62188e73a48f6878ce920a3b4724dba101564aef","subject":"Remove SecretsHelper","status":"MERGED","created":"2017-11-16 17:47:56.000000000","updated":"2017-11-16 20:26:43.000000000","submitted":"2017-11-16 20:26:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"520666-1510864003320-550f4d9b","meta_rev_id":"c8195a0b1ea1a954e6fca9e34e5469cda77d1d88","_number":520666,"virtual_id_number":520666,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":2,"date":"2017-11-16 20:26:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":2,"date":"2017-11-16 18:07:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2017-11-16 18:22:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"all":[{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2017-11-16 18:22:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-11-16 18:07:41.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2017-11-16 18:22:12.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"},{"updated":"2017-11-16 20:26:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ec7b613ba10a76626e3d3815a4609364afdf99fd","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2017-11-16 17:47:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c40bf914cac1fc1959b3ee4ffad73e788d9e5f55","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2017-11-16 18:07:41.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3582393d556a7f70f608291271fae02d0a7bbc78","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2017-11-16 18:22:12.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2\n\nAlways like such patches:)","accounts_in_message":[],"_revision_number":1},{"id":"6e91af7179ccca708cd9454c491444ed13adff0d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-16 19:00:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/66/520666/1/check/openstack-tox-pep8/6bf83d2/ : SUCCESS in 3m 08s\n- openstack-tox-py27 http://logs.openstack.org/66/520666/1/check/openstack-tox-py27/a7632fa/ : SUCCESS in 3m 06s\n- openstack-tox-py35 http://logs.openstack.org/66/520666/1/check/openstack-tox-py35/06e3526/ : SUCCESS in 4m 03s\n- build-openstack-sphinx-docs http://logs.openstack.org/66/520666/1/check/build-openstack-sphinx-docs/1c07928/html/ : SUCCESS in 3m 17s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/66/520666/1/check/legacy-tempest-dsvm-neutron-src/66095da/ : SUCCESS in 1h 09m 49s\n- legacy-novaclient-dsvm-functional-identity-v3-only http://logs.openstack.org/66/520666/1/check/legacy-novaclient-dsvm-functional-identity-v3-only/880d946/ : SUCCESS in 47m 16s (non-voting)\n- legacy-novaclient-dsvm-functional-neutron http://logs.openstack.org/66/520666/1/check/legacy-novaclient-dsvm-functional-neutron/608a341/ : SUCCESS in 46m 32s","accounts_in_message":[],"_revision_number":1},{"id":"2f697ae959d14ec4eb1ab742140d1817d347a7dd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-16 19:00:16.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a3860f1dc3b740b9bf0382ffe3addd2f92766307","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-16 20:26:43.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"ea4472e72c8bcb0e81ae21eaabd1a5bedce9a231","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-16 20:26:43.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/66/520666/1/gate/openstack-tox-pep8/a18cf2c/ : SUCCESS in 3m 01s\n- openstack-tox-py27 http://logs.openstack.org/66/520666/1/gate/openstack-tox-py27/7dbd370/ : SUCCESS in 3m 20s\n- openstack-tox-py35 http://logs.openstack.org/66/520666/1/gate/openstack-tox-py35/b154bac/ : SUCCESS in 3m 12s\n- build-openstack-sphinx-docs http://logs.openstack.org/66/520666/1/gate/build-openstack-sphinx-docs/a7bcb8a/html/ : SUCCESS in 3m 08s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/66/520666/1/gate/legacy-tempest-dsvm-neutron-src/13417fa/ : SUCCESS in 1h 25m 08s\n- legacy-novaclient-dsvm-functional-neutron http://logs.openstack.org/66/520666/1/gate/legacy-novaclient-dsvm-functional-neutron/e19b752/ : SUCCESS in 41m 26s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8bfcd2b0e6ff90c7a0e80af4ee14e60a71401cc3","revisions":{"8bfcd2b0e6ff90c7a0e80af4ee14e60a71401cc3":{"kind":"REWORK","_number":1,"created":"2017-11-16 17:47:56.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/66/520666/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/66/520666/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/66/520666/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/66/520666/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/66/520666/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/66/520666/1"}}},"commit":{"parents":[{"commit":"3637f6bf16dcf71878852fe460e63bd79df358e6","subject":"Merge \"Fix missing metavar in aggregate-update\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/3637f6bf16dcf71878852fe460e63bd79df358e6"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2017-11-16 17:45:51.000000000","tz":-300},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2017-11-16 17:45:51.000000000","tz":-300},"subject":"Remove SecretsHelper","message":"Remove SecretsHelper\n\nThis code hasn\u0027t worked for over two years when\n9ed9ab68f7d2fb98c505afc3a1079a72f15c959c was added\nwhich does API version discovery, which requires auth,\nwhich happens before the SecretsHelper is used. That was\nback in the 2.27.0 release in the Liberty series.\n\nGiven how long this has been broken without anyone noticing,\nand it\u0027s undocumented and untested (basically), and\npython-openstackclient properly handles prompting for a password,\nwe should just remove this code rather than try to fix it.\n\nChange-Id: I62188e73a48f6878ce920a3b4724dba101564aef\nCloses-Bug: #1732744\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/8bfcd2b0e6ff90c7a0e80af4ee14e60a71401cc3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/8bfcd2b0e6ff90c7a0e80af4ee14e60a71401cc3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}