)]}'
{"novaclient/tests/functional/v2/test_resize.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"a006bc97c19b9aec0c43a48487b548da7a179b69","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        \"\"\"Creates two flavors with different size ram but same size vcpus"},{"line_number":92,"context_line":"        and disk."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        :returns: tuple of (larger_flavor_name, smaller_flavor_name)"},{"line_number":95,"context_line":"        \"\"\""},{"line_number":96,"context_line":"        output \u003d self.nova(\u0027flavor-create\u0027,"},{"line_number":97,"context_line":"                           params\u003d\u0027resize-larger-flavor auto 128 0 1\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_22dc4e45","line":94,"range":{"start_line":94,"start_character":27,"end_line":94,"end_character":68},"updated":"2017-11-20 02:01:33.000000000","message":"It should be fixed.","commit_id":"3e30e133f33c74ad426df6560ab065dca02f968a"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"55775db3a8983c8931e287678026166f3ece7d49","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        \"\"\"Creates two flavors with different size ram but same size vcpus"},{"line_number":92,"context_line":"        and disk."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        :returns: tuple of (larger_flavor_name, smaller_flavor_name)"},{"line_number":95,"context_line":"        \"\"\""},{"line_number":96,"context_line":"        output \u003d self.nova(\u0027flavor-create\u0027,"},{"line_number":97,"context_line":"                           params\u003d\u0027resize-larger-flavor auto 128 0 1\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_fd5040d7","line":94,"range":{"start_line":94,"start_character":27,"end_line":94,"end_character":68},"in_reply_to":"ff82abbf_22dc4e45","updated":"2017-11-20 12:34:20.000000000","message":"Done","commit_id":"3e30e133f33c74ad426df6560ab065dca02f968a"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"a006bc97c19b9aec0c43a48487b548da7a179b69","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        \"\"\""},{"line_number":96,"context_line":"        output \u003d self.nova(\u0027flavor-create\u0027,"},{"line_number":97,"context_line":"                           params\u003d\u0027resize-larger-flavor auto 128 0 1\u0027)"},{"line_number":98,"context_line":"        larger_id \u003d self._get_value_from_the_table(output, \"ID\")"},{"line_number":99,"context_line":"        self.addCleanup("},{"line_number":100,"context_line":"            self.nova, \u0027flavor-delete\u0027, params\u003d\u0027resize-larger-flavor\u0027)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_62d25637","line":98,"range":{"start_line":98,"start_character":25,"end_line":98,"end_character":50},"updated":"2017-11-20 02:01:33.000000000","message":"It should be \u0027_get_column_value_from_single_row_table\u0027.","commit_id":"3e30e133f33c74ad426df6560ab065dca02f968a"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"55775db3a8983c8931e287678026166f3ece7d49","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        \"\"\""},{"line_number":96,"context_line":"        output \u003d self.nova(\u0027flavor-create\u0027,"},{"line_number":97,"context_line":"                           params\u003d\u0027resize-larger-flavor auto 128 0 1\u0027)"},{"line_number":98,"context_line":"        larger_id \u003d self._get_value_from_the_table(output, \"ID\")"},{"line_number":99,"context_line":"        self.addCleanup("},{"line_number":100,"context_line":"            self.nova, \u0027flavor-delete\u0027, params\u003d\u0027resize-larger-flavor\u0027)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_bd64f8ba","line":98,"range":{"start_line":98,"start_character":25,"end_line":98,"end_character":50},"in_reply_to":"ff82abbf_62d25637","updated":"2017-11-20 12:34:20.000000000","message":"Done","commit_id":"3e30e133f33c74ad426df6560ab065dca02f968a"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"a006bc97c19b9aec0c43a48487b548da7a179b69","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            self.nova, \u0027flavor-delete\u0027, params\u003d\u0027resize-larger-flavor\u0027)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        output \u003d self.nova(\u0027flavor-create\u0027,"},{"line_number":103,"context_line":"                           params\u003d\u0027%s auto 64 0 1\u0027)"},{"line_number":104,"context_line":"        smaller_id \u003d self._get_value_from_the_table(output, \"ID\")"},{"line_number":105,"context_line":"        self.addCleanup("},{"line_number":106,"context_line":"            self.nova, \u0027flavor-delete\u0027, params\u003d\u0027resize-smaller-flavor\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_42e152fe","line":103,"range":{"start_line":103,"start_character":35,"end_line":103,"end_character":37},"updated":"2017-11-20 02:01:33.000000000","message":"It should be fixed.","commit_id":"3e30e133f33c74ad426df6560ab065dca02f968a"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"55775db3a8983c8931e287678026166f3ece7d49","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            self.nova, \u0027flavor-delete\u0027, params\u003d\u0027resize-larger-flavor\u0027)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        output \u003d self.nova(\u0027flavor-create\u0027,"},{"line_number":103,"context_line":"                           params\u003d\u0027%s auto 64 0 1\u0027)"},{"line_number":104,"context_line":"        smaller_id \u003d self._get_value_from_the_table(output, \"ID\")"},{"line_number":105,"context_line":"        self.addCleanup("},{"line_number":106,"context_line":"            self.nova, \u0027flavor-delete\u0027, params\u003d\u0027resize-smaller-flavor\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_5d592cfc","line":103,"range":{"start_line":103,"start_character":35,"end_line":103,"end_character":37},"in_reply_to":"ff82abbf_42e152fe","updated":"2017-11-20 12:34:20.000000000","message":"Done","commit_id":"3e30e133f33c74ad426df6560ab065dca02f968a"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"a006bc97c19b9aec0c43a48487b548da7a179b69","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        output \u003d self.nova(\u0027flavor-create\u0027,"},{"line_number":103,"context_line":"                           params\u003d\u0027%s auto 64 0 1\u0027)"},{"line_number":104,"context_line":"        smaller_id \u003d self._get_value_from_the_table(output, \"ID\")"},{"line_number":105,"context_line":"        self.addCleanup("},{"line_number":106,"context_line":"            self.nova, \u0027flavor-delete\u0027, params\u003d\u0027resize-smaller-flavor\u0027)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_82d75a24","line":104,"range":{"start_line":104,"start_character":26,"end_line":104,"end_character":51},"updated":"2017-11-20 02:01:33.000000000","message":"ditto","commit_id":"3e30e133f33c74ad426df6560ab065dca02f968a"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"a006bc97c19b9aec0c43a48487b548da7a179b69","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                           params\u003d\u0027%s auto 64 0 1\u0027)"},{"line_number":104,"context_line":"        smaller_id \u003d self._get_value_from_the_table(output, \"ID\")"},{"line_number":105,"context_line":"        self.addCleanup("},{"line_number":106,"context_line":"            self.nova, \u0027flavor-delete\u0027, params\u003d\u0027resize-smaller-flavor\u0027)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        return larger_id, smaller_id"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_e2e5060c","line":106,"range":{"start_line":106,"start_character":47,"end_line":106,"end_character":70},"updated":"2017-11-20 02:01:33.000000000","message":"It should be fixed.","commit_id":"3e30e133f33c74ad426df6560ab065dca02f968a"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"55775db3a8983c8931e287678026166f3ece7d49","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                           params\u003d\u0027%s auto 64 0 1\u0027)"},{"line_number":104,"context_line":"        smaller_id \u003d self._get_value_from_the_table(output, \"ID\")"},{"line_number":105,"context_line":"        self.addCleanup("},{"line_number":106,"context_line":"            self.nova, \u0027flavor-delete\u0027, params\u003d\u0027resize-smaller-flavor\u0027)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        return larger_id, smaller_id"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_dd6c5c9e","line":106,"range":{"start_line":106,"start_character":47,"end_line":106,"end_character":70},"in_reply_to":"ff82abbf_e2e5060c","updated":"2017-11-20 12:34:20.000000000","message":"The names were not changed in this patch, so the cleanup should work as is.","commit_id":"3e30e133f33c74ad426df6560ab065dca02f968a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6688e7daab446b37b0cb6f3f65781bed464ea62f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        Compares quota before, during and after the resize."},{"line_number":68,"context_line":"        \"\"\""},{"line_number":69,"context_line":"        server_id \u003d self._create_server(\u0027resize-up-confirm\u0027,"},{"line_number":70,"context_line":"                                        flavor\u003dself.flavor.id).id"},{"line_number":71,"context_line":"        # get the starting quota now that we\u0027ve created a server"},{"line_number":72,"context_line":"        starting_usage \u003d self._get_absolute_limits()"},{"line_number":73,"context_line":"        # now resize up"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_c2465322","line":70,"range":{"start_line":70,"start_character":40,"end_line":70,"end_character":61},"updated":"2017-11-23 12:14:52.000000000","message":"I think it is the default behavior of _create_server to use the self.flavor is the flavor param is not provided. So I think this change is not needed.","commit_id":"a8e4521b673ed3935c096580ad1f14a1be9a4f39"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a6c917354137d026a1c284ebede049efbcda9bcd","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        Compares quota before, during and after the resize."},{"line_number":68,"context_line":"        \"\"\""},{"line_number":69,"context_line":"        server_id \u003d self._create_server(\u0027resize-up-confirm\u0027,"},{"line_number":70,"context_line":"                                        flavor\u003dself.flavor.id).id"},{"line_number":71,"context_line":"        # get the starting quota now that we\u0027ve created a server"},{"line_number":72,"context_line":"        starting_usage \u003d self._get_absolute_limits()"},{"line_number":73,"context_line":"        # now resize up"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_5318d473","line":70,"range":{"start_line":70,"start_character":40,"end_line":70,"end_character":61},"in_reply_to":"ff82abbf_6278a729","updated":"2017-11-23 16:04:04.000000000","message":"That make sense. Thanks for the explanation.","commit_id":"a8e4521b673ed3935c096580ad1f14a1be9a4f39"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"3dae7578a565ce51b8e20ba032913329c5e70ca1","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        Compares quota before, during and after the resize."},{"line_number":68,"context_line":"        \"\"\""},{"line_number":69,"context_line":"        server_id \u003d self._create_server(\u0027resize-up-confirm\u0027,"},{"line_number":70,"context_line":"                                        flavor\u003dself.flavor.id).id"},{"line_number":71,"context_line":"        # get the starting quota now that we\u0027ve created a server"},{"line_number":72,"context_line":"        starting_usage \u003d self._get_absolute_limits()"},{"line_number":73,"context_line":"        # now resize up"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_6278a729","line":70,"range":{"start_line":70,"start_character":40,"end_line":70,"end_character":61},"in_reply_to":"ff82abbf_c2465322","updated":"2017-11-23 12:26:40.000000000","message":"Despite the fact that usage of self.flavor is the default behavior,  I decided to transmit it explicitly since this method operates with different flavors and it can be more clear if all arguments will be \"more visible\".","commit_id":"a8e4521b673ed3935c096580ad1f14a1be9a4f39"}]}