)]}'
{"id":"openstack%2Fpython-novaclient~528325","triplet_id":"openstack%2Fpython-novaclient~master~Id61457c3db8a17e2294dc579b2519873927fec48","project":"openstack/python-novaclient","branch":"master","topic":"cleanup","hashtags":[],"change_id":"Id61457c3db8a17e2294dc579b2519873927fec48","subject":"Remove 2 redundant methods","status":"MERGED","created":"2017-12-15 16:32:49.000000000","updated":"2018-02-09 19:07:51.000000000","submitted":"2018-02-09 19:07:51.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"528325-1518203271813-d05392ea","meta_rev_id":"7647c4daea5e285eb6f572cb9c66dd6b232c88fd","_number":528325,"virtual_id_number":528325,"owner":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":19944,"name":"Chen Hanxiao","email":"chen_han_xiao@126.com","username":"chenhanxiao"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"date":"2018-02-09 15:52:47.000000000","_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":2,"date":"2018-02-09 19:07:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2018-02-09 15:26:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":19944,"name":"Chen Hanxiao","email":"chen_han_xiao@126.com","username":"chenhanxiao"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2018-02-09 15:26:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":19944,"name":"Chen Hanxiao","email":"chen_han_xiao@126.com","username":"chenhanxiao"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":19944,"name":"Chen Hanxiao","email":"chen_han_xiao@126.com","username":"chenhanxiao"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":19944,"name":"Chen Hanxiao","email":"chen_han_xiao@126.com","username":"chenhanxiao"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-12-15 16:34:38.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2017-12-29 01:37:24.000000000","updated_by":{"_account_id":19944,"name":"Chen Hanxiao","email":"chen_han_xiao@126.com","username":"chenhanxiao"},"reviewer":{"_account_id":19944,"name":"Chen Hanxiao","email":"chen_han_xiao@126.com","username":"chenhanxiao"},"state":"REVIEWER"},{"updated":"2018-02-05 14:56:17.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2018-02-09 15:26:32.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2018-02-09 19:07:51.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f39484496d3e4dd8d7a2ded554c3e2f7cd19831b","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2017-12-15 16:32:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9e31cc6a48d18d3d56e777c860b6c5a224f410b1","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2017-12-15 17:02:26.000000000","message":"Patch Set 1:\n\nI agree that we can do a cleanup without deprecation.  However, I\u0027d like to go ahead and include a release note, in case third parties are using these functions.  While I don\u0027t believe we have any responsibility to support them, we should at least advertise to them that these are going away, and release notes is the mechanism we\u0027ve established for that.","accounts_in_message":[],"_revision_number":1},{"id":"29bfbc63bd72a97adbc8830f8e9567bdce3b08b1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-15 18:02:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/25/528325/1/check/openstack-tox-pep8/bc2de91/ : SUCCESS in 3m 07s\n- openstack-tox-py27 http://logs.openstack.org/25/528325/1/check/openstack-tox-py27/684c14c/ : SUCCESS in 3m 14s\n- openstack-tox-py35 http://logs.openstack.org/25/528325/1/check/openstack-tox-py35/ce28ba6/ : SUCCESS in 5m 28s\n- build-openstack-sphinx-docs http://logs.openstack.org/25/528325/1/check/build-openstack-sphinx-docs/d78400b/html/ : SUCCESS in 5m 08s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/25/528325/1/check/legacy-tempest-dsvm-neutron-src/51f3890/ : SUCCESS in 1h 24m 17s\n- novaclient-dsvm-functional http://logs.openstack.org/25/528325/1/check/novaclient-dsvm-functional/65739e3/ : SUCCESS in 51m 24s","accounts_in_message":[],"_revision_number":1},{"id":"0fdce859d9c2d7a5a49282d8cd874b1f507f9ae1","author":{"_account_id":19944,"name":"Chen Hanxiao","email":"chen_han_xiao@126.com","username":"chenhanxiao"},"date":"2017-12-29 01:37:24.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"bff271527d554675991fcd72076130ea548cfbfd","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2018-02-05 14:27:33.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"07dd69561f7f21eb24095b3d1affa374459dd1a7","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2018-02-05 14:28:16.000000000","message":"Patch Set 1:\n\n@Kevin: sorry for a delay. the proper release notes are added","accounts_in_message":[],"_revision_number":1},{"id":"f53a62ae1c58a5f2ed6c9078416d990cf296b218","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2018-02-05 14:56:17.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"590d5ef23080b499a4c7f240a882a94ab60d38ff","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-05 15:50:39.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/25/528325/2/check/openstack-tox-pep8/2617755/ : SUCCESS in 2m 31s\n- openstack-tox-py27 http://logs.openstack.org/25/528325/2/check/openstack-tox-py27/b4db715/ : SUCCESS in 2m 53s\n- openstack-tox-py35 http://logs.openstack.org/25/528325/2/check/openstack-tox-py35/35d77d7/ : SUCCESS in 2m 37s\n- build-openstack-sphinx-docs http://logs.openstack.org/25/528325/2/check/build-openstack-sphinx-docs/3d61c72/html/ : SUCCESS in 2m 53s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/25/528325/2/check/legacy-tempest-dsvm-neutron-src/51ada4f/ : SUCCESS in 1h 16m 22s\n- build-openstack-releasenotes http://logs.openstack.org/25/528325/2/check/build-openstack-releasenotes/b0e51c9/html/ : SUCCESS in 3m 16s\n- novaclient-dsvm-functional http://logs.openstack.org/25/528325/2/check/novaclient-dsvm-functional/f486479/ : SUCCESS in 48m 01s","accounts_in_message":[],"_revision_number":2},{"id":"10b8ad3b7e8fb761de76b40288b632fdc7d55fab","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2018-02-09 15:25:32.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"9b995d251c14583b2b7755163de6de2a03f0b69f","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2018-02-09 15:26:11.000000000","message":"Patch Set 3: Published edit on patch set 2.","accounts_in_message":[],"_revision_number":3},{"id":"af743d679817bc089f141c61a1722429747e0737","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2018-02-09 15:26:32.000000000","message":"Patch Set 3: Workflow+1 Code-Review+2\n\nTrivial typo fixes and Kevin was +2 already, so fast approving","accounts_in_message":[],"_revision_number":3},{"id":"fc74c5bad32949773c9ca97b61d05d1b69481241","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2018-02-09 15:52:47.000000000","message":"Patch Set 3:\n\nStephen, thanks!","accounts_in_message":[],"_revision_number":3},{"id":"7f53b85219b4bbcbc0e46ae62ebe957cdf5c3c3c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-09 17:13:44.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/25/528325/3/check/openstack-tox-pep8/cf1b419/ : SUCCESS in 3m 05s\n- openstack-tox-py27 http://logs.openstack.org/25/528325/3/check/openstack-tox-py27/b2c63d3/ : SUCCESS in 2m 56s\n- openstack-tox-py35 http://logs.openstack.org/25/528325/3/check/openstack-tox-py35/5713821/ : SUCCESS in 3m 06s\n- build-openstack-sphinx-docs http://logs.openstack.org/25/528325/3/check/build-openstack-sphinx-docs/98b8039/html/ : SUCCESS in 3m 40s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/25/528325/3/check/legacy-tempest-dsvm-neutron-src/7aafe0d/ : SUCCESS in 1h 37m 05s\n- build-openstack-releasenotes http://logs.openstack.org/25/528325/3/check/build-openstack-releasenotes/dc5a93c/html/ : SUCCESS in 3m 05s\n- novaclient-dsvm-functional http://logs.openstack.org/25/528325/3/check/novaclient-dsvm-functional/9323079/ : SUCCESS in 45m 53s","accounts_in_message":[],"_revision_number":3},{"id":"a1bcfd001a89cfad4633bdbc829f4eff458b485c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-09 17:18:35.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"1f3e4010d212a8a6fa8d0a4c03556e691e910019","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-09 19:07:51.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"7f47e1adb47d887be060a8bd58806c05eb97df9d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-09 19:07:51.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/25/528325/3/gate/openstack-tox-pep8/e361692/ : SUCCESS in 3m 06s\n- openstack-tox-py27 http://logs.openstack.org/25/528325/3/gate/openstack-tox-py27/374d5b1/ : SUCCESS in 3m 30s\n- openstack-tox-py35 http://logs.openstack.org/25/528325/3/gate/openstack-tox-py35/4ba2cfe/ : SUCCESS in 3m 17s\n- build-openstack-sphinx-docs http://logs.openstack.org/25/528325/3/gate/build-openstack-sphinx-docs/b9a5344/html/ : SUCCESS in 3m 38s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/25/528325/3/gate/legacy-tempest-dsvm-neutron-src/b6fcbdb/ : SUCCESS in 1h 38m 37s\n- build-openstack-releasenotes http://logs.openstack.org/25/528325/3/gate/build-openstack-releasenotes/6fab8ac/html/ : SUCCESS in 3m 42s\n- novaclient-dsvm-functional http://logs.openstack.org/25/528325/3/gate/novaclient-dsvm-functional/a5e03e1/ : SUCCESS in 45m 49s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"ca27736810a41080761e604e09c6763aaed07ed7","revisions":{"f559bd73149098fa4883957fb2c903f0bd32b6ee":{"kind":"REWORK","_number":1,"created":"2017-12-15 16:32:49.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/25/528325/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/25/528325/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/528325/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/528325/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/528325/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/25/528325/1"}}},"commit":{"parents":[{"commit":"ee2221f0526c4a6bed431229e363c740d07b8ee9","subject":"Optimize jobs run on novaclient","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ee2221f0526c4a6bed431229e363c740d07b8ee9"}]}],"author":{"name":"Andrey Kurilin","email":"andr.kurilin@gmail.com","date":"2017-12-15 16:24:53.000000000","tz":120},"committer":{"name":"Andrey Kurilin","email":"andr.kurilin@gmail.com","date":"2017-12-15 16:24:53.000000000","tz":120},"subject":"Remove 2 redundant methods","message":"Remove 2 redundant methods\n\nI suppose that methods get_resource_manager_extra_kwargs and\nadd_resource_manager_extra_kwargs_hook were designed in those days when\nNova API had extensions.\nNowdays, Nova API has strict schema validation of requests, so no\nadditional arguments are allowed and these methods look redundant.\n\nThe fact that get_resource_manager_extra_kwargs lists of the objects\nadded by add_resource_manager_extra_kwargs_hook and the fact that\nadd_resource_manager_extra_kwargs_hook is not called anywhere\ndo not add chances for leaving these code in our code.\n\nCompatibility: both methods are designed for CLI and the CLI behaviour\n  will not change after removing them, so we can do a cleanup without\n  deprecation and release notes.\n\nChange-Id: Id61457c3db8a17e2294dc579b2519873927fec48\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f559bd73149098fa4883957fb2c903f0bd32b6ee"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f559bd73149098fa4883957fb2c903f0bd32b6ee"}]},"branch":"refs/heads/master"},"34d45ac8cd43fb5f0d79c6a9574fc9b227803a6a":{"kind":"REWORK","_number":2,"created":"2018-02-05 14:27:33.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/25/528325/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/25/528325/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/528325/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/528325/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/528325/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/25/528325/2"}}},"commit":{"parents":[{"commit":"beb90ec793dff9e55e67d4ebe80d3f87ec2f0dce","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/beb90ec793dff9e55e67d4ebe80d3f87ec2f0dce"}]}],"author":{"name":"Andrey Kurilin","email":"andr.kurilin@gmail.com","date":"2017-12-15 16:24:53.000000000","tz":120},"committer":{"name":"Andrey Kurilin","email":"andr.kurilin@gmail.com","date":"2018-02-05 14:25:51.000000000","tz":120},"subject":"Remove 2 redundant methods","message":"Remove 2 redundant methods\n\nI suppose that methods get_resource_manager_extra_kwargs and\nadd_resource_manager_extra_kwargs_hook were designed in those days when\nNova API had extensions.\nNowdays, Nova API has strict schema validation of requests, so no\nadditional arguments are allowed and these methods look redundant.\n\nThe fact that get_resource_manager_extra_kwargs lists of the objects\nadded by add_resource_manager_extra_kwargs_hook whereas\nadd_resource_manager_extra_kwargs_hook is not called anywhere\ndoesn\u0027t add chances for leaving these methods in our code.\n\nCompatibility: both methods are designed for CLI and the CLI behaviour\n  will not change after removing them, so we can do a cleanup without\n  following standard deprecation cycle.\n\nChange-Id: Id61457c3db8a17e2294dc579b2519873927fec48\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/34d45ac8cd43fb5f0d79c6a9574fc9b227803a6a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/34d45ac8cd43fb5f0d79c6a9574fc9b227803a6a"}]},"branch":"refs/heads/master"},"ca27736810a41080761e604e09c6763aaed07ed7":{"kind":"REWORK","_number":3,"created":"2018-02-09 15:26:11.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/25/528325/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/25/528325/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/528325/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/528325/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/528325/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/25/528325/3"}}},"commit":{"parents":[{"commit":"beb90ec793dff9e55e67d4ebe80d3f87ec2f0dce","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/beb90ec793dff9e55e67d4ebe80d3f87ec2f0dce"}]}],"author":{"name":"Andrey Kurilin","email":"andr.kurilin@gmail.com","date":"2017-12-15 16:24:53.000000000","tz":120},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2018-02-09 15:26:08.000000000","tz":0},"subject":"Remove 2 redundant methods","message":"Remove 2 redundant methods\n\nI suppose that methods get_resource_manager_extra_kwargs and\nadd_resource_manager_extra_kwargs_hook were designed in those days when\nNova API had extensions.\nNowdays, Nova API has strict schema validation of requests, so no\nadditional arguments are allowed and these methods look redundant.\n\nThe fact that get_resource_manager_extra_kwargs lists of the objects\nadded by add_resource_manager_extra_kwargs_hook whereas\nadd_resource_manager_extra_kwargs_hook is not called anywhere\ndoesn\u0027t add chances for leaving these methods in our code.\n\nCompatibility: both methods are designed for CLI and the CLI behaviour\n  will not change after removing them, so we can do a cleanup without\n  following standard deprecation cycle.\n\nChange-Id: Id61457c3db8a17e2294dc579b2519873927fec48\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ca27736810a41080761e604e09c6763aaed07ed7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ca27736810a41080761e604e09c6763aaed07ed7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}