)]}'
{"id":"openstack%2Fpython-novaclient~533005","triplet_id":"openstack%2Fpython-novaclient~master~I60490f3d74212bb172dccc1c7d337198e1021236","project":"openstack/python-novaclient","branch":"master","topic":"bug/1668743","hashtags":[],"change_id":"I60490f3d74212bb172dccc1c7d337198e1021236","subject":"Remove deprecated services binary CLI arg","status":"MERGED","created":"2018-01-11 22:52:01.000000000","updated":"2018-01-13 19:41:12.000000000","submitted":"2018-01-13 19:41:12.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"533005-1515872472307-550f4d9b","meta_rev_id":"aa4ff748f721625d0f90afbc2a862948546035a0","_number":533005,"virtual_id_number":533005,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2018-01-12 19:10:10.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2018-01-13 19:41:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2018-01-12 10:08:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":2,"date":"2018-01-12 14:50:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":1,"date":"2018-01-12 14:50:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-12 10:08:14.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2018-01-12 14:50:33.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2018-01-13 19:41:12.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b9ef25b51595c961cc84ab1f606fdf39266e086f","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2018-01-11 22:52:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"14a0562c175a6bbcc8e637363082f15f4b6443f4","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2018-01-12 00:06:48.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"66ab1d0f7da0b5fe03995d945486142f85d6ce37","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-12 00:36:53.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/05/533005/1/check/openstack-tox-pep8/d914714/ : SUCCESS in 3m 02s\n- openstack-tox-py27 http://logs.openstack.org/05/533005/1/check/openstack-tox-py27/39f364b/ : SUCCESS in 3m 51s\n- openstack-tox-py35 http://logs.openstack.org/05/533005/1/check/openstack-tox-py35/7f3d00a/ : SUCCESS in 3m 09s\n- build-openstack-sphinx-docs http://logs.openstack.org/05/533005/1/check/build-openstack-sphinx-docs/7a8f9e2/html/ : SUCCESS in 3m 26s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/05/533005/1/check/legacy-tempest-dsvm-neutron-src/de68c34/ : SUCCESS in 1h 13m 55s\n- build-openstack-releasenotes http://logs.openstack.org/05/533005/1/check/build-openstack-releasenotes/09d10fa/html/ : SUCCESS in 3m 49s\n- novaclient-dsvm-functional http://logs.openstack.org/05/533005/1/check/novaclient-dsvm-functional/c233cce/ : FAILURE in 49m 14s","accounts_in_message":[],"_revision_number":1},{"id":"ba14ecd337de53d73f7176094a1a075811d7f6ef","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2018-01-12 02:10:50.000000000","message":"Patch Set 1: Workflow-1\n\nI missed some functional tests here.","accounts_in_message":[],"_revision_number":1},{"id":"f3955a38dd9be1d792fc9bda714856652da46dbf","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2018-01-12 02:16:44.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9a522557f153857ee2d8a9e62039f3f0a6d9f0f3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-12 04:14:28.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/05/533005/2/check/openstack-tox-pep8/387a578/ : SUCCESS in 4m 22s\n- openstack-tox-py27 http://logs.openstack.org/05/533005/2/check/openstack-tox-py27/31b1548/ : SUCCESS in 3m 12s\n- openstack-tox-py35 http://logs.openstack.org/05/533005/2/check/openstack-tox-py35/722d025/ : SUCCESS in 4m 12s\n- build-openstack-sphinx-docs http://logs.openstack.org/05/533005/2/check/build-openstack-sphinx-docs/f810378/html/ : SUCCESS in 4m 10s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/05/533005/2/check/legacy-tempest-dsvm-neutron-src/739b79f/ : SUCCESS in 1h 31m 13s\n- build-openstack-releasenotes http://logs.openstack.org/05/533005/2/check/build-openstack-releasenotes/cf33984/html/ : SUCCESS in 5m 05s\n- novaclient-dsvm-functional http://logs.openstack.org/05/533005/2/check/novaclient-dsvm-functional/cd78273/ : SUCCESS in 47m 14s","accounts_in_message":[],"_revision_number":2},{"id":"b3169a63a7cde9df755d7d5f98b20102016f5c27","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2018-01-12 10:08:14.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"779060c54a1949f98aab5ed5faaeacba186b37d2","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2018-01-12 14:50:33.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"682cc0076ab54742ee0972802dbb02306ce78316","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-12 14:50:46.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"c88a9bda1f835fb106aa27e7e687fbb8cddaef9d","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2018-01-12 19:10:10.000000000","message":"Patch Set 2:\n\nrecheck zuul restart","accounts_in_message":[],"_revision_number":2},{"id":"4d2e642a30caa2c273c23f03d58394e30c0d0123","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-12 20:28:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/05/533005/2/check/openstack-tox-pep8/53533cc/ : SUCCESS in 3m 19s\n- openstack-tox-py27 http://logs.openstack.org/05/533005/2/check/openstack-tox-py27/64909d2/ : SUCCESS in 3m 35s\n- openstack-tox-py35 http://logs.openstack.org/05/533005/2/check/openstack-tox-py35/d899ee3/ : SUCCESS in 4m 28s\n- build-openstack-sphinx-docs http://logs.openstack.org/05/533005/2/check/build-openstack-sphinx-docs/4f8b7a1/html/ : SUCCESS in 3m 04s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/05/533005/2/check/legacy-tempest-dsvm-neutron-src/704f811/ : SUCCESS in 1h 13m 45s\n- build-openstack-releasenotes http://logs.openstack.org/05/533005/2/check/build-openstack-releasenotes/d81edfb/html/ : SUCCESS in 4m 16s\n- novaclient-dsvm-functional http://logs.openstack.org/05/533005/2/check/novaclient-dsvm-functional/0352580/ : SUCCESS in 42m 29s","accounts_in_message":[],"_revision_number":2},{"id":"8ccd399ade03c2c13dae841b3c8f60edaa3af7b0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-13 18:12:58.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"93b4d1cab1ee6f688450838aa51c64795b3e6e37","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-13 19:41:12.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"7f061c7b4065fdf77bbdd05bdb654b3c5ae803b5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-13 19:41:12.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/05/533005/2/gate/openstack-tox-pep8/9f9bd68/ : SUCCESS in 2m 41s\n- openstack-tox-py27 http://logs.openstack.org/05/533005/2/gate/openstack-tox-py27/b283b74/ : SUCCESS in 3m 24s\n- openstack-tox-py35 http://logs.openstack.org/05/533005/2/gate/openstack-tox-py35/f8a1c27/ : SUCCESS in 3m 27s\n- build-openstack-sphinx-docs http://logs.openstack.org/05/533005/2/gate/build-openstack-sphinx-docs/a7a7e1d/html/ : SUCCESS in 4m 44s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/05/533005/2/gate/legacy-tempest-dsvm-neutron-src/6c8f9c0/ : SUCCESS in 1h 17m 34s\n- build-openstack-releasenotes http://logs.openstack.org/05/533005/2/gate/build-openstack-releasenotes/1f1b60c/html/ : SUCCESS in 3m 05s\n- novaclient-dsvm-functional http://logs.openstack.org/05/533005/2/gate/novaclient-dsvm-functional/1b54bce/ : SUCCESS in 45m 47s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fefc3ba723865307f4cc2ca287eb59faa4e8a5b1","revisions":{"f16b70259fd0b04d7d4401843ae0be416420a396":{"kind":"REWORK","_number":1,"created":"2018-01-11 22:52:01.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/05/533005/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/05/533005/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/05/533005/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/05/533005/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/05/533005/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/05/533005/1"}}},"commit":{"parents":[{"commit":"65f6fde174154eeb6057e82f6f3b12dde3b49752","subject":"Remove deprecated fixedip/floatingip/virtual interface CLIs/APIs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/65f6fde174154eeb6057e82f6f3b12dde3b49752"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2018-01-11 22:39:50.000000000","tz":-300},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2018-01-11 22:52:26.000000000","tz":-300},"subject":"Remove deprecated services binary CLI arg","message":"Remove deprecated services binary CLI arg\n\nThe services CLI \u0027binary\u0027 arg was deprecated in Pike\nvia change Idd0d2be960ca0ed59097c10c931da47a1a3e66fb\nbecause with cells v2 support in the API, the binary\nargument for the enable/disable CLIs doesn\u0027t make sense\nas the only binary those work with is \u0027nova-compute\u0027.\nSo this removes the deprecated argument and hard-codes\nthe value to be \u0027nova-compute\u0027.\n\nChange-Id: I60490f3d74212bb172dccc1c7d337198e1021236\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f16b70259fd0b04d7d4401843ae0be416420a396"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f16b70259fd0b04d7d4401843ae0be416420a396"}]},"branch":"refs/heads/master"},"fefc3ba723865307f4cc2ca287eb59faa4e8a5b1":{"kind":"REWORK","_number":2,"created":"2018-01-12 02:16:44.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/05/533005/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/05/533005/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/05/533005/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/05/533005/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/05/533005/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/05/533005/2"}}},"commit":{"parents":[{"commit":"01fb16533bf562f39fe822bc12b9cc34b8580359","subject":"Remove deprecated fixedip/floatingip/virtual interface CLIs/APIs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/01fb16533bf562f39fe822bc12b9cc34b8580359"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2018-01-11 22:39:50.000000000","tz":-300},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2018-01-12 02:17:04.000000000","tz":-300},"subject":"Remove deprecated services binary CLI arg","message":"Remove deprecated services binary CLI arg\n\nThe services CLI \u0027binary\u0027 arg was deprecated in Pike\nvia change Idd0d2be960ca0ed59097c10c931da47a1a3e66fb\nbecause with cells v2 support in the API, the binary\nargument for the enable/disable CLIs doesn\u0027t make sense\nas the only binary those work with is \u0027nova-compute\u0027.\nSo this removes the deprecated argument and hard-codes\nthe value to be \u0027nova-compute\u0027.\n\nChange-Id: I60490f3d74212bb172dccc1c7d337198e1021236\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/fefc3ba723865307f4cc2ca287eb59faa4e8a5b1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/fefc3ba723865307f4cc2ca287eb59faa4e8a5b1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
