)]}'
{"id":"openstack%2Fpython-novaclient~541610","triplet_id":"openstack%2Fpython-novaclient~master~I63bc3dc8807021f5a97f58b0fe13a10d93688c7e","project":"openstack/python-novaclient","branch":"master","topic":"bug/1746534","hashtags":[],"change_id":"I63bc3dc8807021f5a97f58b0fe13a10d93688c7e","subject":"Fix crashing console-log","status":"MERGED","created":"2018-02-07 08:29:00.000000000","updated":"2019-04-11 15:05:49.000000000","submitted":"2018-02-09 12:28:02.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"541610-1518179282298-7f84d19e","meta_rev_id":"ee188283a804c20e90244c9e12ef0a58a2fc7dea","_number":541610,"virtual_id_number":541610,"owner":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2018-02-09 12:28:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2018-02-09 11:00:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":2,"date":"2018-02-08 14:38:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2018-02-09 11:00:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-02-08 14:38:43.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2018-02-09 11:00:10.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2018-02-09 12:28:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"addf0b64d3d6c3a27d95c8fabac477e98de78065","author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"date":"2018-02-07 08:29:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0f434568d5a583bdf48cb5588e661da89750d620","author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"date":"2018-02-07 08:53:47.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1759bf2a7ad76d0795b8965cba8b4b09f3ca3be9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-07 10:28:54.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/10/541610/2/check/openstack-tox-pep8/894f147/ : SUCCESS in 2m 54s\n- openstack-tox-py27 http://logs.openstack.org/10/541610/2/check/openstack-tox-py27/55ee956/ : SUCCESS in 3m 16s\n- openstack-tox-py35 http://logs.openstack.org/10/541610/2/check/openstack-tox-py35/3292110/ : SUCCESS in 3m 08s\n- build-openstack-sphinx-docs http://logs.openstack.org/10/541610/2/check/build-openstack-sphinx-docs/3bf421d/html/ : SUCCESS in 2m 26s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/10/541610/2/check/legacy-tempest-dsvm-neutron-src/6f13c1a/ : SUCCESS in 1h 33m 49s\n- novaclient-dsvm-functional http://logs.openstack.org/10/541610/2/check/novaclient-dsvm-functional/94edbc7/ : SUCCESS in 45m 45s","accounts_in_message":[],"_revision_number":2},{"id":"0b7cada842d1e73e420bf4b75e670e59f3c7841a","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2018-02-07 16:14:13.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nI\u0027d also like to see a regression test added to the suite to cover the new code, since this is in response to a bug report.","accounts_in_message":[],"_revision_number":2},{"id":"83711b4ec73b5f7c93a1fe2306453598bc162900","author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"date":"2018-02-08 08:21:05.000000000","message":"Patch Set 2:\n\nKevin, I\u0027m reporting the bug, and I sent my patch, however, I\u0027m sorry, but I have no time to add tests and such, I have enough in my plate with 421 Debian packages for OpenStack to maintain. Please do feel free to take over this patch and be co-author if you want to add a test.\n\nHowever, the idea to add a leading \\n is very good, and I\u0027ll do that right away.","accounts_in_message":[],"_revision_number":2},{"id":"3f1798c67e35817c1444ab500dddf0e75341e3d0","author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"date":"2018-02-08 08:23:26.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"490e893e7592b7f7a32ed7c94722162edd7c6bd4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-08 09:37:14.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/10/541610/3/check/openstack-tox-pep8/42a8665/ : SUCCESS in 3m 02s\n- openstack-tox-py27 http://logs.openstack.org/10/541610/3/check/openstack-tox-py27/80e1982/ : SUCCESS in 3m 20s\n- openstack-tox-py35 http://logs.openstack.org/10/541610/3/check/openstack-tox-py35/0cd3eb8/ : SUCCESS in 3m 49s\n- build-openstack-sphinx-docs http://logs.openstack.org/10/541610/3/check/build-openstack-sphinx-docs/0d6dd27/html/ : SUCCESS in 2m 13s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/10/541610/3/check/legacy-tempest-dsvm-neutron-src/f506940/ : SUCCESS in 1h 11m 50s\n- novaclient-dsvm-functional http://logs.openstack.org/10/541610/3/check/novaclient-dsvm-functional/d37f7e2/ : SUCCESS in 48m 20s","accounts_in_message":[],"_revision_number":3},{"id":"f3d1509d03daddfccb24781b4ca001d7b6d7c850","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2018-02-08 14:38:43.000000000","message":"Patch Set 3: Code-Review+2\n\nYeah, I understand the time constraint you\u0027re under, and I\u0027d love to help, but I\u0027m under my own time constraint.  I\u0027ll +2 with the fix of reassigning sys.stdout, but still with a request for tests, and we\u0027ll see what other cores think…","accounts_in_message":[],"_revision_number":3},{"id":"1bd9d95a2222b1376fb984f7b4290fb878fe0494","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2018-02-09 11:00:10.000000000","message":"Patch Set 3: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"4cef0a389b9f46edfa53fea4bf824de6697685ea","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-09 11:00:33.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"d17634aec84d381c52caea029782a2d01830dd87","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-09 12:28:02.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"30083e0301d43048af99b12301eda7923d0ab04a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-09 12:28:02.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/10/541610/3/gate/openstack-tox-pep8/615853d/ : SUCCESS in 2m 43s\n- openstack-tox-py27 http://logs.openstack.org/10/541610/3/gate/openstack-tox-py27/5e8f849/ : SUCCESS in 3m 14s\n- openstack-tox-py35 http://logs.openstack.org/10/541610/3/gate/openstack-tox-py35/cc5f652/ : SUCCESS in 2m 52s\n- build-openstack-sphinx-docs http://logs.openstack.org/10/541610/3/gate/build-openstack-sphinx-docs/99ab9e8/html/ : SUCCESS in 2m 54s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/10/541610/3/gate/legacy-tempest-dsvm-neutron-src/9ee8f6e/ : SUCCESS in 1h 26m 14s\n- novaclient-dsvm-functional http://logs.openstack.org/10/541610/3/gate/novaclient-dsvm-functional/7f7abc8/ : SUCCESS in 50m 01s","accounts_in_message":[],"_revision_number":3},{"id":"ea583979e21c48e0f7fc536fad51b64e21f35f19","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-04-05 06:40:36.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"9a8dbc0bdf25cedbea5d2e8608644edeb638997a","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-04-05 06:57:31.000000000","message":"Patch Set 3:\n\nRevert with rationale proposed here:\n\n  https://review.openstack.org/#/c/650235/\n\nHappy to discuss/iterate on that there. This stuff is _super_ complicated :(","accounts_in_message":[],"_revision_number":3},{"id":"a4e7c4cd988897ee8c93ed2d7bdc7e88d47fa756","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-11 15:05:49.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"d272d6f3df2610a62f81e2ca26798ea8a6674b06","revisions":{"aa51a7057ce996b7f89e7b204f84ef0dae1610e7":{"kind":"REWORK","_number":1,"created":"2018-02-07 08:29:00.000000000","uploader":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"ref":"refs/changes/10/541610/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/10/541610/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/10/541610/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/10/541610/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/10/541610/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/10/541610/1"}}},"commit":{"parents":[{"commit":"5de74bef5c67f08811ab0c166df0230b01e4ed8a","subject":"Merge \"Add CLI to show instance usage audit logs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5de74bef5c67f08811ab0c166df0230b01e4ed8a"}]}],"author":{"name":"Thomas Goirand","email":"zigo@debian.org","date":"2018-02-07 08:17:12.000000000","tz":60},"committer":{"name":"Thomas Goirand","email":"zigo@debian.org","date":"2018-02-07 08:28:52.000000000","tz":60},"subject":"Fix crashing console-log","message":"Fix crashing console-log\n\nBecause of encoding issue, the \"nova console-log\" is prone to a stack\ndump, as explained in the bug report.\n\nThis patch sets the encoding output of stdout to utf8 before attempting\nto print in it.\n\nChange-Id: I63bc3dc8807021f5a97f58b0fe13a10d93688c7e\nCloses-Bug: 1746534\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/aa51a7057ce996b7f89e7b204f84ef0dae1610e7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/aa51a7057ce996b7f89e7b204f84ef0dae1610e7"}]},"branch":"refs/heads/master"},"be876fb3cc64717b6dea64e2f6f7f84c27f95aec":{"kind":"REWORK","_number":2,"created":"2018-02-07 08:53:47.000000000","uploader":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"ref":"refs/changes/10/541610/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/10/541610/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/10/541610/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/10/541610/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/10/541610/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/10/541610/2"}}},"commit":{"parents":[{"commit":"5de74bef5c67f08811ab0c166df0230b01e4ed8a","subject":"Merge \"Add CLI to show instance usage audit logs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5de74bef5c67f08811ab0c166df0230b01e4ed8a"}]}],"author":{"name":"Thomas Goirand","email":"zigo@debian.org","date":"2018-02-07 08:17:12.000000000","tz":60},"committer":{"name":"Thomas Goirand","email":"zigo@debian.org","date":"2018-02-07 08:53:30.000000000","tz":60},"subject":"Fix crashing console-log","message":"Fix crashing console-log\n\nBecause of encoding issue, the \"nova console-log\" is prone to a stack\ndump, as explained in the bug report.\n\nThis patch sets the encoding output of stdout to utf8 before attempting\nto print in it.\n\nChange-Id: I63bc3dc8807021f5a97f58b0fe13a10d93688c7e\nCloses-Bug: 1746534\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/be876fb3cc64717b6dea64e2f6f7f84c27f95aec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/be876fb3cc64717b6dea64e2f6f7f84c27f95aec"}]},"branch":"refs/heads/master"},"d272d6f3df2610a62f81e2ca26798ea8a6674b06":{"kind":"REWORK","_number":3,"created":"2018-02-08 08:23:26.000000000","uploader":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"ref":"refs/changes/10/541610/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/10/541610/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/10/541610/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/10/541610/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/10/541610/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/10/541610/3"}}},"commit":{"parents":[{"commit":"5de74bef5c67f08811ab0c166df0230b01e4ed8a","subject":"Merge \"Add CLI to show instance usage audit logs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5de74bef5c67f08811ab0c166df0230b01e4ed8a"}]}],"author":{"name":"Thomas Goirand","email":"zigo@debian.org","date":"2018-02-07 08:17:12.000000000","tz":60},"committer":{"name":"Thomas Goirand","email":"zigo@debian.org","date":"2018-02-08 08:23:05.000000000","tz":60},"subject":"Fix crashing console-log","message":"Fix crashing console-log\n\nBecause of encoding issue, the \"nova console-log\" is prone to a stack\ndump, as explained in the bug report.\n\nThis patch sets the encoding output of stdout to utf8 before attempting\nto print in it.\n\nChange-Id: I63bc3dc8807021f5a97f58b0fe13a10d93688c7e\nCloses-Bug: 1746534\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d272d6f3df2610a62f81e2ca26798ea8a6674b06"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d272d6f3df2610a62f81e2ca26798ea8a6674b06"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}