)]}'
{"id":"openstack%2Fpython-novaclient~543968","triplet_id":"openstack%2Fpython-novaclient~stable%2Fqueens~I4194e6d5e34ecc0ac704851c08bb895e223aa850","project":"openstack/python-novaclient","branch":"stable/queens","topic":"bug/1743532-stable/queens","hashtags":[],"change_id":"I4194e6d5e34ecc0ac704851c08bb895e223aa850","subject":"Fix listing of instances above API max_limit","status":"ABANDONED","created":"2018-02-13 15:25:13.000000000","updated":"2018-04-18 20:40:28.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2cf25156684c7f7b79222017466e555aa14d91d8","_number":543968,"virtual_id_number":543968,"owner":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2018-02-16 10:14:59.000000000","_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"_account_id":20312,"name":"Jacek Tomasiak","email":"jacek.tomasiak@gmail.com","username":"skazi"},{"date":"2018-02-18 14:36:33.000000000","_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2018-02-13 16:44:47.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"value":0,"date":"2018-03-06 09:51:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":20312,"name":"Jacek Tomasiak","email":"jacek.tomasiak@gmail.com","username":"skazi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":-1,"date":"2018-02-13 15:27:48.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"_account_id":20312,"name":"Jacek Tomasiak","email":"jacek.tomasiak@gmail.com","username":"skazi"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":20312,"name":"Jacek Tomasiak","email":"jacek.tomasiak@gmail.com","username":"skazi"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},{"_account_id":20312,"name":"Jacek Tomasiak","email":"jacek.tomasiak@gmail.com","username":"skazi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-02-13 15:27:48.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2018-02-13 16:44:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-02-18 14:36:33.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"},{"updated":"2018-03-06 09:51:46.000000000","updated_by":{"_account_id":20312,"name":"Jacek Tomasiak","email":"jacek.tomasiak@gmail.com","username":"skazi"},"reviewer":{"_account_id":20312,"name":"Jacek Tomasiak","email":"jacek.tomasiak@gmail.com","username":"skazi"},"state":"REVIEWER"}],"messages":[{"id":"48906a0e5342d30a20836a041ada750a1037860d","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2018-02-13 15:25:13.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"ae6e1fa7559817a2d6880a8322f0099a4e8741d3","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2018-02-13 15:27:48.000000000","message":"Patch Set 1: Code-Review-1\n\nI don\u0027t think this is appropriate as a stable branch backport since it changes the behavior of the CLI. If you want to list all servers, then pass --limit -1.","accounts_in_message":[],"_revision_number":1},{"id":"1f379a890ed1910e1a7d2c8e2b54dbde8d089c4a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-13 16:44:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/68/543968/1/check/openstack-tox-pep8/1404068/ : SUCCESS in 3m 01s\n- openstack-tox-py27 http://logs.openstack.org/68/543968/1/check/openstack-tox-py27/2cf4a24/ : SUCCESS in 3m 07s\n- openstack-tox-py35 http://logs.openstack.org/68/543968/1/check/openstack-tox-py35/4d9ada9/ : SUCCESS in 3m 33s\n- build-openstack-sphinx-docs http://logs.openstack.org/68/543968/1/check/build-openstack-sphinx-docs/8f79e6b/html/ : SUCCESS in 2m 51s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/68/543968/1/check/legacy-tempest-dsvm-neutron-src/dd9210e/ : SUCCESS in 1h 15m 57s\n- novaclient-dsvm-functional http://logs.openstack.org/68/543968/1/check/novaclient-dsvm-functional/97b2fa5/ : SUCCESS in 47m 45s","accounts_in_message":[],"_revision_number":1},{"id":"fceaedf56939a35553515ffba12b6e4d68ab07e2","author":{"_account_id":20312,"name":"Jacek Tomasiak","email":"jacek.tomasiak@gmail.com","username":"skazi"},"date":"2018-02-14 10:27:34.000000000","message":"Patch Set 1:\n\n\u003e I don\u0027t think this is appropriate as a stable branch backport since\n \u003e it changes the behavior of the CLI. If you want to list all\n \u003e servers, then pass --limit -1.\n\nThe --limit -1 doesn\u0027t work without this fix either.","accounts_in_message":[],"_revision_number":1},{"id":"f4e7a5d1eafaa36d72e0824b3dd7c401c0ab549e","author":{"_account_id":20312,"name":"Jacek Tomasiak","email":"jacek.tomasiak@gmail.com","username":"skazi"},"date":"2018-02-14 10:27:42.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"2b4bc370b9f44f5028640addea458c6b22f1e2d8","author":{"_account_id":20312,"name":"Jacek Tomasiak","email":"jacek.tomasiak@gmail.com","username":"skazi"},"date":"2018-02-16 09:26:22.000000000","message":"Patch Set 1:\n\nLet me explain why I think the backport should be accepted.\n\nThe \"behavior change\" here is actually rather \"fix of known bug documented in the help text\". If it wasn\u0027t described in the help text there would be nothing stopping us from merging this backport?\nThe loop which was supposed to run multiple queries until all VMs were listed was already there. It was just broken and never ran more than one time. It worked the same (wrong) for `nova list` and `nova list --limit -1`.\nThe result of this bug was that the list of VMs was cut off at the `max_limit` level without any hint for the user that there are more entries in the DB. I think it\u0027s quite unlikely that someone would rely on that behavior.","accounts_in_message":[],"_revision_number":1},{"id":"3a16016a58e329b38a2dad7731ca486eb97c7f98","author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"date":"2018-02-16 10:14:59.000000000","message":"Patch Set 1:\n\n\u003e I think it\u0027s quite unlikely that someone would rely on that behavior.\n\nYou underestimate what people do with publicly available officially supported clients.","accounts_in_message":[],"_revision_number":1},{"id":"e58a89335f022590761d15045d73b426f306b757","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2018-02-18 14:36:33.000000000","message":"Patch Set 1:\n\n@Jacek:\n\n\u003e It worked the same (wrong) for `nova list` and `nova list --limit -1`.\n\nPlease explain how `limit -1` was broken. It looks like this patch doesn\u0027t affect `limit -1` at all.","accounts_in_message":[],"_revision_number":1},{"id":"2e4f879bc864187c5403355ef770b34b8f258e78","author":{"_account_id":20312,"name":"Jacek Tomasiak","email":"jacek.tomasiak@gmail.com","username":"skazi"},"date":"2018-03-06 09:51:46.000000000","message":"Patch Set 1: -Code-Review\n\n\u003e @Jacek:\n \u003e \n \u003e \u003e It worked the same (wrong) for `nova list` and `nova list --limit\n \u003e -1`.\n \u003e \n \u003e Please explain how `limit -1` was broken. It looks like this patch\n \u003e doesn\u0027t affect `limit -1` at all.\n\nI\u0027m not sure how this happened but I can\u0027t reproduce the problem now. It seems to work as expected with `--limit -1`.","accounts_in_message":[],"_revision_number":1},{"id":"5604ef13d6ffeaea561b8c1fa3cb3963ce8253a4","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2018-04-18 20:40:28.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2a4fe7d1b109b1e470320f59a9e9dd3323ab35f2","revisions":{"2a4fe7d1b109b1e470320f59a9e9dd3323ab35f2":{"kind":"REWORK","_number":1,"created":"2018-02-13 15:25:13.000000000","uploader":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"ref":"refs/changes/68/543968/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/68/543968/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/543968/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/543968/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/543968/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/68/543968/1"}}},"commit":{"parents":[{"commit":"b3553f2eef9187de83ddeb0606c2e8aa14c298aa","subject":"Update UPPER_CONSTRAINTS_FILE for stable/queens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b3553f2eef9187de83ddeb0606c2e8aa14c298aa"}]}],"author":{"name":"Jacek Tomasiak","email":"jacek.tomasiak@gmail.com","date":"2018-01-16 10:09:26.000000000","tz":60},"committer":{"name":"Boris Bobrov","email":"breton@cynicmansion.ru","date":"2018-02-13 15:25:13.000000000","tz":0},"subject":"Fix listing of instances above API max_limit","message":"Fix listing of instances above API max_limit\n\nOutput of `nova list` command contained only `max_limit` entries even\nwhen there were more. The list needs to be obtained in multiple\nrequests and the paging loop was terminated prematurely.\n\nChange-Id: I4194e6d5e34ecc0ac704851c08bb895e223aa850\nCloses-Bug: 1743532\n(cherry picked from commit eff607ccef91d09052d58f6798f68d67404f51ce)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2a4fe7d1b109b1e470320f59a9e9dd3323ab35f2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2a4fe7d1b109b1e470320f59a9e9dd3323ab35f2"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}