)]}'
{"id":"openstack%2Fpython-novaclient~546543","triplet_id":"openstack%2Fpython-novaclient~master~Id4b47eeae1d3e86a3cb259c32fcb376ffbd3f8c7","project":"openstack/python-novaclient","branch":"master","hashtags":[],"change_id":"Id4b47eeae1d3e86a3cb259c32fcb376ffbd3f8c7","subject":"Clean imports in code","status":"MERGED","created":"2018-02-21 09:11:36.000000000","updated":"2018-02-22 05:52:56.000000000","submitted":"2018-02-22 05:52:56.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"546543-1519278776810-012d3a75","meta_rev_id":"6fa44e3a21e6a286634b57a1324019c4adbbc291","_number":546543,"virtual_id_number":546543,"owner":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2018-02-22 05:52:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"all":[{"value":2,"date":"2018-02-22 04:38:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":2,"date":"2018-02-21 15:25:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"all":[{"value":1,"date":"2018-02-22 04:38:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-02-21 15:25:55.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2018-02-22 04:38:46.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2018-02-22 05:52:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"23edf3ade7802465c2d387e1cd948517175fde67","author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"date":"2018-02-21 09:11:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"eef13439afa1a7bb0721c84b13cac89e554acad4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-21 10:31:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/43/546543/1/check/openstack-tox-pep8/313a241/ : SUCCESS in 3m 07s\n- openstack-tox-py27 http://logs.openstack.org/43/546543/1/check/openstack-tox-py27/2de1d91/ : SUCCESS in 3m 06s\n- openstack-tox-py35 http://logs.openstack.org/43/546543/1/check/openstack-tox-py35/f85747e/ : SUCCESS in 3m 47s\n- build-openstack-sphinx-docs http://logs.openstack.org/43/546543/1/check/build-openstack-sphinx-docs/94871fe/html/ : SUCCESS in 2m 28s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/43/546543/1/check/legacy-tempest-dsvm-neutron-src/422099f/ : SUCCESS in 1h 17m 05s\n- novaclient-dsvm-functional http://logs.openstack.org/43/546543/1/check/novaclient-dsvm-functional/628539a/ : SUCCESS in 45m 20s","accounts_in_message":[],"_revision_number":1},{"id":"bdc2d6288625409b516ad42ff8efa560f076413d","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2018-02-21 15:25:55.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a619b8fe275d8c1c0a32d78859c5153314c5e017","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2018-02-22 04:38:46.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2\n\nlgtm","accounts_in_message":[],"_revision_number":1},{"id":"c463e8e6d4b1890db416824061123c242810a2e4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-22 04:38:57.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"3adcb3264cae0938bb44b52aa4077f759a1cac5f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-22 05:52:56.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"6fa44e3a21e6a286634b57a1324019c4adbbc291","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-22 05:52:56.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/43/546543/1/gate/openstack-tox-pep8/cdcf4f6/ : SUCCESS in 2m 45s\n- openstack-tox-py27 http://logs.openstack.org/43/546543/1/gate/openstack-tox-py27/98b1ebc/ : SUCCESS in 3m 52s\n- openstack-tox-py35 http://logs.openstack.org/43/546543/1/gate/openstack-tox-py35/d1fc562/ : SUCCESS in 3m 12s\n- build-openstack-sphinx-docs http://logs.openstack.org/43/546543/1/gate/build-openstack-sphinx-docs/6137007/html/ : SUCCESS in 3m 19s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/43/546543/1/gate/legacy-tempest-dsvm-neutron-src/4695615/ : SUCCESS in 1h 12m 43s\n- novaclient-dsvm-functional http://logs.openstack.org/43/546543/1/gate/novaclient-dsvm-functional/e925ed5/ : SUCCESS in 53m 49s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"bc4f9195adf196bf4d0fabc4baa98809cdf9430f","revisions":{"bc4f9195adf196bf4d0fabc4baa98809cdf9430f":{"kind":"REWORK","_number":1,"created":"2018-02-21 09:11:36.000000000","uploader":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"ref":"refs/changes/43/546543/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/43/546543/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/43/546543/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/43/546543/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/43/546543/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/43/546543/1"}}},"commit":{"parents":[{"commit":"1bdf8c65d9ea1e812444aeb87bb17405bdc1172d","subject":"Merge \"Remove 2 redundant methods\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/1bdf8c65d9ea1e812444aeb87bb17405bdc1172d"}]}],"author":{"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","date":"2018-02-21 08:49:49.000000000","tz":420},"committer":{"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","date":"2018-02-21 09:09:51.000000000","tz":420},"subject":"Clean imports in code","message":"Clean imports in code\n\nIn some part in the code we import objects. In the Openstack style guidelines\nthey recommend to import only modules. [1]: \"Do not import objects, only modules\".\n\n[1] https://docs.openstack.org/hacking/0.10.3/\n\nChange-Id: Id4b47eeae1d3e86a3cb259c32fcb376ffbd3f8c7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/bc4f9195adf196bf4d0fabc4baa98809cdf9430f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/bc4f9195adf196bf4d0fabc4baa98809cdf9430f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}