)]}'
{"novaclient/base.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"71477b8281108e778f266e3f515973cb01b55bcc","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        try:"},{"line_number":115,"context_line":"            os.makedirs(cache_dir, 0755)"},{"line_number":116,"context_line":"        except OSError as e:"},{"line_number":117,"context_line":"            # NOTE(kiall): This is typicaly either permission denied while"},{"line_number":118,"context_line":"            #              attempting to create the directory, or the directory"},{"line_number":119,"context_line":"            #              already exists. Either way, don\u0027t fail."},{"line_number":120,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAE3%2F%2F7sA%3D","line":117,"updated":"2012-03-21 16:07:54.000000000","message":"femtonit: \"typically\"","commit_id":"39e252ad056ff65c7c326095938deb1eb50c4b40"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"2a7357d4994c42a1498650e87a501da9ecb20450","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        try:"},{"line_number":115,"context_line":"            os.makedirs(cache_dir, 0755)"},{"line_number":116,"context_line":"        except OSError as e:"},{"line_number":117,"context_line":"            # NOTE(kiall): This is typicaly either permission denied while"},{"line_number":118,"context_line":"            #              attempting to create the directory, or the directory"},{"line_number":119,"context_line":"            #              already exists. Either way, don\u0027t fail."},{"line_number":120,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAE3%2F%2F7bY%3D","line":117,"in_reply_to":"AAAAE3%2F%2F7sA%3D","updated":"2012-03-22 00:32:12.000000000","message":"Heh - Too late now... Hopefully someone will fix it on the next edit of this file ;)","commit_id":"39e252ad056ff65c7c326095938deb1eb50c4b40"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"6f3ab27643cf10db06b9ff6ca357a2944c3e2dbb","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            # NOTE(kiall): This is typicaly either permission denied while"},{"line_number":118,"context_line":"            #              attempting to create the directory, or the directory"},{"line_number":119,"context_line":"            #              already exists. Either way, don\u0027t fail."},{"line_number":120,"context_line":"            pass"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        resource \u003d obj_class.__name__.lower()"},{"line_number":123,"context_line":"        filename \u003d \"%s-%s-cache\" % (resource, cache_type.replace(\u0027_\u0027, \u0027-\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAE3%2F%2F7wM%3D","line":120,"updated":"2012-03-21 13:00:49.000000000","message":"return?","commit_id":"39e252ad056ff65c7c326095938deb1eb50c4b40"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"71477b8281108e778f266e3f515973cb01b55bcc","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            # NOTE(kiall): This is typicaly either permission denied while"},{"line_number":118,"context_line":"            #              attempting to create the directory, or the directory"},{"line_number":119,"context_line":"            #              already exists. Either way, don\u0027t fail."},{"line_number":120,"context_line":"            pass"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        resource \u003d obj_class.__name__.lower()"},{"line_number":123,"context_line":"        filename \u003d \"%s-%s-cache\" % (resource, cache_type.replace(\u0027_\u0027, \u0027-\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAE3%2F%2F7r0%3D","line":120,"in_reply_to":"AAAAE3%2F%2F7wM%3D","updated":"2012-03-21 16:07:54.000000000","message":"Why return?  If the directory exists, we want to continue.  If the directory doesn\u0027t exist, the open() below will raise IOError, the cache won\u0027t be set, and nothing happens, which is the desired result.\n\nAlso, this function is a generator, because of the yield; if we were to simply \"return\" here, the caller would get a StopIteration exception thrown, and likely wouldn\u0027t progress to actually executing the requested command, thus failing to address the original bug: failure to create cache directory or cache should not inhibit function.","commit_id":"39e252ad056ff65c7c326095938deb1eb50c4b40"}]}