)]}'
{"id":"openstack%2Fpython-novaclient~561772","triplet_id":"openstack%2Fpython-novaclient~master~I426895467dfa693214f78b495d82e730f4307b9d","project":"openstack/python-novaclient","branch":"master","topic":"fix_comment","hashtags":[],"change_id":"I426895467dfa693214f78b495d82e730f4307b9d","subject":"Fix comments in novaclient/tests/unit/fakes.py","status":"MERGED","created":"2018-04-17 02:40:30.000000000","updated":"2018-04-17 18:07:57.000000000","submitted":"2018-04-17 18:07:57.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"561772-1523988477496-ab0fbd82","meta_rev_id":"ff6eb7ffcad4bc1124f0f3f9550f981ce282c0f4","_number":561772,"virtual_id_number":561772,"owner":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2018-04-17 18:07:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":2,"date":"2018-04-17 04:24:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2018-04-17 03:05:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":2,"date":"2018-04-17 16:51:35.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":1,"date":"2018-04-17 16:51:35.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-04-17 03:05:55.000000000","updated_by":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"reviewer":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"state":"REVIEWER"},{"updated":"2018-04-17 04:24:32.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2018-04-17 16:51:35.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2018-04-17 18:07:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1011fcca3f25bb181bd3dd3608ee910bb61dfe51","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2018-04-17 02:40:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"00cf7b11fa75085f6a0e01c18e8e5e480f47899c","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2018-04-17 03:05:55.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"8897dfa4e558c441e6ca632392810d589ab45dcd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-17 03:57:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/72/561772/1/check/openstack-tox-pep8/42e5577/ : SUCCESS in 3m 27s\n- openstack-tox-py27 http://logs.openstack.org/72/561772/1/check/openstack-tox-py27/8218ba9/ : SUCCESS in 3m 11s\n- openstack-tox-py35 http://logs.openstack.org/72/561772/1/check/openstack-tox-py35/74d12b3/ : SUCCESS in 3m 38s\n- build-openstack-sphinx-docs http://logs.openstack.org/72/561772/1/check/build-openstack-sphinx-docs/f2765d1/html/ : SUCCESS in 2m 42s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/72/561772/1/check/legacy-tempest-dsvm-neutron-src/59b26c5/ : SUCCESS in 1h 15m 23s\n- novaclient-dsvm-functional http://logs.openstack.org/72/561772/1/check/novaclient-dsvm-functional/a1ee62a/ : SUCCESS in 52m 14s\n- openstack-tox-lower-constraints http://logs.openstack.org/72/561772/1/check/openstack-tox-lower-constraints/52dd00a/ : SUCCESS in 4m 08s","accounts_in_message":[],"_revision_number":1},{"id":"8f543d0a1c3f0eb9ac65480eec8e1eed10ca88de","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2018-04-17 04:24:32.000000000","message":"Patch Set 1: Code-Review+2\n\nThis is indeed a trivial fix, but I wonder if it could be bundled with some other change.  I\u0027ll +2, but I have to admit to some reservations over code churn…","accounts_in_message":[],"_revision_number":1},{"id":"9b14ae4e692d6d9731043f87056c1e933881ff48","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2018-04-17 16:51:35.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b9750983c0d91d1c108337d9f231ea0131a41e67","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-17 16:51:47.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"55ee17560134c2969603aafa0cf4d4b550be048f","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2018-04-17 16:52:12.000000000","message":"Patch Set 1:\n\nI assume Takashi noticed this when working on https://review.openstack.org/#/c/561520/ and if he would have changed it in that patch, he would run the risk of someone pointing out it\u0027s an unrelated change and should be split out.","accounts_in_message":[],"_revision_number":1},{"id":"78d62bc0ffee595029ff78e053c12270c485749f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-17 18:07:57.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"d21cb5799fbf2cd8d0bcae8e67427892974c47d1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-17 18:07:57.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/72/561772/1/gate/openstack-tox-pep8/1b848b0/ : SUCCESS in 3m 37s\n- openstack-tox-py27 http://logs.openstack.org/72/561772/1/gate/openstack-tox-py27/85c3001/ : SUCCESS in 4m 18s\n- openstack-tox-py35 http://logs.openstack.org/72/561772/1/gate/openstack-tox-py35/d100fda/ : SUCCESS in 3m 42s\n- build-openstack-sphinx-docs http://logs.openstack.org/72/561772/1/gate/build-openstack-sphinx-docs/9a2a163/html/ : SUCCESS in 3m 31s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/72/561772/1/gate/legacy-tempest-dsvm-neutron-src/9e2164a/ : SUCCESS in 1h 13m 57s\n- novaclient-dsvm-functional http://logs.openstack.org/72/561772/1/gate/novaclient-dsvm-functional/ef551e8/ : SUCCESS in 1h 00m 22s\n- openstack-tox-lower-constraints http://logs.openstack.org/72/561772/1/gate/openstack-tox-lower-constraints/7edfe6a/ : SUCCESS in 4m 10s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"936b5a572d43c7694e3534c52331c2658cd04b40","revisions":{"936b5a572d43c7694e3534c52331c2658cd04b40":{"kind":"REWORK","_number":1,"created":"2018-04-17 02:40:30.000000000","uploader":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"ref":"refs/changes/72/561772/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/72/561772/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/72/561772/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/72/561772/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/72/561772/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/72/561772/1"}}},"commit":{"parents":[{"commit":"69d41135a043c0c27fc4bad869266a928a38ea2c","subject":"Merge \"Replace GB with GiB\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/69d41135a043c0c27fc4bad869266a928a38ea2c"}]}],"author":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2018-04-17 02:35:20.000000000","tz":540},"committer":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2018-04-17 02:38:03.000000000","tz":540},"subject":"Fix comments in novaclient/tests/unit/fakes.py","message":"Fix comments in novaclient/tests/unit/fakes.py\n\nReplace \u0027Assert than\u0027 with \u0027Assert that\u0027.\n\nTrivialFix\nChange-Id: I426895467dfa693214f78b495d82e730f4307b9d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/936b5a572d43c7694e3534c52331c2658cd04b40"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/936b5a572d43c7694e3534c52331c2658cd04b40"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
