)]}'
{"novaclient/tests/functional/v2/test_instance_action.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"84d0585a3ffe5b34713c2890b025068c72da87e0","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                         (before_stop, stop_output, create_output))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"class TestInstanceActionCLIV262(TestInstanceActionCLIV258, base.TenantTestBase):"},{"line_number":119,"context_line":"    \"\"\"Instance action functional tests for v2.62 nova-api microversion.\"\"\""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    COMPUTE_API_VERSION \u003d \"2.62\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_98b6dfdc","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":80},"updated":"2018-04-27 06:45:53.000000000","message":"It should be wrapped within 79 characters.","commit_id":"6865a9176d682d72f1ba30f770d2a5ffdf5aff3b"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"0ed3d35e27dec7f3904e3c72f0c06365de9f915d","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                         (before_stop, stop_output, create_output))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"class TestInstanceActionCLIV262(TestInstanceActionCLIV258, base.TenantTestBase):"},{"line_number":119,"context_line":"    \"\"\"Instance action functional tests for v2.62 nova-api microversion.\"\"\""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    COMPUTE_API_VERSION \u003d \"2.62\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_be9e2bb6","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":80},"in_reply_to":"9f6a8fd7_98b6dfdc","updated":"2018-04-27 07:37:05.000000000","message":"Done","commit_id":"6865a9176d682d72f1ba30f770d2a5ffdf5aff3b"},{"author":{"_account_id":15834,"name":"Tomi Juvonen","email":"tomi.juvonen@nokia.com","username":"tojuvone"},"change_message_id":"509a426f89c65ab32d2894dbda60855d1e43a416","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        output \u003d self.nova(\"instance-action-list %s\" % server.id)"},{"line_number":127,"context_line":"        # NOTE(andreykurilin): output is not a single row table, so we can"},{"line_number":128,"context_line":"        #   obtain just \"create\" action. It should be enough for testing"},{"line_number":129,"context_line":"        #   \"nova instance-action \u003cserver\u003e \u003crequest-id\u003e\" command"},{"line_number":130,"context_line":"        request_id \u003d self._get_column_value_from_single_row_table("},{"line_number":131,"context_line":"            output, \"Request_ID\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_78442b1c","line":128,"range":{"start_line":128,"start_character":10,"end_line":128,"end_character":12},"updated":"2018-04-27 05:35:29.000000000","message":"Nit, Extra white space here and the following line.","commit_id":"6865a9176d682d72f1ba30f770d2a5ffdf5aff3b"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"0ed3d35e27dec7f3904e3c72f0c06365de9f915d","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        output \u003d self.nova(\"instance-action-list %s\" % server.id)"},{"line_number":127,"context_line":"        # NOTE(andreykurilin): output is not a single row table, so we can"},{"line_number":128,"context_line":"        #   obtain just \"create\" action. It should be enough for testing"},{"line_number":129,"context_line":"        #   \"nova instance-action \u003cserver\u003e \u003crequest-id\u003e\" command"},{"line_number":130,"context_line":"        request_id \u003d self._get_column_value_from_single_row_table("},{"line_number":131,"context_line":"            output, \"Request_ID\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_5ea34f01","line":128,"range":{"start_line":128,"start_character":10,"end_line":128,"end_character":12},"in_reply_to":"9f6a8fd7_78442b1c","updated":"2018-04-27 07:37:05.000000000","message":"Done","commit_id":"6865a9176d682d72f1ba30f770d2a5ffdf5aff3b"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"84d0585a3ffe5b34713c2890b025068c72da87e0","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        output \u003d self.nova(\"instance-action %s %s\" % (server.id, request_id))"},{"line_number":134,"context_line":"        # The microversion 2.62 adds ``host`` (hostname) and ``hostId`` (an"},{"line_number":135,"context_line":"        # obfuscated hashed host id string) fields to action event."},{"line_number":136,"context_line":"        self.assertIn(\"\u0027host\u0027\", output)"},{"line_number":137,"context_line":"        self.assertIn(\"\u0027hostId\u0027\", output)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_8381944d","line":136,"range":{"start_line":136,"start_character":7,"end_line":136,"end_character":39},"updated":"2018-04-27 06:45:53.000000000","message":"The \u0027host\u0027 parameter is not included by default when non-admin users call the API.\nAre you going to add the test using \u0027another_nova\u0027?","commit_id":"6865a9176d682d72f1ba30f770d2a5ffdf5aff3b"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"0ed3d35e27dec7f3904e3c72f0c06365de9f915d","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        output \u003d self.nova(\"instance-action %s %s\" % (server.id, request_id))"},{"line_number":134,"context_line":"        # The microversion 2.62 adds ``host`` (hostname) and ``hostId`` (an"},{"line_number":135,"context_line":"        # obfuscated hashed host id string) fields to action event."},{"line_number":136,"context_line":"        self.assertIn(\"\u0027host\u0027\", output)"},{"line_number":137,"context_line":"        self.assertIn(\"\u0027hostId\u0027\", output)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_1eadd7e9","line":136,"range":{"start_line":136,"start_character":7,"end_line":136,"end_character":39},"in_reply_to":"9f6a8fd7_8381944d","updated":"2018-04-27 07:37:05.000000000","message":"Yes, sure. you can see I add the TenantTestBase, but I didn\u0027t found a way to create a server with non-admin user.\n\nAnd now I found we can use something like:\n    # Create server with non-admin user\n    server \u003d self.another_nova(\u0027boot --flavor %s --image %s --poll %s\u0027 %\n                               (self.flavor.name, self.image.name, name))\n\nSo, I will update soon.","commit_id":"6865a9176d682d72f1ba30f770d2a5ffdf5aff3b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7e977f8c87221532c1c229f46482377f38833426","unresolved":false,"context_lines":[{"line_number":65,"context_line":"class TestInstanceActionCLIV258(TestInstanceActionCLI):"},{"line_number":66,"context_line":"    \"\"\"Instance action functional tests for v2.58 nova-api microversion.\"\"\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    COMPUTE_API_VERSION \u003d \"2.58\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_list_instance_action_with_marker_and_limit(self):"},{"line_number":71,"context_line":"        server \u003d self._create_server()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_7c3f3687","line":68,"updated":"2018-04-27 13:48:55.000000000","message":"It would probably be good to assert that the responses before 2.62 don\u0027t include \u0027host\u0027 or \u0027hostId\u0027. That could go into either of the existing tests in here, but could also be done in a follow up patch.","commit_id":"5483be7fe74a90e3a38428cfb436864ffeee4c54"}]}