)]}'
{"id":"openstack%2Fpython-novaclient~564702","triplet_id":"openstack%2Fpython-novaclient~master~Ic2463fc2ec5c26d1f3375f635455c9d2438f27cf","project":"openstack/python-novaclient","branch":"master","topic":"bug/1767272","hashtags":[],"change_id":"Ic2463fc2ec5c26d1f3375f635455c9d2438f27cf","subject":"api_version decorator becomes an error in Python 3.5.0.","status":"ABANDONED","created":"2018-04-27 08:39:07.000000000","updated":"2018-07-27 08:24:06.000000000","total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"45393e410b84d0faa7610fe7dbc026691f03ca84","_number":564702,"virtual_id_number":564702,"owner":{"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":15637,"name":"Dmitry Ratushnyy","email":"d.ratushnyy@gmail.com","username":"dratushnyy"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"date":"2018-06-06 02:57:22.000000000","_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},{"value":1,"date":"2018-05-09 06:23:10.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":1,"date":"2018-05-10 05:38:36.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":15637,"name":"Dmitry Ratushnyy","email":"d.ratushnyy@gmail.com","username":"dratushnyy"},{"value":-1,"date":"2018-05-09 13:47:04.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":-2,"date":"2018-06-05 09:55:26.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":15637,"name":"Dmitry Ratushnyy","email":"d.ratushnyy@gmail.com","username":"dratushnyy"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":15637,"name":"Dmitry Ratushnyy","email":"d.ratushnyy@gmail.com","username":"dratushnyy"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":15637,"name":"Dmitry Ratushnyy","email":"d.ratushnyy@gmail.com","username":"dratushnyy"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-04-27 08:39:17.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2018-05-08 18:41:57.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2018-05-09 06:23:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-05-09 13:47:04.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2018-05-10 05:38:36.000000000","updated_by":{"_account_id":15637,"name":"Dmitry Ratushnyy","email":"d.ratushnyy@gmail.com","username":"dratushnyy"},"reviewer":{"_account_id":15637,"name":"Dmitry Ratushnyy","email":"d.ratushnyy@gmail.com","username":"dratushnyy"},"state":"REVIEWER"},{"updated":"2018-06-05 09:55:26.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"}],"messages":[{"id":"6c5e1f85fcd528d9ba1599adc09660debb41bc59","author":{"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},"date":"2018-04-27 08:39:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"09b453473ecc8d4a4ae21877e6dc398bf514e606","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2018-04-27 08:39:17.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\n    Your patch will now be tested automatically by OpenStack testing frameworks\n    and once the automatic tests pass, it will be reviewed by other friendly\n    developers. They will give you feedback and may require you to refine it.\n\n    People seldom get their patch approved on the first try, so don\u0027t be\n    concerned if requested to make corrections. Feel free to modify your patch\n    and resubmit a new change-set.\n\n    Patches usually take 3 to 7 days to be reviewed so be patient and be\n    available on IRC to ask and answer questions about your work. Also it\n    takes generally at least a couple of weeks for cores to get around to\n    reviewing code. The more you participate in the community the more\n    rewarding it is for you. You may also notice that the more you get to know\n    people and get to be known, the faster your patches will be reviewed and\n    eventually approved. Get to know others and become known by doing code\n    reviews: anybody can do it, and it\u0027s a great way to learn the code base.\n\n    Thanks again for supporting OpenStack, we look forward to working with you.\n\n    IRC: https://wiki.openstack.org/wiki/IRC\n    Workflow: http://docs.openstack.org/infra/manual/developers.html\n    Commit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"9c2e231c69553cbc60ce5505e1d41d894ccae422","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-27 09:06:19.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/02/564702/1/check/openstack-tox-pep8/c9a4636/ : FAILURE in 2m 31s\n- openstack-tox-py27 http://logs.openstack.org/02/564702/1/check/openstack-tox-py27/6947212/ : POST_FAILURE in 2m 48s\n- openstack-tox-py35 http://logs.openstack.org/02/564702/1/check/openstack-tox-py35/cfc90dd/ : POST_FAILURE in 2m 42s\n- build-openstack-sphinx-docs http://logs.openstack.org/02/564702/1/check/build-openstack-sphinx-docs/b459a91/ : FAILURE in 3m 04s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/02/564702/1/check/legacy-tempest-dsvm-neutron-src/708298f/ : FAILURE in 23m 36s\n- novaclient-dsvm-functional http://logs.openstack.org/02/564702/1/check/novaclient-dsvm-functional/25fd8de/ : FAILURE in 21m 03s\n- openstack-tox-lower-constraints http://logs.openstack.org/02/564702/1/check/openstack-tox-lower-constraints/a4ee57d/ : POST_FAILURE in 3m 52s","accounts_in_message":[],"_revision_number":1},{"id":"fbd9b3548619441f502387010524c42099f8f45d","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2018-04-27 14:21:43.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nCommit message needs some enhancement.  Also, there are test failures; please use the command \"tox\" to run the tests locally and address the failures…","accounts_in_message":[],"_revision_number":1},{"id":"7dab9424492ec1c53f32a91a2b19e88af5e3202e","author":{"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},"date":"2018-04-28 01:01:38.000000000","message":"Patch Set 1:\n\nSorry, I amend the code to as clear the test.","accounts_in_message":[],"_revision_number":1},{"id":"56f031e2836264457c72dde7a911e21ca386e8a8","author":{"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},"date":"2018-05-08 12:44:47.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2384fc0f83a7dee2d8d21dd7b2c9b0a2ab3b27ea","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2018-05-08 12:46:45.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a9b8e9671d3e67cd2cdb95c0687c9c41927230ce","author":{"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},"date":"2018-05-08 12:56:42.000000000","message":"Patch Set 2:\n\nSorry. It is about when the state of before change.","accounts_in_message":[],"_revision_number":2},{"id":"4aeafc28481f77c484a006a9186d6bfd1169dc6a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-08 14:18:43.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/02/564702/2/check/openstack-tox-pep8/392a943/ : SUCCESS in 3m 38s\n- openstack-tox-py27 http://logs.openstack.org/02/564702/2/check/openstack-tox-py27/8538007/ : SUCCESS in 3m 13s\n- openstack-tox-py35 http://logs.openstack.org/02/564702/2/check/openstack-tox-py35/260500f/ : SUCCESS in 3m 33s\n- build-openstack-sphinx-docs http://logs.openstack.org/02/564702/2/check/build-openstack-sphinx-docs/fdc66d6/html/ : SUCCESS in 3m 22s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/02/564702/2/check/legacy-tempest-dsvm-neutron-src/a73c745/ : SUCCESS in 1h 32m 43s\n- novaclient-dsvm-functional http://logs.openstack.org/02/564702/2/check/novaclient-dsvm-functional/c4c7d33/ : SUCCESS in 52m 21s\n- openstack-tox-lower-constraints http://logs.openstack.org/02/564702/2/check/openstack-tox-lower-constraints/c9a96fb/ : SUCCESS in 4m 11s","accounts_in_message":[],"_revision_number":2},{"id":"576451d32cbfd20ad4a7e688fe318dd8d64f495b","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2018-05-08 14:49:54.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nI don\u0027t see any tests.  A bug fix should include at least one regression test that would catch the reappearance of the fixed bug.\n\nAlso, I don\u0027t understand your answer to Matt Riedemann\u0027s question.  You seem to be saying that running the unit tests with Python 3.5.0, without this patch, would result in a test failure; however, Matt\u0027s pointing out that we\u0027ve already been running the unit tests, with Python 3.5 and without your patch, and haven\u0027t been seeing the error.  Could you go into details about why we\u0027re not seeing the error?  (That\u0027ll probably guide the creation of the test I ask for above.)","accounts_in_message":[],"_revision_number":2},{"id":"47d90f8659ddbdd2474092ee121c8b8116a671c9","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2018-05-08 18:41:57.000000000","message":"Patch Set 2: Code-Review-1\n\nCorrect. I can run \"tox -e py35\" without this change and everything passes so I don\u0027t understand why we need this, unless we just don\u0027t have coverage for this function, but if that\u0027s the case, then you should add a test for it to show the bug.","accounts_in_message":[],"_revision_number":2},{"id":"e38b568daae5e6ad32cfe0de7234a3049c3d0bfb","author":{"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},"date":"2018-05-09 01:19:59.000000000","message":"Patch Set 2:\n\nThank you for comment.\nBut, I think you should execute the \u0027tox -e py35\u0027 using the Python 3.5.0.\nWhen you execute \u0027tox -e py35\u0027, maybe you use the Python 3.5.1 or more.\n\nPython 3.5.0 has different from other versions(python 3.5.1 or more) the behavior of the traceback.\nThis problem is only python 3.5.0. It doesn\u0027t matter python3.5.1 or more.\n\nSo the user who doesn\u0027t use python 3.5.0 user has no problem.\nthey have succeeded the unit test.\nCI is using python 3.5.1, so the unit-test is succeeded.\nhttps://packages.ubuntu.com/en/xenial/python3","accounts_in_message":[],"_revision_number":2},{"id":"677b2d93a4cf58ee1075190b1f1e700ceb8edec5","author":{"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},"date":"2018-05-09 05:04:34.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"7839ff29f03f5d285e646b27c69dc8cd2677a560","author":{"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},"date":"2018-05-09 05:11:44.000000000","message":"Patch Set 3:\n\nIf you execute \u0027tox -e py35\u0027 using python 3.5.0, maybe you will get the result like below.\n\n$ python --version\nPython 3.5.0\n$ git clone https://git.openstack.org/openstack/python-novaclient\n\n$ tox -e py35\n... skip ...\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 2130 tests in 17.2834 sec.\n - Passed: 1937\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 193\nSum of execute time for each test: 42.2270 sec.\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nWorker Balance\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n - Worker 0 (524 tests) \u003d\u003e 0:00:09.662297\n - Worker 1 (535 tests) \u003d\u003e 0:00:12.682557\n - Worker 2 (543 tests) \u003d\u003e 0:00:11.122140\n - Worker 3 (528 tests) \u003d\u003e 0:00:11.684435\nERROR: InvocationError for command \u0027/bin/bash tools/pretty_tox.sh \u0027 (exited with code 1)\n_________________________________________________________________________________________________________________________________________ summary _________________________________________________________________________________________________________________________________________\nERROR:   py35: commands failed","accounts_in_message":[],"_revision_number":3},{"id":"88b976cf97d81f84d736cd29f788dfb30071b43a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-09 06:23:10.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/02/564702/3/check/openstack-tox-pep8/ecec5d3/ : SUCCESS in 3m 01s\n- openstack-tox-py27 http://logs.openstack.org/02/564702/3/check/openstack-tox-py27/66d8c06/ : SUCCESS in 3m 22s\n- openstack-tox-py35 http://logs.openstack.org/02/564702/3/check/openstack-tox-py35/4055e42/ : SUCCESS in 3m 16s\n- build-openstack-sphinx-docs http://logs.openstack.org/02/564702/3/check/build-openstack-sphinx-docs/ee1c0cb/html/ : SUCCESS in 3m 15s\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/02/564702/3/check/legacy-tempest-dsvm-neutron-src/2647e5c/ : SUCCESS in 1h 15m 12s\n- novaclient-dsvm-functional http://logs.openstack.org/02/564702/3/check/novaclient-dsvm-functional/6b7e9c7/ : SUCCESS in 54m 39s\n- openstack-tox-lower-constraints http://logs.openstack.org/02/564702/3/check/openstack-tox-lower-constraints/bd36937/ : SUCCESS in 3m 57s","accounts_in_message":[],"_revision_number":3},{"id":"8a08fa50cfcf608019d70a7dfe71e63a11289bfb","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2018-05-09 13:47:04.000000000","message":"Patch Set 3: Code-Review-1\n\nSo, it sounds like this change is about working around a bug in a single Python version release.  TBH, I think I\u0027d rather we document the incompatibility with 3.5.0, as we\u0027ll never be able to create a test that demonstrates the bug, and so someone will eventually try to simplify the code.\n\nThat said, -1 just because this is still missing that regression test…","accounts_in_message":[],"_revision_number":3},{"id":"e2f94c3139b2322acd01821f03cce5a259ca6a38","author":{"_account_id":15637,"name":"Dmitry Ratushnyy","email":"d.ratushnyy@gmail.com","username":"dratushnyy"},"date":"2018-05-10 05:38:36.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"aae6ed4f86f2860c6d91d13d783999c2c724f47a","author":{"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},"date":"2018-05-11 11:01:03.000000000","message":"Patch Set 3:\n\nSorry, I don\u0027t change the behavior. So, I think Unit-Test doesn\u0027t need to add the test case.\n\nCurrently, This bug is only Python3.5.0. But Another version(python3.6.5 or later) is likely to occur it too.\nif you took the solution that \u0027I think I\u0027d rather we document the incompatibility with 3.5.0\u0027 and If it occurs,\nyou have to write the comment \u0027the incompatibility with 3.x.x\u0027 every time.\nSo, I think that `traceback.extract_stack()[-4]` is not good.\nThe cause of the bug in current approach is \u0027-4\u0027.\n\nBut, My way isn\u0027t likely to occur it.\nBecause This change is referring to the argument of `func`. \nAnd This change doesn\u0027t need the comment it.\n\n\u003e So, it sounds like this change is about working around a bug in a\n \u003e single Python version release.  TBH, I think I\u0027d rather we document\n \u003e the incompatibility with 3.5.0, as we\u0027ll never be able to create a\n \u003e test that demonstrates the bug, and so someone will eventually try\n \u003e to simplify the code.\n \u003e \n \u003e That said, -1 just because this is still missing that regression\n \u003e test…","accounts_in_message":[],"_revision_number":3},{"id":"3c50508b3e9f62d715c58446efdb2ec6b26dda8a","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2018-05-11 12:34:35.000000000","message":"Patch Set 3:\n\nWell, one, you\u0027ve proposed this as a bug fix.  If there\u0027s a bug, then, if possible, we need a regression test for that bug.  That regression test should fail on Python 3.5.0 without your fix, and should pass with your fix.  This seems quite possible to me, so I want to see a regression test included with this change.\n\nTwo, the fact that this occurred only with Python 3.5.0 suggests to me that there was a bug in 3.5.0 that was fixed in 3.5.1, unless you can show me something from the Python developers saying that the behavior will be reintroduced in the future.  Thus, I\u0027m not 100% convinced that a fix is necessary, and I\u0027d suggest some form of write-up indicating that users of novaclient should avoid 3.5.0.  Since 3.5.0 is an old release by now, just documenting it somewhere (in the bug report, say) should be sufficient.  That doesn\u0027t mean, by the way, that I\u0027m opposed to this fix; my current -1 is just for the fact that this change, as currently proposed, lacks a regression test.  If you were to add a proper regression test, I would change my vote to +2.","accounts_in_message":[],"_revision_number":3},{"id":"6ac4ceecc5a89e4462c3a51a3a9d17714a67efef","author":{"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},"date":"2018-05-11 14:16:20.000000000","message":"Patch Set 3:\n\nThe current test cases are failing on Python 3.5.0 without my fix...\nDid you execute the test on Python 3.5.0?","accounts_in_message":[],"_revision_number":3},{"id":"cd9ebafca3b3c1c68d5610b3cf465eb5ed36a806","author":{"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},"date":"2018-05-11 14:20:43.000000000","message":"Patch Set 3:\n\nIf you executed the test on Python 3.5.0 without my fix, you got this likely result.\n\n$ tox -e py35\n... skip ...\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 2130 tests in 17.2834 sec.\n - Passed: 1937\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 193","accounts_in_message":[],"_revision_number":3},{"id":"e00b6d2b718405b9ccb008247bfe832c481439b4","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2018-06-05 09:55:26.000000000","message":"Patch Set 3: Code-Review-2\n\nhi Takahito and Team.\n\nI could not validate the issue myself (have only py3.5.5 env), so I checked changelog of python 3.5 releases.\nThe issue is valid and here is it - https://bugs.python.org/issue25108\n\nDespite the fact that issue is confirmed in python upstream, I strongly believe that we should not take care of old minor releases of python and suggest to use the latest one. Updating the installed python should solve the issue","accounts_in_message":[],"_revision_number":3},{"id":"afb40bce54c5982bdb53c957be771066b252f88d","author":{"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},"date":"2018-06-06 02:57:22.000000000","message":"Patch Set 3:\n\nI think too. I\u0027m always using Python 3.5.5 or more.\nI think that most important part of this is that specifying with magic number might cause a problem not only in Python 3.5 but in other future releases in Python.\nThis code can be used even if what magic number points in the traceback array have been changed.","accounts_in_message":[],"_revision_number":3},{"id":"78e9b104a1e4d8d88a034743b8035e72441db47e","author":{"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},"date":"2018-07-27 08:24:06.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"857555adc743b7054701496525e11b02e2559b72","revisions":{"cc56998cbf187f140fee2b18aa0a1cf5332d354e":{"kind":"REWORK","_number":1,"created":"2018-04-27 08:39:07.000000000","uploader":{"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},"ref":"refs/changes/02/564702/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/02/564702/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/564702/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/564702/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/564702/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/02/564702/1"}}},"commit":{"parents":[{"commit":"f4d927c358e22e899396004590f381278fde10ba","subject":"Trivial: Update pypi url to new url","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f4d927c358e22e899396004590f381278fde10ba"}]}],"author":{"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","date":"2018-04-27 08:38:25.000000000","tz":540},"committer":{"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","date":"2018-04-27 08:38:25.000000000","tz":540},"subject":"modified novaclient/api_versions.py When using python 3.5.0, [- 4] can not take information. Necessary information is in the [-5]. Because it better is using \u0027for loops\u0027.","message":"modified novaclient/api_versions.py\nWhen using python 3.5.0, [- 4] can not take information.\nNecessary information is in the [-5].\nBecause it better is using \u0027for loops\u0027.\n\nChange-Id: Ic2463fc2ec5c26d1f3375f635455c9d2438f27cf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/cc56998cbf187f140fee2b18aa0a1cf5332d354e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/cc56998cbf187f140fee2b18aa0a1cf5332d354e"}]},"branch":"refs/heads/master"},"a2e949f11a92016876509c0cde4f90c14733ba97":{"kind":"REWORK","_number":2,"created":"2018-05-08 12:44:47.000000000","uploader":{"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},"ref":"refs/changes/02/564702/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/02/564702/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/564702/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/564702/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/564702/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/02/564702/2"}}},"commit":{"parents":[{"commit":"460638436ebbdeaf240ee427a2e222c094f231e2","subject":"Make sure microversion \u003c 2.62 does not show host(Id) for instance actions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/460638436ebbdeaf240ee427a2e222c094f231e2"}]}],"author":{"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","date":"2018-05-08 11:58:56.000000000","tz":540},"committer":{"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","date":"2018-05-08 12:35:33.000000000","tz":540},"subject":"api_version decorator becomes an error in Python 3.5.0.","message":"api_version decorator becomes an error in Python 3.5.0.\n\nI changed that how to get the module name from `func` arguments.\n_get_function_name method needs the full function name which\nincludes module name, owner name(optional) and just function name.\nSo I don\u0027t change the program operation.\nIf you use the python 3.5.0 you got the failure of the unit test.\nOnly python3.5.0 has the full function name in not traceback.extract_stack()[-4]\nbut traceback.extract_stack()[-5].\n\nCloses-Bug: #1767272\nChange-Id: Ic2463fc2ec5c26d1f3375f635455c9d2438f27cf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a2e949f11a92016876509c0cde4f90c14733ba97"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a2e949f11a92016876509c0cde4f90c14733ba97"}]},"branch":"refs/heads/master"},"857555adc743b7054701496525e11b02e2559b72":{"kind":"REWORK","_number":3,"created":"2018-05-09 05:04:34.000000000","uploader":{"_account_id":28140,"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","username":"thirose"},"ref":"refs/changes/02/564702/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/02/564702/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/564702/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/564702/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/02/564702/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/02/564702/3"}}},"commit":{"parents":[{"commit":"460638436ebbdeaf240ee427a2e222c094f231e2","subject":"Make sure microversion \u003c 2.62 does not show host(Id) for instance actions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/460638436ebbdeaf240ee427a2e222c094f231e2"}]}],"author":{"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","date":"2018-05-08 11:58:56.000000000","tz":540},"committer":{"name":"Takahito Hirose","email":"takahito.hirose0518@gmail.com","date":"2018-05-09 05:00:48.000000000","tz":540},"subject":"api_version decorator becomes an error in Python 3.5.0.","message":"api_version decorator becomes an error in Python 3.5.0.\n\nThis change the behavior of `_get_ function_name` has not changed.\nI have changed that how to get the module name from `func` arguments.\n\nIf you use the python 3.5.0 you got the failure of the unit test.\nPython 3.5.0 has different from other versions(python 3.5.1 or more) the behavior of the traceback.\nOnly python3.5.0 has the full function name in not traceback.extract_stack()[-4]\nbut traceback.extract_stack()[-5].\n\nCloses-Bug: #1767272\nChange-Id: Ic2463fc2ec5c26d1f3375f635455c9d2438f27cf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/857555adc743b7054701496525e11b02e2559b72"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/857555adc743b7054701496525e11b02e2559b72"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}