)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"a6024ed0748413196ef6fdc984fff51e372dab9c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Removing --all-tenant from when doing nova list – tenant"},{"line_number":10,"context_line":"1d6799399ce34204a6d3970f20d7e529, which do not have"},{"line_number":11,"context_line":"any significance in it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2e12d45acce6c759b3b7e787a322bda568ff74e4"},{"line_number":14,"context_line":"Closes-Bug: #1468992"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"5f7c97a3_29971048","line":12,"updated":"2018-06-19 00:59:36.000000000","message":"Add \"Depends-On:\" tag for the patch in nova side.","commit_id":"370d0e29fcbe7845ddfeef980275d5be0a787f60"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5ac978c2833fb8d204efe65a84877a5abb728da1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Removing --all-tenant from when doing nova list – tenant"},{"line_number":10,"context_line":"1d6799399ce34204a6d3970f20d7e529, which do not have"},{"line_number":11,"context_line":"any significance in it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2e12d45acce6c759b3b7e787a322bda568ff74e4"},{"line_number":14,"context_line":"Closes-Bug: #1468992"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"5f7c97a3_15465e51","line":12,"in_reply_to":"5f7c97a3_29971048","updated":"2018-06-26 02:43:51.000000000","message":"Again, add the following line.\n\nDepends-On: https://review.openstack.org/577111/","commit_id":"370d0e29fcbe7845ddfeef980275d5be0a787f60"}],"novaclient/tests/functional/hooks/check_resources.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"dbef45a9d89b053bf3723694bb5c97852cb2eb8c","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        print(\"$ nova list --all-tenants\")"},{"line_number":25,"context_line":"        print(self.nova(\"list\", params\u003d\"--all-tenants\"))"},{"line_number":26,"context_line":"        print(\"\\n\")"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"if __name__ \u003d\u003d \"__main__\":"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_246569b5","side":"PARENT","line":26,"updated":"2018-05-31 14:06:45.000000000","message":"So, now, this does nothing, and potentially allows functional test resources to stick around without us being able to see them.  I\u0027m very uncomfortable with removing this section of code.","commit_id":"24bb7ea831032bddca8891bae54f7125221b69d0"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"b4de0ecc26ca094d6476a51b58852b7bdbd599ae","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        print(\"$ nova list --all-tenants\")"},{"line_number":25,"context_line":"        print(self.nova(\"list\", params\u003d\"--all-tenants\"))"},{"line_number":26,"context_line":"        print(\"\\n\")"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"if __name__ \u003d\u003d \"__main__\":"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_406ba4b5","side":"PARENT","line":26,"in_reply_to":"5f7c97a3_246569b5","updated":"2018-06-01 04:12:39.000000000","message":"Yeah I will update the prints back. Thanks","commit_id":"24bb7ea831032bddca8891bae54f7125221b69d0"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b7d5589d0b18d7418fd29d3d5193c527182c44e4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        self.setUp()"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        print(\"$ nova list\")"},{"line_number":25,"context_line":"        print(self.nova(\"list\"))"},{"line_number":26,"context_line":"        print(\"\\n\")"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_1ca742be","line":25,"updated":"2018-06-14 13:33:44.000000000","message":"Since we\u0027re now preserving --all-tenants, this change should be reverted.","commit_id":"e9ffe0e7ab25853cb5848e9447ee318e1fe60c15"}],"novaclient/tests/functional/v2/legacy/test_readonly_nova.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b7d5589d0b18d7418fd29d3d5193c527182c44e4","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.assertRaises(exceptions.CommandFailed,"},{"line_number":69,"context_line":"                          self.nova,"},{"line_number":70,"context_line":"                          \u0027list\u0027,"},{"line_number":71,"context_line":"                          params\u003d\u0027--all-tenants bad\u0027)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_admin_server_group_list(self):"},{"line_number":74,"context_line":"        self.nova(\u0027server-group-list\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_fc8fe62a","side":"PARENT","line":71,"updated":"2018-06-14 13:33:44.000000000","message":"We should continue to test --all-tenants functions.","commit_id":"7907528256439d02b555c976485ea85cc49fa14c"}],"novaclient/v2/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"4d0da3a982f532835869d6fee11f2c63ef50ab0b","unresolved":false,"context_lines":[{"line_number":1955,"context_line":""},{"line_number":1956,"context_line":"@utils.arg("},{"line_number":1957,"context_line":"    \u0027--all-tenants\u0027,"},{"line_number":1958,"context_line":"    dest\u003d\u0027all_tenants\u0027,"},{"line_number":1959,"context_line":"    action\u003d\u0027store_const\u0027,"},{"line_number":1960,"context_line":"    metavar\u003d\u0027\u003c0|1\u003e\u0027,"},{"line_number":1961,"context_line":"    const\u003d1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_c91d7374","line":1958,"updated":"2018-05-17 13:41:50.000000000","message":"Not needed; dest defaults to the appropriately massaged version of the argument name.","commit_id":"389d0ce2a31505369b531a1bc12e5acaddbd5f85"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"4d0da3a982f532835869d6fee11f2c63ef50ab0b","unresolved":false,"context_lines":[{"line_number":1957,"context_line":"    \u0027--all-tenants\u0027,"},{"line_number":1958,"context_line":"    dest\u003d\u0027all_tenants\u0027,"},{"line_number":1959,"context_line":"    action\u003d\u0027store_const\u0027,"},{"line_number":1960,"context_line":"    metavar\u003d\u0027\u003c0|1\u003e\u0027,"},{"line_number":1961,"context_line":"    const\u003d1,"},{"line_number":1962,"context_line":"    default\u003dint(strutils.bool_from_string("},{"line_number":1963,"context_line":"        os.environ.get(\"ALL_TENANTS\", \u0027false\u0027), True)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_09036b11","line":1960,"updated":"2018-05-17 13:41:50.000000000","message":"Frankly, I detest this convention.  In my opinion, --all-tenants should be a pure boolean option.  Given that this is action\u003d\u0027store_const\u0027, the metavar is irrelevant, btw.","commit_id":"389d0ce2a31505369b531a1bc12e5acaddbd5f85"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"4d0da3a982f532835869d6fee11f2c63ef50ab0b","unresolved":false,"context_lines":[{"line_number":1960,"context_line":"    metavar\u003d\u0027\u003c0|1\u003e\u0027,"},{"line_number":1961,"context_line":"    const\u003d1,"},{"line_number":1962,"context_line":"    default\u003dint(strutils.bool_from_string("},{"line_number":1963,"context_line":"        os.environ.get(\"ALL_TENANTS\", \u0027false\u0027), True)),"},{"line_number":1964,"context_line":"    help\u003d_(\u0027Stop server(s) in another tenant by name (Admin only).\u0027))"},{"line_number":1965,"context_line":"@utils.arg("},{"line_number":1966,"context_line":"    \u0027server\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_6c20ed9c","line":1963,"updated":"2018-05-17 13:41:50.000000000","message":"If we\u0027re going to get the default from the ALL_TENANTS environment variable, there needs to be a corresponding --no-all-tenants or something similar to turn the option off.","commit_id":"389d0ce2a31505369b531a1bc12e5acaddbd5f85"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"8c7f6cfed706ad6b3f41caec549b953a6db9144c","unresolved":false,"context_lines":[{"line_number":1595,"context_line":"        ]"},{"line_number":1596,"context_line":"        # If getting the data for all tenants, print"},{"line_number":1597,"context_line":"        # Tenant ID as well"},{"line_number":1598,"context_line":"        if search_opts[\u0027tenant_id\u0027] or search_opts[\u0027user_id\u0027]:"},{"line_number":1599,"context_line":"            columns.insert(2, \u0027Tenant ID\u0027)"},{"line_number":1600,"context_line":"        if search_opts[\u0027changes-since\u0027]:"},{"line_number":1601,"context_line":"            columns.append(\u0027Updated\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_c562663e","line":1598,"updated":"2018-06-13 15:34:45.000000000","message":"We will also want the Tenant ID field to be output if all_tenants is set.","commit_id":"6337c3ff36652fcb9a6654bf9079c61a71c1a569"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b7d5589d0b18d7418fd29d3d5193c527182c44e4","unresolved":false,"context_lines":[{"line_number":1384,"context_line":"    \u0027--all-tenants\u0027,"},{"line_number":1385,"context_line":"    action\u003d\u0027store_const\u0027,"},{"line_number":1386,"context_line":"    const\u003d1,"},{"line_number":1387,"context_line":"    default\u003d0,"},{"line_number":1388,"context_line":"    help\u003d_(\u0027Display information from all tenants (Admin only).\u0027))"},{"line_number":1389,"context_line":"@utils.arg("},{"line_number":1390,"context_line":"    \u0027--tenant\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_fc78462b","line":1387,"updated":"2018-06-14 13:33:44.000000000","message":"We should probably fully revert this change, including setting the default from the ALL_TENANTS environment variable.","commit_id":"e9ffe0e7ab25853cb5848e9447ee318e1fe60c15"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"b7d5589d0b18d7418fd29d3d5193c527182c44e4","unresolved":false,"context_lines":[{"line_number":1595,"context_line":"        ]"},{"line_number":1596,"context_line":"        # If getting the data for all tenants, print"},{"line_number":1597,"context_line":"        # Tenant ID as well"},{"line_number":1598,"context_line":"        if search_opts[\u0027all_tenants\u0027] or search_opts[\u0027tenant_id\u0027] or\\"},{"line_number":1599,"context_line":"                search_opts[\u0027user_id\u0027]:"},{"line_number":1600,"context_line":"            columns.insert(2, \u0027Tenant ID\u0027)"},{"line_number":1601,"context_line":"        if search_opts[\u0027changes-since\u0027]:"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_dcd0eaf9","line":1598,"updated":"2018-06-14 13:33:44.000000000","message":"Please use parentheses to avoid the need for a backslash here.  E.g.:\n\n    if (search_opts[\u0027all_tenants\u0027] or search_opts[\u0027tenant_id\u0027] or\n            search_opts[\u0027user_id\u0027]):\n        columns.insert(2, \u0027Tenant ID\u0027)\n\n(Note the indentation I used; that\u0027s to help visually distinguish the condition from the code branch.)","commit_id":"e9ffe0e7ab25853cb5848e9447ee318e1fe60c15"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"1f0a7dc5fd2c9a11225c9cae3acd86f6a211a277","unresolved":false,"context_lines":[{"line_number":1595,"context_line":"        ]"},{"line_number":1596,"context_line":"        # If getting the data for all tenants, print"},{"line_number":1597,"context_line":"        # Tenant ID as well"},{"line_number":1598,"context_line":"        if search_opts[\u0027all_tenants\u0027] or search_opts[\u0027tenant_id\u0027] or\\"},{"line_number":1599,"context_line":"                search_opts[\u0027user_id\u0027]:"},{"line_number":1600,"context_line":"            columns.insert(2, \u0027Tenant ID\u0027)"},{"line_number":1601,"context_line":"        if search_opts[\u0027changes-since\u0027]:"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_ad16e348","line":1598,"in_reply_to":"5f7c97a3_dcd0eaf9","updated":"2018-06-18 06:49:02.000000000","message":"Done","commit_id":"e9ffe0e7ab25853cb5848e9447ee318e1fe60c15"}]}
