)]}'
{"novaclient/shell.py":[{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"06520c4f2293f0c42525181e795619856d93d73e","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        parser.set_defaults("},{"line_number":276,"context_line":"            os_project_domain_name\u003dutils.env(\u0027OS_PROJECT_DOMAIN_NAME\u0027))"},{"line_number":277,"context_line":"        parser.set_defaults("},{"line_number":278,"context_line":"            os_project_domain_id\u003dutils.env(\u0027OS_USER_DOMAIN_ID\u0027))"},{"line_number":279,"context_line":"        parser.set_defaults("},{"line_number":280,"context_line":"            os_project_domain_name\u003dutils.env(\u0027OS_USER_DOMAIN_NAME\u0027))"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a557b826","line":278,"range":{"start_line":278,"start_character":12,"end_line":278,"end_character":32},"updated":"2018-06-07 02:19:21.000000000","message":"It should be os_user_domain_id.","commit_id":"a84b41ac6a5a04907776436ae9fd3cc12e910b99"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"06520c4f2293f0c42525181e795619856d93d73e","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        parser.set_defaults("},{"line_number":278,"context_line":"            os_project_domain_id\u003dutils.env(\u0027OS_USER_DOMAIN_ID\u0027))"},{"line_number":279,"context_line":"        parser.set_defaults("},{"line_number":280,"context_line":"            os_project_domain_name\u003dutils.env(\u0027OS_USER_DOMAIN_NAME\u0027))"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def get_base_parser(self, argv):"},{"line_number":283,"context_line":"        parser \u003d NovaClientArgumentParser("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_652f60a7","line":280,"range":{"start_line":280,"start_character":12,"end_line":280,"end_character":34},"updated":"2018-06-07 02:19:21.000000000","message":"It should be os_user_domain_name","commit_id":"a84b41ac6a5a04907776436ae9fd3cc12e910b99"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"85c25179c7e77efe19e818e79eeed91d7915fe1e","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        parser.set_defaults("},{"line_number":278,"context_line":"            os_user_domain_id\u003dutils.env(\u0027OS_USER_DOMAIN_ID\u0027))"},{"line_number":279,"context_line":"        parser.set_defaults("},{"line_number":280,"context_line":"            os_user_domain_name\u003dutils.env(\u0027OS_USER_DOMAIN_NAME\u0027))"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def get_base_parser(self, argv):"},{"line_number":283,"context_line":"        parser \u003d NovaClientArgumentParser("}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_88888c22","line":280,"updated":"2018-06-07 08:59:48.000000000","message":"Just a question:\nWhy isn\u0027t the default value of \u0027OS_USER_ID\u0027 set by the shell variable?","commit_id":"967bf06245f0c3097c79fd639a57c684346ff5f0"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"59b2893ba3484217124697ea1d24c6d42b69cfdc","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        parser.set_defaults("},{"line_number":278,"context_line":"            os_user_domain_id\u003dutils.env(\u0027OS_USER_DOMAIN_ID\u0027))"},{"line_number":279,"context_line":"        parser.set_defaults("},{"line_number":280,"context_line":"            os_user_domain_name\u003dutils.env(\u0027OS_USER_DOMAIN_NAME\u0027))"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def get_base_parser(self, argv):"},{"line_number":283,"context_line":"        parser \u003d NovaClientArgumentParser("}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_e893f2a1","line":280,"in_reply_to":"5f7c97a3_88888c22","updated":"2018-06-11 16:03:57.000000000","message":"Thanks Natsume san for review. Will add test case and upload patch soon.\n\nPlease refer [1] and [2], here they have listed minimum required OpenStack environment variables, and here OS_USER_ID is not listed.\n\nAlso verified for all supported authentication plugins provided by the keystoneclient library, there no one demanding for same, so not listing here.\n\nVerified for \u0027nova --os-auth-type rackspace_apikey list\u0027, here after these changes giving below error:\nERROR (NotFound): (http://10.232.48.204/identity/tokens): The resource could not be found. (HTTP 404)\nSaid error is due to currently keystone supports bydefult IDENTITY_API_VERSION as 3, so rackspace-keystoneauth-plugin need to be upgrade accordingly to use v3 implementation\n\n\n[1]: https://docs.oracle.com/cd/E78305_01/E78304/html/openstack-envars.html\n[2]: https://docs.openstack.org/python-openstackclient/latest/cli/man/openstack.html#manpage","commit_id":"967bf06245f0c3097c79fd639a57c684346ff5f0"},{"author":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"change_message_id":"1ec174d92488e8da3b4965a9b56bbb1e2a7f48d1","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def __init__(self):"},{"line_number":247,"context_line":"        self.client_logger \u003d None"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def _append_global_identity_args(self, parser, argv):"},{"line_number":250,"context_line":"        # Register the CLI arguments that have moved to the session object."},{"line_number":251,"context_line":"        loading.register_session_argparse_arguments(parser)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_8150cb0b","line":248,"updated":"2018-06-14 12:38:42.000000000","message":"Hi Bhagyashri/Shilpa, thanks for your efforts. Reading through all the investigations and analysis shared in the comments, I find this issue not as simple as the added lines of code indicate. So could you please add TODO note here so that we can keep track of what else should be addressed later on.","commit_id":"7e1c5d38f7d22b953775f160bc71844cfba30544"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"329366b97d03c5da01280c853d964d080e74b0ac","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def __init__(self):"},{"line_number":247,"context_line":"        self.client_logger \u003d None"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def _append_global_identity_args(self, parser, argv):"},{"line_number":250,"context_line":"        # Register the CLI arguments that have moved to the session object."},{"line_number":251,"context_line":"        loading.register_session_argparse_arguments(parser)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_83fbdd13","line":248,"in_reply_to":"5f7c97a3_8150cb0b","updated":"2018-06-15 06:35:31.000000000","message":"Done","commit_id":"7e1c5d38f7d22b953775f160bc71844cfba30544"}]}
