)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"44adca8174f6bc7fdc96c8854d8dcb146d9fe6c1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"[3] RESP BODY: https://review.openstack.org/#/c/505764/8/keystoneauth1/session.py@454"},{"line_number":24,"context_line":"[4] https://review.openstack.org/#/c/568878/"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id:I3c47b5249141b3f05b2f54984bb5b1d7801a02bc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_1ee81f13","line":26,"updated":"2018-07-16 15:02:09.000000000","message":"nit: I think we should have a bug for this.","commit_id":"19784cf82a16fdb0a1c89e8027907c9355390f2e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b2e66fdd236275c1bfb727e8013aee64f383fd08","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable split logging for cinder-novaclient interaction"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch ensures that log messages[1][2][3] are logged only when"},{"line_number":10,"context_line":"keystoneauth\u003dDEBUG is enabled in cinder.conf. This will also enable"},{"line_number":11,"context_line":"us to consume split_logger config option [4] when enabled in cinder"},{"line_number":12,"context_line":"without making any additional changes in client code."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_5757f027","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":46},"updated":"2018-08-01 12:38:02.000000000","message":"this sounds like an issue that should be addressed at cinder side...just transmit a proper logging object...","commit_id":"91ee2329721b2a280bb0ec9f244b064ff6364d9d"},{"author":{"_account_id":26541,"name":"Neha Alhat","email":"neha.alhat@nttdata.com","username":"nehaalhat"},"change_message_id":"e3c8a75ac04518eabf783e070091078c8799f0cb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable split logging for cinder-novaclient interaction"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch ensures that log messages[1][2][3] are logged only when"},{"line_number":10,"context_line":"keystoneauth\u003dDEBUG is enabled in cinder.conf. This will also enable"},{"line_number":11,"context_line":"us to consume split_logger config option [4] when enabled in cinder"},{"line_number":12,"context_line":"without making any additional changes in client code."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_725768cb","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":46},"in_reply_to":"5f7c97a3_5757f027","updated":"2018-08-03 06:26:06.000000000","message":"At novaclient the log messages specified below, are getting logged when log level is keystoneauth\u003dWARN, but it should get logged only when we set default_log_level to Keystoneauth\u003dDEBUG. And these log messages are getting logged by logger name \u0027novaclient.v2.client\u0027 instead of \u0027keystoneauth.session\u0027.","commit_id":"91ee2329721b2a280bb0ec9f244b064ff6364d9d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b6c5ab3bc8540c69288501b9516e2a4f3bc2043d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"us to consume split_logger config option [4] when enabled in cinder"},{"line_number":12,"context_line":"without making any additional changes in client code."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] REQ: https://review.openstack.org/#/c/505764/8/keystoneauth1/session.py@391"},{"line_number":15,"context_line":"[2] RESP: https://review.openstack.org/#/c/505764/8/keystoneauth1/session.py@422"},{"line_number":16,"context_line":"[3] RESP BODY: https://review.openstack.org/#/c/505764/8/keystoneauth1/session.py@454"},{"line_number":17,"context_line":"[4] https://review.openstack.org/#/c/568878/"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: #1782134"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_e8f35072","line":16,"range":{"start_line":14,"start_character":1,"end_line":16,"end_character":85},"updated":"2018-08-08 13:30:00.000000000","message":"These are all in keystoneauth1 version 3.5.0 which means you need to bump the lower constraints to 3.5.0:\n\nhttps://github.com/openstack/python-novaclient/blob/master/lower-constraints.txt#L37","commit_id":"91ee2329721b2a280bb0ec9f244b064ff6364d9d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"51af3f71567e3c145ee7ff231db0e0a06114469b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable split logging for cinder-novaclient interaction"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch ensures that log messages[1][2][3] are logged only when"},{"line_number":10,"context_line":"keystoneauth\u003dDEBUG is enabled in cinder.conf. This will also enable"},{"line_number":11,"context_line":"us to consume split_logger config option [4] when enabled in cinder"},{"line_number":12,"context_line":"without making any additional changes in client code."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_974bd45c","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":44},"updated":"2018-10-09 10:54:28.000000000","message":"how nova client ment to read the cinder.conf\n\nis this being used in cinder?\n\nif so a better approch to filtering the logs would be to use the python loggers inbuilt filtering supprot so that cinder\ncan spcify what it want to filter out without effect other users of nova client.\n\nthis can be done the same way nova filters out privsep debug logs or glanceclient logs.\n\nhttps://github.com/openstack/nova/blob/3d31e6c95afe3dff01af037348c0c18e896970db/nova/config.py#L37-L46","commit_id":"05e287fa9f131d51e19e09ac3f3bfde20a9dc0d4"}],"novaclient/v2/client.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"0a798753f1d64c22c5f9610b605b796f1c2cc495","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                 extensions\u003dNone,"},{"line_number":70,"context_line":"                 http_log_debug\u003dFalse,"},{"line_number":71,"context_line":"                 insecure\u003dFalse,"},{"line_number":72,"context_line":"                 logger\u003dNone,"},{"line_number":73,"context_line":"                 os_cache\u003dFalse,"},{"line_number":74,"context_line":"                 password\u003dNone,"},{"line_number":75,"context_line":"                 project_domain_id\u003dNone,"},{"line_number":76,"context_line":"                 project_domain_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ec2b8298","line":73,"range":{"start_line":72,"start_character":17,"end_line":73,"end_character":17},"updated":"2018-07-12 12:34:11.000000000","message":"should the logger parameter be completely removed, then?","commit_id":"19784cf82a16fdb0a1c89e8027907c9355390f2e"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"c4b249f04d95df7067a6fde5acee82935d7b710b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                 extensions\u003dNone,"},{"line_number":70,"context_line":"                 http_log_debug\u003dFalse,"},{"line_number":71,"context_line":"                 insecure\u003dFalse,"},{"line_number":72,"context_line":"                 logger\u003dNone,"},{"line_number":73,"context_line":"                 os_cache\u003dFalse,"},{"line_number":74,"context_line":"                 password\u003dNone,"},{"line_number":75,"context_line":"                 project_domain_id\u003dNone,"},{"line_number":76,"context_line":"                 project_domain_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4564d1b3","line":73,"range":{"start_line":72,"start_character":17,"end_line":73,"end_character":17},"in_reply_to":"5f7c97a3_3ec15b30","updated":"2018-07-24 06:48:06.000000000","message":"For backward compatibility, the logger argument can be removed because it can be included in kwargs.But IMO, it had better be there explicitly.","commit_id":"19784cf82a16fdb0a1c89e8027907c9355390f2e"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"033ef14fe5728663e51ba75a763801d113159884","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                 extensions\u003dNone,"},{"line_number":70,"context_line":"                 http_log_debug\u003dFalse,"},{"line_number":71,"context_line":"                 insecure\u003dFalse,"},{"line_number":72,"context_line":"                 logger\u003dNone,"},{"line_number":73,"context_line":"                 os_cache\u003dFalse,"},{"line_number":74,"context_line":"                 password\u003dNone,"},{"line_number":75,"context_line":"                 project_domain_id\u003dNone,"},{"line_number":76,"context_line":"                 project_domain_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_8a8c2dd9","line":73,"range":{"start_line":72,"start_character":17,"end_line":73,"end_character":17},"in_reply_to":"5f7c97a3_4564d1b3","updated":"2018-07-24 12:50:27.000000000","message":"I am talking about the logger *attribute* of the client, not the logger *argument* to the constructor.","commit_id":"19784cf82a16fdb0a1c89e8027907c9355390f2e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"44adca8174f6bc7fdc96c8854d8dcb146d9fe6c1","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                 extensions\u003dNone,"},{"line_number":70,"context_line":"                 http_log_debug\u003dFalse,"},{"line_number":71,"context_line":"                 insecure\u003dFalse,"},{"line_number":72,"context_line":"                 logger\u003dNone,"},{"line_number":73,"context_line":"                 os_cache\u003dFalse,"},{"line_number":74,"context_line":"                 password\u003dNone,"},{"line_number":75,"context_line":"                 project_domain_id\u003dNone,"},{"line_number":76,"context_line":"                 project_domain_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_fee44344","line":73,"range":{"start_line":72,"start_character":17,"end_line":73,"end_character":17},"in_reply_to":"5f7c97a3_ec2b8298","updated":"2018-07-16 15:02:09.000000000","message":"Unfortunately we cannot remove it without breaking backward compatibility.  So even if it\u0027s no longer being used we have to keep it there. :-(","commit_id":"19784cf82a16fdb0a1c89e8027907c9355390f2e"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"0038bae5076809cacb959ec2ff4e20be9804be4d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                 extensions\u003dNone,"},{"line_number":70,"context_line":"                 http_log_debug\u003dFalse,"},{"line_number":71,"context_line":"                 insecure\u003dFalse,"},{"line_number":72,"context_line":"                 logger\u003dNone,"},{"line_number":73,"context_line":"                 os_cache\u003dFalse,"},{"line_number":74,"context_line":"                 password\u003dNone,"},{"line_number":75,"context_line":"                 project_domain_id\u003dNone,"},{"line_number":76,"context_line":"                 project_domain_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3ec15b30","line":73,"range":{"start_line":72,"start_character":17,"end_line":73,"end_character":17},"in_reply_to":"5f7c97a3_fee44344","updated":"2018-07-16 15:15:18.000000000","message":"ack. I wonder if the logger attribute of the base client class should be removed then (even if the kwarg itself remains for backwards compat, as you say)","commit_id":"19784cf82a16fdb0a1c89e8027907c9355390f2e"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"aa453fcea40ac0ea6905eec3c09e0863649eae0d","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        self.server_external_events \u003d \\"},{"line_number":178,"context_line":"            server_external_events.ServerExternalEventManager(self)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        self.logger \u003d logger or logging.getLogger(__name__)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        # Add in any extensions..."},{"line_number":183,"context_line":"        if extensions:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_50e80314","side":"PARENT","line":180,"range":{"start_line":180,"start_character":8,"end_line":180,"end_character":59},"updated":"2018-07-24 16:26:47.000000000","message":"Question: Why are this line and self.logger removed?\nDoesn\u0027t just passing logger (argument of __init__) in line 209 instead of self.logger work well?","commit_id":"2e6ef0c45a6ada10440eb0ce87df74bf7070c1e4"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"7d1531b70108a4a061dbd875b5dc400371811992","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        self.server_external_events \u003d \\"},{"line_number":178,"context_line":"            server_external_events.ServerExternalEventManager(self)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        self.logger \u003d logger or logging.getLogger(__name__)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        # Add in any extensions..."},{"line_number":183,"context_line":"        if extensions:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_d3741d3a","side":"PARENT","line":180,"range":{"start_line":180,"start_character":8,"end_line":180,"end_character":59},"in_reply_to":"5f7c97a3_50e80314","updated":"2018-07-24 17:23:51.000000000","message":"I agree, we can retain this line as is except change made at line 209 is needed otherwise the logger of keystoneauth will be overridden by novaclient resulting in ignoring logging level \"KEYSTONEAUTH\u003dWARN\" set in the default_log_levels config option.","commit_id":"2e6ef0c45a6ada10440eb0ce87df74bf7070c1e4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"51af3f71567e3c145ee7ff231db0e0a06114469b","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        self.server_external_events \u003d \\"},{"line_number":178,"context_line":"            server_external_events.ServerExternalEventManager(self)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        self.logger \u003d logger or logging.getLogger(__name__)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        # Add in any extensions..."},{"line_number":183,"context_line":"        if extensions:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_942f52a5","line":180,"range":{"start_line":180,"start_character":6,"end_line":180,"end_character":59},"updated":"2018-10-09 10:54:28.000000000","message":"previously when using self.logger this would \nhave alway been initalised to eigher logger if logger was non None or logging.getLogger(__name__)\n\nby changeing the  http_client logger to logger\u003dlogger\nif logger is not passed in when the encloseing Client is constucted the http clinet will have no client either.\n\nso this is not just going to effect keysotne auth it will effect all logging done by the httpclient.","commit_id":"05e287fa9f131d51e19e09ac3f3bfde20a9dc0d4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"51af3f71567e3c145ee7ff231db0e0a06114469b","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            endpoint_type\u003dendpoint_type,"},{"line_number":207,"context_line":"            http_log_debug\u003dhttp_log_debug,"},{"line_number":208,"context_line":"            insecure\u003dinsecure,"},{"line_number":209,"context_line":"            logger\u003dlogger,"},{"line_number":210,"context_line":"            os_cache\u003dself.os_cache,"},{"line_number":211,"context_line":"            password\u003dpassword,"},{"line_number":212,"context_line":"            project_domain_id\u003dproject_domain_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_b48daed5","line":209,"range":{"start_line":209,"start_character":13,"end_line":209,"end_character":26},"updated":"2018-10-09 10:54:28.000000000","message":"is this correct? see comment above","commit_id":"05e287fa9f131d51e19e09ac3f3bfde20a9dc0d4"}]}