)]}'
{"novaclient/utils.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"1f41c6da3b4b8541bd9787a4c785eabb4811cde0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"import sys"},{"line_number":6,"context_line":"import textwrap"},{"line_number":7,"context_line":"import uuid"},{"line_number":8,"context_line":"import json"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"import prettytable"},{"line_number":11,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BewA%3D","line":8,"updated":"2013-11-25 16:41:31.000000000","message":"1. We keep imports in alphabetical order in three blocks: standard library, third-party libraries, then internal imports.\n\n2. There\u0027s no need to import something twice.","commit_id":"8ab1303c2b80d4d0328dc6c690197e0ce6bb034f"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"1f41c6da3b4b8541bd9787a4c785eabb4811cde0","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                data \u003d getattr(o, field_name, \u0027\u0027)"},{"line_number":170,"context_line":"                row.append(data)"},{"line_number":171,"context_line":"        if show_json \u003d\u003d True:"},{"line_number":172,"context_line":"            json_output.append(dict(zip(fields, row)))"},{"line_number":173,"context_line":"        pt.add_row(row)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    if show_json \u003d\u003d True:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Bets%3D","line":172,"updated":"2013-11-25 16:41:31.000000000","message":"I would rather this block be moved to the beginning of the \u0027for\u0027 loop and that a continue be added to it; this will reduce the amount of work that has to be done.  For that matter, I\u0027d almost rather you create a brand new json_list() function that you call if show_json would be set to True; the logic for the two different cases is substantially different, after all.\n\nAlso, when the variable is a singleton, such as True, False, or None, we want you to use the \"is\" operator—or, when the variable has only two values (True or False), just test the variable:\n\n    if show_json:\n        …","commit_id":"8ab1303c2b80d4d0328dc6c690197e0ce6bb034f"}]}