)]}'
{"id":"openstack%2Fpython-novaclient~5819","triplet_id":"openstack%2Fpython-novaclient~master~I6ef49f9e4e1b67074f51ab442abd4a196d437b00","project":"openstack/python-novaclient","branch":"master","topic":"help","hashtags":[],"change_id":"I6ef49f9e4e1b67074f51ab442abd4a196d437b00","subject":"Fixed the subcommand error message for nova shell.","status":"MERGED","created":"2012-03-26 17:18:56.000000000","updated":"2012-04-10 21:27:09.000000000","submitted":"2012-04-10 21:27:08.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bdb8c639f70d9cad5a8389a6dc6d7a1c1e9d4373","_number":5819,"virtual_id_number":5819,"owner":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1184,"name":"Andrew Clay Shafer","email":"acs@parvuscaptus.com","username":"littleidea"},{"value":1,"date":"2012-04-10 21:27:08.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"all":[{"value":0,"_account_id":1184,"name":"Andrew Clay Shafer","email":"acs@parvuscaptus.com","username":"littleidea"},{"value":0,"date":"2012-04-10 21:27:08.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2012-04-10 20:04:36.000000000","_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"all":[{"value":0,"_account_id":1184,"name":"Andrew Clay Shafer","email":"acs@parvuscaptus.com","username":"littleidea"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2012-04-10 20:04:36.000000000","_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1184,"name":"Andrew Clay Shafer","email":"acs@parvuscaptus.com","username":"littleidea"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1184,"name":"Andrew Clay Shafer","email":"acs@parvuscaptus.com","username":"littleidea"},{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-03-26 18:27:06.000000000","updated_by":{"_account_id":1184,"name":"Andrew Clay Shafer","email":"acs@parvuscaptus.com","username":"littleidea"},"reviewer":{"_account_id":1184,"name":"Andrew Clay Shafer","email":"acs@parvuscaptus.com","username":"littleidea"},"state":"REVIEWER"},{"updated":"2012-03-26 20:08:41.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2012-04-10 20:04:36.000000000","updated_by":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"reviewer":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"state":"REVIEWER"},{"updated":"2012-04-10 21:27:08.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"64350f92e131763b620adb4ba673405fce774243","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-03-26 17:32:24.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"7ca02afae55e2e5da4b5f0e929af390cbc903d70","author":{"_account_id":1184,"name":"Andrew Clay Shafer","email":"acs@parvuscaptus.com","username":"littleidea"},"date":"2012-03-26 18:27:06.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t submit this\n\nI prefer the condition is used to build the message, and a single call to self.exit\n\nmaybe something like:\n\nerrmsg \u003d message.split(choose_from)[0]\nmainp \u003d progparts[0]\nsubp \u003d  \" %s\" % progparts[2]\n\nmsg \u003d \"error: %(errmsg)s\\nTry \u0027%(mainp)s help%(subp)s\u0027 for more information.\\n\" %\n              {\u0027errmsg\u0027: errmsg,\n               \u0027mainp\u0027: mainp,\n               \u0027subp\u0027: subp }","accounts_in_message":[],"_revision_number":1},{"id":"8624b8239b615a230f0380ec1072c6b77963e91d","author":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"date":"2012-03-26 18:32:44.000000000","message":"Patch Set 1:\n\nI wrote it that way the first time, then cringed at the extra space that approach adds :)  That\u0027s probably not a valid reason for extra code complexity though.","accounts_in_message":[],"_revision_number":1},{"id":"6e2bae87aa1c5900a1c123b1601c4f2a939f45da","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-03-26 18:37:56.000000000","message":"Patch Set 1:\n\nEh.  He\u0027s taken care of the extra space, if you look closely.  As for me, I can go either way…","accounts_in_message":[],"_revision_number":1},{"id":"b66af1fa0ef64b334de27fa17c7d0d1cb725f71f","author":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"date":"2012-03-26 19:46:22.000000000","message":"Patch Set 1:\n\nMaybe I\u0027m not looking close enough :)  I\u0027m pretty sure that\n\nsubp \u003d \" %s\" % progparts[2]\n\nmeans that subp will contain a single space if progparts[2] is empty, in which case the final message will look like this:\n\nTry \u0027nova help \u0027 for more information.\n\n*shrug* I can live with that, and it\u0027s definitely tidier.  I\u0027m submitting a shortened version.","accounts_in_message":[],"_revision_number":1},{"id":"46f5394275227472a19c5c984da0292e4efa5477","author":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"date":"2012-03-26 19:46:29.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4fe77051a8304035ae697076710750201682745c","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-03-26 20:08:41.000000000","message":"Patch Set 2:\n\nAh, I thought there was an \u0027if\u0027 in there; hard to see for the spaces.  (BTW, to pre-format some text in gerrit, indent it.)","accounts_in_message":[],"_revision_number":2},{"id":"f77bddee4499d621988137993e90f47f585f2a51","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-03-26 20:09:27.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nEh.  It\u0027ll work, I suppose…","accounts_in_message":[],"_revision_number":2},{"id":"b251f557056258b1b78bf2cbe8a5e2f792ea6da0","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-04-10 06:03:02.000000000","message":"Patch Set 2:\n\ncode review expired after 2 weeks of no activity","accounts_in_message":[],"_revision_number":2},{"id":"55f8eae75298bde8bc5ae0232e776669019c56d7","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-04-10 06:03:02.000000000","message":"Patch Set 2: Abandoned\n\ncode review expired after 2 weeks of no activity","accounts_in_message":[],"_revision_number":2},{"id":"10cfe6e38cf4f808279688a3e68be8085cb1b4f8","author":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"date":"2012-04-10 13:25:32.000000000","message":"Patch Set 2: Restored","accounts_in_message":[],"_revision_number":2},{"id":"452b0de0f2249146bce960db722d9250b3dc7d68","author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"date":"2012-04-10 19:09:12.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\nI\u0027ll pick this one","accounts_in_message":[],"_revision_number":2},{"id":"d0fc8f2e23c4e8b5735e9de533a58c93278ff8dd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-04-10 19:59:00.000000000","message":"Patch Set 2: Fails\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-python-novaclient-merge/167/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/3394/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-unittests/182/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-pep8/171/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"ddd2f080a712a0bb167fa31b1471d1cc850ea651","author":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"date":"2012-04-10 20:02:00.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"9089bf5d947878c60432b7e68c24d082cdf7aa8d","author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"date":"2012-04-10 20:04:36.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\nTrivial pep8 fix","accounts_in_message":[],"_revision_number":3},{"id":"b4721bdf3728b78aedce7a7386fae1f45c10e3e7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-04-10 21:27:08.000000000","message":"Patch Set 3: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-python-novaclient-merge/168/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/3401/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-unittests/183/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-pep8/172/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"de42974ab98fd0a31ee02a62e44f1118d4c9e9d0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-04-10 21:27:09.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"565d144611710ed7591244892a936549f91e9473","revisions":{"f841d6a6c923ea29c0088abe5749ee34e4f5dead":{"kind":"REWORK","_number":1,"created":"2012-03-26 17:18:56.000000000","uploader":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"ref":"refs/changes/19/5819/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/19/5819/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/19/5819/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/19/5819/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/19/5819/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/19/5819/1"}}},"commit":{"parents":[{"commit":"d4f7ffc6684dc95d4fde079c13f5dd609400debf","subject":"Merge \"Improve the error message from the nova shell\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d4f7ffc6684dc95d4fde079c13f5dd609400debf"}]}],"author":{"name":"Andrew Bogott","email":"abogott@wikimedia.org","date":"2012-03-26 17:07:21.000000000","tz":-300},"committer":{"name":"Andrew Bogott","email":"abogott@wikimedia.org","date":"2012-03-26 17:11:01.000000000","tz":-300},"subject":"Fixed the subcommand error message for nova shell.","message":"Fixed the subcommand error message for nova shell.\n\nPreviously we were giving advice like this:\n\n\"Try \u0027nova volume-show help\u0027 for more information.\"\n\nBad advice -- that doesn\u0027t work. Now when there\u0027s a subcommand\nspecified we make a proper suggestion:\n\n\"Try \u0027nova help volume-show\u0027 for more information.\"\n\nChange-Id: I6ef49f9e4e1b67074f51ab442abd4a196d437b00\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f841d6a6c923ea29c0088abe5749ee34e4f5dead"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f841d6a6c923ea29c0088abe5749ee34e4f5dead"}]},"branch":"refs/heads/master"},"ff7bdf425864f5dd27887c5421d4fdd13691504e":{"kind":"REWORK","_number":2,"created":"2012-03-26 19:46:29.000000000","uploader":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"ref":"refs/changes/19/5819/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/19/5819/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/19/5819/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/19/5819/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/19/5819/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/19/5819/2"}}},"commit":{"parents":[{"commit":"6556686508b7d54422832bc7f7f70602d954838b","subject":"Merge \"Set up the log handler only once.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/6556686508b7d54422832bc7f7f70602d954838b"}]}],"author":{"name":"Andrew Bogott","email":"abogott@wikimedia.org","date":"2012-03-26 17:07:21.000000000","tz":-300},"committer":{"name":"Andrew Bogott","email":"abogott@wikimedia.org","date":"2012-03-26 19:25:32.000000000","tz":-300},"subject":"Fixed the subcommand error message for nova shell.","message":"Fixed the subcommand error message for nova shell.\n\nPreviously we were giving advice like this:\n\n\"Try \u0027nova volume-show help\u0027 for more information.\"\n\nBad advice -- that doesn\u0027t work. Now when there\u0027s a subcommand\nspecified we make a proper suggestion:\n\n\"Try \u0027nova help volume-show\u0027 for more information.\"\n\nChange-Id: I6ef49f9e4e1b67074f51ab442abd4a196d437b00\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ff7bdf425864f5dd27887c5421d4fdd13691504e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ff7bdf425864f5dd27887c5421d4fdd13691504e"}]},"branch":"refs/heads/master"},"565d144611710ed7591244892a936549f91e9473":{"kind":"REWORK","_number":3,"created":"2012-04-10 20:02:00.000000000","uploader":{"_account_id":1998,"name":"andrewbogott","username":"andrewbogott","inactive":true},"ref":"refs/changes/19/5819/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/19/5819/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/19/5819/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/19/5819/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/19/5819/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/19/5819/3"}}},"commit":{"parents":[{"commit":"9485608cefe1ebfe301c057077fd0a7c8b7f5e0e","subject":"Merge \"add packages using find_packages()\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/9485608cefe1ebfe301c057077fd0a7c8b7f5e0e"}]}],"author":{"name":"Andrew Bogott","email":"abogott@wikimedia.org","date":"2012-03-26 17:07:21.000000000","tz":-300},"committer":{"name":"Andrew Bogott","email":"abogott@wikimedia.org","date":"2012-04-10 20:01:53.000000000","tz":-300},"subject":"Fixed the subcommand error message for nova shell.","message":"Fixed the subcommand error message for nova shell.\n\nPreviously we were giving advice like this:\n\n\"Try \u0027nova volume-show help\u0027 for more information.\"\n\nBad advice -- that doesn\u0027t work. Now when there\u0027s a subcommand\nspecified we make a proper suggestion:\n\n\"Try \u0027nova help volume-show\u0027 for more information.\"\n\nChange-Id: I6ef49f9e4e1b67074f51ab442abd4a196d437b00\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/565d144611710ed7591244892a936549f91e9473"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/565d144611710ed7591244892a936549f91e9473"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}