)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"d60d191b9a41835414218eb589e358c6f6231ad2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2013-12-10 17:14:48 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Novaclient should shutdown gracefully when the"},{"line_number":8,"context_line":"user presses Ctrl+C"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Currently it prints a stacktrace and exits. This patchs makes it print"},{"line_number":11,"context_line":"a message and exit gracefully."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATn%2F9hz0%3D","line":8,"updated":"2013-12-10 15:13:47.000000000","message":"Technically, the summary line should be a single line of about 50 characters in length, though we allow up to 72 (which is why nothing has tripped).  You could change it to something like:\n\n    Allow graceful shutdown on Ctrl+C\n\nBut that\u0027s a femtonit.","commit_id":"b0742e89b7b89df126b31be48990f1a8683a071f"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"d60d191b9a41835414218eb589e358c6f6231ad2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Novaclient should shutdown gracefully when the"},{"line_number":8,"context_line":"user presses Ctrl+C"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Currently it prints a stacktrace and exits. This patchs makes it print"},{"line_number":11,"context_line":"a message and exit gracefully."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1256732"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATn%2F9h1c%3D","line":10,"updated":"2013-12-10 15:13:47.000000000","message":"s/patchs/patch/ (femtonit)","commit_id":"b0742e89b7b89df126b31be48990f1a8683a071f"}],"novaclient/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"cf80df2d733739ed4aadf3066ed8377d3c9cf9a5","unresolved":false,"context_lines":[{"line_number":727,"context_line":"        sys.exit(1)"},{"line_number":728,"context_line":"    except KeyboardInterrupt as e:"},{"line_number":729,"context_line":"        logger.debug(e)"},{"line_number":730,"context_line":"        print(\"Shutting down novaclient\")"},{"line_number":731,"context_line":"        sys.exit(1)"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BEQM%3D","line":730,"updated":"2013-12-02 21:51:04.000000000","message":"I\u0027d like the output here redirected to sys.stderr also…","commit_id":"ee2ccee144c49f8eb676dc729a77e68bfa64fc5d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e944e1e891761ab72666b885dd4f339ba506cf5d","unresolved":false,"context_lines":[{"line_number":726,"context_line":"              file\u003dsys.stderr)"},{"line_number":727,"context_line":"        sys.exit(1)"},{"line_number":728,"context_line":"    except KeyboardInterrupt as e:"},{"line_number":729,"context_line":"        logger.debug(e)"},{"line_number":730,"context_line":"        print(\"Shutting down novaclient\", file\u003dsys.stderr)"},{"line_number":731,"context_line":"        sys.exit(1)"},{"line_number":732,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9y%2Bs%3D","line":729,"updated":"2013-12-05 19:59:29.000000000","message":"I think you need\n\n logger.debug(e, exc_info\u003d1)\n\nin order to log the stacktrace. Otherwise it\u0027s blank.","commit_id":"2195bad3fd24d7af216fac2e78ffc1ead651006b"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"572f67d03c469306351aa04235dd9897e0b687e4","unresolved":false,"context_lines":[{"line_number":726,"context_line":"              file\u003dsys.stderr)"},{"line_number":727,"context_line":"        sys.exit(1)"},{"line_number":728,"context_line":"    except KeyboardInterrupt as e:"},{"line_number":729,"context_line":"        logger.debug(e)"},{"line_number":730,"context_line":"        print(\"Shutting down novaclient\", file\u003dsys.stderr)"},{"line_number":731,"context_line":"        sys.exit(1)"},{"line_number":732,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9y8Y%3D","line":729,"in_reply_to":"AAAATn%2F9y%2Bs%3D","updated":"2013-12-05 20:10:50.000000000","message":"I don\u0027t think there\u0027s value in displaying the stack trace from a KeyboardInterrupt exception, which is why I didn\u0027t bother to comment on it.  In fact, there\u0027s probably no value in logging anything, but it is a .debug(), so again, no big deal.","commit_id":"2195bad3fd24d7af216fac2e78ffc1ead651006b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"60c54bf6b69395cf2897c79d91e87b885beb38c8","unresolved":false,"context_lines":[{"line_number":726,"context_line":"              file\u003dsys.stderr)"},{"line_number":727,"context_line":"        sys.exit(1)"},{"line_number":728,"context_line":"    except KeyboardInterrupt as e:"},{"line_number":729,"context_line":"        logger.debug(e)"},{"line_number":730,"context_line":"        print(\"Shutting down novaclient\", file\u003dsys.stderr)"},{"line_number":731,"context_line":"        sys.exit(1)"},{"line_number":732,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9y8A%3D","line":729,"in_reply_to":"AAAATn%2F9y8Y%3D","updated":"2013-12-05 20:13:34.000000000","message":"Fair enough -- I was going off the commit message which says it logs the stacktrace. So probably the log statement can be removed (as it logs a blank line) and the commit message updated.","commit_id":"2195bad3fd24d7af216fac2e78ffc1ead651006b"}]}