)]}'
{"id":"openstack%2Fpython-novaclient~59861","triplet_id":"openstack%2Fpython-novaclient~master~I74f6e969aea1e1b37c13bc2525a5e3f9f57a6f14","project":"openstack/python-novaclient","branch":"master","topic":"lp/1153926","hashtags":[],"change_id":"I74f6e969aea1e1b37c13bc2525a5e3f9f57a6f14","subject":"Use flavor details from server data if available","status":"ABANDONED","created":"2013-12-03 22:59:09.000000000","updated":"2014-01-10 06:03:08.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"342703bbd903f0243e256a640697171c5bb7aff2","_number":59861,"virtual_id_number":59861,"owner":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2014-01-02 17:16:17.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-12-18 17:31:45.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},{"value":0,"date":"2014-01-02 16:19:31.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-12-18 17:31:45.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},{"date":"2014-01-02 16:19:31.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-12-18 17:31:45.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2014-01-02 16:19:31.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2014-01-02 17:16:17.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"61e01a6426c9be29702a6c072a6080c5acac1f77","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-12-03 23:18:24.000000000","message":"Patch Set 1: (1 inline comment)\n\nSo, other than a femtonit, this looks OK to me…though it does make me wonder why we choose to look up the flavor if we\u0027re already given the name.  Was this a change in the nova API at some point, perhaps?\n\nI would like to see a test added to cover the change, but I won\u0027t insist on it.  The 0 score is just to get a response to the above question about nova API change…","accounts_in_message":[],"_revision_number":1},{"id":"1eb40b10501a1408bfea1a3bf2bfae0e3e6ca758","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-03 23:58:19.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/61/59861/1/check/gate-python-novaclient-pep8/d62112d : SUCCESS in 38s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/61/59861/1/check/gate-python-novaclient-docs/7fded70/doc/build/html/ : SUCCESS in 57s\n- gate-python-novaclient-python26 http://logs.openstack.org/61/59861/1/check/gate-python-novaclient-python26/09bf5e1 : SUCCESS in 1m 12s\n- gate-python-novaclient-python27 http://logs.openstack.org/61/59861/1/check/gate-python-novaclient-python27/23d68b7 : SUCCESS in 1m 06s\n- gate-python-novaclient-python33 http://logs.openstack.org/61/59861/1/check/gate-python-novaclient-python33/3bd0d8f : SUCCESS in 4m 32s\n- gate-python-novaclient-pypy http://logs.openstack.org/61/59861/1/check/gate-python-novaclient-pypy/79a71f9 : SUCCESS in 2m 01s\n- check-tempest-dsvm-full http://logs.openstack.org/61/59861/1/check/check-tempest-dsvm-full/a6be4cf : SUCCESS in 51m 45s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/61/59861/1/check/check-tempest-dsvm-postgres-full/a77636b : SUCCESS in 38m 39s\n- check-tempest-dsvm-neutron http://logs.openstack.org/61/59861/1/check/check-tempest-dsvm-neutron/2f0b136 : SUCCESS in 30m 04s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/61/59861/1/check/gate-tempest-dsvm-large-ops/6b6aa75 : SUCCESS in 14m 34s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/61/59861/1/check/gate-tempest-dsvm-neutron-large-ops/1a0e6bc : SUCCESS in 15m 56s\n- check-grenade-dsvm http://logs.openstack.org/61/59861/1/check/check-grenade-dsvm/8f73aa8 : SUCCESS in 32m 39s\n","accounts_in_message":[],"_revision_number":1},{"id":"db2a6228a652058b6614511f696ba38dc1a48d6b","author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"date":"2013-12-18 12:13:00.000000000","message":"Patch Set 1:\n\nThe nova api for server show only returns the flavor id as of now. To get the name of the flavor, we have to do a flavor show api call. Also, with this patch, you only get the flavor name in server details when the flavor is deleted and nova server show api decides to return the entire flavor details from the system_metadata. If the flavor is not deleted and we do a server show, we have to do the flavor show call since we only get the flavor id in that request.\n\nAlso the nova reviewers dont want to change this for the nova v2 api, and only the v3 api will be changed. So i am pushing a new patchset for these changes.","accounts_in_message":[],"_revision_number":1},{"id":"f0784409bca00817949786ac913001b9b31fb4dd","author":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"date":"2013-12-18 12:25:05.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"788240a1b2d2bc8bc4ebbfbb522d3a956dcf64c1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-18 13:14:07.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/61/59861/2/check/gate-python-novaclient-pep8/05fee03 : SUCCESS in 51s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/61/59861/2/check/gate-python-novaclient-docs/805b1b6/doc/build/html/ : SUCCESS in 54s\n- gate-python-novaclient-python26 http://logs.openstack.org/61/59861/2/check/gate-python-novaclient-python26/a65c608 : SUCCESS in 1m 11s\n- gate-python-novaclient-python27 http://logs.openstack.org/61/59861/2/check/gate-python-novaclient-python27/1bb8578 : SUCCESS in 1m 12s\n- gate-python-novaclient-python33 http://logs.openstack.org/61/59861/2/check/gate-python-novaclient-python33/980509b : SUCCESS in 4m 20s\n- gate-python-novaclient-pypy http://logs.openstack.org/61/59861/2/check/gate-python-novaclient-pypy/0406cfd : SUCCESS in 2m 01s\n- check-tempest-dsvm-full http://logs.openstack.org/61/59861/2/check/check-tempest-dsvm-full/d4ee981 : SUCCESS in 48m 50s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/61/59861/2/check/check-tempest-dsvm-postgres-full/7ee9f43 : SUCCESS in 42m 08s\n- check-tempest-dsvm-neutron http://logs.openstack.org/61/59861/2/check/check-tempest-dsvm-neutron/3595905 : SUCCESS in 40m 51s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/61/59861/2/check/gate-tempest-dsvm-large-ops/23dd1d0 : SUCCESS in 19m 22s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/61/59861/2/check/gate-tempest-dsvm-neutron-large-ops/4a207a7 : SUCCESS in 19m 21s\n- check-grenade-dsvm http://logs.openstack.org/61/59861/2/check/check-grenade-dsvm/5e25128 : SUCCESS in 35m 55s\n","accounts_in_message":[],"_revision_number":2},{"id":"018aad1277eb59fd881b497503c82923be241cb4","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-12-18 17:31:45.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nOK, fair enough…","accounts_in_message":[],"_revision_number":2},{"id":"5d50da85e09e6d779e9fdd02cb70faed550f8070","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2014-01-02 16:19:31.000000000","message":"Patch Set 2:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":2},{"id":"5364c079432b1444210b0740ec0c91184c68b9f1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-02 17:16:17.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/61/59861/2/check/gate-python-novaclient-pep8/b20a01f : SUCCESS in 1m 11s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/61/59861/2/check/gate-python-novaclient-docs/54c0d50/doc/build/html/ : SUCCESS in 1m 11s\n- gate-python-novaclient-python26 http://logs.openstack.org/61/59861/2/check/gate-python-novaclient-python26/a54b986 : SUCCESS in 1m 17s\n- gate-python-novaclient-python27 http://logs.openstack.org/61/59861/2/check/gate-python-novaclient-python27/955da6d : SUCCESS in 1m 34s\n- gate-python-novaclient-python33 http://logs.openstack.org/61/59861/2/check/gate-python-novaclient-python33/152c8df : SUCCESS in 4m 32s\n- gate-python-novaclient-pypy http://logs.openstack.org/61/59861/2/check/gate-python-novaclient-pypy/81ba6c1 : SUCCESS in 2m 15s\n- check-tempest-dsvm-full http://logs.openstack.org/61/59861/2/check/check-tempest-dsvm-full/4846321 : SUCCESS in 40m 44s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/61/59861/2/check/check-tempest-dsvm-postgres-full/94c6d4d : SUCCESS in 48m 58s\n- check-tempest-dsvm-neutron http://logs.openstack.org/61/59861/2/check/check-tempest-dsvm-neutron/3c62477 : SUCCESS in 39m 30s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/61/59861/2/check/gate-tempest-dsvm-large-ops/8442ef9 : FAILURE in 20m 39s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/61/59861/2/check/gate-tempest-dsvm-neutron-large-ops/bb1a131 : SUCCESS in 19m 08s\n- check-grenade-dsvm http://logs.openstack.org/61/59861/2/check/check-grenade-dsvm/3d40bbd : SUCCESS in 32m 37s\n","accounts_in_message":[],"_revision_number":2},{"id":"d3a40b9d67cb592f8ab0658de73aa9338794c681","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-01-02 17:16:33.000000000","message":"Patch Set 2:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1257626\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1257626\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1257626","accounts_in_message":[],"_revision_number":2},{"id":"172185d822b7e8c7fa6884d1b8165b26a3cd8f5a","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-01-10 06:03:08.000000000","message":"Patch Set 2:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":2},{"id":"df678419d4e15df7bce5142365e99769006177d3","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-01-10 06:03:08.000000000","message":"Patch Set 2: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c3eac4b422091e4a7aa659b98406ab6058bf11de","revisions":{"944f162b9527d83bbea4b3bd3e5d647f8d59d1d1":{"kind":"REWORK","_number":1,"created":"2013-12-03 22:59:09.000000000","uploader":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"ref":"refs/changes/61/59861/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/61/59861/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/61/59861/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/61/59861/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/61/59861/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/61/59861/1"}}},"commit":{"parents":[{"commit":"66d59d57b099009213d3f2bf915aec18523eaed5","subject":"Merge \"Allows users to retrieve ciphered VM passwords\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/66d59d57b099009213d3f2bf915aec18523eaed5"}]}],"author":{"name":"Rohan Kanade","email":"rohan.kanade@izeltech.com","date":"2013-12-04 04:22:15.000000000","tz":330},"committer":{"name":"Rohan Kanade","email":"rohan.kanade@izeltech.com","date":"2013-12-04 04:28:33.000000000","tz":330},"subject":"Use flavor details from server data","message":"Use flavor details from server data\n\n* Nova patch (https://review.openstack.org/59860) will disable showing deleted flavors\n* Hence use deleted flavor details from server data instead of querying flavor api\n* Nova patch will not show deleted flavors because flavor id\u0027s are not\n  unique and any duplicate deleted/non-deleted flavor\n  with same flavor id can be returned\n\nChange-Id: I74f6e969aea1e1b37c13bc2525a5e3f9f57a6f14\nCloses-Bug: #1153926\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/944f162b9527d83bbea4b3bd3e5d647f8d59d1d1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/944f162b9527d83bbea4b3bd3e5d647f8d59d1d1"}]},"branch":"refs/heads/master"},"c3eac4b422091e4a7aa659b98406ab6058bf11de":{"kind":"REWORK","_number":2,"created":"2013-12-18 12:25:05.000000000","uploader":{"_account_id":6124,"name":"Rohan Kanade","email":"openstack@rohankanade.com","username":"kanaderohan"},"ref":"refs/changes/61/59861/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/61/59861/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/61/59861/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/61/59861/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/61/59861/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/61/59861/2"}}},"commit":{"parents":[{"commit":"ffc479752a67e71415e46b67b5707c7d219dd160","subject":"Merge \"Remove commands not supported by Nova V3 API\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ffc479752a67e71415e46b67b5707c7d219dd160"}]}],"author":{"name":"Rohan Kanade","email":"rohan.kanade@izeltech.com","date":"2013-12-18 17:45:54.000000000","tz":330},"committer":{"name":"Rohan Kanade","email":"rohan.kanade@izeltech.com","date":"2013-12-18 17:45:54.000000000","tz":330},"subject":"Use flavor details from server data if available","message":"Use flavor details from server data if available\n\n* Nova patch (https://review.openstack.org/59860) will disable showing\n  deleted flavors\n* Hence use deleted flavor details from server data instead of querying\n  flavor api\n* Nova patch will not show deleted flavors because flavor id\u0027s are not\n  unique and any duplicate deleted/non-deleted flavor with same flavor\n  id can be returned\n\nCloses-Bug: #1153926\nChange-Id: I74f6e969aea1e1b37c13bc2525a5e3f9f57a6f14\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/c3eac4b422091e4a7aa659b98406ab6058bf11de"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/c3eac4b422091e4a7aa659b98406ab6058bf11de"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}