)]}'
{"novaclient/crypto.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cbe1dcd4d51406f3be9da6bbe6deee68b23a6c63","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    proc.stdin.close()"},{"line_number":36,"context_line":"    if proc.returncode:"},{"line_number":37,"context_line":"        raise DecryptionFailure(err)"},{"line_number":38,"context_line":"    return out.decode()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_720afbd1","line":38,"updated":"2018-09-24 22:05:45.000000000","message":"This will default to \u0027ascii\u0027 encoding in python 2 [1], which I don\u0027t think is what we want in the python 2 case.\n\nLooking at the server side code [2], we could do something similar and specify \u0027utf-8\u0027 to decode here and only do so \"if six.PY3 and isinstance(out, bytes)\". Note that for python 3, \u0027utf-8\u0027 is the default for decode [3], but it might be good to be explicit anyway.\n\n[1] https://docs.python.org/2/library/codecs.html#codecs.decode\n[2] https://github.com/openstack/nova/blob/eb26f1b/nova/api/metadata/password.py#L48\n[3] https://docs.python.org/3/library/stdtypes.html#bytes.decode","commit_id":"12bca19b577243a230e779c754a34b0b714a17ef"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"d1e6aeea99fdcfe0a027ba13c82a665bc0cfc7d9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    proc.stdin.close()"},{"line_number":36,"context_line":"    if proc.returncode:"},{"line_number":37,"context_line":"        raise DecryptionFailure(err)"},{"line_number":38,"context_line":"    return out.decode()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_26e6e24b","line":38,"in_reply_to":"3f79a3b5_720afbd1","updated":"2018-10-26 05:19:43.000000000","message":"Done","commit_id":"12bca19b577243a230e779c754a34b0b714a17ef"}]}