)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"92f9ee3b70e56265e94363d3dd0d22ebba6e88d0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add a CLI to disable/enable a flavor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a flavor is disabled, it is invisible to tenants while show a list of flavors."},{"line_number":10,"context_line":"But if a flavor is already associated with instances, a tenants can still access it by the flavor_id."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"usage: nova flavor-disabled \u003cflavor\u003e \u003cdisabled\u003e"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F9bzQ%3D","line":10,"updated":"2013-12-11 15:17:45.000000000","message":"Commit messages should be word-wrapped at 72 columns…","commit_id":"5ca0372b1aee33449acb8519c86b753af4b8e88d"},{"author":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"change_message_id":"8150fa1b8800d6a4281e44110191e6f826f1d06e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"| 42 | m1.nano   | 64        | 0    | 0         |      | 1     | 1.0         | True      | False    |"},{"line_number":53,"context_line":"| 5  | m1.xlarge | 16384     | 160  | 0         |      | 8     | 1.0         | True      | False    |"},{"line_number":54,"context_line":"| 84 | m1.micro  | 128       | 0    | 0         |      | 1     | 1.0         | True      | False    |"},{"line_number":55,"context_line":"+----+-----------+-----------+------+-----------+------+-------+-------------+-----------+----------+"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Change-Id: I0f244c4bcc7e56d6181445b5d58785607a8dac03"},{"line_number":58,"context_line":"Closes-Bug: #1259262"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F9ea8%3D","line":55,"updated":"2013-12-11 05:14:42.000000000","message":"You don\u0027t need an example in the commit. I\u0027d prefer a DocImpact tag instead.","commit_id":"5ca0372b1aee33449acb8519c86b753af4b8e88d"}],"novaclient/tests/v1_1/fakes.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"92f9ee3b70e56265e94363d3dd0d22ebba6e88d0","unresolved":false,"context_lines":[{"line_number":749,"context_line":"        )"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    def put_flavors_2(self, **kw):"},{"line_number":752,"context_line":"                return ("},{"line_number":753,"context_line":"        200,"},{"line_number":754,"context_line":"        {},"},{"line_number":755,"context_line":"        {\u0027flavor\u0027: self.get_flavors_detail()[2][\u0027flavors\u0027][1]}"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9byw%3D","line":752,"updated":"2013-12-11 15:17:45.000000000","message":"Please indent only four spaces, then indent the remaining lines four spaces beyond that.  Your end result should be similar in style to post_flavors() above.","commit_id":"5ca0372b1aee33449acb8519c86b753af4b8e88d"}],"novaclient/v1_1/flavors.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"92f9ee3b70e56265e94363d3dd0d22ebba6e88d0","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @property"},{"line_number":35,"context_line":"    def disabled(self):"},{"line_number":36,"context_line":"        \"\"\"\t36"},{"line_number":37,"context_line":"        Provide a user-friendly accessor to OS-FLV-DISABLED:disabled"},{"line_number":38,"context_line":"        \"\"\""},{"line_number":39,"context_line":"        return self._info.get(\"OS-FLV-DISABLED:disabled\", False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9byo%3D","line":36,"updated":"2013-12-11 15:17:45.000000000","message":"Please do not use tabs…","commit_id":"5ca0372b1aee33449acb8519c86b753af4b8e88d"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"92f9ee3b70e56265e94363d3dd0d22ebba6e88d0","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def update(self, flavor, disabled):"},{"line_number":197,"context_line":"        \"\"\""},{"line_number":198,"context_line":"        update field disabled."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        :param flavor: The ID of the :class:`Flavor` to get."},{"line_number":201,"context_line":"        :param disabled: Whether flavor visible to the public."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9byc%3D","line":198,"updated":"2013-12-11 15:17:45.000000000","message":"s/update/Update/ (femtonit)","commit_id":"5ca0372b1aee33449acb8519c86b753af4b8e88d"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"92f9ee3b70e56265e94363d3dd0d22ebba6e88d0","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        update field disabled."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        :param flavor: The ID of the :class:`Flavor` to get."},{"line_number":201,"context_line":"        :param disabled: Whether flavor visible to the public."},{"line_number":202,"context_line":"        \"\"\""},{"line_number":203,"context_line":"        body \u003d {"},{"line_number":204,"context_line":"            \"flavor\": {"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9bx0%3D","line":201,"updated":"2013-12-11 15:17:45.000000000","message":"1. Insert \"should be\" between \"flavor\" and \"visible\"\n\n2. \"disabled\" doesn\u0027t necessarily imply \"invisible\"; I would actually expect a \"disabled\" flavor to be visible, but unusable for booting new servers.","commit_id":"5ca0372b1aee33449acb8519c86b753af4b8e88d"}],"novaclient/v1_1/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"92f9ee3b70e56265e94363d3dd0d22ebba6e88d0","unresolved":false,"context_lines":[{"line_number":666,"context_line":""},{"line_number":667,"context_line":"@utils.arg(\u0027flavor_id\u0027,"},{"line_number":668,"context_line":"     metavar\u003d\u0027\u003cflavor_id\u003e\u0027,"},{"line_number":669,"context_line":"     help\u003d\"flavor id.\")"},{"line_number":670,"context_line":"@utils.arg(\u0027disabled\u0027,"},{"line_number":671,"context_line":"     metavar\u003d\u0027\u003cdisabled\u003e\u0027,"},{"line_number":672,"context_line":"     help\u003d\"value of disabled (true or false).\","}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9bw4%3D","line":669,"updated":"2013-12-11 15:17:45.000000000","message":"Why didn\u0027t you copy the help text from do_flavor_key() for this option?  For that matter, why is it a different name (flavor_id vs. flavor)?  Where possible, we\u0027d like to maintain consistency with similar commands in the interface, for the benefit of users.","commit_id":"5ca0372b1aee33449acb8519c86b753af4b8e88d"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"92f9ee3b70e56265e94363d3dd0d22ebba6e88d0","unresolved":false,"context_lines":[{"line_number":670,"context_line":"@utils.arg(\u0027disabled\u0027,"},{"line_number":671,"context_line":"     metavar\u003d\u0027\u003cdisabled\u003e\u0027,"},{"line_number":672,"context_line":"     help\u003d\"value of disabled (true or false).\","},{"line_number":673,"context_line":"     type\u003dutils.bool_from_str)"},{"line_number":674,"context_line":"def do_flavor_disabled(cs, args):"},{"line_number":675,"context_line":"    \"\"\"Change the visibility of a flavor between Enabled and Disabled.\"\"\""},{"line_number":676,"context_line":"    flavor \u003d cs.flavors.update(args.flavor_id, args.disabled)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9bwc%3D","line":673,"updated":"2013-12-11 15:17:45.000000000","message":"My personal inclination would actually be to have a flavor-disable and a flavor-enable command, neither taking this argument, but simply hard-coding the \"disable\" parameter for flavors.update().  Barring that, I would make this optional, defaulting to True.","commit_id":"5ca0372b1aee33449acb8519c86b753af4b8e88d"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"92f9ee3b70e56265e94363d3dd0d22ebba6e88d0","unresolved":false,"context_lines":[{"line_number":671,"context_line":"     metavar\u003d\u0027\u003cdisabled\u003e\u0027,"},{"line_number":672,"context_line":"     help\u003d\"value of disabled (true or false).\","},{"line_number":673,"context_line":"     type\u003dutils.bool_from_str)"},{"line_number":674,"context_line":"def do_flavor_disabled(cs, args):"},{"line_number":675,"context_line":"    \"\"\"Change the visibility of a flavor between Enabled and Disabled.\"\"\""},{"line_number":676,"context_line":"    flavor \u003d cs.flavors.update(args.flavor_id, args.disabled)"},{"line_number":677,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9bxY%3D","line":674,"updated":"2013-12-11 15:17:45.000000000","message":"\"disabled\" is past tense.  That\u0027s appropriate for displaying the status of the flavor, but for changing, you need to use the present tense, \"disable\".  The command should then be \"flavor-disable\".","commit_id":"5ca0372b1aee33449acb8519c86b753af4b8e88d"}]}