)]}'
{"id":"openstack%2Fpython-novaclient~6234","triplet_id":"openstack%2Fpython-novaclient~master~Ifdc014283f8caacdded14a94c27f03673c996e60","project":"openstack/python-novaclient","branch":"master","hashtags":[],"change_id":"Ifdc014283f8caacdded14a94c27f03673c996e60","subject":"Render -1 quota threshold as \u0027-1 (Unlimited)\u0027","status":"ABANDONED","created":"2012-04-04 16:58:47.000000000","updated":"2012-05-22 06:03:11.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f1d3b40ea6ae2072b7db39f98c5f44ebe12cb76e","_number":6234,"virtual_id_number":6234,"owner":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2012-04-27 16:53:49.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"all":[{"value":0,"date":"2012-04-27 16:53:49.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-04-26 17:35:24.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2012-04-27 16:43:31.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"date":"2012-04-27 16:49:33.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-04-26 17:35:24.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"date":"2012-04-27 16:43:38.000000000","_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"date":"2012-04-26 17:33:06.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-04-05 08:38:18.000000000","updated_by":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"reviewer":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"state":"REVIEWER"},{"updated":"2012-04-26 17:35:24.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2012-04-27 16:43:38.000000000","updated_by":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"reviewer":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"state":"REVIEWER"},{"updated":"2012-04-27 16:53:49.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"89434f35da551ed9a9f63e29a6dd5a6c9394e1a0","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-04-19 06:03:02.000000000","message":"Patch Set 1:\n\ncode review expired after 2 weeks of no activity","accounts_in_message":[],"_revision_number":1},{"id":"aa88f5c2323490e1941bfc8b92bf08635aa4fd9d","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-04-19 06:03:02.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 2 weeks of no activity","accounts_in_message":[],"_revision_number":1},{"id":"96edd0914e99808bf64c25319ccea69324f742f0","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2012-04-26 17:29:49.000000000","message":"Patch Set 1: Restored\n\nRestored after automated expiry due to lack of reviewer attention.","accounts_in_message":[],"_revision_number":1},{"id":"ca9d7e7a7b4228a539ff23ad9f05a2bd2d623d1b","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2012-04-26 17:33:06.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"86a870313dc0b035edf512046a85942804a67d23","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-04-26 17:35:24.000000000","message":"Patch Set 2:\n\nCan you tweak this patch to also accept \"None\" as unlimited?  If the patch can be liberal in what it accepts, we can probably get this approved without having to worry about 6233.","accounts_in_message":[],"_revision_number":2},{"id":"b2dad9268ed5276ecb9595caddf26d2a402fc79f","author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"date":"2012-04-27 16:43:31.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n6233 is approved and merged, no?","accounts_in_message":[],"_revision_number":2},{"id":"3a654fa94551686f72af65c5ac27dbc03ee8945e","author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"date":"2012-04-27 16:43:38.000000000","message":"Patch Set 2: No score\n\n","accounts_in_message":[],"_revision_number":2},{"id":"649f197af03dc609475adb860abc46976170caf0","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2012-04-27 16:49:33.000000000","message":"Patch Set 2:\n\n@Mark - yes, the related patch #6233 has already been merged.\n\n@Kevin - is the proposed tweak really required, given that #6233 has landed? \n\nOr are you thinking of a scenario where a newer novaclient should be usable against an older nova-api service?","accounts_in_message":[],"_revision_number":2},{"id":"5c2cf4294e33034e7fd21af2c1f2396aaf7b30e9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-04-27 16:53:49.000000000","message":"Patch Set 2: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-python-novaclient-merge/174/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/3692/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-unittests/189/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-pep8/178/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"0fee015562e2720ed4c480e68a1dd90dc54845a1","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-04-27 17:03:08.000000000","message":"Patch Set 2:\n\n@eglynn: At the time at which I wrote that, I was under the impression that 6233 wasn\u0027t yet in.  That said, it\u0027s probably worthwhile to make sure we interoperate properly with pre-6233 nova :)","accounts_in_message":[],"_revision_number":2},{"id":"f7b6639dae09695ededb7a457d54f05a7f04b6c7","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-05-07 19:17:46.000000000","message":"Patch Set 2:\n\nHave we confirmed that this change will be backwards-compatible?","accounts_in_message":[],"_revision_number":2},{"id":"3e0db64772745f040c87a3eefa94c0cc903175fc","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-05-22 06:03:11.000000000","message":"Patch Set 2:\n\ncode review expired after 2 weeks of no activity, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":2},{"id":"e6bb10b7efe09b568b2b350be661a26e8cc31f05","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2012-05-22 06:03:11.000000000","message":"Patch Set 2: Abandoned\n\ncode review expired after 2 weeks of no activity, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"40c5d9cabc25a7e1f5d11b34ada4475e01f15f90","revisions":{"641f04d0026cb7d44db089f05cbb979d04977915":{"kind":"REWORK","_number":1,"created":"2012-04-04 16:58:47.000000000","uploader":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"ref":"refs/changes/34/6234/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/34/6234/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/34/6234/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/34/6234/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/34/6234/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/34/6234/1"}}},"commit":{"parents":[{"commit":"ea448e24971c58e9edc7d837c6dfef3941a6c878","subject":"Set resources as loaded on get","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ea448e24971c58e9edc7d837c6dfef3941a6c878"}]}],"author":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2012-04-04 14:55:25.000000000","tz":60},"committer":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2012-04-04 16:54:33.000000000","tz":60},"subject":"Render -1 quota threshold as \u0027-1 (Unlimited)\u0027","message":"Render -1 quota threshold as \u0027-1 (Unlimited)\u0027\n\nClarify the value displayed for unlimited thresholds.\n\nDepends on nova core patch:\n\n  https://review.openstack.org/6233\n\nChange-Id: Ifdc014283f8caacdded14a94c27f03673c996e60\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/641f04d0026cb7d44db089f05cbb979d04977915"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/641f04d0026cb7d44db089f05cbb979d04977915"}]},"branch":"refs/heads/master"},"40c5d9cabc25a7e1f5d11b34ada4475e01f15f90":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2012-04-26 17:33:06.000000000","uploader":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"ref":"refs/changes/34/6234/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/34/6234/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/34/6234/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/34/6234/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/34/6234/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/34/6234/2"}}},"commit":{"parents":[{"commit":"765f551a267f07e43eb3acb92835ac7e5d6ca31b","subject":"Rename NOVA_VERSION to OS_COMPUTE_API_VERSION.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/765f551a267f07e43eb3acb92835ac7e5d6ca31b"}]}],"author":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2012-04-04 14:55:25.000000000","tz":60},"committer":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2012-04-26 17:24:38.000000000","tz":60},"subject":"Render -1 quota threshold as \u0027-1 (Unlimited)\u0027","message":"Render -1 quota threshold as \u0027-1 (Unlimited)\u0027\n\nClarify the value displayed for unlimited thresholds.\n\nDepends on nova core patch:\n\n  https://review.openstack.org/6233\n\nChange-Id: Ifdc014283f8caacdded14a94c27f03673c996e60\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/40c5d9cabc25a7e1f5d11b34ada4475e01f15f90"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/40c5d9cabc25a7e1f5d11b34ada4475e01f15f90"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}