)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2959d4ccfa166bab281b55297216a6e3a870b06f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix changes-before values in an instance action test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some DBMSs (e.g. MySQL 5.7 (*1)), fractions (millisecond and"},{"line_number":10,"context_line":"microsecond) of DateTime column is not stored by default."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"*1: https://dev.mysql.com/doc/refman/5.7/en/date-and-time-type-overview.html"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_f75526c3","line":9,"updated":"2019-02-25 22:57:43.000000000","message":"When the test is run is it actually using mysql? I guess if we\u0027re running it against devstack then yes.","commit_id":"dfba7824c3403bde1d20091d77ffe2a70dbe7ca0"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"c48bf1bc2ebfae07d549b1d420ee96f20632a440","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix changes-before values in an instance action test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some DBMSs (e.g. MySQL 5.7 (*1)), fractions (millisecond and"},{"line_number":10,"context_line":"microsecond) of DateTime column is not stored by default."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"*1: https://dev.mysql.com/doc/refman/5.7/en/date-and-time-type-overview.html"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_c652b267","line":9,"in_reply_to":"9fdfeff1_f75526c3","updated":"2019-02-26 05:19:24.000000000","message":"Yes. When we\u0027re running it against devstack. In nova side.","commit_id":"dfba7824c3403bde1d20091d77ffe2a70dbe7ca0"}],"novaclient/tests/functional/v2/test_instance_action.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2959d4ccfa166bab281b55297216a6e3a870b06f","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    COMPUTE_API_VERSION \u003d \"2.66\""},{"line_number":161,"context_line":"    expect_event_hostId_field \u003d True"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _wait_for_instance_actions(self, server, length):"},{"line_number":164,"context_line":"        start_time \u003d time.time()"},{"line_number":165,"context_line":"        # Time out after 60 seconds"},{"line_number":166,"context_line":"        while time.time() - start_time \u003c 60:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_77bb760e","line":163,"range":{"start_line":163,"start_character":49,"end_line":163,"end_character":55},"updated":"2019-02-25 22:57:43.000000000","message":"Maybe call this expected_num_of_actions?","commit_id":"dfba7824c3403bde1d20091d77ffe2a70dbe7ca0"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"c48bf1bc2ebfae07d549b1d420ee96f20632a440","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    COMPUTE_API_VERSION \u003d \"2.66\""},{"line_number":161,"context_line":"    expect_event_hostId_field \u003d True"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _wait_for_instance_actions(self, server, length):"},{"line_number":164,"context_line":"        start_time \u003d time.time()"},{"line_number":165,"context_line":"        # Time out after 60 seconds"},{"line_number":166,"context_line":"        while time.time() - start_time \u003c 60:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_467ec2e4","line":163,"range":{"start_line":163,"start_character":49,"end_line":163,"end_character":55},"in_reply_to":"9fdfeff1_77bb760e","updated":"2019-02-26 05:19:24.000000000","message":"Done","commit_id":"dfba7824c3403bde1d20091d77ffe2a70dbe7ca0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2959d4ccfa166bab281b55297216a6e3a870b06f","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        # NOTE(takashin): In some DBMSs (e.g. MySQL 5.7), fractions"},{"line_number":187,"context_line":"        # (millisecond and microsecond) of DateTime column is not stored"},{"line_number":188,"context_line":"        # by default. So sleep a second."},{"line_number":189,"context_line":"        time.sleep(1)"},{"line_number":190,"context_line":"        server.stop()"},{"line_number":191,"context_line":"        end_stop \u003d self._wait_for_instance_actions(server, 2)"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_b74a3e24","line":189,"range":{"start_line":189,"start_character":8,"end_line":189,"end_character":21},"updated":"2019-02-25 22:57:43.000000000","message":"_wait_for_instance_actions already does this so why do we need to do it again here?","commit_id":"dfba7824c3403bde1d20091d77ffe2a70dbe7ca0"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"c48bf1bc2ebfae07d549b1d420ee96f20632a440","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        # NOTE(takashin): In some DBMSs (e.g. MySQL 5.7), fractions"},{"line_number":187,"context_line":"        # (millisecond and microsecond) of DateTime column is not stored"},{"line_number":188,"context_line":"        # by default. So sleep a second."},{"line_number":189,"context_line":"        time.sleep(1)"},{"line_number":190,"context_line":"        server.stop()"},{"line_number":191,"context_line":"        end_stop \u003d self._wait_for_instance_actions(server, 2)"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_66e0a698","line":189,"range":{"start_line":189,"start_character":8,"end_line":189,"end_character":21},"in_reply_to":"9fdfeff1_b74a3e24","updated":"2019-02-26 05:19:24.000000000","message":"If \u0027end_create\u0027 time and a stop action are with in same second,\n\"instance-action-list server --changes-before end_create\" returns two actions because fractions (millisecond and microsecond) is not stored. So an extra second is necessary.\n\nhttps://github.com/openstack/nova/blob/29e5b0ad7bde210f95885656768f0480d06882c0/nova/db/sqlalchemy/api.py#L2032","commit_id":"dfba7824c3403bde1d20091d77ffe2a70dbe7ca0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"36187c7602025d7246e9a9f6cd1cf8648e8e524c","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            # Sleep 1 second"},{"line_number":171,"context_line":"            time.sleep(1)"},{"line_number":172,"context_line":"        else:"},{"line_number":173,"context_line":"            self.fail(\"The nmuber of instance actions for server %s \""},{"line_number":174,"context_line":"                      \"was not %d after 60 s\" %"},{"line_number":175,"context_line":"                      (server.id, expected_num_of_actions))"},{"line_number":176,"context_line":"        # NOTE(takashin): In some DBMSs (e.g. MySQL 5.7), fractions"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_73a04fa6","line":173,"range":{"start_line":173,"start_character":27,"end_line":173,"end_character":33},"updated":"2019-02-27 00:44:09.000000000","message":"number","commit_id":"753c2578ff545a8be2ed87a8bf508b9432fb8a4a"}]}