)]}'
{"novaclient/v2/flavors.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5bb3ef16df4edee7866ff0fa544a2c645b2d7de4","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        :param min_disk: Filters the flavors by a minimum disk space, in GiB."},{"line_number":117,"context_line":"        :param min_ram: Filters the flavors by a minimum RAM, in MiB."},{"line_number":118,"context_line":"        :param limit: maximum number of flavors to return (optional)."},{"line_number":119,"context_line":"                      If limit is either not specified or is larger than"},{"line_number":120,"context_line":"                      \u0027CONF.api.max_limit\u0027 option of Nova API, limit"},{"line_number":121,"context_line":"                      \u0027CONF.api.max_limit\u0027 will be used."},{"line_number":122,"context_line":"        :param sort_key: Flavors list sort key (optional)."},{"line_number":123,"context_line":"        :param sort_dir: Flavors list sort direction (optional)."},{"line_number":124,"context_line":"        :returns: list of :class:`Flavor`."}],"source_content_type":"text/x-python","patch_set":7,"id":"ffb9cba7_662519c2","line":121,"range":{"start_line":119,"start_character":0,"end_line":121,"end_character":56},"updated":"2019-04-26 15:54:46.000000000","message":"I agree with matt here. We need to word this from an API user perspective, they can\u0027t see nova.conf or what it is set too.\n\nAs such, we should say something like:\n\n\"Note the server has a configurable default limit, which is used by default if no limit is specified here. If you specify a higher limit than the server side configuration, your request will be ignored.\"","commit_id":"75cb378a15665d5a4d6e2c0c0c8d45facab08cea"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"63145332d3d8c3d9a954f4bf6373b983a54eccc6","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        :param min_disk: Filters the flavors by a minimum disk space, in GiB."},{"line_number":117,"context_line":"        :param min_ram: Filters the flavors by a minimum RAM, in MiB."},{"line_number":118,"context_line":"        :param limit: maximum number of flavors to return (optional)."},{"line_number":119,"context_line":"                      If limit is either not specified or is larger than"},{"line_number":120,"context_line":"                      \u0027CONF.api.max_limit\u0027 option of Nova API, limit"},{"line_number":121,"context_line":"                      \u0027CONF.api.max_limit\u0027 will be used."},{"line_number":122,"context_line":"        :param sort_key: Flavors list sort key (optional)."},{"line_number":123,"context_line":"        :param sort_dir: Flavors list sort direction (optional)."},{"line_number":124,"context_line":"        :returns: list of :class:`Flavor`."}],"source_content_type":"text/x-python","patch_set":7,"id":"ffb9cba7_0bebf212","line":121,"range":{"start_line":119,"start_character":0,"end_line":121,"end_character":56},"in_reply_to":"ffb9cba7_662519c2","updated":"2019-04-28 11:50:33.000000000","message":"yes, thank.\nDone.","commit_id":"75cb378a15665d5a4d6e2c0c0c8d45facab08cea"}],"novaclient/v2/migrations.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"cf58814eecfdb3ee2d0d7dbb304b125fb5d19f80","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        :param marker: Begin returning migrations that appear later in the"},{"line_number":95,"context_line":"        migrations list than that represented by this migration UUID"},{"line_number":96,"context_line":"        (optional)."},{"line_number":97,"context_line":"        :param limit: maximum number of migrations to return (optional)."},{"line_number":98,"context_line":"        :param changes_since: Only return migrations changed later or equal"},{"line_number":99,"context_line":"        to a certain point of time. The provided time should be an ISO 8061"},{"line_number":100,"context_line":"        formatted time. e.g. 2016-03-04T06:27:59Z . (optional)."}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_f656245c","line":97,"range":{"start_line":97,"start_character":8,"end_line":97,"end_character":72},"updated":"2019-03-28 22:18:26.000000000","message":"It should also be fixed.","commit_id":"6ac70a5daf9b28527b4e802fb4e0f487bd151c75"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"d0f5a7152dfffb25bb8bd6fe2bd9f09ff989370d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        :param marker: Begin returning migrations that appear later in the"},{"line_number":95,"context_line":"        migrations list than that represented by this migration UUID"},{"line_number":96,"context_line":"        (optional)."},{"line_number":97,"context_line":"        :param limit: maximum number of migrations to return (optional)."},{"line_number":98,"context_line":"        :param changes_since: Only return migrations changed later or equal"},{"line_number":99,"context_line":"        to a certain point of time. The provided time should be an ISO 8061"},{"line_number":100,"context_line":"        formatted time. e.g. 2016-03-04T06:27:59Z . (optional)."}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_90ed6326","line":97,"range":{"start_line":97,"start_character":8,"end_line":97,"end_character":72},"in_reply_to":"5fc1f717_f656245c","updated":"2019-03-29 01:12:33.000000000","message":"Done","commit_id":"6ac70a5daf9b28527b4e802fb4e0f487bd151c75"}],"novaclient/v2/servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"69519b1cf204bdb0227978cf601aed44bc3f9d02","unresolved":false,"context_lines":[{"line_number":832,"context_line":"        :param marker: Begin returning servers that appear later in the server"},{"line_number":833,"context_line":"                       list than that represented by this server id (optional)."},{"line_number":834,"context_line":"        :param limit: Maximum number of servers to return (optional)."},{"line_number":835,"context_line":"            If limit \u003d\u003d -1, all servers will be return. If limit is bigger than"},{"line_number":836,"context_line":"            \u0027CONF.api.max_limit\u0027 option of Nova API, limit \u0027CONF.api.max_limit\u0027"},{"line_number":837,"context_line":"            will be used."},{"line_number":838,"context_line":"        :param sort_keys: List of sort keys"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_7e2ca2ab","line":835,"range":{"start_line":835,"start_character":48,"end_line":835,"end_character":54},"updated":"2019-03-13 12:38:45.000000000","message":"returned","commit_id":"8240019c8a3b48e327d3f6f037b0afcbce1bad4c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"69519b1cf204bdb0227978cf601aed44bc3f9d02","unresolved":false,"context_lines":[{"line_number":833,"context_line":"                       list than that represented by this server id (optional)."},{"line_number":834,"context_line":"        :param limit: Maximum number of servers to return (optional)."},{"line_number":835,"context_line":"            If limit \u003d\u003d -1, all servers will be return. If limit is bigger than"},{"line_number":836,"context_line":"            \u0027CONF.api.max_limit\u0027 option of Nova API, limit \u0027CONF.api.max_limit\u0027"},{"line_number":837,"context_line":"            will be used."},{"line_number":838,"context_line":"        :param sort_keys: List of sort keys"},{"line_number":839,"context_line":"        :param sort_dirs: List of sort directions"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_3e1cda76","line":836,"range":{"start_line":836,"start_character":13,"end_line":836,"end_character":31},"updated":"2019-03-13 12:38:45.000000000","message":"This isn\u0027t really something the client-side user has control over so we should re-word this.\n\nAlso, https://developer.openstack.org/api-guide/compute/paginated_collections.html says a 413 error is returned if the requested limit is bigger than the configured max limit. But looking at the code I think that doc is wrong, the API just takes the min of the configured and requested limit:\n\nhttps://github.com/openstack/nova/blob/2529ddfbe7940e90548175d6e2032383c38cda8f/nova/api/openstack/common.py#L215\n\nSo maybe we should just say, \"The server has a configurable maximum limit and if the limit is either not specified or is larger than the configurable maximum limit in the server, the configured maximum limit will be used.\"","commit_id":"8240019c8a3b48e327d3f6f037b0afcbce1bad4c"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"bddee3de1b87eef9dc09fdbd34a85ed470d542c2","unresolved":false,"context_lines":[{"line_number":833,"context_line":"                       list than that represented by this server id (optional)."},{"line_number":834,"context_line":"        :param limit: Maximum number of servers to return (optional)."},{"line_number":835,"context_line":"            If limit \u003d\u003d -1, all servers will be return. If limit is bigger than"},{"line_number":836,"context_line":"            \u0027CONF.api.max_limit\u0027 option of Nova API, limit \u0027CONF.api.max_limit\u0027"},{"line_number":837,"context_line":"            will be used."},{"line_number":838,"context_line":"        :param sort_keys: List of sort keys"},{"line_number":839,"context_line":"        :param sort_dirs: List of sort directions"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_f96d0ccc","line":836,"range":{"start_line":836,"start_character":13,"end_line":836,"end_character":31},"in_reply_to":"5fc1f717_3e1cda76","updated":"2019-03-13 12:43:36.000000000","message":"yes, If limit is equal -1,this part code will get all servers, so i think the docs string should describe this situation.","commit_id":"8240019c8a3b48e327d3f6f037b0afcbce1bad4c"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"7a9a81b09a0ae9ce5556231df0f5e1e2f629aa69","unresolved":false,"context_lines":[{"line_number":834,"context_line":"        :param limit: Maximum number of servers to return (optional)."},{"line_number":835,"context_line":"            If limit is either not specified or is larger than"},{"line_number":836,"context_line":"            \u0027CONF.api.max_limit\u0027 option of Nova API, limit \u0027CONF.api.max_limit\u0027"},{"line_number":837,"context_line":"            will be used. If limit \u003d\u003d -1, all servers will be returned."},{"line_number":838,"context_line":"        :param sort_keys: List of sort keys"},{"line_number":839,"context_line":"        :param sort_dirs: List of sort directions"},{"line_number":840,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_6fe5bb08","line":837,"range":{"start_line":837,"start_character":29,"end_line":837,"end_character":40},"updated":"2019-03-14 05:15:44.000000000","message":"The minimum value of CONF.api.max_limit is 0.\n\nhttps://github.com/openstack/nova/blob/ca7cb9eeb7192f4320c95e2e323886627963f10d/nova/conf/api.py#L238\n\nIf argument limit is -1, the query parameter is not set. (line 873).\nSo CONF.api.max_limit is used in the nova side.","commit_id":"d5c761e24ec83036031936b48aea7277cc2385ee"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"7a9a81b09a0ae9ce5556231df0f5e1e2f629aa69","unresolved":false,"context_lines":[{"line_number":870,"context_line":"            if marker:"},{"line_number":871,"context_line":"                qparams[\u0027marker\u0027] \u003d marker"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"            if limit and limit !\u003d -1:"},{"line_number":874,"context_line":"                qparams[\u0027limit\u0027] \u003d limit"},{"line_number":875,"context_line":""},{"line_number":876,"context_line":"            # Transform the dict to a sequence of two-element tuples in fixed"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_2feb33dc","line":873,"range":{"start_line":873,"start_character":12,"end_line":873,"end_character":36},"updated":"2019-03-14 05:15:44.000000000","message":"Here","commit_id":"d5c761e24ec83036031936b48aea7277cc2385ee"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"da7bfd7ade7bbb70c0c709820a58a48fc60279b3","unresolved":false,"context_lines":[{"line_number":896,"context_line":"            result.extend(servers)"},{"line_number":897,"context_line":"            result.append_request_ids(servers.request_ids)"},{"line_number":898,"context_line":""},{"line_number":899,"context_line":"            if not servers or limit !\u003d -1:"},{"line_number":900,"context_line":"                break"},{"line_number":901,"context_line":"            marker \u003d result[-1].id"},{"line_number":902,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_8f6a67ea","line":899,"range":{"start_line":899,"start_character":12,"end_line":899,"end_character":42},"updated":"2019-03-14 06:00:40.000000000","message":"hello, thanks for your review. I understand your means about \"If argument limit is -1, the query parameter is not set. (line 873)\". In this line(), if limit \u003d\u003d -1 and more than max_limit servers, it will\u0027t break and continue enter while cycle to get all servers, so i decscribe that \"If limit \u003d\u003d -1, all servers will be returned.\"","commit_id":"d5c761e24ec83036031936b48aea7277cc2385ee"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"af11dc68b8dc916f3e805e55be2cbe4343ebf987","unresolved":false,"context_lines":[{"line_number":832,"context_line":"        :param marker: Begin returning servers that appear later in the server"},{"line_number":833,"context_line":"                       list than that represented by this server id (optional)."},{"line_number":834,"context_line":"        :param limit: Maximum number of servers to return (optional)."},{"line_number":835,"context_line":"                      Note the server has a configurable default limit."},{"line_number":836,"context_line":"                      If no limit is specified here or limit is larger"},{"line_number":837,"context_line":"                      than default, the default limit will be used."},{"line_number":838,"context_line":"                      If limit \u003d\u003d -1, all servers will be returned."}],"source_content_type":"text/x-python","patch_set":11,"id":"dfbec78f_1f6064a5","line":835,"range":{"start_line":835,"start_character":27,"end_line":835,"end_character":37},"updated":"2019-05-07 01:40:53.000000000","message":"IMO, it is a little confusing. A \"server\" sometimes stands for a VM instance. This expression should be replaced with another expression.","commit_id":"8b253160ccfe1293daa0e911c9df9fec1b215cee"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"1af15c0b159378a4db908a833835650229802176","unresolved":false,"context_lines":[{"line_number":832,"context_line":"        :param marker: Begin returning servers that appear later in the server"},{"line_number":833,"context_line":"                       list than that represented by this server id (optional)."},{"line_number":834,"context_line":"        :param limit: Maximum number of servers to return (optional)."},{"line_number":835,"context_line":"                      Note the server has a configurable default limit."},{"line_number":836,"context_line":"                      If no limit is specified here or limit is larger"},{"line_number":837,"context_line":"                      than default, the default limit will be used."},{"line_number":838,"context_line":"                      If limit \u003d\u003d -1, all servers will be returned."}],"source_content_type":"text/x-python","patch_set":11,"id":"dfbec78f_7a74aafe","line":835,"range":{"start_line":835,"start_character":27,"end_line":835,"end_character":37},"in_reply_to":"dfbec78f_1f6064a5","updated":"2019-05-13 13:53:03.000000000","message":"Done","commit_id":"8b253160ccfe1293daa0e911c9df9fec1b215cee"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"7a3f79006b3274248fb0e46425b8962d3aa798f7","unresolved":false,"context_lines":[{"line_number":832,"context_line":"        :param marker: Begin returning servers that appear later in the server"},{"line_number":833,"context_line":"                       list than that represented by this server id (optional)."},{"line_number":834,"context_line":"        :param limit: Maximum number of servers to return (optional)."},{"line_number":835,"context_line":"                      Note the Api server has a configurable default limit."},{"line_number":836,"context_line":"                      If no limit is specified here or limit is larger than"},{"line_number":837,"context_line":"                      default, the default limit will be used."},{"line_number":838,"context_line":"                      If limit \u003d\u003d -1, all servers will be returned."}],"source_content_type":"text/x-python","patch_set":12,"id":"bfb3d3c7_1da41f08","line":835,"range":{"start_line":835,"start_character":31,"end_line":835,"end_character":34},"updated":"2019-05-17 02:45:08.000000000","message":"nit: \u0027API\u0027 is better.","commit_id":"73d5b604b3b0807b855ed10b4861e0f76be78242"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"4f586bdcfb08e944dd0dc43402053c3a72cb7f19","unresolved":false,"context_lines":[{"line_number":832,"context_line":"        :param marker: Begin returning servers that appear later in the server"},{"line_number":833,"context_line":"                       list than that represented by this server id (optional)."},{"line_number":834,"context_line":"        :param limit: Maximum number of servers to return (optional)."},{"line_number":835,"context_line":"                      Note the Api server has a configurable default limit."},{"line_number":836,"context_line":"                      If no limit is specified here or limit is larger than"},{"line_number":837,"context_line":"                      default, the default limit will be used."},{"line_number":838,"context_line":"                      If limit \u003d\u003d -1, all servers will be returned."}],"source_content_type":"text/x-python","patch_set":12,"id":"bfb3d3c7_dd20c74c","line":835,"range":{"start_line":835,"start_character":31,"end_line":835,"end_character":34},"in_reply_to":"bfb3d3c7_1da41f08","updated":"2019-05-17 03:03:09.000000000","message":"Done","commit_id":"73d5b604b3b0807b855ed10b4861e0f76be78242"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"1c3f2526eecd3ae6da628007a91d46db1cc7bc00","unresolved":false,"context_lines":[{"line_number":832,"context_line":"        :param marker: Begin returning servers that appear later in the server"},{"line_number":833,"context_line":"                       list than that represented by this server id (optional)."},{"line_number":834,"context_line":"        :param limit: Maximum number of servers to return (optional)."},{"line_number":835,"context_line":"                      Note the Api server has a configurable default limit."},{"line_number":836,"context_line":"                      If no limit is specified here or limit is larger than"},{"line_number":837,"context_line":"                      default, the default limit will be used."},{"line_number":838,"context_line":"                      If limit \u003d\u003d -1, all servers will be returned."}],"source_content_type":"text/x-python","patch_set":12,"id":"bfb3d3c7_bd5073d6","line":835,"range":{"start_line":835,"start_character":31,"end_line":835,"end_character":34},"in_reply_to":"bfb3d3c7_1da41f08","updated":"2019-05-17 02:55:57.000000000","message":"Yep, i will update it.","commit_id":"73d5b604b3b0807b855ed10b4861e0f76be78242"}]}