)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"8449bc4c6a0bd6c761329f3358341f677f5a85eb","unresolved":false,"context_lines":[{"line_number":12,"context_line":"when locking the server and to filter/sort out instances that are"},{"line_number":13,"context_line":"locked or unlocked while listing servers from the 2.73 microversion."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements blueprint add-locked-reason"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I438e6db2dd5000ba388d0a0f1c8ab74b96b47a71"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ffb9cba7_9a742e6a","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":10},"updated":"2019-04-26 01:24:15.000000000","message":"Implements:","commit_id":"f54bcf81c02aa5e99ff4be0fa1e7b4c26d607452"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"8449bc4c6a0bd6c761329f3358341f677f5a85eb","unresolved":false,"context_lines":[{"line_number":13,"context_line":"locked or unlocked while listing servers from the 2.73 microversion."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements blueprint add-locked-reason"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I438e6db2dd5000ba388d0a0f1c8ab74b96b47a71"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ffb9cba7_fa5d2ae9","line":16,"updated":"2019-04-26 01:24:15.000000000","message":"Add \"Depends-On: https://review.opendev.org/#/c/648662/\"","commit_id":"f54bcf81c02aa5e99ff4be0fa1e7b4c26d607452"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"8d4c246aa7d4d0e19eec0e116983d5734a4731e1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"locked or unlocked while listing servers from the 2.73 microversion."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements blueprint add-locked-reason"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I438e6db2dd5000ba388d0a0f1c8ab74b96b47a71"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dfbec78f_096e8ec8","line":16,"in_reply_to":"ffb9cba7_fa5d2ae9","updated":"2019-05-13 12:16:26.000000000","message":"Done","commit_id":"f54bcf81c02aa5e99ff4be0fa1e7b4c26d607452"}],"novaclient/tests/unit/v2/fakes.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"fe9ce49576a81c7641467ba06d8c648afc493dfc","unresolved":false,"context_lines":[{"line_number":851,"context_line":"                        expected.add(\u0027locked_reason\u0027)"},{"line_number":852,"context_line":"                    assert set(body[action].keys()) \u003d\u003d expected"},{"line_number":853,"context_line":"                else:"},{"line_number":854,"context_line":"                    assert body[action] is None"},{"line_number":855,"context_line":"        elif action \u003d\u003d \u0027rebuild\u0027:"},{"line_number":856,"context_line":"            body \u003d body[action]"},{"line_number":857,"context_line":"            adminPass \u003d body.get(\u0027adminPass\u0027, \u0027randompassword\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_e95d3115","line":854,"range":{"start_line":854,"start_character":20,"end_line":854,"end_character":47},"updated":"2019-05-13 17:50:09.000000000","message":"this seems redundant given L847/853","commit_id":"a1ac69c69a4fede8ac02b165d23f62b30a242a48"}],"novaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6619221640d99551650029d1f73ceb6858f0dfe4","unresolved":false,"context_lines":[{"line_number":2096,"context_line":"        self.assertRaises(SystemExit,"},{"line_number":2097,"context_line":"                          self.run_command,"},{"line_number":2098,"context_line":"                          \u0027lock sample-server --reason zombies \u0027,"},{"line_number":2099,"context_line":"                          api_version\u003d\u00272.72\u0027)"},{"line_number":2100,"context_line":""},{"line_number":2101,"context_line":"    def test_lock_v273(self):"},{"line_number":2102,"context_line":"        self.run_command(\u0027lock sample-server\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_dd2b74e8","line":2099,"updated":"2019-05-10 10:23:12.000000000","message":"Do we have something specific in the exception to assert to see that this command failed due the two low microversion?","commit_id":"f54bcf81c02aa5e99ff4be0fa1e7b4c26d607452"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"8d4c246aa7d4d0e19eec0e116983d5734a4731e1","unresolved":false,"context_lines":[{"line_number":2096,"context_line":"        self.assertRaises(SystemExit,"},{"line_number":2097,"context_line":"                          self.run_command,"},{"line_number":2098,"context_line":"                          \u0027lock sample-server --reason zombies \u0027,"},{"line_number":2099,"context_line":"                          api_version\u003d\u00272.72\u0027)"},{"line_number":2100,"context_line":""},{"line_number":2101,"context_line":"    def test_lock_v273(self):"},{"line_number":2102,"context_line":"        self.run_command(\u0027lock sample-server\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_84a90525","line":2099,"in_reply_to":"dfbec78f_ae3e84d7","updated":"2019-05-13 12:16:26.000000000","message":"looks like it happens here: https://github.com/openstack/python-novaclient/blob/b0dd41fc02ba821ce987d0041fca6388cfac2fe5/novaclient/shell.py#L219 , nothing particlar shows its due to bad microversion support :(","commit_id":"f54bcf81c02aa5e99ff4be0fa1e7b4c26d607452"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"85f27d04dbc3b4538d8d0839c6432aa9aa260e44","unresolved":false,"context_lines":[{"line_number":2096,"context_line":"        self.assertRaises(SystemExit,"},{"line_number":2097,"context_line":"                          self.run_command,"},{"line_number":2098,"context_line":"                          \u0027lock sample-server --reason zombies \u0027,"},{"line_number":2099,"context_line":"                          api_version\u003d\u00272.72\u0027)"},{"line_number":2100,"context_line":""},{"line_number":2101,"context_line":"    def test_lock_v273(self):"},{"line_number":2102,"context_line":"        self.run_command(\u0027lock sample-server\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_ae3e84d7","line":2099,"in_reply_to":"dfbec78f_dd2b74e8","updated":"2019-05-13 08:42:58.000000000","message":"yea I think we should have something, I\u0027ll assertIn the statement after catching the exception.","commit_id":"f54bcf81c02aa5e99ff4be0fa1e7b4c26d607452"}],"novaclient/v2/shell.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"8449bc4c6a0bd6c761329f3358341f677f5a85eb","unresolved":false,"context_lines":[{"line_number":1566,"context_line":"@utils.arg("},{"line_number":1567,"context_line":"    \u0027--locked\u0027,"},{"line_number":1568,"context_line":"    dest\u003d\u0027locked\u0027,"},{"line_number":1569,"context_line":"    metavar\u003d\u0027\u003clocked\u003e\u0027,"},{"line_number":1570,"context_line":"    default\u003dNone,"},{"line_number":1571,"context_line":"    help\u003d_(\u0027Only display locked or unlocked servers\u0027),"},{"line_number":1572,"context_line":"    start_version\u003d\"2.73\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_3a32e2a8","line":1569,"range":{"start_line":1569,"start_character":4,"end_line":1569,"end_character":22},"updated":"2019-04-26 01:24:15.000000000","message":"In https://review.opendev.org/#/c/648662/7, the query parameter is defined as a boolean. So \u0027--locked\u0027 should be a boolean option. This line should be removed and the following lines should be added.\n\naction\u003d\"store_true\",\ndefault\u003dFalse,","commit_id":"f54bcf81c02aa5e99ff4be0fa1e7b4c26d607452"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"62616c8aedfd0238e727344c1b6f788b85120c5b","unresolved":false,"context_lines":[{"line_number":1566,"context_line":"@utils.arg("},{"line_number":1567,"context_line":"    \u0027--locked\u0027,"},{"line_number":1568,"context_line":"    dest\u003d\u0027locked\u0027,"},{"line_number":1569,"context_line":"    metavar\u003d\u0027\u003clocked\u003e\u0027,"},{"line_number":1570,"context_line":"    default\u003dNone,"},{"line_number":1571,"context_line":"    help\u003d_(\u0027Only display locked or unlocked servers\u0027),"},{"line_number":1572,"context_line":"    start_version\u003d\"2.73\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_9cd8797b","line":1569,"range":{"start_line":1569,"start_character":4,"end_line":1569,"end_character":22},"in_reply_to":"ffb9cba7_3a32e2a8","updated":"2019-04-30 01:17:22.000000000","message":"hmm, if that\u0027s not allowed then maybe I should change it here, because my intension is to do something like \"all-tenants\": https://review.opendev.org/#/c/648662/7/api-ref/source/parameters.yaml@395 and not a boolean thing. because \"--locked\" cannot be a boolean by default it shouldn\u0027t be false unless the user wants locked\u003dfalse instances. \"locked\" is not the same like \"deleted\". If user says give me locked\u003dTrue then we give only locked instances and if user says locked\u003dFalse then we give only unlocked instances. By default giving unlocked instances only is not the intention.","commit_id":"f54bcf81c02aa5e99ff4be0fa1e7b4c26d607452"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"36be2c0d4a346c2697f2e345cc919b423ea3a8a9","unresolved":false,"context_lines":[{"line_number":1566,"context_line":"@utils.arg("},{"line_number":1567,"context_line":"    \u0027--locked\u0027,"},{"line_number":1568,"context_line":"    dest\u003d\u0027locked\u0027,"},{"line_number":1569,"context_line":"    metavar\u003d\u0027\u003clocked\u003e\u0027,"},{"line_number":1570,"context_line":"    default\u003dNone,"},{"line_number":1571,"context_line":"    help\u003d_(\u0027Only display locked or unlocked servers\u0027),"},{"line_number":1572,"context_line":"    start_version\u003d\"2.73\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_f8c2cf33","line":1569,"range":{"start_line":1569,"start_character":4,"end_line":1569,"end_character":22},"in_reply_to":"ffb9cba7_9cd8797b","updated":"2019-05-01 08:02:25.000000000","message":"Fair enough.","commit_id":"f54bcf81c02aa5e99ff4be0fa1e7b4c26d607452"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bd454734a291c7b7ff25c6b3202da1b206759639","unresolved":false,"context_lines":[{"line_number":1568,"context_line":"    dest\u003d\u0027locked\u0027,"},{"line_number":1569,"context_line":"    metavar\u003d\u0027\u003clocked\u003e\u0027,"},{"line_number":1570,"context_line":"    default\u003dNone,"},{"line_number":1571,"context_line":"    help\u003d_(\u0027Display servers based on their locked value\u0027),"},{"line_number":1572,"context_line":"    start_version\u003d\"2.73\")"},{"line_number":1573,"context_line":"def do_list(cs, args):"},{"line_number":1574,"context_line":"    \"\"\"List servers.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_e13f8522","line":1571,"updated":"2019-05-13 23:25:29.000000000","message":"Would be good to mention that a value needs to be supplied with this option, e.g. true to only list locked servers, false to only list unlocked servers. I know there are a bunch of other supported values in the API like yes/no/True/False/1/0 but I don\u0027t think we need to enumerate all of those here.\n\nAlso note that the CLI docs should be updated:\n\nhttps://github.com/openstack/python-novaclient/blob/master/doc/source/cli/nova.rst#nova-list","commit_id":"a1ac69c69a4fede8ac02b165d23f62b30a242a48"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"eb358344e5c3c4bcd8db0ee2a3c4e53e377ee9f3","unresolved":false,"context_lines":[{"line_number":1568,"context_line":"    dest\u003d\u0027locked\u0027,"},{"line_number":1569,"context_line":"    metavar\u003d\u0027\u003clocked\u003e\u0027,"},{"line_number":1570,"context_line":"    default\u003dNone,"},{"line_number":1571,"context_line":"    help\u003d_(\u0027Display servers based on their locked value\u0027),"},{"line_number":1572,"context_line":"    start_version\u003d\"2.73\")"},{"line_number":1573,"context_line":"def do_list(cs, args):"},{"line_number":1574,"context_line":"    \"\"\"List servers.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_a9596b35","line":1571,"in_reply_to":"dfbec78f_e13f8522","updated":"2019-05-14 11:43:45.000000000","message":"Done","commit_id":"a1ac69c69a4fede8ac02b165d23f62b30a242a48"}],"releasenotes/notes/bp-add-locked-reason-3f136db97b820c73.yaml":[{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"49a7d47443310961976d67110388dbc509cc0a2e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added a new ``--reason`` option to ``nova lock`` command"},{"line_number":4,"context_line":"    in microversion 2.73. It enables administrators to specify"},{"line_number":5,"context_line":"    a reason when locking a server."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_156dddca","line":4,"range":{"start_line":4,"start_character":37,"end_line":4,"end_character":51},"updated":"2019-03-29 10:45:34.000000000","message":"err, anyone!","commit_id":"29cfa798d348d730fc54d746781979862ed7adbd"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6619221640d99551650029d1f73ceb6858f0dfe4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    a new ``--locked`` filter option to ``nova list`` command"},{"line_number":5,"context_line":"    in microversion 2.73. It enables users to specify a reason when"},{"line_number":6,"context_line":"    locking a server and also to filter servers based on whether they"},{"line_number":7,"context_line":"    are locked or not."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dfbec78f_ddc7f411","line":7,"updated":"2019-05-10 10:23:12.000000000","message":"Do we also support sorting on locked in the CLI?","commit_id":"f54bcf81c02aa5e99ff4be0fa1e7b4c26d607452"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"85f27d04dbc3b4538d8d0839c6432aa9aa260e44","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    a new ``--locked`` filter option to ``nova list`` command"},{"line_number":5,"context_line":"    in microversion 2.73. It enables users to specify a reason when"},{"line_number":6,"context_line":"    locking a server and also to filter servers based on whether they"},{"line_number":7,"context_line":"    are locked or not."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dfbec78f_0e5a304e","line":7,"in_reply_to":"dfbec78f_ddc7f411","updated":"2019-05-13 08:42:58.000000000","message":"oh good point, I\u0027ll add this","commit_id":"f54bcf81c02aa5e99ff4be0fa1e7b4c26d607452"}]}