)]}'
{"id":"openstack%2Fpython-novaclient~6498","triplet_id":"openstack%2Fpython-novaclient~master~I18187eb68d936632b4ae78676a0a9f062afba8f2","project":"openstack/python-novaclient","branch":"master","topic":"bug/940432","hashtags":[],"change_id":"I18187eb68d936632b4ae78676a0a9f062afba8f2","subject":"Rename NOVA_VERSION to OS_COMPUTE_API_VERSION.","status":"MERGED","created":"2012-04-12 19:17:23.000000000","updated":"2012-04-23 22:24:43.000000000","submitted":"2012-04-23 22:24:43.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"88ae021e77150865c6f192ec419cd03256267c14","_number":6498,"virtual_id_number":6498,"owner":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":1,"date":"2012-04-23 22:24:43.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"all":[{"value":0,"date":"2012-04-13 17:04:37.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":2,"date":"2012-04-23 20:20:27.000000000","_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"date":"2012-04-23 20:28:07.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2012-04-13 17:03:04.000000000","_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"all":[{"value":1,"date":"2012-04-23 22:06:23.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":1,"date":"2012-04-23 20:20:27.000000000","_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-04-13 17:03:04.000000000","_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-04-13 17:03:04.000000000","updated_by":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"reviewer":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"state":"REVIEWER"},{"updated":"2012-04-23 20:20:27.000000000","updated_by":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"reviewer":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"state":"REVIEWER"},{"updated":"2012-04-23 22:24:43.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"dcf9f2e5ad490d084bbc4ecaf549a00c0a969017","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2012-04-12 23:38:09.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t submit this\n\nWe need to use something specific to COMPUTE so we can specify individual api versions for in a novarc file.","accounts_in_message":[],"_revision_number":1},{"id":"d90705f711767e477f78921aadbb8b8c9d83aa98","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2012-04-13 14:49:19.000000000","message":"Patch Set 1:\n\nOops, good call Brian. I misread the details of the bug report. Re-pushing.","accounts_in_message":[],"_revision_number":1},{"id":"a89161ceb4cab0ac60cc835f65e948d94a127c91","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2012-04-13 15:41:39.000000000","message":"Patch Set 1:\n\nI was planning on using OS_IMAGE_API_VERSION in python-glanceclient, fwiw","accounts_in_message":[],"_revision_number":1},{"id":"b33cfad8abe43ecb4cf542047a30f241df17880b","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2012-04-13 15:48:09.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0e433cc946475442d1be9f85290aa732911154fa","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2012-04-13 17:03:04.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nWorks for me. Not worried about breaking backwards-compatibility as we only support one version right now.","accounts_in_message":[],"_revision_number":2},{"id":"a7083234934798a4355d7749a910622cc2f3837f","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2012-04-13 17:04:37.000000000","message":"Patch Set 2:\n\nYeah, since it defaults to the only version that we support, I didn\u0027t bother leaving NOVA_VERSION around.","accounts_in_message":[],"_revision_number":2},{"id":"e86c38ad344569cac03e559a3a6a6804d531b452","author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"date":"2012-04-23 20:20:27.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\nNice change","accounts_in_message":[],"_revision_number":2},{"id":"3269a97419b2769b750cccbf7b12418be2786bf0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-04-23 20:28:07.000000000","message":"Patch Set 2: Fails\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-python-novaclient-merge/171/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/3575/ : FAILURE \nhttps://jenkins.openstack.org/job/gate-python-novaclient-unittests/186/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-pep8/175/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"3c9f770c8742f33a7bfc89401b1a332954ec2d1d","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2012-04-23 22:06:23.000000000","message":"Patch Set 2: Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"a270c43d896c71b33bf7bdd1bf71033ec7a2a254","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-04-23 22:24:43.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"7aff6262abb61e9b568cf97f2f5e40993876b540","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-04-23 22:24:43.000000000","message":"Patch Set 2: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-python-novaclient-merge/172/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/3576/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-unittests/187/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-pep8/176/ : SUCCESS","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"765f551a267f07e43eb3acb92835ac7e5d6ca31b","revisions":{"b2881841491c10d38254bec39f6ccb24a3768195":{"kind":"REWORK","_number":1,"created":"2012-04-12 19:17:23.000000000","uploader":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"ref":"refs/changes/98/6498/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/98/6498/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/98/6498/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/98/6498/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/98/6498/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/98/6498/1"}}},"commit":{"parents":[{"commit":"ad4a04a64e3a49c5613e766a9f93727cd6b8a678","subject":"Make \u0027--help\u0027 argument more useful.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/ad4a04a64e3a49c5613e766a9f93727cd6b8a678"}]}],"author":{"name":"Josh Kearney","email":"josh@jk0.org","date":"2012-04-12 19:16:31.000000000","tz":-300},"committer":{"name":"Josh Kearney","email":"josh@jk0.org","date":"2012-04-12 19:17:19.000000000","tz":-300},"subject":"Rename NOVA_VERSION to OS_API_VERSION.","message":"Rename NOVA_VERSION to OS_API_VERSION.\n\nFixes bug 940432.\n\nChange-Id: I18187eb68d936632b4ae78676a0a9f062afba8f2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b2881841491c10d38254bec39f6ccb24a3768195"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b2881841491c10d38254bec39f6ccb24a3768195"}]},"branch":"refs/heads/master"},"765f551a267f07e43eb3acb92835ac7e5d6ca31b":{"kind":"REWORK","_number":2,"created":"2012-04-13 15:48:09.000000000","uploader":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"ref":"refs/changes/98/6498/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/98/6498/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/98/6498/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/98/6498/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/98/6498/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/98/6498/2"}}},"commit":{"parents":[{"commit":"d6d7386fad20fe3165419b3ab2ee51bd90b46e2c","subject":"Update unittests to be Python 2.6 compatible.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d6d7386fad20fe3165419b3ab2ee51bd90b46e2c"}]}],"author":{"name":"Josh Kearney","email":"josh@jk0.org","date":"2012-04-12 19:16:31.000000000","tz":-300},"committer":{"name":"Josh Kearney","email":"josh@jk0.org","date":"2012-04-13 15:48:05.000000000","tz":-300},"subject":"Rename NOVA_VERSION to OS_COMPUTE_API_VERSION.","message":"Rename NOVA_VERSION to OS_COMPUTE_API_VERSION.\n\nFixes bug 940432.\n\nChange-Id: I18187eb68d936632b4ae78676a0a9f062afba8f2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/765f551a267f07e43eb3acb92835ac7e5d6ca31b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/765f551a267f07e43eb3acb92835ac7e5d6ca31b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}