)]}'
{"id":"openstack%2Fpython-novaclient~650235","triplet_id":"openstack%2Fpython-novaclient~master~Iaeec1e74262a35f3de3c81f7013835a6aa6f9029","project":"openstack/python-novaclient","branch":"master","topic":"bug/1823287","hashtags":[],"change_id":"Iaeec1e74262a35f3de3c81f7013835a6aa6f9029","subject":"Revert \"Fix crashing console-log\"","status":"MERGED","created":"2019-04-05 06:54:18.000000000","updated":"2019-04-11 16:08:19.000000000","submitted":"2019-04-05 22:56:38.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"650235-1554504998124-b57ba32f","meta_rev_id":"c78ed84191b245d74e4f4f9ba5ef1b7da4e74e94","_number":650235,"virtual_id_number":650235,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},{"value":2,"date":"2019-04-05 22:56:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"all":[{"value":2,"date":"2019-04-05 07:35:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":2,"date":"2019-04-05 14:26:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":1,"date":"2019-04-05 14:26:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2019-04-05 06:56:52.000000000","_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-05 06:56:52.000000000","updated_by":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"reviewer":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"state":"REVIEWER"},{"updated":"2019-04-05 07:35:36.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2019-04-05 14:26:21.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2019-04-05 22:56:37.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0d8ad6db3018c9372d7cf5d27965aa6cf01358ae","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-04-05 06:54:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2689a869d61531a840d02089bb7d5215e8f8ce59","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-04-05 07:35:36.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"12aba63d08bca2f92dba24e908cbf90752003a51","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-04-05 07:39:30.000000000","message":"Patch Set 1:\n\nNeeds a follow-up patch to fix an original issue (bug 1746534) or describe the solution in the document.","accounts_in_message":[],"_revision_number":1},{"id":"435474e014997ac5367298970281d6b3fde49043","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-05 08:49:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/35/650235/1/check/tempest-full/ef7a504/ : SUCCESS in 1h 50m 18s\n- tempest-full-py3 http://logs.openstack.org/35/650235/1/check/tempest-full-py3/f362d63/ : SUCCESS in 1h 31m 52s\n- openstack-tox-cover http://logs.openstack.org/35/650235/1/check/openstack-tox-cover/0b427b0/cover/ : SUCCESS in 4m 14s\n- openstack-tox-lower-constraints http://logs.openstack.org/35/650235/1/check/openstack-tox-lower-constraints/ff5cb10/ : SUCCESS in 4m 12s\n- openstack-tox-pep8 http://logs.openstack.org/35/650235/1/check/openstack-tox-pep8/bbe1fa3/ : SUCCESS in 3m 34s\n- openstack-tox-py27 http://logs.openstack.org/35/650235/1/check/openstack-tox-py27/42d1471/ : SUCCESS in 3m 31s\n- openstack-tox-py35 http://logs.openstack.org/35/650235/1/check/openstack-tox-py35/240c8d1/ : SUCCESS in 3m 57s\n- openstack-tox-py36 http://logs.openstack.org/35/650235/1/check/openstack-tox-py36/d5b401f/ : SUCCESS in 3m 35s\n- openstack-tox-py37 http://logs.openstack.org/35/650235/1/check/openstack-tox-py37/ab7efd8/ : SUCCESS in 4m 00s\n- openstack-tox-docs http://logs.openstack.org/35/650235/1/check/openstack-tox-docs/9d6f61a/html/ : SUCCESS in 3m 18s\n- novaclient-dsvm-functional http://logs.openstack.org/35/650235/1/check/novaclient-dsvm-functional/35ce51b/ : SUCCESS in 53m 11s","accounts_in_message":[],"_revision_number":1},{"id":"660fcce93611537b5240d052c2a21d9d9bc9e5aa","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2019-04-05 14:26:21.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"b6bef51fce8d6a56646280551af0827a9e7a5dfd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-05 14:26:33.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"1f65286a7cf4fad88d600dde00ccd9a8e2a7bda0","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-04-05 15:35:55.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit 30a4b3d72bc005eebe098dbe287f141a160428e1","accounts_in_message":[],"_revision_number":1},{"id":"623007fadfa44ccdb4a73a97caffcce426f3ed53","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-05 16:35:47.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tempest-full http://logs.openstack.org/35/650235/1/gate/tempest-full/07b52fa/ : SUCCESS in 2h 03m 15s\n- tempest-full-py3 http://logs.openstack.org/35/650235/1/gate/tempest-full-py3/d13684b/ : SUCCESS in 1h 41m 48s\n- openstack-tox-lower-constraints http://logs.openstack.org/35/650235/1/gate/openstack-tox-lower-constraints/ded5f72/ : SUCCESS in 5m 13s\n- openstack-tox-pep8 http://logs.openstack.org/35/650235/1/gate/openstack-tox-pep8/d23b7a0/ : SUCCESS in 5m 07s\n- openstack-tox-py27 http://logs.openstack.org/35/650235/1/gate/openstack-tox-py27/dd22ef3/ : SUCCESS in 5m 42s\n- openstack-tox-py35 http://logs.openstack.org/35/650235/1/gate/openstack-tox-py35/534cc16/ : SUCCESS in 4m 28s\n- openstack-tox-py36 http://logs.openstack.org/35/650235/1/gate/openstack-tox-py36/e04c969/ : SUCCESS in 7m 01s\n- openstack-tox-py37 http://logs.openstack.org/35/650235/1/gate/openstack-tox-py37/27e262e/ : SUCCESS in 5m 53s\n- openstack-tox-docs http://logs.openstack.org/35/650235/1/gate/openstack-tox-docs/1222f1b/html/ : SUCCESS in 4m 30s\n- novaclient-dsvm-functional http://logs.openstack.org/35/650235/1/gate/novaclient-dsvm-functional/a8fca27/ : FAILURE in 13m 12s","accounts_in_message":[],"_revision_number":1},{"id":"d0d6f8aa59d9a20e9cf36cf55c72e1ac2580fa59","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-04-05 19:03:00.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"f66b0f4d3b942bdcf02bf4c8b8d6fc892d80a1dc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-05 21:03:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/35/650235/1/check/tempest-full/9fcfd29/ : SUCCESS in 1h 44m 24s\n- tempest-full-py3 http://logs.openstack.org/35/650235/1/check/tempest-full-py3/7d8d8d0/ : SUCCESS in 1h 30m 27s\n- openstack-tox-cover http://logs.openstack.org/35/650235/1/check/openstack-tox-cover/3d39c4f/cover/ : SUCCESS in 4m 30s\n- openstack-tox-lower-constraints http://logs.openstack.org/35/650235/1/check/openstack-tox-lower-constraints/4f95741/ : SUCCESS in 5m 19s\n- openstack-tox-pep8 http://logs.openstack.org/35/650235/1/check/openstack-tox-pep8/e010f85/ : SUCCESS in 4m 56s\n- openstack-tox-py27 http://logs.openstack.org/35/650235/1/check/openstack-tox-py27/d3b0377/ : SUCCESS in 5m 06s\n- openstack-tox-py35 http://logs.openstack.org/35/650235/1/check/openstack-tox-py35/bdfe147/ : SUCCESS in 6m 30s\n- openstack-tox-py36 http://logs.openstack.org/35/650235/1/check/openstack-tox-py36/ef95069/ : SUCCESS in 5m 03s\n- openstack-tox-py37 http://logs.openstack.org/35/650235/1/check/openstack-tox-py37/0e2834c/ : SUCCESS in 6m 58s\n- openstack-tox-docs http://logs.openstack.org/35/650235/1/check/openstack-tox-docs/4b7b151/html/ : SUCCESS in 4m 13s\n- novaclient-dsvm-functional http://logs.openstack.org/35/650235/1/check/novaclient-dsvm-functional/2d6e4df/ : SUCCESS in 1h 07m 08s","accounts_in_message":[],"_revision_number":1},{"id":"a473a7e6d103e918c0efa271de3be7accb998bcb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-05 21:03:25.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"89c2a2519077f875af5c044a43e9f72e3de88fd4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-05 22:56:37.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full http://logs.openstack.org/35/650235/1/gate/tempest-full/fc335da/ : SUCCESS in 1h 46m 52s\n- tempest-full-py3 http://logs.openstack.org/35/650235/1/gate/tempest-full-py3/f3d4b47/ : SUCCESS in 1h 34m 29s\n- openstack-tox-lower-constraints http://logs.openstack.org/35/650235/1/gate/openstack-tox-lower-constraints/c1c0e9d/ : SUCCESS in 6m 43s\n- openstack-tox-pep8 http://logs.openstack.org/35/650235/1/gate/openstack-tox-pep8/3361f7a/ : SUCCESS in 5m 30s\n- openstack-tox-py27 http://logs.openstack.org/35/650235/1/gate/openstack-tox-py27/9a365b0/ : SUCCESS in 4m 45s\n- openstack-tox-py35 http://logs.openstack.org/35/650235/1/gate/openstack-tox-py35/96966cc/ : SUCCESS in 7m 02s\n- openstack-tox-py36 http://logs.openstack.org/35/650235/1/gate/openstack-tox-py36/dfb825c/ : SUCCESS in 5m 29s\n- openstack-tox-py37 http://logs.openstack.org/35/650235/1/gate/openstack-tox-py37/3215919/ : SUCCESS in 5m 46s\n- openstack-tox-docs http://logs.openstack.org/35/650235/1/gate/openstack-tox-docs/8630a97/html/ : SUCCESS in 5m 05s\n- novaclient-dsvm-functional http://logs.openstack.org/35/650235/1/gate/novaclient-dsvm-functional/6d0076a/ : SUCCESS in 58m 07s","accounts_in_message":[],"_revision_number":1},{"id":"6adb0d5e9c2d7b8b2d4ba37ffff2cd54925f5866","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-05 22:56:38.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"41f9ee75c402cb880997f4c7bb725fb5ad8cc954","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-11 15:07:19.000000000","message":"Patch Set 1:\n\nPresumably there was never a unit test for this code at all or we could have spotted this in py3 unit tests?","accounts_in_message":[],"_revision_number":1},{"id":"1fbbba692f276a07846a183ef3bfc3639fcd3be8","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-11 15:10:33.000000000","message":"Patch Set 1:\n\nThe same thing was merged in OSC:\n\nhttps://review.openstack.org/#/c/541609/\n\nAre you going to revert that as well?","accounts_in_message":[],"_revision_number":1},{"id":"9d2d47686eacc6e096f5fa142d4fa1a3c0d727c2","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-04-11 15:18:07.000000000","message":"Patch Set 1:\n\n\u003e The same thing was merged in OSC:\n \u003e \n \u003e https://review.openstack.org/#/c/541609/\n \u003e \n \u003e Are you going to revert that as well?\n\nAs noted on IRC, I don\u0027t think it\u0027s an issue there owing to the follow up [1] which switches printing to cliff\u0027s implementation (which works just fine)","accounts_in_message":[],"_revision_number":1},{"id":"545282e17dd8f47eeea71d838b0b4c615d71a730","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-04-11 15:18:18.000000000","message":"Patch Set 1:\n\n[1] https://review.openstack.org/#/c/554698/","accounts_in_message":[],"_revision_number":1},{"id":"65b6c00cc2212dae229a84476a433c2b2fb883b8","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-11 15:49:14.000000000","message":"Patch Set 1:\n\nWe could put something in the docs like this:\n\nhttps://click.palletsprojects.com/en/5.x/python3/#python-3-surrogate-handling\n\nWhich I found via the pep 538 doc:\n\nhttps://www.python.org/dev/peps/pep-0538/","accounts_in_message":[],"_revision_number":1},{"id":"777ad8a66393873e35bf5db8375b78210d1948ea","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-11 16:08:19.000000000","message":"Patch Set 1:\n\nUnit test and docs patch here:\n\nhttps://review.openstack.org/#/c/651827/\n\nThe unit test fails to reproduce the original bug though.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a9b1125f7ba209887cac36b3c0900cffe2516fa8","revisions":{"a9b1125f7ba209887cac36b3c0900cffe2516fa8":{"kind":"REWORK","_number":1,"created":"2019-04-05 06:54:18.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/35/650235/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/35/650235/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/35/650235/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/35/650235/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/35/650235/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/35/650235/1"}}},"commit":{"parents":[{"commit":"df8e10ccc89fc586f132a6975f349fc24a1feecc","subject":"Replace openstack.org git:// URLs with https://","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/df8e10ccc89fc586f132a6975f349fc24a1feecc"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-04-05 06:49:38.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-04-05 06:53:47.000000000","tz":60},"subject":"Revert \"Fix crashing console-log\"","message":"Revert \"Fix crashing console-log\"\n\nThis reverts commit d272d6f3df2610a62f81e2ca26798ea8a6674b06. This\nworked around a misconfigured environment by forcing stdout to use\nUTF-8. This is kind of a hack and it only works in Python 2, breaking\nPython 3 [1].\n\nThe correct solution to this issue and all Python 2 unicode print issues\nis to correctly configuring LC_ALL to use a UTF-8 locale.\n\n[1] https://stackoverflow.com/q/4374455\n\nChange-Id: Iaeec1e74262a35f3de3c81f7013835a6aa6f9029\nCloses-Bug: #1823287\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a9b1125f7ba209887cac36b3c0900cffe2516fa8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/a9b1125f7ba209887cac36b3c0900cffe2516fa8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}