)]}'
{"id":"openstack%2Fpython-novaclient~651925","triplet_id":"openstack%2Fpython-novaclient~stable%2Fstein~Ic7059260dfc031ea1b08d2b8a7cec684bbe7dfa5","project":"openstack/python-novaclient","branch":"stable/stein","topic":"bug/1746534","hashtags":[],"change_id":"Ic7059260dfc031ea1b08d2b8a7cec684bbe7dfa5","subject":"Add test for console-log and docs for bug 1746534","status":"MERGED","created":"2019-04-11 20:49:13.000000000","updated":"2019-04-15 11:54:31.000000000","submitted":"2019-04-15 11:54:31.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"651925-1555329271405-06c4f5fb","meta_rev_id":"64c37141774a8eb3f085288a038eec59d6efb514","_number":651925,"virtual_id_number":651925,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":2,"date":"2019-04-15 11:54:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"recommended":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2019-04-15 02:42:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":1,"date":"2019-04-12 10:27:51.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":2,"date":"2019-04-15 10:24:59.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":1,"date":"2019-04-15 10:24:59.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-12 10:27:51.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2019-04-15 02:42:03.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2019-04-15 10:24:59.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-04-15 11:54:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1a5d9ce73e5231f6a60102de66a0d43060fe9f93","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-11 20:49:13.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"dc62038d74dfc95e89505ebcfbf594b0582d86c4","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-11 20:49:22.000000000","message":"Topic changed from bug/1746534-stable/stein to bug/1746534","accounts_in_message":[],"_revision_number":1},{"id":"22a6459a6e124dd3c7cf1dcc227a6616336957af","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-04-11 20:49:27.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"222f2d7d0cb47e12b5739b6a1530ad8ee632e3e3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-11 23:32:14.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/25/651925/2/check/tempest-full/2beb00a/ : SUCCESS in 1h 30m 17s\n- tempest-full-py3 http://logs.openstack.org/25/651925/2/check/tempest-full-py3/26f4450/ : SUCCESS in 2h 02m 26s\n- openstack-tox-cover http://logs.openstack.org/25/651925/2/check/openstack-tox-cover/c5ff140/cover/ : SUCCESS in 5m 46s\n- openstack-tox-lower-constraints http://logs.openstack.org/25/651925/2/check/openstack-tox-lower-constraints/4935a08/ : SUCCESS in 6m 28s\n- openstack-tox-pep8 http://logs.openstack.org/25/651925/2/check/openstack-tox-pep8/ca14276/ : SUCCESS in 6m 19s\n- openstack-tox-py27 http://logs.openstack.org/25/651925/2/check/openstack-tox-py27/f5f9dae/ : SUCCESS in 5m 33s\n- openstack-tox-py35 http://logs.openstack.org/25/651925/2/check/openstack-tox-py35/8d2f3b5/ : SUCCESS in 6m 29s\n- openstack-tox-py36 http://logs.openstack.org/25/651925/2/check/openstack-tox-py36/adda8b0/ : SUCCESS in 5m 21s\n- openstack-tox-py37 http://logs.openstack.org/25/651925/2/check/openstack-tox-py37/f5720e2/ : SUCCESS in 6m 18s\n- openstack-tox-docs http://logs.openstack.org/25/651925/2/check/openstack-tox-docs/359a218/html/ : SUCCESS in 4m 34s\n- novaclient-dsvm-functional http://logs.openstack.org/25/651925/2/check/novaclient-dsvm-functional/5235ba6/ : SUCCESS in 1h 06m 49s","accounts_in_message":[],"_revision_number":2},{"id":"8989794508f1f887b46fc84572561d3503480642","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-04-12 10:27:51.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"a9298b3f0be35b248a10acedae1f212909c2f57e","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-04-12 10:28:08.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/rocky as commit 82b148734a9d08736670b1102cccb90fbcece6e7","accounts_in_message":[],"_revision_number":2},{"id":"ffcdb47dd46ae5de9a062285eb7c3b38687b45b7","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-04-15 02:42:03.000000000","message":"Patch Set 2: Code-Review+1\n\nClean backport. LGTM.","accounts_in_message":[],"_revision_number":2},{"id":"dddd922c13cc23c75fe817c9e83ca560028f0a8e","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-04-15 10:24:59.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLGTM, clean and useful in the context of the previously merged bugfix. Fast approving as this is from another Nova stable core.","accounts_in_message":[],"_revision_number":2},{"id":"eebbf83cae2a28a0a6d3a87037b7efd26e768ef5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-15 10:25:11.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"2c26e8d14d1efe706a1369c13ab8e93264cfdd55","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-15 11:54:31.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"64c37141774a8eb3f085288a038eec59d6efb514","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-15 11:54:31.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full http://logs.openstack.org/25/651925/2/gate/tempest-full/6235c29/ : SUCCESS in 1h 28m 03s\n- tempest-full-py3 http://logs.openstack.org/25/651925/2/gate/tempest-full-py3/efa1d88/ : SUCCESS in 1h 12m 34s\n- openstack-tox-lower-constraints http://logs.openstack.org/25/651925/2/gate/openstack-tox-lower-constraints/5644fd5/ : SUCCESS in 3m 56s\n- openstack-tox-pep8 http://logs.openstack.org/25/651925/2/gate/openstack-tox-pep8/4a291e7/ : SUCCESS in 3m 22s\n- openstack-tox-py27 http://logs.openstack.org/25/651925/2/gate/openstack-tox-py27/6a7e8b6/ : SUCCESS in 3m 22s\n- openstack-tox-py35 http://logs.openstack.org/25/651925/2/gate/openstack-tox-py35/acd4d3e/ : SUCCESS in 3m 35s\n- openstack-tox-py36 http://logs.openstack.org/25/651925/2/gate/openstack-tox-py36/8412f1f/ : SUCCESS in 3m 23s\n- openstack-tox-py37 http://logs.openstack.org/25/651925/2/gate/openstack-tox-py37/3807b09/ : SUCCESS in 3m 25s\n- openstack-tox-docs http://logs.openstack.org/25/651925/2/gate/openstack-tox-docs/94660ce/html/ : SUCCESS in 3m 15s\n- novaclient-dsvm-functional http://logs.openstack.org/25/651925/2/gate/novaclient-dsvm-functional/f8da621/ : SUCCESS in 1h 02m 34s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"60bf9a236dfbaa98e7d93b4baf0997e645b02bb0","revisions":{"afeee8711544a605c00ca3f8d579d5d45348d1c8":{"kind":"REWORK","_number":1,"created":"2019-04-11 20:49:13.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/25/651925/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/25/651925/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/651925/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/651925/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/651925/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/25/651925/1"}}},"commit":{"parents":[{"commit":"70ed7918a6512b2cfe06ba1f65281c823a5d7aa0","subject":"Replace openstack.org git:// URLs with https://","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/70ed7918a6512b2cfe06ba1f65281c823a5d7aa0"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-04-11 16:03:30.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-04-11 20:49:13.000000000","tz":0},"subject":"Add test for console-log and docs for bug 1746534","message":"Add test for console-log and docs for bug 1746534\n\nWe had no unit test coverage for the console-log command\nso this adds a simple test. It unfortunately does not\nrecreate the original UnicodeEncodeError bug though, but\nit gives us some test coverage anyway.\n\nThis change also adds docs on how to resolve bug 1746534\nby configuring the environment for UTF-8 as noted in\nthe revert change Iaeec1e74262a35f3de3c81f7013835a6aa6f9029.\n\nThe documentation added here is shamelessly copied from\nClick [1] which was found via the PEP 538 docs [2].\n\n[1] https://click.palletsprojects.com/en/5.x/python3/#python-3-surrogate-handling\n[2] https://www.python.org/dev/peps/pep-0538/\n\nChange-Id: Ic7059260dfc031ea1b08d2b8a7cec684bbe7dfa5\nRelated-Bug: #1823287\nRelated-Bug: #1746534\n(cherry picked from commit e8f7aaf9091330bbb046f2bd42dc9c92f1dcebaa)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/afeee8711544a605c00ca3f8d579d5d45348d1c8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/afeee8711544a605c00ca3f8d579d5d45348d1c8"}]},"branch":"refs/heads/stable/stein"},"60bf9a236dfbaa98e7d93b4baf0997e645b02bb0":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-04-11 20:49:27.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/25/651925/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/25/651925/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/651925/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/651925/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/651925/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/25/651925/2"}}},"commit":{"parents":[{"commit":"2ca1814a2b4d1e887974a71951b7e744273a43b4","subject":"Revert \"Fix crashing console-log\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2ca1814a2b4d1e887974a71951b7e744273a43b4"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-04-11 16:03:30.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-04-11 20:49:27.000000000","tz":0},"subject":"Add test for console-log and docs for bug 1746534","message":"Add test for console-log and docs for bug 1746534\n\nWe had no unit test coverage for the console-log command\nso this adds a simple test. It unfortunately does not\nrecreate the original UnicodeEncodeError bug though, but\nit gives us some test coverage anyway.\n\nThis change also adds docs on how to resolve bug 1746534\nby configuring the environment for UTF-8 as noted in\nthe revert change Iaeec1e74262a35f3de3c81f7013835a6aa6f9029.\n\nThe documentation added here is shamelessly copied from\nClick [1] which was found via the PEP 538 docs [2].\n\n[1] https://click.palletsprojects.com/en/5.x/python3/#python-3-surrogate-handling\n[2] https://www.python.org/dev/peps/pep-0538/\n\nChange-Id: Ic7059260dfc031ea1b08d2b8a7cec684bbe7dfa5\nRelated-Bug: #1823287\nRelated-Bug: #1746534\n(cherry picked from commit e8f7aaf9091330bbb046f2bd42dc9c92f1dcebaa)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/60bf9a236dfbaa98e7d93b4baf0997e645b02bb0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/60bf9a236dfbaa98e7d93b4baf0997e645b02bb0"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}