)]}'
{"id":"openstack%2Fpython-novaclient~65997","triplet_id":"openstack%2Fpython-novaclient~master~Ie529d14c0dbac6ac081c5286c26738005c73e7cc","project":"openstack/python-novaclient","branch":"master","topic":"fixIsInstance","hashtags":[],"change_id":"Ie529d14c0dbac6ac081c5286c26738005c73e7cc","subject":"Python3: use six\u0027s type when using isinstance","status":"ABANDONED","created":"2014-01-10 16:06:07.000000000","updated":"2014-01-24 11:15:45.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"036f8f2d955f234ae99c6d597d220f4f9c9f8620","_number":65997,"virtual_id_number":65997,"owner":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2014-01-13 17:51:09.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-01-13 08:05:48.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"value":-1,"date":"2014-01-21 16:22:42.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":-2,"date":"2014-01-22 22:28:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"date":"2014-01-10 21:47:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},{"value":0,"date":"2014-01-10 22:59:00.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2014-01-10 16:06:52.000000000","_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"value":0,"date":"2014-01-10 17:09:16.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"date":"2014-01-10 22:44:04.000000000","_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},{"date":"2014-01-10 16:06:44.000000000","_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-01-10 16:06:44.000000000","updated_by":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"reviewer":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"state":"REVIEWER"},{"updated":"2014-01-10 16:06:52.000000000","updated_by":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"reviewer":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"state":"REVIEWER"},{"updated":"2014-01-10 17:09:16.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2014-01-10 22:44:04.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2014-01-13 17:51:09.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"277dbf1c313da33dc29a9c7f8c7323f73b71b7ac","author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"date":"2014-01-10 16:15:44.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"7cbb544a0b0a7375d18bbd4e60c0199401904572","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2014-01-10 17:09:16.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"cb52f2838aa6312e6bfc1435de270aedefefaf77","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-10 17:54:34.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/97/65997/1/check/gate-python-novaclient-pep8/58da7c3 : SUCCESS in 54s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/97/65997/1/check/gate-python-novaclient-docs/41089b0/doc/build/html/ : SUCCESS in 1m 07s\n- gate-python-novaclient-python26 http://logs.openstack.org/97/65997/1/check/gate-python-novaclient-python26/a09cfb2 : SUCCESS in 1m 14s\n- gate-python-novaclient-python27 http://logs.openstack.org/97/65997/1/check/gate-python-novaclient-python27/98e1ff8 : SUCCESS in 1m 25s\n- gate-python-novaclient-python33 http://logs.openstack.org/97/65997/1/check/gate-python-novaclient-python33/ce0a38a : SUCCESS in 4m 24s\n- gate-python-novaclient-pypy http://logs.openstack.org/97/65997/1/check/gate-python-novaclient-pypy/b67d1db : SUCCESS in 2m 12s\n- check-tempest-dsvm-full http://logs.openstack.org/97/65997/1/check/check-tempest-dsvm-full/7fab500 : FAILURE in 59m 15s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/97/65997/1/check/check-tempest-dsvm-postgres-full/402c2f7 : SUCCESS in 45m 04s\n- check-tempest-dsvm-neutron http://logs.openstack.org/97/65997/1/check/check-tempest-dsvm-neutron/5a833f7 : SUCCESS in 53m 42s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/97/65997/1/check/gate-tempest-dsvm-large-ops/4f00dfa : SUCCESS in 20m 01s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/97/65997/1/check/gate-tempest-dsvm-neutron-large-ops/274c9e5 : SUCCESS in 13m 36s\n- check-grenade-dsvm http://logs.openstack.org/97/65997/1/check/check-grenade-dsvm/e9c80be : SUCCESS in 30m 15s\n","accounts_in_message":[],"_revision_number":1},{"id":"07f9842a81de0642b4d749b78a5e77f57e9a3df7","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2014-01-10 21:47:46.000000000","message":"Patch Set 1:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":1},{"id":"221ff46c4ce1aa32805d5e0a9d474a42afce8671","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2014-01-10 22:44:04.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nWhy? We already gate on python33 support in novaclient. so what does this buy us? At the very least the commit message needs updating.","accounts_in_message":[],"_revision_number":1},{"id":"f149634f1a0c18cc98f25e1757e8f4960a635575","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2014-01-10 22:59:00.000000000","message":"Patch Set 1:\n\nUsing \"basestring\" will probably fail in Python 3. Yassine, could you add tests to this patch, that would show the failure ?","accounts_in_message":[],"_revision_number":1},{"id":"f51ae3457680ea3551a67f984788bb02afbfab47","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-10 23:02:03.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/97/65997/1/check/gate-python-novaclient-pep8/12c78c6 : SUCCESS in 59s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/97/65997/1/check/gate-python-novaclient-docs/af6e7fa/doc/build/html/ : SUCCESS in 50s\n- gate-python-novaclient-python26 http://logs.openstack.org/97/65997/1/check/gate-python-novaclient-python26/ba9d3ea : SUCCESS in 1m 11s\n- gate-python-novaclient-python27 http://logs.openstack.org/97/65997/1/check/gate-python-novaclient-python27/2c23f65 : SUCCESS in 1m 11s\n- gate-python-novaclient-python33 http://logs.openstack.org/97/65997/1/check/gate-python-novaclient-python33/4fd1615 : SUCCESS in 4m 25s\n- gate-python-novaclient-pypy http://logs.openstack.org/97/65997/1/check/gate-python-novaclient-pypy/4831718 : SUCCESS in 2m 10s\n- check-tempest-dsvm-full http://logs.openstack.org/97/65997/1/check/check-tempest-dsvm-full/85900d6 : SUCCESS in 42m 07s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/97/65997/1/check/check-tempest-dsvm-postgres-full/6fd75c6 : SUCCESS in 44m 35s\n- check-tempest-dsvm-neutron http://logs.openstack.org/97/65997/1/check/check-tempest-dsvm-neutron/a517bbd : SUCCESS in 37m 55s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/97/65997/1/check/gate-tempest-dsvm-large-ops/97a9e04 : SUCCESS in 14m 10s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/97/65997/1/check/gate-tempest-dsvm-neutron-large-ops/da9398a : SUCCESS in 12m 18s\n- check-grenade-dsvm http://logs.openstack.org/97/65997/1/check/check-grenade-dsvm/bccaf7f : FAILURE in 29m 54s\n","accounts_in_message":[],"_revision_number":1},{"id":"e6b7d5f5059b928123b63df4d4ae800abba97e27","author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"date":"2014-01-13 08:05:48.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n\u003e Why? We already gate on python33 support in novaclient. so what does this buy us? At the very least the commit message needs updating.\n\nI\u0027m quite sure that this part of the code is not tested by python33\u0027s gate, because basestring doesn\u0027t exist anymore in Python 3 and so will raise a NameError.\n\n$ python3\n\u003e\u003e\u003e basestring\nNameError: name \u0027basestring\u0027 is not defined","accounts_in_message":[],"_revision_number":1},{"id":"960eeef690cfd93b2e4fcec58546fab47a1dc0a3","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2014-01-13 16:29:20.000000000","message":"Patch Set 1:\n\n@Joe: Thanks for your remark. As Victor said, it means that the code is not covered...","accounts_in_message":[],"_revision_number":1},{"id":"847d642b827232f41a7de321df5e57b248e42862","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2014-01-13 16:32:28.000000000","message":"Patch Set 1:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":1},{"id":"dfb79d296e488f448a26e63eeb1534f68cf34041","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-13 17:51:09.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-novaclient-pep8 http://logs.openstack.org/97/65997/1/check/gate-python-novaclient-pep8/eb5512f : SUCCESS in 40s\n- gate-python-novaclient-docs http://docs-draft.openstack.org/97/65997/1/check/gate-python-novaclient-docs/74d6b85/doc/build/html/ : SUCCESS in 1m 14s\n- gate-python-novaclient-python26 http://logs.openstack.org/97/65997/1/check/gate-python-novaclient-python26/d5a1e9c : SUCCESS in 1m 09s\n- gate-python-novaclient-python27 http://logs.openstack.org/97/65997/1/check/gate-python-novaclient-python27/a4519b2 : SUCCESS in 53s\n- gate-python-novaclient-python33 http://logs.openstack.org/97/65997/1/check/gate-python-novaclient-python33/805765d : SUCCESS in 4m 27s\n- gate-python-novaclient-pypy http://logs.openstack.org/97/65997/1/check/gate-python-novaclient-pypy/d25dda7 : SUCCESS in 2m 09s\n- check-tempest-dsvm-full http://logs.openstack.org/97/65997/1/check/check-tempest-dsvm-full/c91961c : SUCCESS in 1h 00m 19s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/97/65997/1/check/check-tempest-dsvm-postgres-full/b5bc442 : SUCCESS in 1h 11m 53s\n- check-tempest-dsvm-neutron http://logs.openstack.org/97/65997/1/check/check-tempest-dsvm-neutron/28581f1 : SUCCESS in 34m 40s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/97/65997/1/check/gate-tempest-dsvm-large-ops/a6e62c1 : SUCCESS in 11m 51s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/97/65997/1/check/gate-tempest-dsvm-neutron-large-ops/925aa1e : SUCCESS in 17m 32s\n- check-grenade-dsvm http://logs.openstack.org/97/65997/1/check/check-grenade-dsvm/b93359d : SUCCESS in 35m 17s\n","accounts_in_message":[],"_revision_number":1},{"id":"e8279781a8fc34024bc05aa7d8a624fde527b934","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2014-01-13 21:03:05.000000000","message":"Patch Set 1: No score\n\nThen the thing to do is to add tests to provide that coverage.  Then you can show that the original code fails in Python 3.3, but passes with the patch.","accounts_in_message":[],"_revision_number":1},{"id":"f70305dbb2db37f3b7981037a3d5acfca5aa0e6c","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2014-01-14 10:48:50.000000000","message":"Patch Set 1:\n\n@Kevin: Agreed, but as i understood, the current unit tests monkey patch the nova client for all tests so we need to modify the tests logic which is not in the scope of this patch imo.","accounts_in_message":[],"_revision_number":1},{"id":"5e120dd82b2204b6a1ca84662b0fbdde91309033","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2014-01-14 20:53:01.000000000","message":"Patch Set 1:\n\nSo, I see no tests on the unit novaclient.v1_1.shell._boot(); we clearly need such tests, but I agree that writing the full suite of such tests is outside of the scope of the patch.  However, I see a number of tests on boot() with no mock-out of _boot(); the only thing keeping this code from being called (and thus being found to fail on Python 3.3) is the lack of a test on scheduler hints.  I would think the addition of a single test_boot_scheduler_hints() should be within the scope of the patch, as it will demonstrate that your patch finds and fixes the issue.","accounts_in_message":[],"_revision_number":1},{"id":"3e0b1c1c300ea2fcc19b1d4c1b3da5936291b361","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2014-01-21 16:22:42.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nDuplicate of https://review.openstack.org/#/c/68157/.  Although that review was submitted later than yours, it has the tests that we asked for, and adds a necessary \"import six\" in v3/shell.py.","accounts_in_message":[],"_revision_number":1},{"id":"e19b241ff5c0c6aa77775c70e723f80cf2740751","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2014-01-22 22:28:50.000000000","message":"Patch Set 1: Do not merge\n\nreplaced by https://review.openstack.org/#/c/68157/","accounts_in_message":[],"_revision_number":1},{"id":"884a3a6a56587eb7ed7b105185ed07111c54dfbf","author":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"date":"2014-01-24 11:15:45.000000000","message":"Patch Set 1: Abandoned\n\nSorry, i\u0027m late for the update...\n\nPatch abandonned, see https://review.openstack.org/#/c/68157","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d2487c2ec01f54b85b9e0dde12401028a24b2f08","revisions":{"d2487c2ec01f54b85b9e0dde12401028a24b2f08":{"kind":"REWORK","_number":1,"created":"2014-01-10 16:06:07.000000000","uploader":{"_account_id":7450,"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@redhat.com","username":"yassine.lamgarchal"},"ref":"refs/changes/97/65997/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/97/65997/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/97/65997/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/97/65997/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/97/65997/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/97/65997/1"}}},"commit":{"parents":[{"commit":"5a65f40d1f51697245fc672a8493470588cc5a33","subject":"Merge \"Removes vim configuration headers\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/5a65f40d1f51697245fc672a8493470588cc5a33"}]}],"author":{"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@enovance.com","date":"2014-01-10 16:05:33.000000000","tz":60},"committer":{"name":"Yassine Lamgarchal","email":"yassine.lamgarchal@enovance.com","date":"2014-01-10 16:06:04.000000000","tz":60},"subject":"Python3: use six\u0027s type when using isinstance","message":"Python3: use six\u0027s type when using isinstance\n\nsix.string_types replaces basestring() in Python 2 and str\nin Python 3.\n\nChange-Id: Ie529d14c0dbac6ac081c5286c26738005c73e7cc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d2487c2ec01f54b85b9e0dde12401028a24b2f08"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d2487c2ec01f54b85b9e0dde12401028a24b2f08"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}