)]}'
{"id":"openstack%2Fpython-novaclient~660861","triplet_id":"openstack%2Fpython-novaclient~master~Ie909c16568b017ca0acc802194140da7bece76c5","project":"openstack/python-novaclient","branch":"master","topic":"bug/1829854","hashtags":[],"change_id":"Ie909c16568b017ca0acc802194140da7bece76c5","subject":"Set the lower limit of api_version for volume_type","status":"MERGED","created":"2019-05-23 00:25:33.000000000","updated":"2019-05-23 14:54:21.000000000","submitted":"2019-05-23 14:38:16.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"660861-1558622296830-b828c741","meta_rev_id":"a510a5a36f0316e752b4b4729c3b9421cbe41017","_number":660861,"virtual_id_number":660861,"owner":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":30448,"name":"moser-cui","email":"cuilei@awcloud.com","username":"cuilei"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"date":"2019-05-23 02:55:37.000000000","_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":2,"date":"2019-05-23 14:38:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"recommended":{"_account_id":30448,"name":"moser-cui","email":"cuilei@awcloud.com","username":"cuilei"},"all":[{"value":1,"date":"2019-05-23 06:04:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30448,"name":"moser-cui","email":"cuilei@awcloud.com","username":"cuilei"},{"value":2,"date":"2019-05-23 01:30:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":2,"date":"2019-05-23 12:44:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-05-23 06:06:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"all":[{"value":0,"_account_id":30448,"name":"moser-cui","email":"cuilei@awcloud.com","username":"cuilei"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":1,"date":"2019-05-23 12:44:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2019-05-23 00:26:10.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":30448,"name":"moser-cui","email":"cuilei@awcloud.com","username":"cuilei"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"_account_id":30448,"name":"moser-cui","email":"cuilei@awcloud.com","username":"cuilei"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-23 00:26:10.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-05-23 01:30:17.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2019-05-23 06:04:00.000000000","updated_by":{"_account_id":30448,"name":"moser-cui","email":"cuilei@awcloud.com","username":"cuilei"},"reviewer":{"_account_id":30448,"name":"moser-cui","email":"cuilei@awcloud.com","username":"cuilei"},"state":"REVIEWER"},{"updated":"2019-05-23 06:06:58.000000000","updated_by":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"reviewer":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"state":"REVIEWER"},{"updated":"2019-05-23 12:44:46.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2019-05-23 14:38:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e275784d12b87e92f8d0be16a71496b4ab8a6b8c","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2019-05-23 00:25:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d6a40e9054093508d003461bf7647b2a08585dc9","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-05-23 01:30:17.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"876c154bf1822ff12f78eadc22f38f6df27b7fc4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-23 02:22:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/61/660861/1/check/tempest-full/ddb86bc/ : SUCCESS in 1h 50m 25s\n- tempest-full-py3 http://logs.openstack.org/61/660861/1/check/tempest-full-py3/9278e03/ : SUCCESS in 1h 34m 25s\n- openstack-tox-cover http://logs.openstack.org/61/660861/1/check/openstack-tox-cover/7d0181d/cover/ : SUCCESS in 3m 59s\n- openstack-tox-lower-constraints http://logs.openstack.org/61/660861/1/check/openstack-tox-lower-constraints/806edfb/ : SUCCESS in 4m 20s\n- openstack-tox-pep8 http://logs.openstack.org/61/660861/1/check/openstack-tox-pep8/3fd8889/ : SUCCESS in 3m 12s\n- openstack-tox-py27 http://logs.openstack.org/61/660861/1/check/openstack-tox-py27/d0e5129/ : SUCCESS in 4m 22s\n- openstack-tox-py36 http://logs.openstack.org/61/660861/1/check/openstack-tox-py36/08c14c5/ : SUCCESS in 3m 05s\n- openstack-tox-py37 http://logs.openstack.org/61/660861/1/check/openstack-tox-py37/7690410/ : SUCCESS in 4m 07s\n- openstack-tox-docs http://logs.openstack.org/61/660861/1/check/openstack-tox-docs/ad0e4a5/html/ : SUCCESS in 3m 33s\n- novaclient-dsvm-functional http://logs.openstack.org/61/660861/1/check/novaclient-dsvm-functional/de49db7/ : SUCCESS in 1h 00m 29s","accounts_in_message":[],"_revision_number":1},{"id":"bb58be889f4f0272c76d276853030ccb5b54ea37","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2019-05-23 02:55:37.000000000","message":"Patch Set 1:\n\n\u003e (1 comment)\n \u003e \n \u003e I would have a small preference instead of this, to add api_version as \n \u003e a @ddt.data parameter and pass \u00272.67\u0027 and \u00272.latest\u0027 in \n \u003e test_boot_from_volume_with_volume_type on L664 to be DRYer and save \n \u003e some lines of code.\n\nThanks melwitt. I am not very professional about @ddt.data ^^, I will try to learn to use @ddt.data, this will be the beginning of a good habit :D","accounts_in_message":[],"_revision_number":1},{"id":"be110e7f298719fa4a883ca51f6827a3fe9a0216","author":{"_account_id":30448,"name":"moser-cui","email":"cuilei@awcloud.com","username":"cuilei"},"date":"2019-05-23 06:04:00.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"bf1da1d26e75b858c22d7b08d20f5d90f7111fa2","author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"date":"2019-05-23 06:06:58.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"aa7da3fff1a6e228645262cabcd4a2b78114ef9a","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2019-05-23 12:44:46.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"3dd7e772aa4f1fa6dedbc2ead1d181d48a65cde7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-23 12:44:58.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"495099c8f0da99054b108f245f6fde5382d4b8b6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-23 14:38:16.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"fd1fd8037f3b6313bb81f5eb6a08d08f4971ffb6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-23 14:38:16.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full http://logs.openstack.org/61/660861/1/gate/tempest-full/24fafa4/ : SUCCESS in 1h 47m 30s\n- tempest-full-py3 http://logs.openstack.org/61/660861/1/gate/tempest-full-py3/d3ffbf6/ : SUCCESS in 1h 38m 14s\n- openstack-tox-lower-constraints http://logs.openstack.org/61/660861/1/gate/openstack-tox-lower-constraints/95e21b8/ : SUCCESS in 4m 10s\n- openstack-tox-pep8 http://logs.openstack.org/61/660861/1/gate/openstack-tox-pep8/bac5ec9/ : SUCCESS in 3m 12s\n- openstack-tox-py27 http://logs.openstack.org/61/660861/1/gate/openstack-tox-py27/ec50248/ : SUCCESS in 3m 28s\n- openstack-tox-py36 http://logs.openstack.org/61/660861/1/gate/openstack-tox-py36/cdb48c2/ : SUCCESS in 3m 49s\n- openstack-tox-py37 http://logs.openstack.org/61/660861/1/gate/openstack-tox-py37/0d687fa/ : SUCCESS in 4m 18s\n- openstack-tox-docs http://logs.openstack.org/61/660861/1/gate/openstack-tox-docs/7899a1c/html/ : SUCCESS in 3m 12s\n- novaclient-dsvm-functional http://logs.openstack.org/61/660861/1/gate/novaclient-dsvm-functional/b82c849/ : SUCCESS in 59m 17s","accounts_in_message":[],"_revision_number":1},{"id":"3429888ee8c51d0afd0952197bdc4ad74ed5d7db","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2019-05-23 14:54:21.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit ef842ca0d834a52b1dfb1ae5155cbd4993a599a1","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7b9d3000893aefa9c5efc77b50dc0fec5cab29be","revisions":{"7b9d3000893aefa9c5efc77b50dc0fec5cab29be":{"kind":"REWORK","_number":1,"created":"2019-05-23 00:25:33.000000000","uploader":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"ref":"refs/changes/61/660861/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/61/660861/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/61/660861/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/61/660861/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/61/660861/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/61/660861/1"}}},"commit":{"parents":[{"commit":"dfb84228a2748bed82f9b83c1209d5e2e0557bfa","subject":"Merge \"Optimize limit option docs string description for novaclient\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/dfb84228a2748bed82f9b83c1209d5e2e0557bfa"}]}],"author":{"name":"zhangbailin","email":"zhangbailin@inspur.com","date":"2019-05-23 00:18:00.000000000","tz":480},"committer":{"name":"zhangbailin","email":"zhangbailin@inspur.com","date":"2019-05-23 00:18:04.000000000","tz":480},"subject":"Set the lower limit of api_version for volume_type","message":"Set the lower limit of api_version for volume_type\n\nIn boot server API, the volume_type is supported by microversion 2.67.\nTherefore, the lower limit of the volume_type should be added to the CLI\ncommand, otherwise an exception will occur.\n\nCo-Authored-By: Eric Xie \u003ceric_xiett@163.com\u003e\n\nCloses-Bug: #1829854\nChange-Id: Ie909c16568b017ca0acc802194140da7bece76c5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7b9d3000893aefa9c5efc77b50dc0fec5cab29be"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/7b9d3000893aefa9c5efc77b50dc0fec5cab29be"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}