)]}'
{"id":"openstack%2Fpython-novaclient~664025","triplet_id":"openstack%2Fpython-novaclient~stable%2Frocky~Ia8750bc27aa9a2cfafb6f4f49252f5bd81bc1a40","project":"openstack/python-novaclient","branch":"stable/rocky","hashtags":[],"change_id":"Ia8750bc27aa9a2cfafb6f4f49252f5bd81bc1a40","subject":"Use SHA256 instead of MD5 in completion cache","status":"MERGED","created":"2019-06-07 18:32:35.000000000","updated":"2019-06-28 10:38:00.000000000","submitted":"2019-06-28 10:37:59.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"664025-1561718280014-4aedcafd","meta_rev_id":"3fba7131ccaf4f71851be70256f58ab926a432ea","_number":664025,"virtual_id_number":664025,"owner":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":2,"date":"2019-06-28 10:37:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":2,"date":"2019-06-28 09:03:33.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-27 10:31:27.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":1,"date":"2019-06-28 09:03:33.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-10 02:21:50.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2019-06-27 10:31:27.000000000","updated_by":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"reviewer":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"state":"REVIEWER"},{"updated":"2019-06-28 09:03:33.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-06-28 10:37:59.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"69dacce629909dce954139273f8596e2fbbcddee","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2019-06-07 18:32:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8bacc4c96f5e94c7993cf7d567b75f506a9fbbe2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-07 23:28:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/25/664025/1/check/openstack-tox-pep8/452919f/ : SUCCESS in 5m 03s\n- openstack-tox-py27 http://logs.openstack.org/25/664025/1/check/openstack-tox-py27/441e8e5/ : SUCCESS in 3m 57s\n- openstack-tox-py35 http://logs.openstack.org/25/664025/1/check/openstack-tox-py35/530fe0b/ : SUCCESS in 3m 41s\n- build-openstack-sphinx-docs http://logs.openstack.org/25/664025/1/check/build-openstack-sphinx-docs/9cb4a69/html/ : SUCCESS in 3m 22s\n- tempest-full http://logs.openstack.org/25/664025/1/check/tempest-full/cfd8768/ : SUCCESS in 1h 40m 05s\n- novaclient-dsvm-functional http://logs.openstack.org/25/664025/1/check/novaclient-dsvm-functional/21e2e89/ : SUCCESS in 1h 04m 11s\n- openstack-tox-lower-constraints http://logs.openstack.org/25/664025/1/check/openstack-tox-lower-constraints/245e1c7/ : SUCCESS in 3m 53s","accounts_in_message":[],"_revision_number":1},{"id":"47fea70c004ac41ef23decaf5469b33aae483b1d","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-06-10 02:21:50.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"65ed2bc107eb3ec1caf2c5fbf1f5a2b330cc710b","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-06-26 15:45:35.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)\n\nLGTM, needs to land in stable/stein, nit with the cherry picked from lines but that\u0027s not worth -1\u0027ing for as this is a useful fix for stable.","accounts_in_message":[],"_revision_number":1},{"id":"dc1b5411efa6cce8c0ac2999537d085feb81f860","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2019-06-27 10:28:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d4256d1971d4ebc7c9b5b77cac1094b4f0f8b657","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2019-06-27 10:28:42.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"7ab036cbb0ba4f614fa2d28a1bec9c4d6481f6cd","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2019-06-27 10:31:27.000000000","message":"Patch Set 2: Code-Review+1\n\nSeems good, I guess we need to wait for the other one to merge first though. Happy for someone to take this as a +2 once the other patch has merged (or I can recast my vote, if I am around).","accounts_in_message":[],"_revision_number":2},{"id":"10f675c151f703829932dfe3c034a90fe8a85ccd","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-06-27 10:32:43.000000000","message":"Patch Set 2:\n\n\u003e Seems good, I guess we need to wait for the other one to merge\n \u003e first though. Happy for someone to take this as a +2 once the other\n \u003e patch has merged (or I can recast my vote, if I am around).\n\nACK, I\u0027ll do the needful once stable/stein lands.","accounts_in_message":[],"_revision_number":2},{"id":"4231a8d8a3bfd1c78ac522cdb2aa63461f8f841f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-27 12:21:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/25/664025/2/check/openstack-tox-pep8/dfb31e4/ : SUCCESS in 4m 26s\n- openstack-tox-py27 http://logs.openstack.org/25/664025/2/check/openstack-tox-py27/ff80686/ : SUCCESS in 3m 45s\n- openstack-tox-py35 http://logs.openstack.org/25/664025/2/check/openstack-tox-py35/af541db/ : SUCCESS in 3m 57s\n- build-openstack-sphinx-docs http://logs.openstack.org/25/664025/2/check/build-openstack-sphinx-docs/49cbaf2/html/ : SUCCESS in 3m 41s\n- tempest-full http://logs.openstack.org/25/664025/2/check/tempest-full/4b9dd8a/ : SUCCESS in 1h 36m 42s\n- novaclient-dsvm-functional http://logs.openstack.org/25/664025/2/check/novaclient-dsvm-functional/294d2ae/ : SUCCESS in 49m 34s\n- openstack-tox-lower-constraints http://logs.openstack.org/25/664025/2/check/openstack-tox-lower-constraints/c1ae7aa/ : SUCCESS in 4m 20s","accounts_in_message":[],"_revision_number":2},{"id":"0e267951421f1e0393009087ad5fa5227235a5f8","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-06-28 09:03:33.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLGTM, landed in stable/stein now, proxying John\u0027s +2 as previously agreed.","accounts_in_message":[],"_revision_number":2},{"id":"c7050217457262eec8886373194b56d4c41d2a8c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-28 09:03:46.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"0d746dcb8dfd94ebf8e8adad172138c404be0406","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-28 10:37:59.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/25/664025/2/gate/openstack-tox-pep8/f5b8b0d/ : SUCCESS in 4m 06s\n- openstack-tox-py27 http://logs.openstack.org/25/664025/2/gate/openstack-tox-py27/67907d1/ : SUCCESS in 3m 53s\n- openstack-tox-py35 http://logs.openstack.org/25/664025/2/gate/openstack-tox-py35/3a33f5f/ : SUCCESS in 3m 54s\n- build-openstack-sphinx-docs http://logs.openstack.org/25/664025/2/gate/build-openstack-sphinx-docs/3879821/html/ : SUCCESS in 3m 17s\n- tempest-full http://logs.openstack.org/25/664025/2/gate/tempest-full/a6bebf3/ : SUCCESS in 1h 29m 00s\n- novaclient-dsvm-functional http://logs.openstack.org/25/664025/2/gate/novaclient-dsvm-functional/29743dc/ : SUCCESS in 54m 09s\n- openstack-tox-lower-constraints http://logs.openstack.org/25/664025/2/gate/openstack-tox-lower-constraints/b3dc305/ : SUCCESS in 5m 02s","accounts_in_message":[],"_revision_number":2},{"id":"3fba7131ccaf4f71851be70256f58ab926a432ea","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-28 10:38:00.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"92002c8046ea5f575bb8a7ed6f4e6a8a29fad22d","revisions":{"8d240dd655ec447f2857171056105619c3a3dd76":{"kind":"REWORK","_number":1,"created":"2019-06-07 18:32:35.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/25/664025/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/25/664025/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/664025/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/664025/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/664025/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/25/664025/1"}}},"commit":{"parents":[{"commit":"94cde08c0e02da0c8d13fc6534cd5cebdfcd3c5f","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/94cde08c0e02da0c8d13fc6534cd5cebdfcd3c5f"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2019-05-09 18:34:35.000000000","tz":-240},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2019-06-07 18:32:31.000000000","tz":-240},"subject":"Use SHA256 instead of MD5 in completion cache","message":"Use SHA256 instead of MD5 in completion cache\n\nFIPS 140 are U.S. government computer security standards that specify\nrequirements for cryptography modules. MD5 is not FIPS compliant [1].\nPreviously, MD5 was used as the hash algorithm for the bash completion\ncache. Hosts running in FIPS mode [2] block execution of the MD5 hash.\nThis makes python-novaclient unusable on FIPS-enabled machines. This\npatch replaces MD5 with SHA256, which is FIPS compliant.\n\n[1] https://csrc.nist.gov/projects/hash-functions\n[2] https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/security_guide/chap-federal_standards_and_regulations\n\nChange-Id: Ia8750bc27aa9a2cfafb6f4f49252f5bd81bc1a40\n(cherry picked from commit 2595bac2294ce05e389eaab6636977963d5fc66c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/8d240dd655ec447f2857171056105619c3a3dd76"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/8d240dd655ec447f2857171056105619c3a3dd76"}]},"branch":"refs/heads/stable/rocky"},"92002c8046ea5f575bb8a7ed6f4e6a8a29fad22d":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-06-27 10:28:42.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/25/664025/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/25/664025/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/664025/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/664025/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/25/664025/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/25/664025/2"}}},"commit":{"parents":[{"commit":"94cde08c0e02da0c8d13fc6534cd5cebdfcd3c5f","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/94cde08c0e02da0c8d13fc6534cd5cebdfcd3c5f"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2019-05-09 18:34:35.000000000","tz":-240},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2019-06-27 10:27:56.000000000","tz":180},"subject":"Use SHA256 instead of MD5 in completion cache","message":"Use SHA256 instead of MD5 in completion cache\n\nFIPS 140 are U.S. government computer security standards that specify\nrequirements for cryptography modules. MD5 is not FIPS compliant [1].\nPreviously, MD5 was used as the hash algorithm for the bash completion\ncache. Hosts running in FIPS mode [2] block execution of the MD5 hash.\nThis makes python-novaclient unusable on FIPS-enabled machines. This\npatch replaces MD5 with SHA256, which is FIPS compliant.\n\n[1] https://csrc.nist.gov/projects/hash-functions\n[2] https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/security_guide/chap-federal_standards_and_regulations\n\nChange-Id: Ia8750bc27aa9a2cfafb6f4f49252f5bd81bc1a40\n(cherry picked from commit 2595bac2294ce05e389eaab6636977963d5fc66c)\n(cherry picked from commit e15cc789d9428cd03c2c5fbd6f5023522f2290cc)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/92002c8046ea5f575bb8a7ed6f4e6a8a29fad22d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/92002c8046ea5f575bb8a7ed6f4e6a8a29fad22d"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}