)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fb56b7cc80b4a2bacb029a83457beffe33b160dc","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: https://review.opendev.org/#/c/645611/"},{"line_number":18,"context_line":"Part of blueprint nova-support-instance-power-update"},{"line_number":19,"context_line":"Story: 2004969"},{"line_number":20,"context_line":"Task: 34271"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I1f5de90e19b7b13c7746fea8bbdf8e09bcb92cff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_2b038b75","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":11},"updated":"2019-07-09 21:08:37.000000000","message":"novaclient doesn\u0027t use storyboard so we don\u0027t need these","commit_id":"08eedfc3f6a8ec787c537591879c151019391753"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"084142b15f00c8ee60a2e4aaa098df393a032971","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: https://review.opendev.org/#/c/645611/"},{"line_number":18,"context_line":"Part of blueprint nova-support-instance-power-update"},{"line_number":19,"context_line":"Story: 2004969"},{"line_number":20,"context_line":"Task: 34271"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I1f5de90e19b7b13c7746fea8bbdf8e09bcb92cff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_4ea247fe","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":11},"in_reply_to":"7faddb67_2b038b75","updated":"2019-07-15 13:23:15.000000000","message":"yea but its to track the issues on the ironic side.","commit_id":"08eedfc3f6a8ec787c537591879c151019391753"}],"novaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"c1ea444677b18f38d02cb0af9eb7d52e3aaf2236","unresolved":false,"context_lines":[{"line_number":4274,"context_line":"            70,  # There are no version-wrapped shell method changes for this."},{"line_number":4275,"context_line":"            71,  # There are no version-wrapped shell method changes for this."},{"line_number":4276,"context_line":"            72,  # There are no version-wrapped shell method changes for this."},{"line_number":4277,"context_line":"            75,  # There are no version-wrapped shell method changes for this."},{"line_number":4278,"context_line":"        ])"},{"line_number":4279,"context_line":"        versions_supported \u003d set(range(0,"},{"line_number":4280,"context_line":"                                 novaclient.API_MAX_VERSION.ver_minor + 1))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_2bb32f4f","line":4277,"range":{"start_line":4277,"start_character":12,"end_line":4277,"end_character":14},"updated":"2019-07-16 05:46:55.000000000","message":"It should not be overwritten.\nJust add 75 after 74.","commit_id":"bf85a60a3fb98d289ac11285ebeda26ffb976e6d"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"01d3c703213e916780cd1c64ad3f6ff64695ac4e","unresolved":false,"context_lines":[{"line_number":4274,"context_line":"            70,  # There are no version-wrapped shell method changes for this."},{"line_number":4275,"context_line":"            71,  # There are no version-wrapped shell method changes for this."},{"line_number":4276,"context_line":"            72,  # There are no version-wrapped shell method changes for this."},{"line_number":4277,"context_line":"            75,  # There are no version-wrapped shell method changes for this."},{"line_number":4278,"context_line":"        ])"},{"line_number":4279,"context_line":"        versions_supported \u003d set(range(0,"},{"line_number":4280,"context_line":"                                 novaclient.API_MAX_VERSION.ver_minor + 1))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_f16668c1","line":4277,"range":{"start_line":4277,"start_character":12,"end_line":4277,"end_character":14},"in_reply_to":"7faddb67_2bb32f4f","updated":"2019-07-16 08:27:57.000000000","message":"\u003e It should not be overwritten.\n \u003e Just add 75 after 74.\n\numm, What are you saying ? I thought 74 had version-wrapped method changes since it was adding two new fields: host and hypervisor_hostname.\n\n(later..)\nI see that 74 was added here, (https://github.com/openstack/python-novaclient/commit/41c25881e669b1ebe6211615dd8d2b24a1db23dc#diff-815379030879ca27268b9336fecbe7dc). I don\u0027t know why 74 was added here when it shouldn\u0027t be. And its a rebase glitch from my part to overwrite 74 from my previous patch to 75 in this one.","commit_id":"bf85a60a3fb98d289ac11285ebeda26ffb976e6d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"8bb9b5c0f96f9b217dd7378914e9f74cf3cdc567","unresolved":false,"context_lines":[{"line_number":4274,"context_line":"            70,  # There are no version-wrapped shell method changes for this."},{"line_number":4275,"context_line":"            71,  # There are no version-wrapped shell method changes for this."},{"line_number":4276,"context_line":"            72,  # There are no version-wrapped shell method changes for this."},{"line_number":4277,"context_line":"            75,  # There are no version-wrapped shell method changes for this."},{"line_number":4278,"context_line":"        ])"},{"line_number":4279,"context_line":"        versions_supported \u003d set(range(0,"},{"line_number":4280,"context_line":"                                 novaclient.API_MAX_VERSION.ver_minor + 1))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_d1324c10","line":4277,"range":{"start_line":4277,"start_character":12,"end_line":4277,"end_character":14},"in_reply_to":"7faddb67_f16668c1","updated":"2019-07-16 08:57:36.000000000","message":"@api_versions.wraps was not used in shell methods and Python API binding methods in the change for microversion 2.74.\nSo 74 was added here.\n\nhttps://review.opendev.org/#/c/647671/\n\nOn the other hand, @api_versions.wraps was used in Python API binding methods in the change for microversion 2.68.\nSo it was not necessary to add 68 here.\n\nhttps://review.opendev.org/#/c/635131/","commit_id":"bf85a60a3fb98d289ac11285ebeda26ffb976e6d"}]}
