)]}'
{"id":"openstack%2Fpython-novaclient~6682","triplet_id":"openstack%2Fpython-novaclient~master~Icbc6938ea332bd70a82890bf4dc0744b2471bc24","project":"openstack/python-novaclient","branch":"master","topic":"bug/986213","hashtags":[],"change_id":"Icbc6938ea332bd70a82890bf4dc0744b2471bc24","subject":"Limit hint/nic parsing to one split on \u0027\u003d\u0027","status":"MERGED","created":"2012-04-20 16:55:43.000000000","updated":"2012-05-03 22:41:29.000000000","submitted":"2012-05-03 22:41:29.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"42b44cf60dfe102a64f061e207c9225e487962a7","_number":6682,"virtual_id_number":6682,"owner":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":1,"date":"2012-05-03 22:41:29.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"all":[{"value":2,"date":"2012-05-03 17:53:28.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"date":"2012-05-03 19:50:52.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2012-04-23 15:08:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2012-04-23 15:05:32.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"all":[{"value":1,"date":"2012-05-03 17:53:28.000000000","_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-04-23 15:08:40.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2012-04-23 15:04:07.000000000","_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-04-23 15:08:40.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2012-05-03 17:53:28.000000000","updated_by":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"reviewer":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"state":"REVIEWER"},{"updated":"2012-05-03 22:41:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e12845c0ca3e05d20a82f59ee207c19a4f91239c","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-04-20 18:48:56.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"7731306575b1a02fde4429c97e2e4ffc6bdd34a8","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-04-23 14:37:47.000000000","message":"Patch Set 1: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"126e44721184afd99a239799a4f71607b21e3820","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2012-04-23 15:04:07.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9ff7cd5f0390df39f73db5072dd5679b17f4e85c","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2012-04-23 15:05:32.000000000","message":"Patch Set 2:\n\nIt doesn\u0027t really make sense to apply the same fix to --nic parsing, as it is a user error if either the ip or network uuid have an equals in them. However, the code would just raise with \u0027too many values to unpack\u0027, so I guess this is better.","accounts_in_message":[],"_revision_number":2},{"id":"e8bfcf8b93ab465d5eadef0eaec215be820c0983","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-04-23 15:08:40.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"d9d71ef438152dd4aa1f5b356d2404f12e94d0da","author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"date":"2012-05-03 17:53:28.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"bc1bda32388eb16230746523cc7803b6fc667e82","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-05-03 19:50:52.000000000","message":"Patch Set 2: Fails\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-python-novaclient-merge/183/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/3830/ : FAILURE \nhttps://jenkins.openstack.org/job/gate-python-novaclient-unittests/198/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-pep8/187/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"60143fae11af86b0918785c84e7f82bf6e63363d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-05-03 22:41:29.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"3a14384e94501a7ba805858b117136d7a3419dd8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-05-03 22:41:29.000000000","message":"Patch Set 2: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-python-novaclient-merge/183/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-unittests/198/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-novaclient-pep8/187/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/3841/ : SUCCESS","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f47f603c668f964631e5dce9641ac98ac33bc624","revisions":{"70188150ab5800bb6a277789bcd11ca39ee4dc32":{"kind":"REWORK","_number":1,"created":"2012-04-20 16:55:43.000000000","uploader":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"ref":"refs/changes/82/6682/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/82/6682/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/82/6682/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/82/6682/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/82/6682/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/82/6682/1"}}},"commit":{"parents":[{"commit":"d6d7386fad20fe3165419b3ab2ee51bd90b46e2c","subject":"Update unittests to be Python 2.6 compatible.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d6d7386fad20fe3165419b3ab2ee51bd90b46e2c"}]}],"author":{"name":"Brian Waldon","email":"bcwaldon@gmail.com","date":"2012-04-20 16:54:15.000000000","tz":-420},"committer":{"name":"Brian Waldon","email":"bcwaldon@gmail.com","date":"2012-04-20 16:54:15.000000000","tz":-420},"subject":"Prevent hint parsing from splitting more than once","message":"Prevent hint parsing from splitting more than once\n\n* Make sure we split a scheduler hint like \u0027a\u003db\u003dc\u0027 into (\u0027a\u0027, \u0027b\u003dc\u0027) rather than (\u0027a\u0027, \u0027b\u0027, \u0027c\u0027)\n* Fixes bug 986213\n\nChange-Id: Icbc6938ea332bd70a82890bf4dc0744b2471bc24\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/70188150ab5800bb6a277789bcd11ca39ee4dc32"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/70188150ab5800bb6a277789bcd11ca39ee4dc32"}]},"branch":"refs/heads/master"},"f47f603c668f964631e5dce9641ac98ac33bc624":{"kind":"REWORK","_number":2,"created":"2012-04-23 15:04:07.000000000","uploader":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"ref":"refs/changes/82/6682/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/82/6682/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/82/6682/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/82/6682/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/82/6682/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/82/6682/2"}}},"commit":{"parents":[{"commit":"d6d7386fad20fe3165419b3ab2ee51bd90b46e2c","subject":"Update unittests to be Python 2.6 compatible.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d6d7386fad20fe3165419b3ab2ee51bd90b46e2c"}]}],"author":{"name":"Brian Waldon","email":"bcwaldon@gmail.com","date":"2012-04-20 16:54:15.000000000","tz":-420},"committer":{"name":"Brian Waldon","email":"bcwaldon@gmail.com","date":"2012-04-23 15:02:33.000000000","tz":-420},"subject":"Limit hint/nic parsing to one split on \u0027\u003d\u0027","message":"Limit hint/nic parsing to one split on \u0027\u003d\u0027\n\n* Make sure we split a scheduler hint like \u0027a\u003db\u003dc\u0027 into (\u0027a\u0027, \u0027b\u003dc\u0027) rather than (\u0027a\u0027, \u0027b\u0027, \u0027c\u0027)\n* Also apply fix to --nic argument\n* Fixes bug 986213\n\nChange-Id: Icbc6938ea332bd70a82890bf4dc0744b2471bc24\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f47f603c668f964631e5dce9641ac98ac33bc624"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/f47f603c668f964631e5dce9641ac98ac33bc624"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
