)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"ab41b9312aec7368b390a2a5af110e38427684ba","unresolved":false,"context_lines":[{"line_number":10,"context_line":"creating a server but not for an existing server. So when delete the"},{"line_number":11,"context_line":"server may be caused two cases although the delete_on_termination option"},{"line_number":12,"context_line":"is true, one the attached volume can be deleted, the other is not."},{"line_number":13,"context_line":"The blueprint aimed to eliminate the differences."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"partially implements blueprint add-delete-on-termination-option"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUX%2F%2B%2FO0%3D","line":13,"updated":"2014-02-17 19:42:38.000000000","message":"The last two sentences are hard to understand.  Do you mean something like this:\n\n    So, when deleting the server, there may be cases where, although the\n    delete_on_termination option is True, one attached volume may be deleted\n    while the other is not.  The blueprint is to eliminate the differences.","commit_id":"681f8292b646cf657db699cbc914d7589df33a3f"}],"novaclient/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"195e9265a370a040e7ba94d79cadfdf8ef660e19","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            default\u003dFalse,"},{"line_number":394,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":395,"context_line":"            help\u003d_(\"Whether to remove the volume while server terminated. \""},{"line_number":396,"context_line":"                   \"Defaults to False.\"))"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        # The auth-system-plugins might require some extra options"},{"line_number":399,"context_line":"        novaclient.auth_plugin.load_auth_system_opts(parser)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B2co%3D","line":396,"updated":"2014-02-18 16:23:50.000000000","message":"Woah, why add the argument here?  This makes no sense; please revert.","commit_id":"61e0e852b7a425f38c661a0cbdfc2eba33892a88"}],"novaclient/tests/v1_1/test_shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"ab41b9312aec7368b390a2a5af110e38427684ba","unresolved":false,"context_lines":[{"line_number":1814,"context_line":"                           pos\u003d-1)"},{"line_number":1815,"context_line":""},{"line_number":1816,"context_line":"    def test_volume_attach(self):"},{"line_number":1817,"context_line":"        self.run_command(\u0027volume-attach sample-server Work /dev/vdb False\u0027)"},{"line_number":1818,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/servers/1234/os-volume_attachments\u0027,"},{"line_number":1819,"context_line":"                           {\u0027volumeAttachment\u0027:"},{"line_number":1820,"context_line":"                               {\u0027device\u0027: \u0027/dev/vdb\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2B%2FTE%3D","line":1817,"updated":"2014-02-17 19:42:38.000000000","message":"Add a separate test for verifying that the --delete-on-termination option works properly; see my comment on shell.py for context.","commit_id":"681f8292b646cf657db699cbc914d7589df33a3f"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"ab41b9312aec7368b390a2a5af110e38427684ba","unresolved":false,"context_lines":[{"line_number":1819,"context_line":"                           {\u0027volumeAttachment\u0027:"},{"line_number":1820,"context_line":"                               {\u0027device\u0027: \u0027/dev/vdb\u0027,"},{"line_number":1821,"context_line":"                                \u0027volumeId\u0027: \u0027Work\u0027,"},{"line_number":1822,"context_line":"                                \u0027delete_on_termination\u0027: \u0027False\u0027}})"},{"line_number":1823,"context_line":""},{"line_number":1824,"context_line":"    def test_volume_attach_without_device(self):"},{"line_number":1825,"context_line":"        self.run_command(\u0027volume-attach sample-server Work\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2B%2FRU%3D","line":1822,"updated":"2014-02-17 19:42:38.000000000","message":"The value here should probably be a boolean, not a string.","commit_id":"681f8292b646cf657db699cbc914d7589df33a3f"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"195e9265a370a040e7ba94d79cadfdf8ef660e19","unresolved":false,"context_lines":[{"line_number":1822,"context_line":""},{"line_number":1823,"context_line":"    def test_volume_attach_with_delete_on_termination(self):"},{"line_number":1824,"context_line":"        self.run_command(\u0027volume-attach sample-server Work /dev/vdb \u0027"},{"line_number":1825,"context_line":"                         \u0027--delete_on_termination\u003dTrue\u0027)"},{"line_number":1826,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/servers/1234/os-volume_attachments\u0027,"},{"line_number":1827,"context_line":"                           {\u0027volumeAttachment\u0027:"},{"line_number":1828,"context_line":"                               {\u0027device\u0027: \u0027/dev/vdb\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B2bg%3D","line":1825,"updated":"2014-02-18 16:23:50.000000000","message":"I want to pass \"--delete-on-termination\", not \"--delete_on_termination\u003dTrue\".","commit_id":"61e0e852b7a425f38c661a0cbdfc2eba33892a88"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bbbc50df27dde123a4da13711db6104c5cce746f","unresolved":false,"context_lines":[{"line_number":1822,"context_line":""},{"line_number":1823,"context_line":"    def test_volume_attach_with_delete_on_termination(self):"},{"line_number":1824,"context_line":"        self.run_command(\u0027volume-attach sample-server Work /dev/vdb \u0027"},{"line_number":1825,"context_line":"                         \u0027--delete-on-termination\u003dTrue\u0027)"},{"line_number":1826,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/servers/1234/os-volume_attachments\u0027,"},{"line_number":1827,"context_line":"                           {\u0027volumeAttachment\u0027:"},{"line_number":1828,"context_line":"                               {\u0027device\u0027: \u0027/dev/vdb\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2Btco%3D","line":1825,"updated":"2014-02-19 16:46:11.000000000","message":"You don\u0027t need the \"\u003dTrue\"—or if you do, that\u0027s a bug and I want this test to fail.","commit_id":"20e607c309d7bfa56c509874a120495575e70c30"}],"novaclient/v1_1/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"ab41b9312aec7368b390a2a5af110e38427684ba","unresolved":false,"context_lines":[{"line_number":1710,"context_line":"         \u0027Use \"auto\" for autoassign (if supported)\u0027)"},{"line_number":1711,"context_line":"@utils.arg(\u0027delete_on_termination\u0027, metavar\u003d\u0027\u003cdelete_on_termination\u003e\u0027,"},{"line_number":1712,"context_line":"    default\u003dFalse,"},{"line_number":1713,"context_line":"    help\u003d\u0027Whether to remove the volume while server terminated (optional).\u0027)"},{"line_number":1714,"context_line":"def do_volume_attach(cs, args):"},{"line_number":1715,"context_line":"    \"\"\"Attach a volume to a server.\"\"\""},{"line_number":1716,"context_line":"    if args.device \u003d\u003d \u0027auto\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2B%2FTU%3D","line":1713,"updated":"2014-02-17 19:42:38.000000000","message":"Make this an option, i.e., \"--default-on-termination\"; you\u0027ll want to use the store_true action.","commit_id":"681f8292b646cf657db699cbc914d7589df33a3f"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"195e9265a370a040e7ba94d79cadfdf8ef660e19","unresolved":false,"context_lines":[{"line_number":1708,"context_line":"@utils.arg(\u0027device\u0027, metavar\u003d\u0027\u003cdevice\u003e\u0027, default\u003dNone, nargs\u003d\u0027?\u0027,"},{"line_number":1709,"context_line":"    help\u003d\u0027Name of the device e.g. /dev/vdb. \u0027"},{"line_number":1710,"context_line":"         \u0027Use \"auto\" for autoassign (if supported)\u0027)"},{"line_number":1711,"context_line":"@utils.arg(\u0027--delete_on_termination\u0027, metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":1712,"context_line":"    default\u003dFalse,"},{"line_number":1713,"context_line":"    help\u003d\u0027Whether to remove the volume while server terminated. \u0027"},{"line_number":1714,"context_line":"        \u0027Defaults to False.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2B2cM%3D","line":1711,"updated":"2014-02-18 16:23:50.000000000","message":"Please use dashes (\u0027-\u0027), not underscores (\u0027_\u0027).  Also, use action\u003d\u0027store_true\u0027 to eliminate having to pass a value.","commit_id":"61e0e852b7a425f38c661a0cbdfc2eba33892a88"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"bbbc50df27dde123a4da13711db6104c5cce746f","unresolved":false,"context_lines":[{"line_number":1709,"context_line":"    help\u003d\u0027Name of the device e.g. /dev/vdb. \u0027"},{"line_number":1710,"context_line":"         \u0027Use \"auto\" for autoassign (if supported)\u0027)"},{"line_number":1711,"context_line":"@utils.arg(\u0027--delete-on-termination\u0027,"},{"line_number":1712,"context_line":"    dest\u003d\u0027delete_on_termination\u0027,"},{"line_number":1713,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":1714,"context_line":"    default\u003dFalse,"},{"line_number":1715,"context_line":"    help\u003d\u0027Whether to remove the volume while server terminated. \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2BtdI%3D","line":1712,"updated":"2014-02-19 16:46:11.000000000","message":"\"dest\" is redundant here.","commit_id":"20e607c309d7bfa56c509874a120495575e70c30"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e228f81662a7c62099d413cf180a81b5ef033fd4","unresolved":false,"context_lines":[{"line_number":1712,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":1713,"context_line":"    default\u003dFalse,"},{"line_number":1714,"context_line":"    help\u003d\u0027Whether to remove the volume while server terminated. \u0027"},{"line_number":1715,"context_line":"        \u0027Defaults to False.\u0027)"},{"line_number":1716,"context_line":"def do_volume_attach(cs, args):"},{"line_number":1717,"context_line":"    \"\"\"Attach a volume to a server.\"\"\""},{"line_number":1718,"context_line":"    if args.device \u003d\u003d \u0027auto\u0027:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAVn%2F%2FJ88%3D","line":1715,"updated":"2014-03-08 01:37:24.000000000","message":"Most other arguments explain default values with () like the following:\n\n (default: 4 weeks ago)\n\nSo here also is better to do it like\n\n (default: False)","commit_id":"101170379dd0d4f5f2ebf1081b90d01b46a7236b"}],"novaclient/v1_1/volumes.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"ab41b9312aec7368b390a2a5af110e38427684ba","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        \"\"\""},{"line_number":119,"context_line":"        body \u003d {\u0027volumeAttachment\u0027: {\u0027volumeId\u0027: volume_id,"},{"line_number":120,"context_line":"                            \u0027device\u0027: device,"},{"line_number":121,"context_line":"                            \u0027delete_on_termination\u0027: delete_on_termination}}"},{"line_number":122,"context_line":"        return self._create(\"/servers/%s/os-volume_attachments\" % server_id,"},{"line_number":123,"context_line":"            body, \"volumeAttachment\")"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2B%2FQc%3D","line":121,"updated":"2014-02-17 19:42:38.000000000","message":"For compatibility, I\u0027d like to see this field only added to the body if delete_on_termination is True.","commit_id":"681f8292b646cf657db699cbc914d7589df33a3f"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e010b2881870350a9c96d35706123490deffceab","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        :param volume_id: The ID of the volume to attach."},{"line_number":114,"context_line":"        :param device: The device name"},{"line_number":115,"context_line":"        :param delete_on_termination: Whether to remove the volume while"},{"line_number":116,"context_line":"            server terminated"},{"line_number":117,"context_line":"        :rtype: :class:`Volume`"},{"line_number":118,"context_line":"        \"\"\""},{"line_number":119,"context_line":"        body \u003d {\u0027volumeAttachment\u0027: {\u0027volumeId\u0027: volume_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAWH%2F%2B7qA%3D","line":116,"updated":"2014-03-21 15:42:08.000000000","message":"s/while server terminated/when the server is terminated./ (femtonit)","commit_id":"625609ed01507cf55ecb0d022a2b6cc95046a55f"}],"novaclient/v3/shell.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"ab41b9312aec7368b390a2a5af110e38427684ba","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"         \u0027Use \"auto\" for autoassign (if supported)\u0027)"},{"line_number":1409,"context_line":"@utils.arg(\u0027delete_on_termination\u0027, metavar\u003d\u0027\u003cdelete_on_termination\u003e\u0027,"},{"line_number":1410,"context_line":"    default\u003dFalse,"},{"line_number":1411,"context_line":"    help\u003d\u0027Whether to remove the volume while server terminated (optional).\u0027)"},{"line_number":1412,"context_line":"def do_volume_attach(cs, args):"},{"line_number":1413,"context_line":"    \"\"\"Attach a volume to a server.\"\"\""},{"line_number":1414,"context_line":"    if args.device \u003d\u003d \u0027auto\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2B%2FQE%3D","line":1411,"updated":"2014-02-17 19:42:38.000000000","message":"Same comments here as in v1_1/shell.py","commit_id":"681f8292b646cf657db699cbc914d7589df33a3f"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"f6539b89b9858698eca2f0fda8f602145850f78e","unresolved":false,"context_lines":[{"line_number":1407,"context_line":"    help\u003d\u0027Name of the device e.g. /dev/vdb. \u0027"},{"line_number":1408,"context_line":"         \u0027Use \"auto\" for autoassign (if supported)\u0027)"},{"line_number":1409,"context_line":"@utils.arg(\u0027--delete-on-termination\u0027,"},{"line_number":1410,"context_line":"    dest\u003d\u0027delete_on_termination\u0027,"},{"line_number":1411,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":1412,"context_line":"    default\u003dFalse,"},{"line_number":1413,"context_line":"    help\u003d\u0027Whether to remove the volume while server terminated. \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2BhVM%3D","line":1410,"updated":"2014-02-20 18:25:01.000000000","message":"When I comment on an issue, I don\u0027t always point out all instances.  The \u0027dest\u0027 argument here is also redundant, and you should eliminate it.","commit_id":"69ec7d5e1a7d67c4fac3c3c24994d56dd5332211"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e228f81662a7c62099d413cf180a81b5ef033fd4","unresolved":false,"context_lines":[{"line_number":1410,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":1411,"context_line":"    default\u003dFalse,"},{"line_number":1412,"context_line":"    help\u003d\u0027Whether to remove the volume while server terminated. \u0027"},{"line_number":1413,"context_line":"        \u0027Defaults to False.\u0027)"},{"line_number":1414,"context_line":"def do_volume_attach(cs, args):"},{"line_number":1415,"context_line":"    \"\"\"Attach a volume to a server.\"\"\""},{"line_number":1416,"context_line":"    if args.device \u003d\u003d \u0027auto\u0027:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAVn%2F%2FJ9A%3D","line":1413,"updated":"2014-03-08 01:37:24.000000000","message":"ditto","commit_id":"101170379dd0d4f5f2ebf1081b90d01b46a7236b"}]}