)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2b94f2c2a6c7203039ca4f583040c7254bc432ff","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brin Zhang \u003czhangbailin@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-08 01:23:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Microversion 2.76: Add delete_on_termination to volume-attach API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Support add \u0027delete_on_termination\u0027 field to the voume attach API to"},{"line_number":10,"context_line":"support configuring whether to delete the data volume when the instance"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_63e143cf","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":17},"updated":"2019-09-03 21:52:20.000000000","message":"78 now","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f7ad40a47a39dddfd0182f05ac893bfe18591fb7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brin Zhang \u003czhangbailin@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-08 01:23:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Microversion 2.76: Add delete_on_termination to volume-attach API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Support add \u0027delete_on_termination\u0027 field to the voume attach API to"},{"line_number":10,"context_line":"support configuring whether to delete the data volume when the instance"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_2d06d187","line":7,"range":{"start_line":7,"start_character":15,"end_line":7,"end_character":17},"in_reply_to":"7faddb67_63e143cf","updated":"2019-09-04 10:11:40.000000000","message":"Done","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2b94f2c2a6c7203039ca4f583040c7254bc432ff","unresolved":false,"context_lines":[{"line_number":11,"context_line":"is destroyed, and the ``delete_on_termination`` fields will be added the"},{"line_number":12,"context_line":"GET responses when showing attached volumes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"* The \u0027--delete-on-termination\u0027 will be add the `nova volume-attach` CLI."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Part of blueprint support-delete-on-termination-in-server-attach-volume"},{"line_number":17,"context_line":"Change-Id: I8dcf2fd21a2fd99ca4e05bd953fbbe026be3a619"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_43cc4760","line":14,"range":{"start_line":14,"start_character":32,"end_line":14,"end_character":36},"updated":"2019-09-03 21:52:20.000000000","message":"option is added to the...","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f7ad40a47a39dddfd0182f05ac893bfe18591fb7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"is destroyed, and the ``delete_on_termination`` fields will be added the"},{"line_number":12,"context_line":"GET responses when showing attached volumes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"* The \u0027--delete-on-termination\u0027 will be add the `nova volume-attach` CLI."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Part of blueprint support-delete-on-termination-in-server-attach-volume"},{"line_number":17,"context_line":"Change-Id: I8dcf2fd21a2fd99ca4e05bd953fbbe026be3a619"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_4d09cd92","line":14,"range":{"start_line":14,"start_character":32,"end_line":14,"end_character":36},"in_reply_to":"7faddb67_43cc4760","updated":"2019-09-04 10:11:40.000000000","message":"Done","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2b94f2c2a6c7203039ca4f583040c7254bc432ff","unresolved":false,"context_lines":[{"line_number":12,"context_line":"GET responses when showing attached volumes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"* The \u0027--delete-on-termination\u0027 will be add the `nova volume-attach` CLI."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Part of blueprint support-delete-on-termination-in-server-attach-volume"},{"line_number":17,"context_line":"Change-Id: I8dcf2fd21a2fd99ca4e05bd953fbbe026be3a619"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_c3e037cf","line":15,"updated":"2019-09-03 21:52:20.000000000","message":"Add a Depends-On to the nova change:\n\nhttps://review.opendev.org/#/c/673133/","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f7ad40a47a39dddfd0182f05ac893bfe18591fb7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"GET responses when showing attached volumes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"* The \u0027--delete-on-termination\u0027 will be add the `nova volume-attach` CLI."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Part of blueprint support-delete-on-termination-in-server-attach-volume"},{"line_number":17,"context_line":"Change-Id: I8dcf2fd21a2fd99ca4e05bd953fbbe026be3a619"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_edfbd977","line":15,"in_reply_to":"7faddb67_c3e037cf","updated":"2019-09-04 10:11:40.000000000","message":"Done","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c7fd5654e4e0c250564f035a97247a10aa968b16","unresolved":false,"context_lines":[{"line_number":10,"context_line":"support configuring whether to delete the data volume when the server"},{"line_number":11,"context_line":"is destroyed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Udating the ``nova volume-attachments`` command to show the"},{"line_number":14,"context_line":"``delete_on_termination`` value if 2.79 or greater is used, and will be"},{"line_number":15,"context_line":"add the \u0027DELETE ON TERMINATION\u0027 title to the list."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"5faad753_804f1ebc","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":7},"updated":"2019-09-09 15:20:41.000000000","message":"Updating","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b6a290c4ec0189769411c00ebf12cc1cbba0ad59","unresolved":false,"context_lines":[{"line_number":10,"context_line":"support configuring whether to delete the data volume when the server"},{"line_number":11,"context_line":"is destroyed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Udating the ``nova volume-attachments`` command to show the"},{"line_number":14,"context_line":"``delete_on_termination`` value if 2.79 or greater is used, and will be"},{"line_number":15,"context_line":"add the \u0027DELETE ON TERMINATION\u0027 title to the list."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"5faad753_51c1fa53","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":7},"in_reply_to":"5faad753_804f1ebc","updated":"2019-09-09 16:46:46.000000000","message":"Done","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c7fd5654e4e0c250564f035a97247a10aa968b16","unresolved":false,"context_lines":[{"line_number":11,"context_line":"is destroyed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Udating the ``nova volume-attachments`` command to show the"},{"line_number":14,"context_line":"``delete_on_termination`` value if 2.79 or greater is used, and will be"},{"line_number":15,"context_line":"add the \u0027DELETE ON TERMINATION\u0027 title to the list."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"* The \u0027--delete-on-termination\u0027 option is added to the `nova volume-attach`"},{"line_number":18,"context_line":"  CLI."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"5faad753_e0d7f2be","line":15,"range":{"start_line":14,"start_character":58,"end_line":15,"end_character":50},"updated":"2019-09-09 15:20:41.000000000","message":"You could just remove this, it\u0027s an implementation detail.","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b6a290c4ec0189769411c00ebf12cc1cbba0ad59","unresolved":false,"context_lines":[{"line_number":11,"context_line":"is destroyed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Udating the ``nova volume-attachments`` command to show the"},{"line_number":14,"context_line":"``delete_on_termination`` value if 2.79 or greater is used, and will be"},{"line_number":15,"context_line":"add the \u0027DELETE ON TERMINATION\u0027 title to the list."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"* The \u0027--delete-on-termination\u0027 option is added to the `nova volume-attach`"},{"line_number":18,"context_line":"  CLI."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"5faad753_11bb82e2","line":15,"range":{"start_line":14,"start_character":58,"end_line":15,"end_character":50},"in_reply_to":"5faad753_e0d7f2be","updated":"2019-09-09 16:46:46.000000000","message":"Done","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"}],"doc/source/cli/nova.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2b94f2c2a6c7203039ca4f583040c7254bc432ff","unresolved":false,"context_lines":[{"line_number":3819,"context_line":"  Tag for the attached volume. (Supported by API versions \u00272.49\u0027 - \u00272.latest\u0027)"},{"line_number":3820,"context_line":""},{"line_number":3821,"context_line":"``--delete-on-termination \u003cdelete_on_termination\u003e``"},{"line_number":3822,"context_line":"  Determine if the attached volume is deleted when the server is destroyed."},{"line_number":3823,"context_line":"  Default: ``false``. (Supported by API versions \u00272.76\u0027 - \u00272.latest\u0027)"},{"line_number":3824,"context_line":""},{"line_number":3825,"context_line":".. _nova_volume-attachments:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_a3041b7f","line":3822,"range":{"start_line":3822,"start_character":2,"end_line":3822,"end_character":11},"updated":"2019-09-03 21:52:20.000000000","message":"Specify","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f7ad40a47a39dddfd0182f05ac893bfe18591fb7","unresolved":false,"context_lines":[{"line_number":3819,"context_line":"  Tag for the attached volume. (Supported by API versions \u00272.49\u0027 - \u00272.latest\u0027)"},{"line_number":3820,"context_line":""},{"line_number":3821,"context_line":"``--delete-on-termination \u003cdelete_on_termination\u003e``"},{"line_number":3822,"context_line":"  Determine if the attached volume is deleted when the server is destroyed."},{"line_number":3823,"context_line":"  Default: ``false``. (Supported by API versions \u00272.76\u0027 - \u00272.latest\u0027)"},{"line_number":3824,"context_line":""},{"line_number":3825,"context_line":".. _nova_volume-attachments:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_2dd2515d","line":3822,"range":{"start_line":3822,"start_character":2,"end_line":3822,"end_character":11},"in_reply_to":"7faddb67_a3041b7f","updated":"2019-09-04 10:11:40.000000000","message":"Done","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2b94f2c2a6c7203039ca4f583040c7254bc432ff","unresolved":false,"context_lines":[{"line_number":3820,"context_line":""},{"line_number":3821,"context_line":"``--delete-on-termination \u003cdelete_on_termination\u003e``"},{"line_number":3822,"context_line":"  Determine if the attached volume is deleted when the server is destroyed."},{"line_number":3823,"context_line":"  Default: ``false``. (Supported by API versions \u00272.76\u0027 - \u00272.latest\u0027)"},{"line_number":3824,"context_line":""},{"line_number":3825,"context_line":".. _nova_volume-attachments:"},{"line_number":3826,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_c3091795","line":3823,"range":{"start_line":3823,"start_character":52,"end_line":3823,"end_character":54},"updated":"2019-09-03 21:52:20.000000000","message":"78","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f7ad40a47a39dddfd0182f05ac893bfe18591fb7","unresolved":false,"context_lines":[{"line_number":3820,"context_line":""},{"line_number":3821,"context_line":"``--delete-on-termination \u003cdelete_on_termination\u003e``"},{"line_number":3822,"context_line":"  Determine if the attached volume is deleted when the server is destroyed."},{"line_number":3823,"context_line":"  Default: ``false``. (Supported by API versions \u00272.76\u0027 - \u00272.latest\u0027)"},{"line_number":3824,"context_line":""},{"line_number":3825,"context_line":".. _nova_volume-attachments:"},{"line_number":3826,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7faddb67_4dd54d42","line":3823,"range":{"start_line":3823,"start_character":52,"end_line":3823,"end_character":54},"in_reply_to":"7faddb67_c3091795","updated":"2019-09-04 10:11:40.000000000","message":"Done","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e07e016e152b1620a086e805aaab1f982c627bd4","unresolved":false,"context_lines":[{"line_number":3826,"context_line":""},{"line_number":3827,"context_line":".. code-block:: console"},{"line_number":3828,"context_line":""},{"line_number":3829,"context_line":"   usage: nova volume-attach [--delete-on-termination \u003cdelete_on_termination\u003e]"},{"line_number":3830,"context_line":"                             [--tag \u003ctag\u003e] \u003cserver\u003e \u003cvolume\u003e [\u003cdevice\u003e]"},{"line_number":3831,"context_line":""},{"line_number":3832,"context_line":"Attach a volume to a server."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7faddb67_27d6d728","line":3829,"range":{"start_line":3829,"start_character":53,"end_line":3829,"end_character":77},"updated":"2019-09-05 06:28:50.000000000","message":"Remove it.","commit_id":"dde5cbd4d39eeab2a4c0ce26fe26232b88cc0bbe"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3b7516d5b41a06677783619905be63fa332e3773","unresolved":false,"context_lines":[{"line_number":3826,"context_line":""},{"line_number":3827,"context_line":".. code-block:: console"},{"line_number":3828,"context_line":""},{"line_number":3829,"context_line":"   usage: nova volume-attach [--delete-on-termination \u003cdelete_on_termination\u003e]"},{"line_number":3830,"context_line":"                             [--tag \u003ctag\u003e] \u003cserver\u003e \u003cvolume\u003e [\u003cdevice\u003e]"},{"line_number":3831,"context_line":""},{"line_number":3832,"context_line":"Attach a volume to a server."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7faddb67_028f0923","line":3829,"range":{"start_line":3829,"start_character":53,"end_line":3829,"end_character":77},"in_reply_to":"7faddb67_27d6d728","updated":"2019-09-05 08:08:46.000000000","message":"Done","commit_id":"dde5cbd4d39eeab2a4c0ce26fe26232b88cc0bbe"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e07e016e152b1620a086e805aaab1f982c627bd4","unresolved":false,"context_lines":[{"line_number":3848,"context_line":"``--tag \u003ctag\u003e``"},{"line_number":3849,"context_line":"  Tag for the attached volume. (Supported by API versions \u00272.49\u0027 - \u00272.latest\u0027)"},{"line_number":3850,"context_line":""},{"line_number":3851,"context_line":"``--delete-on-termination \u003cdelete_on_termination\u003e``"},{"line_number":3852,"context_line":"  Specify if the attached volume is deleted when the server is destroyed."},{"line_number":3853,"context_line":"  Default: ``false``. (Supported by API versions \u00272.78\u0027 - \u00272.latest\u0027)"},{"line_number":3854,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7faddb67_07bcfbd9","line":3851,"range":{"start_line":3851,"start_character":25,"end_line":3851,"end_character":49},"updated":"2019-09-05 06:28:50.000000000","message":"ditto","commit_id":"dde5cbd4d39eeab2a4c0ce26fe26232b88cc0bbe"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3b7516d5b41a06677783619905be63fa332e3773","unresolved":false,"context_lines":[{"line_number":3848,"context_line":"``--tag \u003ctag\u003e``"},{"line_number":3849,"context_line":"  Tag for the attached volume. (Supported by API versions \u00272.49\u0027 - \u00272.latest\u0027)"},{"line_number":3850,"context_line":""},{"line_number":3851,"context_line":"``--delete-on-termination \u003cdelete_on_termination\u003e``"},{"line_number":3852,"context_line":"  Specify if the attached volume is deleted when the server is destroyed."},{"line_number":3853,"context_line":"  Default: ``false``. (Supported by API versions \u00272.78\u0027 - \u00272.latest\u0027)"},{"line_number":3854,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7faddb67_2292454c","line":3851,"range":{"start_line":3851,"start_character":25,"end_line":3851,"end_character":49},"in_reply_to":"7faddb67_07bcfbd9","updated":"2019-09-05 08:08:46.000000000","message":"Done","commit_id":"dde5cbd4d39eeab2a4c0ce26fe26232b88cc0bbe"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c7fd5654e4e0c250564f035a97247a10aa968b16","unresolved":false,"context_lines":[{"line_number":3872,"context_line":"  Tag for the attached volume. (Supported by API versions \u00272.49\u0027 - \u00272.latest\u0027)"},{"line_number":3873,"context_line":""},{"line_number":3874,"context_line":"``--delete-on-termination``"},{"line_number":3875,"context_line":"  Specify if the attached volume is deleted when the server is destroyed."},{"line_number":3876,"context_line":"  Default: ``false``. (Supported by API versions \u00272.79\u0027 - \u00272.latest\u0027)"},{"line_number":3877,"context_line":""},{"line_number":3878,"context_line":".. _nova_volume-attachments:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"5faad753_a0e1fa9c","line":3875,"range":{"start_line":3875,"start_character":33,"end_line":3875,"end_character":35},"updated":"2019-09-09 15:20:41.000000000","message":"should be","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b6a290c4ec0189769411c00ebf12cc1cbba0ad59","unresolved":false,"context_lines":[{"line_number":3872,"context_line":"  Tag for the attached volume. (Supported by API versions \u00272.49\u0027 - \u00272.latest\u0027)"},{"line_number":3873,"context_line":""},{"line_number":3874,"context_line":"``--delete-on-termination``"},{"line_number":3875,"context_line":"  Specify if the attached volume is deleted when the server is destroyed."},{"line_number":3876,"context_line":"  Default: ``false``. (Supported by API versions \u00272.79\u0027 - \u00272.latest\u0027)"},{"line_number":3877,"context_line":""},{"line_number":3878,"context_line":".. _nova_volume-attachments:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"5faad753_86741637","line":3875,"range":{"start_line":3875,"start_character":33,"end_line":3875,"end_character":35},"in_reply_to":"5faad753_a0e1fa9c","updated":"2019-09-09 16:46:46.000000000","message":"Done","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c7fd5654e4e0c250564f035a97247a10aa968b16","unresolved":false,"context_lines":[{"line_number":3873,"context_line":""},{"line_number":3874,"context_line":"``--delete-on-termination``"},{"line_number":3875,"context_line":"  Specify if the attached volume is deleted when the server is destroyed."},{"line_number":3876,"context_line":"  Default: ``false``. (Supported by API versions \u00272.79\u0027 - \u00272.latest\u0027)"},{"line_number":3877,"context_line":""},{"line_number":3878,"context_line":".. _nova_volume-attachments:"},{"line_number":3879,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"5faad753_40f04668","line":3876,"range":{"start_line":3876,"start_character":2,"end_line":3876,"end_character":21},"updated":"2019-09-09 15:20:41.000000000","message":"This is a bit confusing since the option does not take a value. I would say instead, \"By default the attached volume is not deleted when the server is destroyed.\"","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b6a290c4ec0189769411c00ebf12cc1cbba0ad59","unresolved":false,"context_lines":[{"line_number":3873,"context_line":""},{"line_number":3874,"context_line":"``--delete-on-termination``"},{"line_number":3875,"context_line":"  Specify if the attached volume is deleted when the server is destroyed."},{"line_number":3876,"context_line":"  Default: ``false``. (Supported by API versions \u00272.79\u0027 - \u00272.latest\u0027)"},{"line_number":3877,"context_line":""},{"line_number":3878,"context_line":".. _nova_volume-attachments:"},{"line_number":3879,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"5faad753_4694de37","line":3876,"range":{"start_line":3876,"start_character":2,"end_line":3876,"end_character":21},"in_reply_to":"5faad753_40f04668","updated":"2019-09-09 16:46:46.000000000","message":"Done","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"}],"novaclient/__init__.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2b94f2c2a6c7203039ca4f583040c7254bc432ff","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# when client supported the max version, and bumped sequentially, otherwise"},{"line_number":26,"context_line":"# the client may break due to server side new version may include some"},{"line_number":27,"context_line":"# backward incompatible change."},{"line_number":28,"context_line":"API_MAX_VERSION \u003d api_versions.APIVersion(\"2.76\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_83ff9f64","line":28,"range":{"start_line":28,"start_character":45,"end_line":28,"end_character":47},"updated":"2019-09-03 21:52:20.000000000","message":"78","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f7ad40a47a39dddfd0182f05ac893bfe18591fb7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# when client supported the max version, and bumped sequentially, otherwise"},{"line_number":26,"context_line":"# the client may break due to server side new version may include some"},{"line_number":27,"context_line":"# backward incompatible change."},{"line_number":28,"context_line":"API_MAX_VERSION \u003d api_versions.APIVersion(\"2.76\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_cdca9d6c","line":28,"range":{"start_line":28,"start_character":45,"end_line":28,"end_character":47},"in_reply_to":"7faddb67_83ff9f64","updated":"2019-09-04 10:11:40.000000000","message":"Done","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"}],"novaclient/tests/unit/v2/fakes.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e07e016e152b1620a086e805aaab1f982c627bd4","unresolved":false,"context_lines":[{"line_number":2032,"context_line":"                 \"zoneState\": {\"available\": False},"},{"line_number":2033,"context_line":"                 \"hosts\": None}]})"},{"line_number":2034,"context_line":""},{"line_number":2035,"context_line":"    def get_servers_1234_os_interface(self, **kw):"},{"line_number":2036,"context_line":"        attachments \u003d {"},{"line_number":2037,"context_line":"            \"interfaceAttachments\": ["},{"line_number":2038,"context_line":"                {\"port_state\": \"ACTIVE\","}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_27a497b8","line":2035,"range":{"start_line":2035,"start_character":8,"end_line":2035,"end_character":37},"updated":"2019-09-05 06:28:50.000000000","message":"It is for the \"GET /servers/{server_id}/os-interface\" API.","commit_id":"dde5cbd4d39eeab2a4c0ce26fe26232b88cc0bbe"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3b7516d5b41a06677783619905be63fa332e3773","unresolved":false,"context_lines":[{"line_number":2032,"context_line":"                 \"zoneState\": {\"available\": False},"},{"line_number":2033,"context_line":"                 \"hosts\": None}]})"},{"line_number":2034,"context_line":""},{"line_number":2035,"context_line":"    def get_servers_1234_os_interface(self, **kw):"},{"line_number":2036,"context_line":"        attachments \u003d {"},{"line_number":2037,"context_line":"            \"interfaceAttachments\": ["},{"line_number":2038,"context_line":"                {\"port_state\": \"ACTIVE\","}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_c2949138","line":2035,"range":{"start_line":2035,"start_character":8,"end_line":2035,"end_character":37},"in_reply_to":"7faddb67_27a497b8","updated":"2019-09-05 08:08:46.000000000","message":"Done","commit_id":"dde5cbd4d39eeab2a4c0ce26fe26232b88cc0bbe"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e07e016e152b1620a086e805aaab1f982c627bd4","unresolved":false,"context_lines":[{"line_number":2053,"context_line":"            # Include the \"tag\" field in each attachment."},{"line_number":2054,"context_line":"            for attachment in attachments[\u0027interfaceAttachments\u0027]:"},{"line_number":2055,"context_line":"                attachment[\u0027tag\u0027] \u003d \u0027test-tag\u0027"},{"line_number":2056,"context_line":""},{"line_number":2057,"context_line":"        if self.api_version \u003e\u003d api_versions.APIVersion(\u00272.78\u0027):"},{"line_number":2058,"context_line":"            # Include the \"delete_on_termination\" field in"},{"line_number":2059,"context_line":"            # each attachment."},{"line_number":2060,"context_line":"            for attachment in attachments[\u0027volumeAttachments\u0027]:"},{"line_number":2061,"context_line":"                attachment[\u0027delete_on_termination\u0027] \u003d True"},{"line_number":2062,"context_line":"        return (200, {}, attachments)"},{"line_number":2063,"context_line":""},{"line_number":2064,"context_line":"    def post_servers_1234_os_interface(self, **kw):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_a78f272c","line":2061,"range":{"start_line":2056,"start_character":0,"end_line":2061,"end_character":58},"updated":"2019-09-05 06:28:50.000000000","message":"It is not necessary. Remove it.","commit_id":"dde5cbd4d39eeab2a4c0ce26fe26232b88cc0bbe"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3b7516d5b41a06677783619905be63fa332e3773","unresolved":false,"context_lines":[{"line_number":2053,"context_line":"            # Include the \"tag\" field in each attachment."},{"line_number":2054,"context_line":"            for attachment in attachments[\u0027interfaceAttachments\u0027]:"},{"line_number":2055,"context_line":"                attachment[\u0027tag\u0027] \u003d \u0027test-tag\u0027"},{"line_number":2056,"context_line":""},{"line_number":2057,"context_line":"        if self.api_version \u003e\u003d api_versions.APIVersion(\u00272.78\u0027):"},{"line_number":2058,"context_line":"            # Include the \"delete_on_termination\" field in"},{"line_number":2059,"context_line":"            # each attachment."},{"line_number":2060,"context_line":"            for attachment in attachments[\u0027volumeAttachments\u0027]:"},{"line_number":2061,"context_line":"                attachment[\u0027delete_on_termination\u0027] \u003d True"},{"line_number":2062,"context_line":"        return (200, {}, attachments)"},{"line_number":2063,"context_line":""},{"line_number":2064,"context_line":"    def post_servers_1234_os_interface(self, **kw):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_e2974d38","line":2061,"range":{"start_line":2056,"start_character":0,"end_line":2061,"end_character":58},"in_reply_to":"7faddb67_a78f272c","updated":"2019-09-05 08:08:46.000000000","message":"Done","commit_id":"dde5cbd4d39eeab2a4c0ce26fe26232b88cc0bbe"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e07e016e152b1620a086e805aaab1f982c627bd4","unresolved":false,"context_lines":[{"line_number":2066,"context_line":"        if self.api_version \u003e\u003d api_versions.APIVersion(\u00272.70\u0027):"},{"line_number":2067,"context_line":"            # Include the \"tag\" field in the response."},{"line_number":2068,"context_line":"            attachment[\u0027tag\u0027] \u003d \u0027test-tag\u0027"},{"line_number":2069,"context_line":""},{"line_number":2070,"context_line":"        if self.api_version \u003e\u003d api_versions.APIVersion(\u00272.78\u0027):"},{"line_number":2071,"context_line":"            # Include the \"delete_on_termination\" field in the"},{"line_number":2072,"context_line":"            # response."},{"line_number":2073,"context_line":"            attachment[\u0027delete_on_termination\u0027] \u003d True"},{"line_number":2074,"context_line":"        return (200, {}, {\u0027interfaceAttachment\u0027: attachment})"},{"line_number":2075,"context_line":""},{"line_number":2076,"context_line":"    def delete_servers_1234_os_interface_port_id(self, **kw):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_479af36e","line":2073,"range":{"start_line":2069,"start_character":0,"end_line":2073,"end_character":54},"updated":"2019-09-05 06:28:50.000000000","message":"ditto","commit_id":"dde5cbd4d39eeab2a4c0ce26fe26232b88cc0bbe"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3b7516d5b41a06677783619905be63fa332e3773","unresolved":false,"context_lines":[{"line_number":2066,"context_line":"        if self.api_version \u003e\u003d api_versions.APIVersion(\u00272.70\u0027):"},{"line_number":2067,"context_line":"            # Include the \"tag\" field in the response."},{"line_number":2068,"context_line":"            attachment[\u0027tag\u0027] \u003d \u0027test-tag\u0027"},{"line_number":2069,"context_line":""},{"line_number":2070,"context_line":"        if self.api_version \u003e\u003d api_versions.APIVersion(\u00272.78\u0027):"},{"line_number":2071,"context_line":"            # Include the \"delete_on_termination\" field in the"},{"line_number":2072,"context_line":"            # response."},{"line_number":2073,"context_line":"            attachment[\u0027delete_on_termination\u0027] \u003d True"},{"line_number":2074,"context_line":"        return (200, {}, {\u0027interfaceAttachment\u0027: attachment})"},{"line_number":2075,"context_line":""},{"line_number":2076,"context_line":"    def delete_servers_1234_os_interface_port_id(self, **kw):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_82a21999","line":2073,"range":{"start_line":2069,"start_character":0,"end_line":2073,"end_character":54},"in_reply_to":"7faddb67_479af36e","updated":"2019-09-05 08:08:46.000000000","message":"Done","commit_id":"dde5cbd4d39eeab2a4c0ce26fe26232b88cc0bbe"}],"novaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"6bea43dbb922b766742887b3e6a5fe7501e56976","unresolved":false,"context_lines":[{"line_number":4304,"context_line":"            71,  # There are no version-wrapped shell method changes for this."},{"line_number":4305,"context_line":"            72,  # There are no version-wrapped shell method changes for this."},{"line_number":4306,"context_line":"            74,  # There are no version-wrapped shell method changes for this."},{"line_number":4307,"context_line":"            75,  # There are no version-wrapped shell method changes for this."},{"line_number":4308,"context_line":"            76,  # NOTE(brinzhang): 2.76 add `delete_on_termination` field to"},{"line_number":4309,"context_line":"                 # volume-attach API, to support configuring whether to delete"},{"line_number":4310,"context_line":"                 # the data volume when the instance is destroyed. And it will"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_ffa0a3f6","line":4307,"range":{"start_line":4307,"start_character":12,"end_line":4307,"end_character":77},"updated":"2019-07-30 12:13:16.000000000","message":"This patch cannot use 2.75 microversion, beacuse it\u0027s not in the nova-runway now. After review at this patch, I will update *this*, maybe 2.76 microversion is not suitable.","commit_id":"39d125f4ff0aa6513e32f45cc0c8d122fef42c97"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"86ea06d3b6066992f385cdcbcb496a028cbdda5a","unresolved":false,"context_lines":[{"line_number":4305,"context_line":"            72,  # There are no version-wrapped shell method changes for this."},{"line_number":4306,"context_line":"            74,  # There are no version-wrapped shell method changes for this."},{"line_number":4307,"context_line":"            75,  # There are no version-wrapped shell method changes for this."},{"line_number":4308,"context_line":"            76,  # NOTE(brinzhang): 2.76 add `delete_on_termination` field to"},{"line_number":4309,"context_line":"                 # volume-attach API, to support configuring whether to delete"},{"line_number":4310,"context_line":"                 # the data volume when the instance is destroyed. And it will"},{"line_number":4311,"context_line":"                 # be added the GET responses when showing attached volumes."},{"line_number":4312,"context_line":"        ])"},{"line_number":4313,"context_line":"        versions_supported \u003d set(range(0,"},{"line_number":4314,"context_line":"                                 novaclient.API_MAX_VERSION.ver_minor + 1))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_7dfa22bd","line":4311,"range":{"start_line":4308,"start_character":0,"end_line":4311,"end_character":76},"updated":"2019-08-05 16:01:59.000000000","message":"this skip list is designed for those microversions which do not have direct changes at CLI level. 2.76 adds a new argument, so it should not be listed here.","commit_id":"39d125f4ff0aa6513e32f45cc0c8d122fef42c97"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"fbbd780f3625ebd42d6c97c606caaffb778a1662","unresolved":false,"context_lines":[{"line_number":4305,"context_line":"            72,  # There are no version-wrapped shell method changes for this."},{"line_number":4306,"context_line":"            74,  # There are no version-wrapped shell method changes for this."},{"line_number":4307,"context_line":"            75,  # There are no version-wrapped shell method changes for this."},{"line_number":4308,"context_line":"            76,  # NOTE(brinzhang): 2.76 add `delete_on_termination` field to"},{"line_number":4309,"context_line":"                 # volume-attach API, to support configuring whether to delete"},{"line_number":4310,"context_line":"                 # the data volume when the instance is destroyed. And it will"},{"line_number":4311,"context_line":"                 # be added the GET responses when showing attached volumes."},{"line_number":4312,"context_line":"        ])"},{"line_number":4313,"context_line":"        versions_supported \u003d set(range(0,"},{"line_number":4314,"context_line":"                                 novaclient.API_MAX_VERSION.ver_minor + 1))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_910b427b","line":4311,"range":{"start_line":4308,"start_character":0,"end_line":4311,"end_character":76},"in_reply_to":"7faddb67_7dfa22bd","updated":"2019-08-06 00:44:36.000000000","message":"Yup, thanks Andrey. Remove it.","commit_id":"39d125f4ff0aa6513e32f45cc0c8d122fef42c97"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e2930349015b490fb72dde2cb88753a7c679cc94","unresolved":false,"context_lines":[{"line_number":3849,"context_line":"        self.assertIn(\u0027True\u0027, out)"},{"line_number":3850,"context_line":""},{"line_number":3851,"context_line":"    def test_volume_attach_without_delete_on_termination(self):"},{"line_number":3852,"context_line":"        self.run_command(\u0027volume-attach sample-server Work\u0027)"},{"line_number":3853,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/servers/1234/os-volume_attachments\u0027,"},{"line_number":3854,"context_line":"                           {\u0027volumeAttachment\u0027:"},{"line_number":3855,"context_line":"                               {\u0027volumeId\u0027: \u0027Work\u0027}})"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_b1065b20","line":3852,"range":{"start_line":3852,"start_character":59,"end_line":3852,"end_character":60},"updated":"2019-09-06 09:20:25.000000000","message":"Add \",api_version\u003d\u00272.79\u0027\"","commit_id":"3a67f770bd1561ae242cc29498f69781b021a446"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"12b3d4ecc742406f9fb63f2125f4d2ebe48db33b","unresolved":false,"context_lines":[{"line_number":3849,"context_line":"        self.assertIn(\u0027True\u0027, out)"},{"line_number":3850,"context_line":""},{"line_number":3851,"context_line":"    def test_volume_attach_without_delete_on_termination(self):"},{"line_number":3852,"context_line":"        self.run_command(\u0027volume-attach sample-server Work\u0027)"},{"line_number":3853,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/servers/1234/os-volume_attachments\u0027,"},{"line_number":3854,"context_line":"                           {\u0027volumeAttachment\u0027:"},{"line_number":3855,"context_line":"                               {\u0027volumeId\u0027: \u0027Work\u0027}})"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_8432fba6","line":3852,"range":{"start_line":3852,"start_character":59,"end_line":3852,"end_character":60},"in_reply_to":"5faad753_b1065b20","updated":"2019-09-06 10:26:00.000000000","message":"Done","commit_id":"3a67f770bd1561ae242cc29498f69781b021a446"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e7cbbaf71bbceb135780b6c554e2adeecf5ee5ca","unresolved":false,"context_lines":[{"line_number":3830,"context_line":"            \u0027volume-attachments 1234\u0027, api_version\u003d\u00272.79\u0027)[0]"},{"line_number":3831,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/servers/1234/os-volume_attachments\u0027)"},{"line_number":3832,"context_line":"        self.assertIn(\u0027True\u0027, out)"},{"line_number":3833,"context_line":""},{"line_number":3834,"context_line":"    def test_volume_attach_with_delete_on_termination_pre_v2_79(self):"},{"line_number":3835,"context_line":"        self.assertRaises("},{"line_number":3836,"context_line":"            SystemExit, self.run_command,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5faad753_b2715de3","line":3833,"updated":"2019-09-09 05:09:25.000000000","message":"Needs a test which checks True (\u0027DELETE ON TERMINATION\u0027) is not included in the output before microversion 2.79 in the \u0027nova volume-attachment\u0027 command.","commit_id":"edd73c965ab420e701e1790f720182a4178f9b85"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3fc88f8a110a17899be11a6b49deb4d45c79b352","unresolved":false,"context_lines":[{"line_number":3830,"context_line":"            \u0027volume-attachments 1234\u0027, api_version\u003d\u00272.79\u0027)[0]"},{"line_number":3831,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/servers/1234/os-volume_attachments\u0027)"},{"line_number":3832,"context_line":"        self.assertIn(\u0027True\u0027, out)"},{"line_number":3833,"context_line":""},{"line_number":3834,"context_line":"    def test_volume_attach_with_delete_on_termination_pre_v2_79(self):"},{"line_number":3835,"context_line":"        self.assertRaises("},{"line_number":3836,"context_line":"            SystemExit, self.run_command,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5faad753_a84a4a7d","line":3833,"in_reply_to":"5faad753_b2715de3","updated":"2019-09-09 07:56:47.000000000","message":"Will be add that test via follow up.","commit_id":"edd73c965ab420e701e1790f720182a4178f9b85"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e7cbbaf71bbceb135780b6c554e2adeecf5ee5ca","unresolved":false,"context_lines":[{"line_number":4343,"context_line":"            76,  # doesn\u0027t require any changes in novaclient."},{"line_number":4344,"context_line":"            77,  # There are no version-wrapped shell method changes for this."},{"line_number":4345,"context_line":"            78,  # There are no version-wrapped shell method changes for this."},{"line_number":4346,"context_line":"            79,  # There are no version-wrapped shell method changes for this."},{"line_number":4347,"context_line":"        ])"},{"line_number":4348,"context_line":"        versions_supported \u003d set(range(0,"},{"line_number":4349,"context_line":"                                 novaclient.API_MAX_VERSION.ver_minor + 1))"}],"source_content_type":"text/x-python","patch_set":12,"id":"5faad753_923a21e5","line":4346,"range":{"start_line":4346,"start_character":0,"end_line":4346,"end_character":78},"updated":"2019-09-09 05:09:25.000000000","message":"It is not necessary. This test covers not only shell methods but only Python API bindings.","commit_id":"edd73c965ab420e701e1790f720182a4178f9b85"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3fc88f8a110a17899be11a6b49deb4d45c79b352","unresolved":false,"context_lines":[{"line_number":4343,"context_line":"            76,  # doesn\u0027t require any changes in novaclient."},{"line_number":4344,"context_line":"            77,  # There are no version-wrapped shell method changes for this."},{"line_number":4345,"context_line":"            78,  # There are no version-wrapped shell method changes for this."},{"line_number":4346,"context_line":"            79,  # There are no version-wrapped shell method changes for this."},{"line_number":4347,"context_line":"        ])"},{"line_number":4348,"context_line":"        versions_supported \u003d set(range(0,"},{"line_number":4349,"context_line":"                                 novaclient.API_MAX_VERSION.ver_minor + 1))"}],"source_content_type":"text/x-python","patch_set":12,"id":"5faad753_485f1641","line":4346,"range":{"start_line":4346,"start_character":0,"end_line":4346,"end_character":78},"in_reply_to":"5faad753_923a21e5","updated":"2019-09-09 07:56:47.000000000","message":"Done","commit_id":"edd73c965ab420e701e1790f720182a4178f9b85"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c7fd5654e4e0c250564f035a97247a10aa968b16","unresolved":false,"context_lines":[{"line_number":3825,"context_line":"                                \u0027tag\u0027: \u0027test-tag\u0027}})"},{"line_number":3826,"context_line":"        self.assertIn(\u0027test-tag\u0027, out)"},{"line_number":3827,"context_line":""},{"line_number":3828,"context_line":"    def test_volume_attachments_v2_79(self):"},{"line_number":3829,"context_line":"        out \u003d self.run_command("},{"line_number":3830,"context_line":"            \u0027volume-attachments 1234\u0027, api_version\u003d\u00272.79\u0027)[0]"},{"line_number":3831,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/servers/1234/os-volume_attachments\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5faad753_00b80e74","line":3828,"range":{"start_line":3828,"start_character":8,"end_line":3828,"end_character":37},"updated":"2019-09-09 15:20:41.000000000","message":"How about a 2.78 version of this that asserts \"DELETE ON TERMINATION\" is not in the output?","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b6a290c4ec0189769411c00ebf12cc1cbba0ad59","unresolved":false,"context_lines":[{"line_number":3825,"context_line":"                                \u0027tag\u0027: \u0027test-tag\u0027}})"},{"line_number":3826,"context_line":"        self.assertIn(\u0027test-tag\u0027, out)"},{"line_number":3827,"context_line":""},{"line_number":3828,"context_line":"    def test_volume_attachments_v2_79(self):"},{"line_number":3829,"context_line":"        out \u003d self.run_command("},{"line_number":3830,"context_line":"            \u0027volume-attachments 1234\u0027, api_version\u003d\u00272.79\u0027)[0]"},{"line_number":3831,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/servers/1234/os-volume_attachments\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5faad753_26b8c2c6","line":3828,"range":{"start_line":3828,"start_character":8,"end_line":3828,"end_character":37},"in_reply_to":"5faad753_00b80e74","updated":"2019-09-09 16:46:46.000000000","message":"Done","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c7fd5654e4e0c250564f035a97247a10aa968b16","unresolved":false,"context_lines":[{"line_number":3829,"context_line":"        out \u003d self.run_command("},{"line_number":3830,"context_line":"            \u0027volume-attachments 1234\u0027, api_version\u003d\u00272.79\u0027)[0]"},{"line_number":3831,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/servers/1234/os-volume_attachments\u0027)"},{"line_number":3832,"context_line":"        self.assertIn(\u0027True\u0027, out)"},{"line_number":3833,"context_line":""},{"line_number":3834,"context_line":"    def test_volume_attach_with_delete_on_termination_pre_v2_79(self):"},{"line_number":3835,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":13,"id":"5faad753_c003d641","line":3832,"range":{"start_line":3832,"start_character":23,"end_line":3832,"end_character":27},"updated":"2019-09-09 15:20:41.000000000","message":"It would probably be more obvious to check for \"DELETE ON TERMINATION\" here.","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b6a290c4ec0189769411c00ebf12cc1cbba0ad59","unresolved":false,"context_lines":[{"line_number":3829,"context_line":"        out \u003d self.run_command("},{"line_number":3830,"context_line":"            \u0027volume-attachments 1234\u0027, api_version\u003d\u00272.79\u0027)[0]"},{"line_number":3831,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/servers/1234/os-volume_attachments\u0027)"},{"line_number":3832,"context_line":"        self.assertIn(\u0027True\u0027, out)"},{"line_number":3833,"context_line":""},{"line_number":3834,"context_line":"    def test_volume_attach_with_delete_on_termination_pre_v2_79(self):"},{"line_number":3835,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":13,"id":"5faad753_06b7c6d7","line":3832,"range":{"start_line":3832,"start_character":23,"end_line":3832,"end_character":27},"in_reply_to":"5faad753_c003d641","updated":"2019-09-09 16:46:46.000000000","message":"Done","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c7fd5654e4e0c250564f035a97247a10aa968b16","unresolved":false,"context_lines":[{"line_number":3846,"context_line":"                               {\u0027device\u0027: \u0027/dev/vdb\u0027,"},{"line_number":3847,"context_line":"                                \u0027volumeId\u0027: \u00272\u0027,"},{"line_number":3848,"context_line":"                                \u0027delete_on_termination\u0027: True}})"},{"line_number":3849,"context_line":"        self.assertIn(\u0027True\u0027, out)"},{"line_number":3850,"context_line":""},{"line_number":3851,"context_line":"    def test_volume_attach_without_delete_on_termination(self):"},{"line_number":3852,"context_line":"        self.run_command(\u0027volume-attach sample-server Work\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5faad753_e085b2ae","line":3849,"range":{"start_line":3849,"start_character":23,"end_line":3849,"end_character":27},"updated":"2019-09-09 15:20:41.000000000","message":"same","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b6a290c4ec0189769411c00ebf12cc1cbba0ad59","unresolved":false,"context_lines":[{"line_number":3846,"context_line":"                               {\u0027device\u0027: \u0027/dev/vdb\u0027,"},{"line_number":3847,"context_line":"                                \u0027volumeId\u0027: \u00272\u0027,"},{"line_number":3848,"context_line":"                                \u0027delete_on_termination\u0027: True}})"},{"line_number":3849,"context_line":"        self.assertIn(\u0027True\u0027, out)"},{"line_number":3850,"context_line":""},{"line_number":3851,"context_line":"    def test_volume_attach_without_delete_on_termination(self):"},{"line_number":3852,"context_line":"        self.run_command(\u0027volume-attach sample-server Work\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5faad753_86c2d632","line":3849,"range":{"start_line":3849,"start_character":23,"end_line":3849,"end_character":27},"in_reply_to":"5faad753_e085b2ae","updated":"2019-09-09 16:46:46.000000000","message":"Done","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"}],"novaclient/tests/unit/v2/test_volumes.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c7fd5654e4e0c250564f035a97247a10aa968b16","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def test_create_server_volume_with_delete_on_termination_pre_v279(self):"},{"line_number":153,"context_line":"        self.cs.api_version \u003d api_versions.APIVersion(\u00272.78\u0027)"},{"line_number":154,"context_line":"        self.assertRaises(TypeError,"},{"line_number":155,"context_line":"                          self.cs.volumes.create_server_volume,"},{"line_number":156,"context_line":"                          \"1234\","},{"line_number":157,"context_line":"                          volume_id\u003d\u002715e59938-07d5-11e1-90e3-e3dffe0c5983\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5faad753_6068e2f4","line":154,"updated":"2019-09-09 15:20:41.000000000","message":"Can we trap the exception and assert something about the error message to know we\u0027re getting a TypeError for the reason we expect? Like would \u0027delete_on_termination\u0027 be in the TypeError message?","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b6a290c4ec0189769411c00ebf12cc1cbba0ad59","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def test_create_server_volume_with_delete_on_termination_pre_v279(self):"},{"line_number":153,"context_line":"        self.cs.api_version \u003d api_versions.APIVersion(\u00272.78\u0027)"},{"line_number":154,"context_line":"        self.assertRaises(TypeError,"},{"line_number":155,"context_line":"                          self.cs.volumes.create_server_volume,"},{"line_number":156,"context_line":"                          \"1234\","},{"line_number":157,"context_line":"                          volume_id\u003d\u002715e59938-07d5-11e1-90e3-e3dffe0c5983\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5faad753_714af655","line":154,"in_reply_to":"5faad753_6068e2f4","updated":"2019-09-09 16:46:46.000000000","message":"Done","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"}],"novaclient/v2/shell.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2b94f2c2a6c7203039ca4f583040c7254bc432ff","unresolved":false,"context_lines":[{"line_number":2608,"context_line":"    start_version\u003d\"2.49\")"},{"line_number":2609,"context_line":"@utils.arg("},{"line_number":2610,"context_line":"    \u0027--delete-on-termination\u0027,"},{"line_number":2611,"context_line":"    metavar\u003d\u0027\u003cdelete_on_termination\u003e\u0027,"},{"line_number":2612,"context_line":"    default\u003dFalse,"},{"line_number":2613,"context_line":"    help\u003d_(\u0027Determine if the attached volume is deleted \u0027"},{"line_number":2614,"context_line":"           \u0027when the server is destroyed.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_6308637f","line":2611,"updated":"2019-09-03 21:52:20.000000000","message":"Seems a bit weird that we\u0027d have a value for this option, why not just add action\u003d\"store_true\" and then specifying --delete-on-termination means delete_on_termination\u003dTrue, but not specifying the option means delete_on_termination\u003dFalse. Taking a value for booleans is weird UX to me, like the --config-drive option. Maybe we should ask Dean Troyer what he thinks, or what he wants to see in the OSC patch.","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0ab3d51070c6059ba411063242418588c58b0d83","unresolved":false,"context_lines":[{"line_number":2608,"context_line":"    start_version\u003d\"2.49\")"},{"line_number":2609,"context_line":"@utils.arg("},{"line_number":2610,"context_line":"    \u0027--delete-on-termination\u0027,"},{"line_number":2611,"context_line":"    metavar\u003d\u0027\u003cdelete_on_termination\u003e\u0027,"},{"line_number":2612,"context_line":"    default\u003dFalse,"},{"line_number":2613,"context_line":"    help\u003d_(\u0027Determine if the attached volume is deleted \u0027"},{"line_number":2614,"context_line":"           \u0027when the server is destroyed.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_59895324","line":2611,"in_reply_to":"5faad753_a544deb8","updated":"2019-09-06 02:30:17.000000000","message":"Sorry.... It seems I looked a wrong line...\n\nI think nova CLI usually provides an option for non-default value, so --delete-on-termination looks fine for nova CLI.","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"e4bb7716fb247a2c0c5dbe8bd932e6a969783ba7","unresolved":false,"context_lines":[{"line_number":2608,"context_line":"    start_version\u003d\"2.49\")"},{"line_number":2609,"context_line":"@utils.arg("},{"line_number":2610,"context_line":"    \u0027--delete-on-termination\u0027,"},{"line_number":2611,"context_line":"    metavar\u003d\u0027\u003cdelete_on_termination\u003e\u0027,"},{"line_number":2612,"context_line":"    default\u003dFalse,"},{"line_number":2613,"context_line":"    help\u003d_(\u0027Determine if the attached volume is deleted \u0027"},{"line_number":2614,"context_line":"           \u0027when the server is destroyed.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_a90dc035","line":2611,"in_reply_to":"7faddb67_185b1586","updated":"2019-09-05 02:26:17.000000000","message":"@Akihiro, yes, in OSC, the format is very uniform, the target parameters are explicitly set and then processed in the code logic.\nHowever, I compared the handling of boolean types in novaclinet and OSC, novaclient did not follow this implementation, e.g.[1]. I will follow the previous implementation in novaclient and then update OSC[2], using the implementation in the above documentation. \n\nHow about using \"--enable-delete-on-termination\" and \"--disable-delete-on-termination\" in OSC?\n\n[1]https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/shell.py#L3536-L3540\n[2]https://review.opendev.org/#/c/673725","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"591ebd45b31838f6ab612e1c5436d6d221334092","unresolved":false,"context_lines":[{"line_number":2608,"context_line":"    start_version\u003d\"2.49\")"},{"line_number":2609,"context_line":"@utils.arg("},{"line_number":2610,"context_line":"    \u0027--delete-on-termination\u0027,"},{"line_number":2611,"context_line":"    metavar\u003d\u0027\u003cdelete_on_termination\u003e\u0027,"},{"line_number":2612,"context_line":"    default\u003dFalse,"},{"line_number":2613,"context_line":"    help\u003d_(\u0027Determine if the attached volume is deleted \u0027"},{"line_number":2614,"context_line":"           \u0027when the server is destroyed.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_a544deb8","line":2611,"in_reply_to":"7faddb67_5c7de119","updated":"2019-09-05 21:39:53.000000000","message":"\u003e At a second look, this option is proposed to \u0027server-create\u0027.\n\nI\u0027m not sure why you say that but this is for the nova volume-attach command, not server create (nova boot).","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"e4bb7716fb247a2c0c5dbe8bd932e6a969783ba7","unresolved":false,"context_lines":[{"line_number":2608,"context_line":"    start_version\u003d\"2.49\")"},{"line_number":2609,"context_line":"@utils.arg("},{"line_number":2610,"context_line":"    \u0027--delete-on-termination\u0027,"},{"line_number":2611,"context_line":"    metavar\u003d\u0027\u003cdelete_on_termination\u003e\u0027,"},{"line_number":2612,"context_line":"    default\u003dFalse,"},{"line_number":2613,"context_line":"    help\u003d_(\u0027Determine if the attached volume is deleted \u0027"},{"line_number":2614,"context_line":"           \u0027when the server is destroyed.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_965fc33f","line":2611,"in_reply_to":"7faddb67_6308637f","updated":"2019-09-05 02:26:17.000000000","message":"\u003e why not just add action\u003d\"store_true\"\n\nYeah, this should add action\u003d\"store_true\", while specifying \"--delete-on-termination\" means \"delete-on-termination\u003dTrue\", will be added.","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"70ed5cf60fefff80b8099eeeb609b5f61b617943","unresolved":false,"context_lines":[{"line_number":2608,"context_line":"    start_version\u003d\"2.49\")"},{"line_number":2609,"context_line":"@utils.arg("},{"line_number":2610,"context_line":"    \u0027--delete-on-termination\u0027,"},{"line_number":2611,"context_line":"    metavar\u003d\u0027\u003cdelete_on_termination\u003e\u0027,"},{"line_number":2612,"context_line":"    default\u003dFalse,"},{"line_number":2613,"context_line":"    help\u003d_(\u0027Determine if the attached volume is deleted \u0027"},{"line_number":2614,"context_line":"           \u0027when the server is destroyed.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_185b1586","line":2611,"in_reply_to":"7faddb67_6308637f","updated":"2019-09-04 11:16:33.000000000","message":"In case of OSC, we usually use --foo and --no-foo for a boolean option. If there is more appropriate and/or natural expression over --no-foo, we use such expression. For example, we use --private over --no-public.\n\nThe guideline is explained at OSC document [1].\n\n[1] https://docs.openstack.org/python-openstackclient/latest/contributor/command-options.html#boolean-options","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3ff5f8acf3cb4a791ad4685ed92c8d2ef89d6d36","unresolved":false,"context_lines":[{"line_number":2608,"context_line":"    start_version\u003d\"2.49\")"},{"line_number":2609,"context_line":"@utils.arg("},{"line_number":2610,"context_line":"    \u0027--delete-on-termination\u0027,"},{"line_number":2611,"context_line":"    metavar\u003d\u0027\u003cdelete_on_termination\u003e\u0027,"},{"line_number":2612,"context_line":"    default\u003dFalse,"},{"line_number":2613,"context_line":"    help\u003d_(\u0027Determine if the attached volume is deleted \u0027"},{"line_number":2614,"context_line":"           \u0027when the server is destroyed.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_5c7de119","line":2611,"in_reply_to":"7faddb67_a90dc035","updated":"2019-09-05 14:30:29.000000000","message":"At a second look, this option is proposed to \u0027server-create\u0027. It is related to a volume, so it is better to include \u0027volume\u0027 keyword in the option name.\n\nConsidering the above, how about --delete-volume-on-termination and --keep-volume-on-termination?\n\"delete\" is a verb, so \"enable/disable-\u003cverb\u003e\" looks tricky a bit.\n\nIn addition, \"termination\" might be replaced with \"delete\" because we use \"nova delete\" when deleting a server.","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2b94f2c2a6c7203039ca4f583040c7254bc432ff","unresolved":false,"context_lines":[{"line_number":2610,"context_line":"    \u0027--delete-on-termination\u0027,"},{"line_number":2611,"context_line":"    metavar\u003d\u0027\u003cdelete_on_termination\u003e\u0027,"},{"line_number":2612,"context_line":"    default\u003dFalse,"},{"line_number":2613,"context_line":"    help\u003d_(\u0027Determine if the attached volume is deleted \u0027"},{"line_number":2614,"context_line":"           \u0027when the server is destroyed.\u0027),"},{"line_number":2615,"context_line":"    start_version\u003d\"2.76\")"},{"line_number":2616,"context_line":"def do_volume_attach(cs, args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_a3297bf2","line":2613,"range":{"start_line":2613,"start_character":12,"end_line":2613,"end_character":21},"updated":"2019-09-03 21:52:20.000000000","message":"Specify","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f7ad40a47a39dddfd0182f05ac893bfe18591fb7","unresolved":false,"context_lines":[{"line_number":2610,"context_line":"    \u0027--delete-on-termination\u0027,"},{"line_number":2611,"context_line":"    metavar\u003d\u0027\u003cdelete_on_termination\u003e\u0027,"},{"line_number":2612,"context_line":"    default\u003dFalse,"},{"line_number":2613,"context_line":"    help\u003d_(\u0027Determine if the attached volume is deleted \u0027"},{"line_number":2614,"context_line":"           \u0027when the server is destroyed.\u0027),"},{"line_number":2615,"context_line":"    start_version\u003d\"2.76\")"},{"line_number":2616,"context_line":"def do_volume_attach(cs, args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_adc5e18f","line":2613,"range":{"start_line":2613,"start_character":12,"end_line":2613,"end_character":21},"in_reply_to":"7faddb67_a3297bf2","updated":"2019-09-04 10:11:40.000000000","message":"Done","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2b94f2c2a6c7203039ca4f583040c7254bc432ff","unresolved":false,"context_lines":[{"line_number":2683,"context_line":"    if cs.api_version \u003e\u003d api_versions.APIVersion(\u00272.70\u0027):"},{"line_number":2684,"context_line":"        fields.append(\u0027TAG\u0027)"},{"line_number":2685,"context_line":"    # Microversion \u003e\u003d 2.76 returns the delete_on_termination value."},{"line_number":2686,"context_line":"    if cs.api_version \u003e\u003d api_versions.APIVersion(\u00272.76\u0027):"},{"line_number":2687,"context_line":"        fields.append(\u0027DELETE ON TERMINATION\u0027)"},{"line_number":2688,"context_line":"    utils.print_list(volumes, fields)"},{"line_number":2689,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_03196fcf","line":2686,"updated":"2019-09-03 21:52:20.000000000","message":"This isn\u0027t mentioned in the commit message but you should mention that you\u0027re also updating the \"nova volume-attachments\" command to show the delete_on_termination value if 2.78 or greater is used.","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f7ad40a47a39dddfd0182f05ac893bfe18591fb7","unresolved":false,"context_lines":[{"line_number":2683,"context_line":"    if cs.api_version \u003e\u003d api_versions.APIVersion(\u00272.70\u0027):"},{"line_number":2684,"context_line":"        fields.append(\u0027TAG\u0027)"},{"line_number":2685,"context_line":"    # Microversion \u003e\u003d 2.76 returns the delete_on_termination value."},{"line_number":2686,"context_line":"    if cs.api_version \u003e\u003d api_versions.APIVersion(\u00272.76\u0027):"},{"line_number":2687,"context_line":"        fields.append(\u0027DELETE ON TERMINATION\u0027)"},{"line_number":2688,"context_line":"    utils.print_list(volumes, fields)"},{"line_number":2689,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_4d8d4d2f","line":2686,"in_reply_to":"7faddb67_03196fcf","updated":"2019-09-04 10:11:40.000000000","message":"Done","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"68706285502a376caa39b86fa01c20507d14e5ae","unresolved":false,"context_lines":[{"line_number":2624,"context_line":"    start_version\u003d\"2.49\")"},{"line_number":2625,"context_line":"@utils.arg("},{"line_number":2626,"context_line":"    \u0027--delete-on-termination\u0027,"},{"line_number":2627,"context_line":"    metavar\u003d\u0027\u003cdelete_on_termination\u003e\u0027,"},{"line_number":2628,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":2629,"context_line":"    default\u003dFalse,"},{"line_number":2630,"context_line":"    help\u003d_(\u0027Specify if the attached volume is deleted \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_49ef6cb0","line":2627,"range":{"start_line":2627,"start_character":4,"end_line":2627,"end_character":38},"updated":"2019-09-05 03:28:21.000000000","message":"redundant","commit_id":"0ac96d89753eeaa30adf0a1ec14fcfdd012835b6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c7fd5654e4e0c250564f035a97247a10aa968b16","unresolved":false,"context_lines":[{"line_number":2637,"context_line":"    \u0027--delete-on-termination\u0027,"},{"line_number":2638,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":2639,"context_line":"    default\u003dFalse,"},{"line_number":2640,"context_line":"    help\u003d_(\u0027Specify if the attached volume is deleted \u0027"},{"line_number":2641,"context_line":"           \u0027when the server is destroyed.\u0027),"},{"line_number":2642,"context_line":"    start_version\u003d\"2.79\")"},{"line_number":2643,"context_line":"def do_volume_attach(cs, args):"}],"source_content_type":"text/x-python","patch_set":13,"id":"5faad753_006d6e03","line":2640,"range":{"start_line":2640,"start_character":43,"end_line":2640,"end_character":45},"updated":"2019-09-09 15:20:41.000000000","message":"should be","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b6a290c4ec0189769411c00ebf12cc1cbba0ad59","unresolved":false,"context_lines":[{"line_number":2637,"context_line":"    \u0027--delete-on-termination\u0027,"},{"line_number":2638,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":2639,"context_line":"    default\u003dFalse,"},{"line_number":2640,"context_line":"    help\u003d_(\u0027Specify if the attached volume is deleted \u0027"},{"line_number":2641,"context_line":"           \u0027when the server is destroyed.\u0027),"},{"line_number":2642,"context_line":"    start_version\u003d\"2.79\")"},{"line_number":2643,"context_line":"def do_volume_attach(cs, args):"}],"source_content_type":"text/x-python","patch_set":13,"id":"5faad753_3176bea6","line":2640,"range":{"start_line":2640,"start_character":43,"end_line":2640,"end_character":45},"in_reply_to":"5faad753_006d6e03","updated":"2019-09-09 16:46:46.000000000","message":"Done","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"}],"novaclient/v2/volumes.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2b94f2c2a6c7203039ca4f583040c7254bc432ff","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        :param device: The device name (optional)."},{"line_number":87,"context_line":"        :param tag: The tag (optional)."},{"line_number":88,"context_line":"        :param delete_on_termination: Marked whether to delete the attached"},{"line_number":89,"context_line":"                                      volume (optional)."},{"line_number":90,"context_line":"        :rtype: :class:`Volume`"},{"line_number":91,"context_line":"        \"\"\""},{"line_number":92,"context_line":"        body \u003d {\u0027volumeAttachment\u0027: {\u0027volumeId\u0027: volume_id}}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_e370d30b","line":89,"range":{"start_line":89,"start_character":38,"end_line":89,"end_character":44},"updated":"2019-09-03 21:52:20.000000000","message":"volume when the server is deleted","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f7ad40a47a39dddfd0182f05ac893bfe18591fb7","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        :param device: The device name (optional)."},{"line_number":87,"context_line":"        :param tag: The tag (optional)."},{"line_number":88,"context_line":"        :param delete_on_termination: Marked whether to delete the attached"},{"line_number":89,"context_line":"                                      volume (optional)."},{"line_number":90,"context_line":"        :rtype: :class:`Volume`"},{"line_number":91,"context_line":"        \"\"\""},{"line_number":92,"context_line":"        body \u003d {\u0027volumeAttachment\u0027: {\u0027volumeId\u0027: volume_id}}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_ad73a17f","line":89,"range":{"start_line":89,"start_character":38,"end_line":89,"end_character":44},"in_reply_to":"7faddb67_e370d30b","updated":"2019-09-04 10:11:40.000000000","message":"Done","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c7fd5654e4e0c250564f035a97247a10aa968b16","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        :param device: The device name (optional)"},{"line_number":50,"context_line":"        :rtype: :class:`Volume`"},{"line_number":51,"context_line":"        \"\"\""},{"line_number":52,"context_line":"        body \u003d {\u0027volumeAttachment\u0027: {\u0027volumeId\u0027: volume_id}}"},{"line_number":53,"context_line":"        if device is not None:"},{"line_number":54,"context_line":"            body[\u0027volumeAttachment\u0027][\u0027device\u0027] \u003d device"},{"line_number":55,"context_line":"        return self._create(\"/servers/%s/os-volume_attachments\" % server_id,"},{"line_number":56,"context_line":"                            body, \"volumeAttachment\")"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5faad753_a0049a18","line":54,"range":{"start_line":52,"start_character":8,"end_line":54,"end_character":55},"updated":"2019-09-09 15:20:41.000000000","message":"this...","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c7fd5654e4e0c250564f035a97247a10aa968b16","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        :param tag: The tag (optional)"},{"line_number":68,"context_line":"        :rtype: :class:`Volume`"},{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":"        body \u003d {\u0027volumeAttachment\u0027: {\u0027volumeId\u0027: volume_id}}"},{"line_number":71,"context_line":"        if device is not None:"},{"line_number":72,"context_line":"            body[\u0027volumeAttachment\u0027][\u0027device\u0027] \u003d device"},{"line_number":73,"context_line":"        if tag is not None:"},{"line_number":74,"context_line":"            body[\u0027volumeAttachment\u0027][\u0027tag\u0027] \u003d tag"},{"line_number":75,"context_line":"        return self._create(\"/servers/%s/os-volume_attachments\" % server_id,"},{"line_number":76,"context_line":"                            body, \"volumeAttachment\")"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5faad753_4b04e715","line":74,"range":{"start_line":70,"start_character":8,"end_line":74,"end_character":49},"updated":"2019-09-09 15:20:41.000000000","message":"...and this...","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c7fd5654e4e0c250564f035a97247a10aa968b16","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                                      (optional)."},{"line_number":91,"context_line":"        :rtype: :class:`Volume`"},{"line_number":92,"context_line":"        \"\"\""},{"line_number":93,"context_line":"        body \u003d {\u0027volumeAttachment\u0027: {\u0027volumeId\u0027: volume_id}}"},{"line_number":94,"context_line":"        if device is not None:"},{"line_number":95,"context_line":"            body[\u0027volumeAttachment\u0027][\u0027device\u0027] \u003d device"},{"line_number":96,"context_line":"        if tag is not None:"},{"line_number":97,"context_line":"            body[\u0027volumeAttachment\u0027][\u0027tag\u0027] \u003d tag"},{"line_number":98,"context_line":"        if delete_on_termination:"},{"line_number":99,"context_line":"            body[\u0027volumeAttachment\u0027][\u0027delete_on_termination\u0027] \u003d ("},{"line_number":100,"context_line":"                delete_on_termination)"},{"line_number":101,"context_line":"        return self._create(\"/servers/%s/os-volume_attachments\" % server_id,"},{"line_number":102,"context_line":"                            body, \"volumeAttachment\")"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5faad753_6b1c436a","line":100,"range":{"start_line":93,"start_character":8,"end_line":100,"end_character":38},"updated":"2019-09-09 15:20:41.000000000","message":"...and this could all be moved into a private helper function to avoid the copy/paste on these version-wrapped methods but let\u0027s deal with that in a follow up change.","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b6a290c4ec0189769411c00ebf12cc1cbba0ad59","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                                      (optional)."},{"line_number":91,"context_line":"        :rtype: :class:`Volume`"},{"line_number":92,"context_line":"        \"\"\""},{"line_number":93,"context_line":"        body \u003d {\u0027volumeAttachment\u0027: {\u0027volumeId\u0027: volume_id}}"},{"line_number":94,"context_line":"        if device is not None:"},{"line_number":95,"context_line":"            body[\u0027volumeAttachment\u0027][\u0027device\u0027] \u003d device"},{"line_number":96,"context_line":"        if tag is not None:"},{"line_number":97,"context_line":"            body[\u0027volumeAttachment\u0027][\u0027tag\u0027] \u003d tag"},{"line_number":98,"context_line":"        if delete_on_termination:"},{"line_number":99,"context_line":"            body[\u0027volumeAttachment\u0027][\u0027delete_on_termination\u0027] \u003d ("},{"line_number":100,"context_line":"                delete_on_termination)"},{"line_number":101,"context_line":"        return self._create(\"/servers/%s/os-volume_attachments\" % server_id,"},{"line_number":102,"context_line":"                            body, \"volumeAttachment\")"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5faad753_d1664aee","line":100,"range":{"start_line":93,"start_character":8,"end_line":100,"end_character":38},"in_reply_to":"5faad753_6b1c436a","updated":"2019-09-09 16:46:46.000000000","message":"Added a TODO.","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"}],"releasenotes/notes/microversion-v2_76-f13bc0414743dc16.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2b94f2c2a6c7203039ca4f583040c7254bc432ff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for `microversion 2.76`_ which adds"},{"line_number":5,"context_line":"    ``delete_on_termination`` parameter to the ``Attach a volume to an"},{"line_number":6,"context_line":"    instance`` API, to support configuring whether to delete the data"},{"line_number":7,"context_line":"    volume when the instance is destroyed."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_e349b3b7","line":4,"range":{"start_line":4,"start_character":38,"end_line":4,"end_character":40},"updated":"2019-09-03 21:52:20.000000000","message":"78","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f7ad40a47a39dddfd0182f05ac893bfe18591fb7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for `microversion 2.76`_ which adds"},{"line_number":5,"context_line":"    ``delete_on_termination`` parameter to the ``Attach a volume to an"},{"line_number":6,"context_line":"    instance`` API, to support configuring whether to delete the data"},{"line_number":7,"context_line":"    volume when the instance is destroyed."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_2dd3313a","line":4,"range":{"start_line":4,"start_character":38,"end_line":4,"end_character":40},"in_reply_to":"7faddb67_e349b3b7","updated":"2019-09-04 10:11:40.000000000","message":"Done","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2b94f2c2a6c7203039ca4f583040c7254bc432ff","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for `microversion 2.76`_ which adds"},{"line_number":5,"context_line":"    ``delete_on_termination`` parameter to the ``Attach a volume to an"},{"line_number":6,"context_line":"    instance`` API, to support configuring whether to delete the data"},{"line_number":7,"context_line":"    volume when the instance is destroyed."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * The ``--delete-on-termination`` options is added to the"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_2354ab53","line":6,"range":{"start_line":5,"start_character":47,"end_line":6,"end_character":14},"updated":"2019-09-03 21:52:20.000000000","message":"attach volume","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f7ad40a47a39dddfd0182f05ac893bfe18591fb7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for `microversion 2.76`_ which adds"},{"line_number":5,"context_line":"    ``delete_on_termination`` parameter to the ``Attach a volume to an"},{"line_number":6,"context_line":"    instance`` API, to support configuring whether to delete the data"},{"line_number":7,"context_line":"    volume when the instance is destroyed."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * The ``--delete-on-termination`` options is added to the"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_8d1265fc","line":6,"range":{"start_line":5,"start_character":47,"end_line":6,"end_character":14},"in_reply_to":"7faddb67_2354ab53","updated":"2019-09-04 10:11:40.000000000","message":"Done","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2b94f2c2a6c7203039ca4f583040c7254bc432ff","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    instance`` API, to support configuring whether to delete the data"},{"line_number":7,"context_line":"    volume when the instance is destroyed."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * The ``--delete-on-termination`` options is added to the"},{"line_number":10,"context_line":"      ``nova volume-attach`` CLI."},{"line_number":11,"context_line":"    * The ``delete_on_termination`` fields will be added the GET responses"},{"line_number":12,"context_line":"      when showing attached volumes."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_835b1f84","line":9,"range":{"start_line":9,"start_character":38,"end_line":9,"end_character":45},"updated":"2019-09-03 21:52:20.000000000","message":"option","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f7ad40a47a39dddfd0182f05ac893bfe18591fb7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    instance`` API, to support configuring whether to delete the data"},{"line_number":7,"context_line":"    volume when the instance is destroyed."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * The ``--delete-on-termination`` options is added to the"},{"line_number":10,"context_line":"      ``nova volume-attach`` CLI."},{"line_number":11,"context_line":"    * The ``delete_on_termination`` fields will be added the GET responses"},{"line_number":12,"context_line":"      when showing attached volumes."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_6d17e9ef","line":9,"range":{"start_line":9,"start_character":38,"end_line":9,"end_character":45},"in_reply_to":"7faddb67_835b1f84","updated":"2019-09-04 10:11:40.000000000","message":"Done","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2b94f2c2a6c7203039ca4f583040c7254bc432ff","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * The ``--delete-on-termination`` options is added to the"},{"line_number":10,"context_line":"      ``nova volume-attach`` CLI."},{"line_number":11,"context_line":"    * The ``delete_on_termination`` fields will be added the GET responses"},{"line_number":12,"context_line":"      when showing attached volumes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    .. _microversion 2.76: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id67"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_23d90bf3","line":12,"range":{"start_line":11,"start_character":6,"end_line":12,"end_character":36},"updated":"2019-09-03 21:52:20.000000000","message":"Re-word this as something like:\n\n\"A ``DELETE ON TERMINATION`` column is added to the ``nova volume-attachments`` table.\"","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f7ad40a47a39dddfd0182f05ac893bfe18591fb7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * The ``--delete-on-termination`` options is added to the"},{"line_number":10,"context_line":"      ``nova volume-attach`` CLI."},{"line_number":11,"context_line":"    * The ``delete_on_termination`` fields will be added the GET responses"},{"line_number":12,"context_line":"      when showing attached volumes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    .. _microversion 2.76: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id67"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_cd1cdd14","line":12,"range":{"start_line":11,"start_character":6,"end_line":12,"end_character":36},"in_reply_to":"7faddb67_23d90bf3","updated":"2019-09-04 10:11:40.000000000","message":"Done","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2b94f2c2a6c7203039ca4f583040c7254bc432ff","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    * The ``delete_on_termination`` fields will be added the GET responses"},{"line_number":12,"context_line":"      when showing attached volumes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    .. _microversion 2.76: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id67"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_a3c5fb0b","line":14,"range":{"start_line":14,"start_character":106,"end_line":14,"end_character":110},"updated":"2019-09-03 21:52:20.000000000","message":"id70","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f7ad40a47a39dddfd0182f05ac893bfe18591fb7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    * The ``delete_on_termination`` fields will be added the GET responses"},{"line_number":12,"context_line":"      when showing attached volumes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    .. _microversion 2.76: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id67"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_ad21614f","line":14,"range":{"start_line":14,"start_character":106,"end_line":14,"end_character":110},"in_reply_to":"7faddb67_a3c5fb0b","updated":"2019-09-04 10:11:40.000000000","message":"Done","commit_id":"61004a08ce2c27ed6f668e199fa9ddc62a1ce5c7"}],"releasenotes/notes/microversion-v2_78-f13bc0414743dc16.yaml":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e07e016e152b1620a086e805aaab1f982c627bd4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"      ``nova volume-attach`` CLI."},{"line_number":11,"context_line":"    * A ``DELETE ON TERMINATION`` column is added to the ``nova"},{"line_number":12,"context_line":"      volume-attachments`` table."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    .. _microversion 2.78: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id70"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_67e7ef10","line":13,"updated":"2019-09-05 06:28:50.000000000","message":"nit: \nThe change for python API bindings should be described. \nSee the following example.\n\nhttps://docs.openstack.org/releasenotes/python-novaclient/rocky.html#new-features (microversion 2.63)","commit_id":"dde5cbd4d39eeab2a4c0ce26fe26232b88cc0bbe"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3b7516d5b41a06677783619905be63fa332e3773","unresolved":false,"context_lines":[{"line_number":10,"context_line":"      ``nova volume-attach`` CLI."},{"line_number":11,"context_line":"    * A ``DELETE ON TERMINATION`` column is added to the ``nova"},{"line_number":12,"context_line":"      volume-attachments`` table."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    .. _microversion 2.78: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id70"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_8288d9c5","line":13,"in_reply_to":"7faddb67_67e7ef10","updated":"2019-09-05 08:08:46.000000000","message":"Done","commit_id":"dde5cbd4d39eeab2a4c0ce26fe26232b88cc0bbe"}],"releasenotes/notes/microversion-v2_79-f13bc0414743dc16.yaml":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e2930349015b490fb72dde2cb88753a7c679cc94","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    - New kwarg called ``delete_on_termination`` added to python API"},{"line_number":15,"context_line":"      bindings:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"        - ``novaclient.v2.volumes.VolumeManager.create_server_volume()``"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    .. _microversion 2.79: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id71"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5faad753_644c9f76","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":8},"updated":"2019-09-06 09:20:25.000000000","message":"Remove two extra white spaces.\n\nSee the output.\n\nhttps://storage.gra1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_0fc/673485/10/check/build-openstack-releasenotes/0fcefe7/html/unreleased.html#new-features","commit_id":"3a67f770bd1561ae242cc29498f69781b021a446"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"12b3d4ecc742406f9fb63f2125f4d2ebe48db33b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    - New kwarg called ``delete_on_termination`` added to python API"},{"line_number":15,"context_line":"      bindings:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"        - ``novaclient.v2.volumes.VolumeManager.create_server_volume()``"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    .. _microversion 2.79: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id71"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5faad753_c41793ed","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":8},"in_reply_to":"5faad753_644c9f76","updated":"2019-09-06 10:26:00.000000000","message":"Done","commit_id":"3a67f770bd1561ae242cc29498f69781b021a446"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c7fd5654e4e0c250564f035a97247a10aa968b16","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for `microversion 2.79`_ which adds"},{"line_number":5,"context_line":"    ``delete_on_termination`` parameter to the attach volume API,"},{"line_number":6,"context_line":"    to support configuring whether to delete the data volume when"},{"line_number":7,"context_line":"    the instance is destroyed."},{"line_number":8,"context_line":"    Which includes the following changes:"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    - The ``--delete-on-termination`` option is added to the"},{"line_number":11,"context_line":"      ``nova volume-attach`` CLI."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5faad753_8b32dff0","line":8,"range":{"start_line":4,"start_character":49,"end_line":8,"end_character":9},"updated":"2019-09-09 15:20:41.000000000","message":"I think you can remove all of this to make the note more clear.","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b6a290c4ec0189769411c00ebf12cc1cbba0ad59","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for `microversion 2.79`_ which adds"},{"line_number":5,"context_line":"    ``delete_on_termination`` parameter to the attach volume API,"},{"line_number":6,"context_line":"    to support configuring whether to delete the data volume when"},{"line_number":7,"context_line":"    the instance is destroyed."},{"line_number":8,"context_line":"    Which includes the following changes:"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    - The ``--delete-on-termination`` option is added to the"},{"line_number":11,"context_line":"      ``nova volume-attach`` CLI."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5faad753_91b53234","line":8,"range":{"start_line":4,"start_character":49,"end_line":8,"end_character":9},"in_reply_to":"5faad753_8b32dff0","updated":"2019-09-09 16:46:46.000000000","message":"Done","commit_id":"dfa6f8dcf091f5ab2b58f77314d03bbd38a71b19"}]}