)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c601963d1d7c8808cb6b8e6b05bc8d6ff287f7bf","unresolved":false,"context_lines":[{"line_number":12,"context_line":"strings."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"An alternative is changing \"migration\" as a valid value to"},{"line_number":15,"context_line":"\"cold-migration\" (or accept both) and under the covers treat"},{"line_number":16,"context_line":"\"cold-migration\" as \"migration\" for the actual API call."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://review.opendev.org/#/c/675117/3/novaclient/v2/shell.py@5430"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_1349418d","line":15,"range":{"start_line":15,"start_character":21,"end_line":15,"end_character":32},"updated":"2019-08-26 17:26:03.000000000","message":"For the sake of those operators who happen to be familiar with the API and are down with the tribal knowledge that \u0027migration\u0027 means \u0027cold migration\u0027, I suppose I would be fine with accepting both, as long as it\u0027s documented that they\u0027re equivalent.","commit_id":"96dcf13f46ff66a68ac5b93b88f21f57ef709bbf"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4e5998e85e9ba12e8501afdd8216fd3137e06601","unresolved":false,"context_lines":[{"line_number":11,"context_line":"a cold migration. This change just updates docs and help"},{"line_number":12,"context_line":"strings."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"An alternative is changing \"migration\" as a valid value to"},{"line_number":15,"context_line":"\"cold-migration\" (or accept both) and under the covers treat"},{"line_number":16,"context_line":"\"cold-migration\" as \"migration\" for the actual API call."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://review.opendev.org/#/c/675117/3/novaclient/v2/shell.py@5430"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_d3b40985","line":15,"range":{"start_line":14,"start_character":18,"end_line":15,"end_character":16},"updated":"2019-08-26 17:22:17.000000000","message":"are we allowed to \"break backward compatibility\" like this?","commit_id":"96dcf13f46ff66a68ac5b93b88f21f57ef709bbf"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"48ac987ccb20f713d2133203dea12ac88770e3bc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"a cold migration. This change just updates docs and help"},{"line_number":12,"context_line":"strings."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"An alternative is changing \"migration\" as a valid value to"},{"line_number":15,"context_line":"\"cold-migration\" (or accept both) and under the covers treat"},{"line_number":16,"context_line":"\"cold-migration\" as \"migration\" for the actual API call."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://review.opendev.org/#/c/675117/3/novaclient/v2/shell.py@5430"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_24b8a30f","line":15,"range":{"start_line":14,"start_character":18,"end_line":15,"end_character":16},"in_reply_to":"7faddb67_09fb4247","updated":"2019-08-27 13:40:50.000000000","message":"Then yeah, I would definitely prefer the option to be named \u0027cold-migration\u0027. (If \u0027migration\u0027 is to be present at all, ideally it would be documented as an alias \"for esoteric historical reasons you should really not worry about unless you are already familiar with the sordid history\".)","commit_id":"96dcf13f46ff66a68ac5b93b88f21f57ef709bbf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7af0b85b94d2fb1254a36c91916bc5c818433d5f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"a cold migration. This change just updates docs and help"},{"line_number":12,"context_line":"strings."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"An alternative is changing \"migration\" as a valid value to"},{"line_number":15,"context_line":"\"cold-migration\" (or accept both) and under the covers treat"},{"line_number":16,"context_line":"\"cold-migration\" as \"migration\" for the actual API call."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://review.opendev.org/#/c/675117/3/novaclient/v2/shell.py@5430"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_09fb4247","line":15,"range":{"start_line":14,"start_character":18,"end_line":15,"end_character":16},"in_reply_to":"7faddb67_d3b40985","updated":"2019-08-27 13:25:19.000000000","message":"\u003e are we allowed to \"break backward compatibility\" like this?\n\nThe change isn\u0027t released yet, but if it were I\u0027d avoid it.","commit_id":"96dcf13f46ff66a68ac5b93b88f21f57ef709bbf"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"27dfb021fffc7844a014890a6352bb5f30f20039","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"An alternative is changing \"migration\" as a valid value to"},{"line_number":15,"context_line":"\"cold-migration\" (or accept both) and under the covers treat"},{"line_number":16,"context_line":"\"cold-migration\" as \"migration\" for the actual API call."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://review.opendev.org/#/c/675117/3/novaclient/v2/shell.py@5430"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_142284bb","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":56},"updated":"2019-08-27 01:06:55.000000000","message":"This is a good method, but it may be a bit unfriendly for people who are not familiar with nova api. After all, the CLI and rest-api request parameters are inconsistent.","commit_id":"96dcf13f46ff66a68ac5b93b88f21f57ef709bbf"}]}